Re: [Piglit] faster piglit start-up

On Wed 12 Apr 2017, Eric Anholt wrote: > For a solution to the startup time, I wish we would just build our whole > test list using filesystem walks or whatever at piglit build time, > instead of executing python to build the test list per piglit run. A nice benefit of building the test list

Re: [Piglit] [PATCH] getteximage-formats: Disable dithering during glDrawPixels

Pushed. ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] getteximage-formats: Disable dithering during glDrawPixels

el Skylake: spec.ext_framebuffer_object.getteximage-formats init-by-clear-and-render spec.ext_framebuffer_object.getteximage-formats init-by-render Regressed by Mesa: commit c4b87f129eb036c9615df3adcc1cebd9df10fc84 Author: Chad Versace <chadvers...@chromium.org> Subject: meta: Disable

Re: [Piglit] [PATCH] egl_khr_gl_image: Add test that clears a shared image

On Tue 03 Jan 2017, Ben Widawsky wrote: > On 17-01-03 13:07:54, Chad Versace wrote: > > Add test 'egl_khr_gl_renderbuffer_image-clear-shared-image'. It creates > > two renderbuffers which share storage through an EGLImage; clears > > a renderbuffer; then checks that the othe

[Piglit] [PATCH] egl_khr_gl_image: Add test that clears a shared image

Add test 'egl_khr_gl_renderbuffer_image-clear-shared-image'. It creates two renderbuffers which share storage through an EGLImage; clears a renderbuffer; then checks that the other renderbuffer pixels have the clear value. On Mesa master@c4b87f12 with Intel Broadwell, testing GL_RGBA fails and

Re: [Piglit] [RFC 0/2] egl_android_native_fence_sync tests.

On Tue 25 Oct 2016, Rob Clark wrote: > On Tue, Oct 25, 2016 at 5:19 PM, Rafael Antognolli > wrote: > > Hi, > > > > I finally got to work on these piglit tests (took longer than I > > expected). But here is an initial version, and I would like to know if > > I'm going

Re: [Piglit] [PATCH] egl_mesa_platform_surfaceless: Fix build against old EGL headers

On Wed 19 Oct 2016, Ilia Mirkin wrote: > It builds. I wonder if this should go into piglit-util-egl.h instead. > Your call. Either way, > > Tested-by: Ilia Mirkin I'll put it in piglit-util-egl.h. That's a good idea. ___ Piglit

[Piglit] [PATCH 4/4] egl_mesa_platform_surfaceless: Initial tests

Adds 4 subtests: - initialize_display - create_window - create_pixmap - create_pbuffer --- tests/egl/spec/CMakeLists.txt | 4 +- .../CMakeLists.no_api.txt | 7 + .../egl_mesa_platform_surfaceless/CMakeLists.txt | 1 +

[Piglit] [PATCH 0/4] EGL_MESA_platform_surfaceless

Tests for my EGL_MESA_platform_surfaceless v2 series on mesa-dev. Branches: - mesa: http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=review/EGL_MESA_platform_surfaceless-v02 - piglit: http://git.kiwitree.net/cgit/~chadv/piglit/log/?h=review/EGL_MESA_platform_surfaceless-v01 Chad Versace

[Piglit] [PATCH 2/4] util: Parse -h|--help in piglit_parse_subtest_args()

If the args contain -h or --help, then print some help and exit. The help test describes how to list and run subtests. --- tests/util/piglit-util.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/tests/util/piglit-util.c b/tests/util/piglit-util.c index

[Piglit] [PATCH 3/4] egl_khr_fence_sync: Drop duplicate code for parsing --help

piglit_parse_subtest_args() now knows how to parse -h and --help, and then print a help message. --- .../spec/egl_khr_fence_sync/egl_khr_fence_sync.c | 76 -- 1 file changed, 12 insertions(+), 64 deletions(-) diff --git

[Piglit] [PATCH 1/4] util: Link to gbm if gbm is used

If PIGLIT_HAS_GBM, then add GBM_LDFLAGS to the linker flags. Fixes undefined symbol errors at link time for me, using Arch Linux. --- tests/util/CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/util/CMakeLists.txt b/tests/util/CMakeLists.txt index 3d5bef5..277386e

Re: [Piglit] [PATCH] ext_image_dma_buf: Fix memory leak.

free(ref_rgba_image); > return PIGLIT_FAIL; > } > > + free(ref_rgba_image); > return PIGLIT_PASS; Reviewed-by: Chad Versace <chad.vers...@intel.com> And pushed. There are two calls to piglit_report_result() that also trigger the leak. Those should be fixe

Re: [Piglit] [PATCH] ext_image_dma_buf_import/sample_rgb: Make sure the window has alpha.

On Tue 26 Apr 2016, Chad Versace wrote: > On Mon 18 Apr 2016, Eric Anholt wrote: > > Fixes test result in non-auto-fbo mode on Intel, where you end up > > without an alpha channel if you forget to ask for one. > > --- > > tests/spec/ext_image_dma_buf_import/sample_rgb.

Re: [Piglit] [PATCH] ext_image_dma_buf_import/sample_rgb: Make sure the window has alpha.

This fixes `bin/ext_image_dma_buf_import-sample_rgb -fmt=XR24 -alpha-one -auto` for me. Reviewed-by: Chad Versace <chad.vers...@intel.com> ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 1/3] ext_image_dma_buf_import: Use piglit-dispatch

Stop calling eglGetProcAddress. Let piglit-dispatch do it. --- .../intel_external_sampler_only.c | 26 +++--- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/tests/spec/ext_image_dma_buf_import/intel_external_sampler_only.c

[Piglit] [PATCH 3/3] util/dma_buf: Use rendernode if available

The GL_OES_EGL_image_external tests only passed if they succeeded to DRI2-authenticate with the X server, because piglit_drm_dma_buf.c used /dev/dri/card0 as the DRM device. This patch teaches that file to first try /dev/dri/renderD128, then fallback to /dev/dri/card0. Despite the simple goal of

[Piglit] [PATCH 2/3] util: Fix crash when xcb_get_setup() fails

Return early if xcb_get_setup() returns NULL. Don't use the NULL. --- tests/util/piglit-framework-gl/piglit_drm_dma_buf.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c

Re: [Piglit] [PATCH] util: Fix texture name returned by piglit_integer_texture()

On Mon 25 Apr 2016, Nicolai Hähnle wrote: > Hi Chad, > > I saw Matt's email and went ahead and just did this before seeing your > email. Sorry about that! No problem. All that matters is that the bugs get fixed! ___ Piglit mailing list

[Piglit] [PATCH] util: Fix texture name returned by piglit_integer_texture()

The function always returned texture name 0. Fix to to return the actual texture name. Found by GCC warning: tests/util/piglit-util-gl.c:2623:1: warning: control reaches end of non-void function [-Wreturn-type] --- tests/util/piglit-util-gl.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [Piglit] [PATCH v4 5/5] khr_texture_compression_astc: Add array tests

On Fri 02 Oct 2015, Nanley Chery wrote: > From: Nanley Chery > > These tests check that 2D texture arrays work for the 5x5 and > 12x12 block sizes. > > v2. add to all.py (Ilia). > create test for gles2. > v3. upgrade required GLES version to 3.1 (for 2d array

Re: [Piglit] [PATCH v4 3/5] khr_texture_compression_astc: Add miptree tests

ssed and decompressed > texture was generated with a reference codec. > > v2. numerous changes (Chad). > v3. upgrade required GLES version to 2. > > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> Patch 3/5 is Revi

Re: [Piglit] [PATCH v4 4/5] khr_texture_compression_astc: Add API tests

/CMakeLists.gl.txt | 1 + > .../CMakeLists.gles2.txt | 1 + > .../khr_compressed_astc-basic.c| 385 > + > 4 files changed, 389 insertions(+) > create mode 100644 > tests/spec/khr_texture_compression_astc/khr_compressed_astc-

Re: [Piglit] [PATCH v4 2/5] arb_texture_compression/invalid-formats: Add ASTC to list of formats

> Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > --- > tests/all.py | 5 +++ > .../spec/arb_texture_compression/invalid-formats.c | 51 > +- > 2 files changed, 55 insertions(+), 1 deletion

Re: [Piglit] [PATCH v4] khr_texture_compression_astc: Add array tests

S version to 3.1 (for 2d array support). > v4. Move CONFIG block to the top of the file (Chad). > > Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> Acked-by: Chad Versace <chad.vers...@intel.com> ___ Piglit mailing list Piglit

Re: [Piglit] [PATCH v3 3/4] khr_texture_compression_astc: Add miptree tests

On Wed 16 Sep 2015, Nanley Chery wrote: > From: Nanley Chery > > These tests run through every ASTC configuration, comparing the > render of a compressed texture against a render of the decompressed > version of that compressed texture. The compressed and decompressed >

[Piglit] [PATCH] cmake: Link libpiglitutil_gl to libGL

This is the obvious thing to do. This eliminates the need to explicitly link to libGL in every other CMakeLists.gl.txt. Tested-by: Nanley Chery --- tests/util/CMakeLists.gl.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/CMakeLists.gl.txt

Re: [Piglit] [PATCH v2 4/4] Add API tests for KHR_texture_compression_astc_ldr

On Mon 14 Sep 2015, Nanley Chery wrote: > On Tue, Sep 8, 2015 at 11:45 AM, Chad Versace <chad.vers...@intel.com> > wrote: > > > On Fri 28 Aug 2015, Nanley Chery wrote: > > > From: Nanley Chery <nanley.g.ch...@intel.com> > > > > > > These tests

Re: [Piglit] [PATCH v2 3/4] Add miptree tests for khr_texture_compression_astc

On Fri 28 Aug 2015, Nanley Chery wrote: > From: Nanley Chery > > These tests run through every ASTC configuration, comparing the > render of a compressed texture against a render of the decompressed > version of that compressed texture. The compressed and decompressed >

Re: [Piglit] [PATCH v2 4/4] Add API tests for KHR_texture_compression_astc_ldr

On Fri 28 Aug 2015, Nanley Chery wrote: > From: Nanley Chery > > These tests check that the GL error returned by valid and invalid API calls > are as defined by the spec. > > Signed-off-by: Nanley Chery > --- >

Re: [Piglit] [PATCH v2 1/4] arb_texture_compression/invalid-formats: add ASTC to list of formats

.@intel.com> > --- > .../spec/arb_texture_compression/invalid-formats.c | 51 > +- > 1 file changed, 50 insertions(+), 1 deletion(-) Patch 1 is Reviewed-by: Chad Versace <chad.vers...@intel.com> ___ Pi

Re: [Piglit] [PATCH v2 1/4] arb_texture_compression/invalid-formats: add ASTC to list of formats

On Tue 08 Sep 2015, Chad Versace wrote: > On Fri 28 Aug 2015, Nanley Chery wrote: > > From: Nanley Chery <nanley.g.ch...@intel.com> > > > > ASTC formats are added to the list of formats that should not be returned > > by the > > COMPRESSED_TEXTURE_FORMAT

Re: [Piglit] [PATCH v2 1/4] arb_texture_compression/invalid-formats: add ASTC to list of formats

do they still get run during a full Piglit run? > On Sep 8, 2015 09:50, "Chad Versace" <chad.vers...@intel.com> wrote: > > > On Tue 08 Sep 2015, Chad Versace wrote: > > > On Fri 28 Aug 2015, Nanley Chery wrote: > > > > From: Nanley Chery <nanley.g.

Re: [Piglit] [PATCH v2 2/4] util: Add a piglit_probe_rects_equal_rgba() function

> Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com> > --- > tests/util/piglit-util-gl.c | 81 > + > tests/util/piglit-util-gl.h | 31 + > 2 files changed, 112 insertions(+) There's a small typo below.

[Piglit] [PATCH] ext_image_dma_buf: Add tests for R8 and GR88 formats (v2)

Add test that transcodes NV12 to RGBA8 by importing the Y plane as DRM_FORMAT_R8 and importing the UV plane as DRM_FORMAT_GR88. v2: Delete commented-out code. CC: Peter Frühberger peter.fruehber...@gmail.com Cc: Rainer Hochecker rainer.hochec...@onlinehome.de --- This test requires a patch

[Piglit] [PATCH] ext_image_dma_buf: Add tests for R8 and GR88 formats

Add test that transcodes NV12 to RGBA8 by importing the Y plane as DRM_FORMAT_R8 and importing the UV plans as DRM_FORMAT_GR88. CC: Peter Frühberger peter.fruehber...@gmail.com Cc: Rainer Hochecker rainer.hochec...@onlinehome.de --- This patch lives on my branch:

Re: [Piglit] [PATCH] request RGB visual, fixes gbm rendering

On Tue 12 May 2015, Ilia Mirkin wrote: ping? should be pretty innocuous (i'd think!) It looks innocuous to me. Reviewed-by: Chad Versace chad.vers...@intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Piglit] [PATCH] request RGB visual, fixes gbm rendering

On Tue 12 May 2015, Emil Velikov wrote: On 9 May 2015 at 08:08, Ilia Mirkin imir...@alum.mit.edu wrote: GBM presumably defaults to RGB565 otherwise. Not all of these are required, as some would still work with less precision, but this makes the tests consistent. At least fp-formats and

Re: [Piglit] [PATCH] request RGB visual, fixes gbm rendering

On Tue 12 May 2015, Ilia Mirkin wrote: On Tue, May 12, 2015 at 1:13 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 9 May 2015 at 08:08, Ilia Mirkin imir...@alum.mit.edu wrote: GBM presumably defaults to RGB565 otherwise. Not all of these are required, as some would still work with

[Piglit] [PATCH] egl_khr_get_all_proc_addresses: Add sanity test

Emil discovered that my implementation in Mesa was bogus. This test exposes the error. Cc: Emil Velikov emil.l.veli...@gmail.com --- tests/all.py | 6 + tests/egl/spec/CMakeLists.txt | 1 + .../CMakeLists.no_api.txt

[Piglit] [PATCH] dispatch: Fix lookup for core OpenGL symbols

The following commit regressed lookup of some new OpenGL symbols: commit cb334db3f2bb7ddf9b2f43641f898896f99c69b1 Author: Daniel Kurtz djku...@chromium.org Date: Thu Oct 16 21:36:01 2014 +0800 Subject: dispatch: Use dlsym to lookup core symbols for EGL (v2) It regressed these

Re: [Piglit] [PATCH 13/14] dispatch: Use dlsym to lookup core symbols for EGL

On Wed, Apr 29, 2015 at 8:56 AM, Marek Olšák mar...@gmail.com wrote: Correction: Only 2 pipeline statistics tests were broken, so all seems to be good (except those 2 tests). Marek On Tue, Apr 28, 2015 at 3:18 PM, Marek Olšák mar...@gmail.com wrote: Hi Chad, The patch breaks

Re: [Piglit] [PATCH 00/14] Fixes for EGL and EGL tests

On Mon 13 Apr 2015, Marek Olšák wrote: Hi everyone, These are mostly fixes that I took from Daniel Kurtz's github repository because I think they are good and he said he had no time to upstream them. I've been working on the fence extensions for Mesa/egl_dri2, so I've tested them all. All

Re: [Piglit] [PATCH 13/14] dispatch: Use dlsym to lookup core symbols for EGL

, then we can easily fix it by changing it to use get_ext_proc_address() instead of dlsym(). Reviewed-by: Chad Versace chad.vers...@intel.com Thanks for upstreaming all of Daniel's fixes. ___ Piglit mailing list Piglit@lists.freedesktop.org http

Re: [Piglit] [PATCH] arb_get_program_binary: Check piglit_check_gl_error results.

(0) pass; glGetProgramiv(prog, GL_PROGRAM_BINARY_RETRIEVABLE_HINT, value); - got_error = piglit_check_gl_error(0); + pass = piglit_check_gl_error(0) pass; if (value != GL_TRUE) { fprintf(stderr, Reviewed-by: Chad Versace chad.vers...@intel.com

Re: [Piglit] [PATCH] glsl: test for sampling using same unit but different uniform

On 10/15/2014 04:36 AM, Tapani Pälli wrote: Reviewed-by: Chad Versace chad.vers...@intel.com Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- ...fs-texture-uniforms-share-same-unit.shader_test | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 tests

Re: [Piglit] Testing an unsupported function?

On 12/28/2014 10:21 PM, Tapani Pälli wrote: On 12/23/2014 12:35 AM, Ian Romanick wrote: How do I make a piglit test that calls an unsupported function? I want to verify that calling a function not supported by the context either crashes or generates GL_INVALID_OPERATION. All of the

[Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests (v4)

for PIGLIT_DEQP_GLES_EXTRA_ARGS and piglit.conf:deqp-gles.extra_args. Cc: Dylan Baker dylanx.c.ba...@intel.com Cc: Michael W Mason michael.w.ma...@intel.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- v2: - Remove unused imports (dcbaker) - Remove extra newlines (dcbaker) - Don't use 'global

Re: [Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests (v4)

On 12/16/2014 02:10 PM, Dylan Baker wrote: On Tuesday, December 16, 2014 01:49:20 PM Chad Versace wrote: +try: +opt = framework.core.PIGLIT_CONFIG.get(config_option[0], + config_option[1]) +except ConfigParser.NoSectionError

[Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests

Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- v2: - Fix DEQPTest.interpret_result to correctly parse test output. (mwmason) - Remove unused imports (dcbaker) - Remove extra newlines (dcbaker) - Don't use 'global' keyword (dcbaker) - Use global constant

Re: [Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests

On 12/10/2014 09:03 AM, Mike Mason wrote: Hi Chad, See comments below... Mike, I sent v2 before I saw your reply. I'll respin a v3 shortly that takes your comments into account. +def iter_deqp_test_cases(): +Iterate over original dEQP GLES3 testcase names. +caselist_path =

[Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests (v3)

Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- v2: - Remove unused imports (dcbaker) - Remove extra newlines (dcbaker) - Don't use 'global' keyword (dcbaker) - Use global constant for DEQP_GLES3_EXE (dcbaker) - Fix DEQPTest.interpret_result to correctly parse test

Re: [Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests

On 12/08/2014 03:45 AM, Dylan Baker wrote: Hi Chad, I have a few comments below for you, mostly relating to the use of the global keyword. I admit that I had trouble with the global variables in this patch. Python wasn't behaving like C, and that confused me. diff --git

Re: [Piglit] [PATCH] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

On 12/03/2014 05:16 AM, Emil Velikov wrote: On 01/12/14 18:17, Chad Versace wrote: On 12/01/2014 09:41 AM, Chad Versace wrote: On 11/26/2014 01:11 AM, Emil Velikov wrote: Things are not as black and white as you might think. Most of piglit uses what I call target-less rules, which means

Re: [Piglit] [PATCH] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

On 12/01/2014 09:41 AM, Chad Versace wrote: On 11/26/2014 01:11 AM, Emil Velikov wrote: Things are not as black and white as you might think. Most of piglit uses what I call target-less rules, which means that when one does add_definitions ( -DPIGLIT_USE_GLX ) or link_libraries

Re: [Piglit] [PATCH v2] util/gl: link against OPENGL_gl_LIBRARY on waffle aware systems

Janes mark.a.ja...@intel.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- tests/util/CMakeLists.txt | 5 + 1 file changed, 5 insertions(+) Strangely, I can't reproduce the linking error on Fedora 20. Anyway, this patch looks good to me. Reviewed-by: Chad Versace chad.vers

Re: [Piglit] [PATCH 43/45] gen_builtin_packing_tests.py: removed unused variable

= 2.0**(-14) * (1.0 / 2.0**10) -subnormal_max = 2.0**(-14) * (1023.0 / 2.0**10) Weird, yeah. Seems unused. Chad? Yes, unused. Maybe I used it in an uncommitted version of the patch, but it's unused now. Reviewed-by: Chad Versace chad.vers...@linux.intel.com

Re: [Piglit] Piglit Plans

On Thu 13 Nov 2014, Tom Gall wrote: Within Linaro we've recently picked up piglit and added into our buckets of automated tests, running on Android. We'd sure like to see piglit advance for GLES testing so there seems like a lot of room for collaboration. More than willing to give it a go. On

Re: [Piglit] [PATCH 2/2] Fixed gl.py so that it correctly parses the new gl.xml file.

Laura, I tested your updated branch 'master-xml' and commited it to master. Thanks. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] egl_khr_fence_sync: check for EGL_KHR_reusable_sync

On 08/18/2014 07:46 PM, Daniel Kurtz wrote: On Tue, Aug 19, 2014 at 7:05 AM, Chad Versace chad.vers...@linux.intel.com wrote: On 08/13/2014 07:13 PM, Daniel Kurtz wrote: I think the original reason why I wrote this patch was to address build breakage due to the incomplete dispatch (using

Re: [Piglit] [PATCH] egl-util: remove GL include

it was just Xlib deprecation warnings, and they're there without your patch. Sorry for the false alarm. Reviewed-by: Kristian Høgsberg k...@bitplanet.net Looks good to me too. Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing

Re: [Piglit] [PATCH] egl_khr_fence_sync: check for EGL_KHR_reusable_sync

On 08/13/2014 07:13 PM, Daniel Kurtz wrote: On Thu, Aug 14, 2014 at 6:41 AM, Chad Versace chad.vers...@linux.intel.com mailto:chad.vers...@linux.intel.com wrote: On 08/07/2014 04:09 AM, Daniel Kurtz wrote: These tests all require EGL_KHR_reusable_sync. No they don't

Re: [Piglit] [PATCH] egl-util: zero-init state in egl_util_run to avoid crash on failure

crashes. Signed-off-by: Daniel Kurtz djku...@chromium.org --- I do not have commit access, so can someone please submit this for me if it looks good? Thanks -djk Reviewed-by: Chad Versace chad.vers...@linux.intel.com And I committed to master

Re: [Piglit] [PATCH] egl_khr_fence_sync: check for EGL_KHR_reusable_sync

On 08/07/2014 04:09 AM, Daniel Kurtz wrote: These tests all require EGL_KHR_reusable_sync. No they don't, at least according to the spec. Have you found a buggy driver? Or... maybe I wrote the test totally wrong... I hope not. EGL_KHR_resuable_sync defines the sync type EGL_SYNC_REUSABLE_KHR,

Re: [Piglit] [Patch v2 15/18] exectest.py: Fix PiglitTest.is_skip()

Patches 1-15 are Reviewed-by: Chad Versace chad.vers...@linux.intel.com I don't know Piglit's Python well enough to judge patches 16-18. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [Patch v2 1/4] framework: allow loading a piglit.conf from more locations

', + os.path.expandvars('$HOME/.config')), + os.path.join(os.path.dirname(__file__), '..', '..')]: The code searches in the correct order, but the comment describes a different order. Fix the comment and Reviewed-by: Chad Versace chad.vers...@linux.intel.com

Re: [Piglit] [Patch v2 2/4] xts.py: Use piglit.conf to set bindir

On 07/07/2014 04:20 PM, Dylan Baker wrote: v2: - replace config name bindir with path (chadv) Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- piglit.conf.example | 3 +++ tests/xts.py| 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/piglit.conf.example

[Piglit] [PATCH 0/4] Fix some compiler warnings

This series eliminates all compiler warnigns when building with clang. Chad Versace (4): util: Fix a -Wtautological-compare warning util: Fix an -Wabsolute-value warning util: Fix an -Wabsolute-value warning util/fbo: Fix -Wunused-function warnings tests/util/piglit-framework-gl

[Piglit] [PATCH 1/4] util: Fix a -Wtautological-compare warning

tests/util/piglit-log.c: warning: comparison of unsigned enum \ expression 0 is always false [-Wtautological-compare] return opt 0 || opt PIGLIT_LOG_OPT_MAX; ~~~ ^ ~ Fix the warning by removing the dead comparison. Signed-off-by: Chad Versace chad.vers

[Piglit] [PATCH 2/4] util: Fix an -Wabsolute-value warning

To fix the warning below, cast uint to int. tests/util/piglit-util-gl-common.c:1273:9: warning: taking the absolute value \ of unsigned type 'unsigned int' has no effect [-Wabsolute-value] if (fabs(probe[p] - expected[p]) = piglit_tolerance[p]) { Signed-off-by: Chad Versace chad.vers

[Piglit] [PATCH 3/4] util: Fix an -Wabsolute-value warning

]) { ^ tests/util/piglit-util-gl-common.c:1240:9: note: use function 'abs' instead if (fabs(probe[p] - expected[p]) = piglit_tolerance[p]) { ^~~~ abs Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-util-gl-common.c | 2 +- 1 file changed, 1 insertion

[Piglit] [PATCH 4/4] util/fbo: Fix -Wunused-function warnings

guards. This patch shouldn't change any runtime behavior. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl/piglit_fbo_framework.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/util/piglit-framework-gl

[Piglit] [PATCH 01/16] util/fbo: Don't re-initialize piglit-dispatch in fbo framework

piglit_wfl_framework already initializes piglit-dispatch. Don't do it again. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl/piglit_fbo_framework.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/util/piglit-framework-gl

[Piglit] [PATCH 04/16] util/shader: Unify some funcs between GL and GLES

. This patch brings us one step closer to unifying Piglit's CMake files. piglit_require_GLSL piglit_require_vertex_shader piglit_require_fragment_shader piglit_program_pipeline_check_status piglit_program_pipeline_check_status_quiet Signed-off-by: Chad Versace chad.vers...@linux.intel.com

[Piglit] [PATCH 02/16] util/shader: Remove an unneeded #ifdef PIGLIT_USE_OPENGL

The entire file piglit-shader-gl.c was protected by #ifdef PIGLIT_USE_OPENGL. This patch removes the #ifdef. Now that piglit-dispatch supports every OpenGL API, there is no longer a need for it. This patch brings us one step closer to unifying Piglit's CMake files. Signed-off-by: Chad Versace

[Piglit] [PATCH 03/16] util: Remove unsued file piglit-shader-gles1.c

CMake never knew about this file, and now it never will. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-shader-gles1.c | 65 1 file changed, 65 deletions(-) delete mode 100644 tests/util/piglit-shader-gles1.c diff --git

[Piglit] [PATCH 05/16] util/shader: Remove empty files piglit-shader-gl*.c

These files are no longer used after moving all their functions to piglit-shader.c. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/CMakeLists.gl.txt | 3 --- tests/util/CMakeLists.gles2.txt | 2 -- tests/util/CMakeLists.gles3.txt | 2 -- tests/util

[Piglit] [PATCH 07/16] util/minmax: Remove all #ifdef PIGLIT_USE_OPENGL guards

Now that piglit-dispatch supports every OpenGL API, there is no longer a need to provide separate implementations for GL and GLES. This patch brings us one step closer to unifying Piglit's CMake files. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/minmax-test.c | 8

[Piglit] [PATCH 11/16] util/gl: Unify piglit_draw_rect_from_arrays() among APIs

Now that piglit-dispatch supports every OpenGL API, there is no longer a need to provide separate implementations for GL and GLES. Piglit can make API-based decisions at runtime rather than buildtime. This patch brings us one step closer to unifying Piglit's CMake files. Signed-off-by: Chad

[Piglit] [PATCH 13/16] util/ktx: Unify piglit_ktx_load_noncubeface() between GL and GLES

Now that piglit-dispatch supports every OpenGL API, there is no longer a need to provide separate implementations for GL and GLES. Piglit can make API-based decisions at runtime rather than buildtime. This patch brings us one step closer to unifying Piglit's CMake files. Signed-off-by: Chad

[Piglit] [PATCH 16/16] cmake: Make each libpiglitutil_gl* contain identical set of files

of libpiglitutil_{gl,gles1,gles2,gles3} contain the same set of source files. This patch brings us one step closer to unifying Piglit's CMake files. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/CMakeLists.gl.txt| 10 -- tests/util/CMakeLists.gles2.txt | 8

[Piglit] [PATCH 10/16] util/gl: Define piglit_*ortho_uniform() functions in GL builds too

Now that piglit-dispatch supports every OpenGL API, there is no longer a need to provide separate implementations for GL and GLES. This patch brings us one step closer to unifying Piglit's CMake files. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-util-gl

[Piglit] [PATCH 12/16] util/gl: Unify vertex_attrib_description::setup() amongs APIs

Now that piglit-dispatch supports every OpenGL API, there is no longer a need to provide separate implementations for GL and GLES. Piglit can make API-based decisions at runtime rather than buildtime. This patch brings us one step closer to unifying Piglit's CMake files. Signed-off-by: Chad

[Piglit] [PATCH 06/16] util/shader: Remove the last #ifdef PIGLIT_USE_OPENGL guard

-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-shader.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/util/piglit-shader.c b/tests/util/piglit-shader.c index 38e5182..1f20a8e 100644 --- a/tests/util/piglit-shader.c +++ b/tests/util/piglit-shader.c @@ -101,14 +101,12

[Piglit] [PATCH 09/16] util/gl: Unify piglit_get_compressed_block_size() between GL and GLES

Now that piglit-dispatch supports every OpenGL API, there is no longer a need to provide separate implementations for GL and GLES. This patch brings us one step closer to unifying Piglit's CMake files. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-util-gl

Re: [Piglit] [PATCH 00/16] Unify piglit-util-{gl, gles}.c into piglit-util-gl-common.c

On Thu, Jul 03, 2014 at 12:37:57PM -0700, Josh Triplett wrote: This patch series unifies both the GL and GLES utility functions into a single set of functions in piglit-util-gl-common.c, in preparation for unifying the libraries themselves. I've confirmed (on an IVB test system) that this

Re: [Piglit] [PATCH] cmake: Require Mako = 0.7

On Fri, Jul 04, 2014 at 08:43:29AM -0700, Tom Stellard wrote: On Wed, Jun 25, 2014 at 08:47:24PM -0700, Chad Versace wrote: Piglit began requiring Mako 0.7 as of commit ac1f382 dispatch: Generate piglit-dispatch from Khronos XML. Piglit has required Mako for a long time, and CMake did

Re: [Piglit] [PATCH] egl-create-surface: Remove unused variable.

...@freedesktop.org --- tests/egl/egl-create-surface.c | 6 -- 1 file changed, 6 deletions(-) Reviewed-by: Chad Versace chad.vers...@linux.intel.com and committed. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org

Re: [Piglit] [PATCH 1/4] framework: allow loading a piglit.conf from more locations

of XDG_CONFIG_HOME should respect the environment variable, if set. Like this: xdg_config_dir = os.environ.get('XDG_CONFIG_HOME', os.path.expanduser('~/.config')) Respect the XDG_CONFIG_HOME env var, and this patches is Reviewed-by: Chad Versace chad.vers

Re: [Piglit] [PATCH 3/4] igt: use piglit.conf instead of a symlink

On Mon, Jun 30, 2014 at 04:53:21PM -0700, Dylan Baker wrote: Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- piglit.conf.example | 4 tests/igt.py| 11 --- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/piglit.conf.example b/piglit.conf.example

Re: [Piglit] [PATCH] util/wfl: remove log prints in success paths

...@alum.mit.edu --- tests/util/piglit-framework-gl/piglit_wfl_framework.c | 4 1 file changed, 4 insertions(+) Reviewed-by: Chad Versace chad.vers...@linux.intel.com ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org

[Piglit] [PATCH 1/2] util/log: Add function piglit_logd()

The function logs a debug message if environment variable PIGLIT_DEBUG is 1 or true. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-log.c | 37 + tests/util/piglit-log.h | 6 ++ 2 files changed, 43 insertions(+) diff --git

[Piglit] [PATCH 2/2] util/wfl: Re-enable GL 3.1 log messages in debug paths

Commit 1fdb953 removed some noisy debug messages with preprocessor guards. This patch re-enables them, but only if the environment variable PIGLIT_DEBUG is 1 or true. Fixes some unused variable warnings. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl

Re: [Piglit] [PATCH 1/2] util/log: Add function piglit_logd()

On Mon, Jun 30, 2014 at 08:14:16PM -0400, Ilia Mirkin wrote: On Mon, Jun 30, 2014 at 8:11 PM, Chad Versace chad.vers...@linux.intel.com wrote: The function logs a debug message if environment variable PIGLIT_DEBUG is 1 or true. Signed-off-by: Chad Versace chad.vers...@linux.intel.com

[Piglit] [PATCH] cmake: Require Mako = 0.7

on failure: Hint: Try installing Mako with `pip install --user --upgrade Mako` Reported-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt | 13 ++ cmake/Modules/PiglitFindMako.cmake | 93

Re: [Piglit] Piglit build fails: NameError: global name 'fake_whitespace' is not defined

for this to cmake. Patch sent: From: Chad Versace chad.vers...@linux.intel.com Date: Wed, 25 Jun 2014 20:38:25 -0700 Subject: [PATCH] cmake: Require Mako = 0.7 If no one objects, I will commit it Thursday evening. ___ Piglit mailing list Piglit

Re: [Piglit] [PATCH] Revert python: change she-bang to python2

On Mon, Jun 23, 2014 at 05:36:13PM -0700, Dylan Baker wrote: Chad, you mentioned you had comments on this patch? Right, I commented on the Bugzilla ticket. https://bugs.freedesktop.org/show_bug.cgi?id=80261 ___ Piglit mailing list

[Piglit] [PATCH 6/6] dispatch: Use piglit-dispatch for GLES1

piglit-dispatch*.c to libpiglitutil_gles1 in the CMake. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/piglit/gl_wrap.h | 68 +- .../depth-stencil-texture.c| 9 --- tests/util/CMakeLists.gl.txt

[Piglit] [PATCH 0/6] Generate dispatch from Khronos XML and use dispatch for GLES1 (v2)

refs/tags/unify-build-2014-06-16 You can follow work in progress on the branch: git://people.freedesktop.org/~chadversary/piglit refs/heads/unify-build v2: - Fix typo: s/Khronox/Khronos/ - Truncate patch 2 so that mailmain accepts it. Chad Versace (6): registry: Import gl.xml from

[Piglit] [PATCH 4/6] glapi: Remove the glapi directory

The directory is no longer used because Piglit now generates piglit-dispatch from the Khronos XML. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- Patch truncated due to size. CMakeLists.txt | 1 - cmake/piglit_glapi.cmake |45 - glapi/.gitignore | 1

  1   2   3   4   5   6   >