Re: [Piglit] [PATCH 01/20] util: Generalize piglit_probe_image_{rgb, rgba}

Hi Paul, this patch is: Acked-by: Marek Olšák mar...@gmail.com Marek On Wed, Jun 6, 2012 at 2:03 AM, Paul Berry stereotype...@gmail.com wrote: This patch eliminates code duplication between piglit_probe_image_rgb() and piglit_probe_image_rgba() by implementing them both in terms of a common

[Piglit] [PATCH] max-texture-size: allow INVALID_VALUE if first TexImage fails with OUT_OF_MEMORY

The GL spec says that the behavior of a command returning OUT_OF_MEMORY is undefined, therefore the following call to TexSubImage may return INVALID_VALUE. (e.g. if TexWidth is 0 because the call to TexImage had no effect because of OUT_OF_MEMORY, then the check xoffset+width TexWidth in

Re: [Piglit] [PATCH] max-texture-size: allow INVALID_VALUE if first TexImage fails with OUT_OF_MEMORY

On Tue, Jun 19, 2012 at 7:41 PM, Eric Anholt e...@anholt.net wrote: On Fri, 15 Jun 2012 04:28:54 +0200, Marek Olšák mar...@gmail.com wrote: The GL spec says that the behavior of a command returning OUT_OF_MEMORY is undefined, therefore the following call to TexSubImage may return

[Piglit] [PATCH 1/2] Add tests for ARB_transform_feedback3

--- tests/all.tests | 11 + tests/spec/ext_transform_feedback/output-type.c | 624 --- 2 files changed, 445 insertions(+), 190 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 07eba93..22cb896 100644 --- a/tests/all.tests

[Piglit] [PATCH 2/2] Add a test for ARB_transform_feedback_instanced

--- tests/all.tests|4 +++ tests/spec/arb_transform_feedback2/draw-auto.c | 40 +--- 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 22cb896..547c2af 100644 --- a/tests/all.tests +++

Re: [Piglit] [PATCH] Add tests for glEdgeFlag().

On Sat, Jul 28, 2012 at 2:14 AM, Eric Anholt e...@anholt.net wrote: --- tests/all.tests |5 ++ tests/spec/CMakeLists.txt |1 + tests/spec/gl-1.0/CMakeLists.gl.txt | 15 + tests/spec/gl-1.0/CMakeLists.txt|1 +

[Piglit] [PATCH] ext_framebuffer_multisample: relax MSAA precision

r600g needs this to successfully pass the 8x MSAA accuracy tests. --- tests/spec/ext_framebuffer_multisample/common.cpp | 10 +- tests/spec/ext_framebuffer_multisample/common.h |2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [Piglit] [PATCH] ext_framebuffer_multisample: relax MSAA precision

It might be caused by the sample positions extending outside of the pixel boundary. I'll see if a different configuration passes the test. Marek On Wed, Aug 15, 2012 at 12:16 AM, Paul Berry stereotype...@gmail.com wrote: On 13 August 2012 10:31, Marek Olšák mar...@gmail.com wrote: r600g needs

Re: [Piglit] [PATCH] copyteximage: loosen the tolerance for compressed formats

Interesting, I have the same patch here, except that I need the tolerance to be 5,5,5,5 for r300g (COMPRESSED_RED is fetched with 4 bits of precision, but 5 is good enough for the test). Could you please change it to 5,5,5,5? Marek On Tue, Aug 28, 2012 at 10:32 PM, Brian Paul

[Piglit] [PATCH 1/2] fbo-generatemipmap-formats: increase tolerance for compressed formats

--- tests/fbo/fbo-generatemipmap-formats.c |9 + 1 file changed, 9 insertions(+) diff --git a/tests/fbo/fbo-generatemipmap-formats.c b/tests/fbo/fbo-generatemipmap-formats.c index 1282a1d..4a7d58e 100644 --- a/tests/fbo/fbo-generatemipmap-formats.c +++

[Piglit] [PATCH 2/2] uniform-initializer tests: fix GLSL version of uint tests

--- generated_tests/gen_uniform_initializer_tests.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/generated_tests/gen_uniform_initializer_tests.py b/generated_tests/gen_uniform_initializer_tests.py index f5b5cb1..dbb798d 100644 ---

[Piglit] [PATCH] glean/texCombine: test fewer combinations

It takes 10 minutes for llvmpipe to finish this test. With this patch, it takes 20 seconds. Before: Tested 104 GL_REPLACE combinations Tested 7540 GL_ADD combinations Tested 7540 GL_ADD_SIGNED_EXT combinations Tested 7540 GL_MODULATE combinations Tested 5957 GL_INTERPOLATE_EXT combinations

[Piglit] [PATCH 1/2] glean/depthStencil: fix the test

It wasn't doing anything. --- tests/glean/tdepthstencil.cpp |4 1 file changed, 4 deletions(-) diff --git a/tests/glean/tdepthstencil.cpp b/tests/glean/tdepthstencil.cpp index c8c1ca9..b4f8469 100644 --- a/tests/glean/tdepthstencil.cpp +++ b/tests/glean/tdepthstencil.cpp @@ -38,8 +38,6

[Piglit] [PATCH 2/2] fbo-blit-stretch: add ability to choose a subtest

--- tests/fbo/fbo-blit-stretch.cpp |9 + 1 file changed, 9 insertions(+) diff --git a/tests/fbo/fbo-blit-stretch.cpp b/tests/fbo/fbo-blit-stretch.cpp index f990954..4c4b528 100644 --- a/tests/fbo/fbo-blit-stretch.cpp +++ b/tests/fbo/fbo-blit-stretch.cpp @@ -530,11 +530,17 @@ tests[]

Re: [Piglit] glean/depthStencil: Warning: depthStencil ignored; not a valid test name.

AFAIK, GL_EXT_packed_depth_stencil is not defined with the new dispatch. I already pushed the fix for the test. Marek On Wed, Sep 12, 2012 at 4:32 PM, Brian Paul bri...@vmware.com wrote: On 09/12/2012 08:23 AM, Andreas Boll wrote: 2012/9/12 Andreas Bollandreas.boll@gmail.com: I get the

[Piglit] [PATCH] fbo-colormask-formats: test glColorMask with all formats

@@ -0,0 +1,237 @@ +/* + * Copyright © 2010 Intel Corporation + * Copyright © 2012 Marek Olšák mar...@gmail.com + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the Software), + * to deal in the Software without

[Piglit] [PATCH] glsl-fs-shadow2D-clamp-z: test clamping of Z in shadow2D

--- .../samplers/glsl-fs-shadow2D-clamp-z.shader_test | 30 1 file changed, 30 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/samplers/glsl-fs-shadow2D-clamp-z.shader_test diff --git

[Piglit] [PATCH 2/3] all.tests: remove MSAA integer tests

AFAIK, integer formats cannot be resolved, but only one sample is chosen and copied to the destination. However the chosen sample might not be at the center of the pixel, so the tests might never pass. --- tests/all.tests |2 -- 1 file changed, 2 deletions(-) diff --git a/tests/all.tests

[Piglit] [PATCH 3/3] Generate a html summary of skipped tests

--- framework/summary.py |3 +++ piglit-summary-html.py |6 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/framework/summary.py b/framework/summary.py index 50ba58b..a193351 100644 --- a/framework/summary.py +++ b/framework/summary.py @@ -97,6 +97,7 @@ results is

[Piglit] [PATCH] fbo-clear-format: test stencil glClear

The test visualizes the stencil buffer (unlike some other tests), which is very useful for debugging. Unfortunately, it doesn't work with Mesa. There seems to be a bogus GL error. The problem can be reproduced by running: ./fbo-clear-formats GL_EXT_packed_depth_stencil stencil -auto It would be

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

-texelFetchOffest-2D. Reported-by: Marek Olšák mar...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com We should fix those tests to work correctly in the presence of alpha in the visual. The system could have all visuals with alpha, and the test should deal with it. That said

[Piglit] [PATCH 2/3] all.tests: move all tests from the vpfpgeneric group into spec

--- tests/all.tests | 95 +-- 1 files changed, 50 insertions(+), 45 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 7bc0eb0..0e46a70 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -484,51 +484,8 @@

[Piglit] [PATCH 1/3] all.tests: move all tests from the fbo group into spec

--- tests/all.tests | 168 +-- 1 files changed, 88 insertions(+), 80 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 6b5466a..7bc0eb0 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -180,84 +180,6 @@ def

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

On Wed, Oct 17, 2012 at 2:12 AM, Ian Romanick i...@freedesktop.org wrote: On 10/16/2012 03:37 PM, Marek Olšák wrote: There is one test fdo25614-genmipmap which reproduces a bug only occuring with a framebuffer without alpha. If we enforce RGBA everywhere, not only would the test be useless

[Piglit] [PATCH 1/3] all.tests: move all tests from general into spec

--- tests/all.tests | 265 +++ 1 files changed, 149 insertions(+), 116 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 341d021..a260073 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -180,119 +180,6 @@ def

[Piglit] [PATCH 2/3] all.tests: move all tests from texturing into spec

--- tests/all.tests | 187 +- tests/quick-driver.tests |2 +- 2 files changed, 103 insertions(+), 86 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index a260073..5849a91 100644 --- a/tests/all.tests +++ b/tests/all.tests @@

[Piglit] [PATCH 3/3] all.tests: remove glean/exactRGBA

I don't know of any driver which passes the test. It's too strict to be useful. --- tests/all.tests |1 - tests/quick-driver.tests |3 --- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 5849a91..78e09e8 100644 ---

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

-texelFetchOffest-2D. Reported-by: Marek Olšák mar...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl.h | 8 tests/util/piglit-framework-gl/piglit_winsys_framework.c | 11 +-- 2 files changed, 13

Re: [Piglit] [PATCH 2/2] glx: Replace glFlush calls with glFinish

I think glFenceSync+glFlush in one context and glWaitSync (server-side synchronization) in the other context would be the best solution. It shouldn't block the CPU, but it should set the right ordering of commands. glFinish seems to be overkill. Marek On Mon, Nov 19, 2012 at 10:27 PM, Eric

Re: [Piglit] [PATCH] texture-integer-glsl130: Expect 1 for alpha in R, RG, RGB cases.

On Thu, Nov 22, 2012 at 2:57 PM, Marek Olšák mar...@gmail.com wrote: The test fails because it's wrong. The expected integer alpha is 1, but the bias is a large negative value, therefore (a - bias) is always = 0, so the test always fails. Correction: bias is a negative value, therefore (alpha

Re: [Piglit] [PATCH 5/5] textureSize: Add support for running with core GL.

Hi Eric, this patch breaks textureSize on drivers which fail to create a 3.1 core context. The test fails with the GLXBadFBConfig error. I'm using waffle. Marek On Thu, Nov 1, 2012 at 7:36 PM, Eric Anholt e...@anholt.net wrote: This lets the textureSize tests for TBOs run on i965. ---

Re: [Piglit] [ANNOUNCE] waffle-1.2.2

On Wed, Nov 28, 2012 at 7:26 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 11/27/2012 07:47 PM, Marek Olšák wrote: HI Chad, FYI, the core GL support in the GLX backend of waffle and/or piglit seems to be broken. All piglit tests that specify the core GL version and are run

Re: [Piglit] [ANNOUNCE] waffle-1.2.2

On Wed, Nov 28, 2012 at 8:42 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 11/28/2012 10:40 AM, Marek Olšák wrote: On Wed, Nov 28, 2012 at 7:26 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 11/27/2012 07:47 PM, Marek Olšák wrote: HI Chad, FYI, the core GL support

[Piglit] [PATCH] glean/pointAtten: test fewer combinations, don't call glFinish

Before: PASS: 87750 antialiased combinations tested. PASS: 87750 aliased combinations tested. real 0m16.731s user 0m4.988s sys0m8.632s After: PASS: 17550 antialiased combinations tested. PASS: 17550 aliased combinations tested. real 0m2.910s user 0m0.880s sys

[Piglit] [PATCH 1/2] getteximage-targets: test glGetTexImage with all texture targets

/getteximage-targets.c b/tests/texturing/getteximage-targets.c new file mode 100644 index 000..64b7e78 --- /dev/null +++ b/tests/texturing/getteximage-targets.c @@ -0,0 +1,220 @@ +/* + * Copyright © 2012 Marek Olšák mar...@gmail.com + * + * Permission is hereby granted, free of charge, to any

[Piglit] [PATCH 2/2] copyteximage: test packed depth stencil formats

--- tests/texturing/copyteximage.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/tests/texturing/copyteximage.c b/tests/texturing/copyteximage.c index f388ed2..43b8daa 100644 --- a/tests/texturing/copyteximage.c +++

[Piglit] [PATCH] ext_framebuffer_multisample: report SKIP if the FBO is unsupported

Why it reports FAIL in that case is beyond me. R6xx doesn't support integer formats and R11G11B10 for MSAA rendering. --- tests/spec/ext_framebuffer_multisample/common.cpp | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git

Re: [Piglit] [PATCH 1/2] getteximage-targets: test glGetTexImage with all texture targets

On Sat, Dec 22, 2012 at 9:25 AM, Eric Anholt e...@anholt.net wrote: Marek Olšák mar...@gmail.com writes: The subject says all texture targets, but how about texture rectangles? (Not that they're really different from the getteximage implementation perspective) Ah, I forgot about texture

Re: [Piglit] Deleting ~20% of glean/no more directory spam

These tests aren't sufficiently covered by piglit tests and should be kept: - fragProg1 (our main test for ARB_fragment_program, the piglit tests aren't so useful as this one) - paths (the only test for polygon stippling apart from pbo?) - pbo - stencil2 (tests glStencilMaskSeparate) - vertProg1

[Piglit] [PATCH] getteximage-targets: test glGetTexImage with all texture targets (v2)

-targets.c @@ -0,0 +1,221 @@ +/* + * Copyright © 2012 Marek Olšák mar...@gmail.com + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the Software), + * to deal in the Software without restriction, including without

[Piglit] [PATCH 1/6] all.tests: test 6x MSAA

This mode is supported by R300-R500 GPUs. --- tests/all.tests |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/all.tests b/tests/all.tests index 7053989..19c9002 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -68,7 +68,7 @@ except SystemExit: pass #

[Piglit] [PATCH 3/6] MSAA tests: don't use glClearBuffer

--- tests/spec/ext_framebuffer_multisample/common.cpp |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/spec/ext_framebuffer_multisample/common.cpp b/tests/spec/ext_framebuffer_multisample/common.cpp index 9109b86..b467c27 100644 ---

[Piglit] [PATCH 4/6] ext_framebuffer_multisample/formats: only create GLSL 1.30 shaders with GL3

--- tests/spec/ext_framebuffer_multisample/formats.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/spec/ext_framebuffer_multisample/formats.cpp b/tests/spec/ext_framebuffer_multisample/formats.cpp index 1947c48..13840e1 100644 ---

[Piglit] [PATCH 5/6] ext_framebuffer_multisample/formats: don't try invalid renderbuffer formats

--- tests/spec/ext_framebuffer_multisample/formats.cpp |5 + 1 file changed, 5 insertions(+) diff --git a/tests/spec/ext_framebuffer_multisample/formats.cpp b/tests/spec/ext_framebuffer_multisample/formats.cpp index 13840e1..8ef6c7f 100644 ---

[Piglit] [PATCH 0/6] Porting MSAA tests to GL 2.1

Since we now have a GL 2.1 driver with MSAA support - r300g, I had to port most MSAA tests to GL 2.1, while not affecting the tests that *really* need GL 3. I have verified that the expected and reported precision of the accuracy tests wasn't changed, even though I had to rewrite some GLSL code

[Piglit] [PATCH 1/3] all.tests: split a plain test name into an array of arguments

--- tests/all.tests |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 7053989..2a99fc8 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -37,8 +37,8 @@ def add_single_param_test_set(group, name, *params): for param in

[Piglit] [PATCH 2/3] fbo-drawbuffers: test masked clear

--- tests/all.tests |1 + tests/fbo/fbo-drawbuffers.c | 40 +--- 2 files changed, 34 insertions(+), 7 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 2a99fc8..f719f7c 100644 --- a/tests/all.tests +++ b/tests/all.tests @@

[Piglit] [PATCH 3/3] fbo-drawbuffers2-color: test masked clear

--- tests/all.tests|1 + tests/fbo/fbo-drawbuffers2-colormask.c | 19 +-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index f719f7c..514b1cb 100644 --- a/tests/all.tests +++ b/tests/all.tests @@

Re: [Piglit] [PATCH 1/3] fbo-blending-formats: Enable testing for channels with 0 bits of data.

The series is: Reviewed-by: Marek Olšák mar...@gmail.com I hope other tests are not broken by this change in the util code. Marek On Mon, Jan 14, 2013 at 11:30 PM, Carl Worth cwo...@cworth.org wrote: The existing code is intentionally disabling testing for channels with 1 bit of data, (since

Re: [Piglit] [PATCH 2/6] MSAA tests: port all GLSL shaders to GLSL 1.20

On Wed, Jan 9, 2013 at 8:57 PM, Paul Berry stereotype...@gmail.com wrote: On 6 January 2013 06:12, Marek Olšák mar...@gmail.com wrote: --- tests/spec/ext_framebuffer_multisample/common.cpp | 126 .../draw-buffers-common.cpp| 52

Re: [Piglit] [PATCH 1/3] fbo-blending-formats: Enable testing for channels with 0 bits of data.

On Wed, Jan 16, 2013 at 12:07 AM, Carl Worth cwo...@cworth.org wrote: Marek Olšák mar...@gmail.com writes: The series is: Reviewed-by: Marek Olšák mar...@gmail.com Thanks for the review, Marek. I hope other tests are not broken by this change in the util code. That's a good point. I do

Re: [Piglit] [PATCH 5/3] fbo-alphatest-formats: Skip testing for ALPHA-only formats

I think it would be better to change the visual and the probes to RGBA and test alpha formats instead of skipping them. That said, I'm okay with committing this patch. Marek On Tue, Jan 22, 2013 at 10:59 PM, Carl Worth cwo...@cworth.org wrote: The test uses an RGB probe to determine whether a

Re: [Piglit] [Mesa-dev] [PATCH] ext_framebuffer_multisample: check for num_samples=1

On Mon, Jan 28, 2013 at 4:54 PM, Brian Paul bri...@vmware.com wrote: [cross-posting this reply to the mesa-dev list] On 01/27/2013 09:07 AM, Brian Paul wrote: On Sun, Jan 27, 2013 at 2:51 AM, Eric Anholte...@anholt.net wrote: Brian Paulbri...@vmware.com writes: Even if

[Piglit] [PATCH] getteximage-formats: test GetTexImage after rendering to textures

This tests whether our GetTexImage doesn't actually rely on TexImage being called first. In this test, TexImage is not used to store data. --- tests/all.tests |1 + tests/texturing/getteximage-formats.c | 75 + 2 files changed, 58

Re: [Piglit] [PATCH] getteximage-formats: test GetTexImage after rendering to textures

On Thu, Feb 7, 2013 at 4:10 PM, Brian Paul bri...@vmware.com wrote: On 02/06/2013 05:06 PM, Marek Olšák wrote: This tests whether our GetTexImage doesn't actually rely on TexImage being called first. In this test, TexImage is not used to store data. --- tests/all.tests

[Piglit] [PATCH] fbo-blit: test BlitFramebuffer with GL_TEXTURE_RECTANGLE

--- tests/all.tests |1 + tests/fbo/fbo-blit.c | 22 +- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 2278026..9595070 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -1140,6 +1140,7 @@

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

The patch seems to be too large for a mailing list. It's here: http://cgit.freedesktop.org/~mareko/piglit/commit/?id=8fa85790a3e5a3caba3a6eba912e7858c893363b Marek On Wed, Mar 27, 2013 at 11:39 PM, Brian Paul bri...@vmware.com wrote: On 03/26/2013 11:13 AM, Marek Olšák wrote: Hi, would

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

On Tue, Apr 2, 2013 at 7:16 PM, Chad Versace chad.vers...@linux.intel.comwrote: On Tue, Mar 26, 2013 at 06:13:59PM +0100, Marek Olšák wrote: Hi, would anyone like to comment on this? Or is it still stuck in the moderation queue? The hunk below will break Piglit on Windows and Mac. Comments

[Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader

HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Authors: + * Marek Olšák mar...@gmail.com

Re: [Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader

On Thu, May 9, 2013 at 1:16 AM, Brian Paul bri...@vmware.com wrote: +static const char *vs_source = + #define NUM %i \n + uniform sampler2D vertex_tex[NUM]; \n + uniform int vertex_index; + varying vec3 vertex_tex_color; \n + void main() \n + { \n +

Re: [Piglit] [PATCH 5/5] fbo-clear-formats: Return texture name as uint.

Thanks. I went ahead and pushed this commit. Marek On Fri, May 3, 2013 at 9:18 AM, Fabian Bieler fabianbie...@fastmail.fm wrote: --- tests/fbo/fbo-clear-formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fbo/fbo-clear-formats.c

[Piglit] [PATCH 3/5] Add -samples=n command-line argument forcing MSAA visuals

--- tests/util/piglit-framework-gl.c | 20 +++- tests/util/piglit-framework-gl.h |1 + .../piglit-framework-gl/piglit_fbo_framework.c |5 + .../piglit-framework-gl/piglit_glut_framework.c|5 +

[Piglit] [PATCH 5/5] all.tests: enable testing of MSAA visuals for a few selected tests

These tests have proved to be useful for implementing and fixing MSAA visuals. I also recommend the mesa/demos tests reflect and copypixrate to test front buffer MSAA rendering. --- tests/all.tests | 64 ++- 1 file changed, 40 insertions(+),

Re: [Piglit] [PATCH 2/5] read-front: modify the test to reproduce an MSAA front buffer bug in st/dri

Yes, that would reproduce the bug too. Marek On Sat, Jun 1, 2013 at 4:31 PM, Paul Berry stereotype...@gmail.com wrote: On 1 June 2013 05:38, Marek Olšák mar...@gmail.com wrote: --- tests/all.tests|1 + tests/general/read-front.c | 15 ++- 2 files changed, 15

Re: [Piglit] Testing against undefined behaviour in asmparsertest/shaders/ARBvp1.0/address-06

If I'm reading the grammar correctly, the constant offset must be in the range [-64, 63]: addrRegRelOffset ::= | + addrRegPosOffset | - addrRegNegOffset addrRegPosOffset ::= integer from 0 to 63 addrRegNegOffset

Re: [Piglit] [PATCH 1/2] texture-integer: fix issue with GL_RGB_INTEGER_EXT swizzle

For the series: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Tue, Aug 13, 2013 at 11:24 PM, Martin Andersson g02ma...@gmail.com wrote: The expected alpha was set to zero instead of the random alpha value. The test passed for all random alpha values greater than zero, because

Re: [Piglit] [PATCH 1/2] texture-integer: fix issue with GL_RGB_INTEGER_EXT swizzle

Pushed, thanks. Marek On Wed, Sep 4, 2013 at 8:46 PM, Martin Andersson g02ma...@gmail.com wrote: Hi Marek, If there are no objections, maybe you could commit these patches? //Martin On Wed, Aug 28, 2013 at 12:25 PM, Marek Olšák mar...@gmail.com wrote: For the series: Reviewed-by: Marek

[Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

The Radeon driver writes GPU page faults to dmesg and we need to know which test caused them. If there is any change in dmesg during a test run, the test result is changed as follows: * pass - dmesg-warn * warn - dmesg-warn * fail - dmesg-fail Dmesg is captured before and after the test and the

[Piglit] [PATCH 1/3] piglit-run: add back -c0

--- piglit-run.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/piglit-run.py b/piglit-run.py index e8e11b7..7945b21 100755 --- a/piglit-run.py +++ b/piglit-run.py @@ -62,7 +62,7 @@ def main(): action = append, metavar =

[Piglit] [PATCH 2/3] Merge quick-driver.tests to quick.tests

--- tests/quick-driver.tests | 14 -- tests/quick.tests| 6 ++ 2 files changed, 6 insertions(+), 14 deletions(-) delete mode 100644 tests/quick-driver.tests diff --git a/tests/quick-driver.tests b/tests/quick-driver.tests deleted file mode 100644 index f7c1a0f..000

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

... Will this throw ?false? positives as a result of DPM performance level changes on kernel 3.11+ (assuming dpm is enabled)? Is there any way to filter these messages out besides disabling DPM? --Aaron On Sep 16, 2013, at 1:08 PM, Marek Olšák mar...@gmail.com wrote: The Radeon driver writes

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

On Wed, Sep 18, 2013 at 1:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013 00:48:45 Marek Olšák wrote: On Tue, Sep 17, 2013 at 6:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday 16 September 2013 20:08:35 Marek Olšák wrote: The Radeon driver writes

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

On Tue, Sep 17, 2013 at 6:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday 16 September 2013 20:08:35 Marek Olšák wrote: The Radeon driver writes GPU page faults to dmesg and we need to know which test caused them. If there is any change in dmesg during a test run, the test result

[Piglit] [PATCH] texelFetch: test various texture dimensions

This is the ultimate test for validating texture allocation in the driver. texelFetch is a perfect test for it: it supports various texture targets, NPOT textures, and mipmapping. It's also our only test for NPOT 3D mipmapped textures. This commit adds support for testing various texture

Re: [Piglit] [PATCH] Optionally capture dmesg changes for each test and report them in a summary

log. Marek On Wed, Sep 18, 2013 at 11:17 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013 14:16:11 you wrote: From: Marek Olšák mar...@gmail.com The Radeon driver writes GPU page faults to dmesg and we need to know which test caused them. If there is any change

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

I'll send a new patch, stay tuned. Marek On Fri, Sep 20, 2013 at 10:32 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013 01:21:59 Marek Olšák wrote: On Wed, Sep 18, 2013 at 1:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013 00:48

[Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

The Radeon driver writes GPU page faults to dmesg and we need to know which tests caused them. If there is any change in dmesg during a test run, the test result is changed as follows: * pass - dmesg-warn * warn - dmesg-warn * fail - dmesg-fail Dmesg is captured before and after each test and the

[Piglit] [PATCH] gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS

From: Marek Olšák marek.ol...@amd.com --- tests/spec/gl-3.1/minmax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/gl-3.1/minmax.c b/tests/spec/gl-3.1/minmax.c index 1128939..ea8c3a6 100644 --- a/tests/spec/gl-3.1/minmax.c +++ b/tests/spec/gl-3.1/minmax.c

[Piglit] [PATCH] gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS

From: Marek Olšák marek.ol...@amd.com --- tests/spec/gl-3.1/minmax.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/spec/gl-3.1/minmax.c b/tests/spec/gl-3.1/minmax.c index 1128939..c965ebe 100644 --- a/tests/spec/gl-3.1/minmax.c +++ b/tests/spec/gl-3.1/minmax.c

Re: [Piglit] [PATCH] GL_ARB_base_instance: Verify that the baseinstance setting does not affect the value of gl_InstanceID.

Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Tue, Nov 5, 2013 at 1:27 AM, Nicholas Mack nichm...@gmail.com wrote: --- tests/all.tests| 4 + tests/spec/CMakeLists.txt | 1 + tests/spec/arb_base_instance

Re: [Piglit] RFC enhance dmesg handling in piglit

Hi Dylan, I'd like to keep the dmesg-warn and dmesg-fail statuses. I use them to distinguish between failures caused by VM protection faults or lockups and failures reported by piglit tests. Marek On Tue, Nov 12, 2013 at 4:53 PM, Dylan Baker baker.dyla...@gmail.com wrote: This series cleans up

Re: [Piglit] RFC enhance dmesg handling in piglit

Do I have to define my own regexp? What if I don't want to filter anything, i.e. '.*'? Marek On Tue, Nov 12, 2013 at 8:07 PM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Nov 12, 2013 at 7:53 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Tuesday, November 12, 2013 07:21:50 PM Daniel Vetter

Re: [Piglit] RFC enhance dmesg handling in piglit

Sounds good. Marek On Tue, Nov 12, 2013 at 10:55 PM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Nov 12, 2013 at 10:32:21PM +0100, Marek Olšák wrote: Do I have to define my own regexp? What if I don't want to filter anything, i.e. '.*'? I was more talking about the filtering out of debug

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

I'll gladly type --dmesg=radeon. I have my own script for running piglit anyway, which calls piglit-run and piglit-summary-html, and the result and summary directories are named $(date)_$(time)_$(GLrenderer)_$(test_filters), and it can do a couple of other things. Marek On Fri, Nov 15, 2013 at

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

Why not to have both? Marek On Fri, Nov 15, 2013 at 7:33 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Friday, November 15, 2013 06:28:41 PM Marek Olšák wrote: I'll gladly type --dmesg=radeon. I have my own script for running piglit anyway, which calls piglit-run and piglit-summary-html

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

with the effects of synchronization. On Fri, Nov 15, 2013 at 12:42 PM, Marek Olšák mar...@gmail.com wrote: Why not to have both? Marek On Fri, Nov 15, 2013 at 7:33 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Friday, November 15, 2013 06:28:41 PM Marek Olšák wrote: I'll gladly

[Piglit] [PATCH 2/2] core: don't report warn if stderr is not empty

From: Marek Olšák marek.ol...@amd.com The usefulness of this is questionable to say the least. --- framework/core.py | 72 --- framework/exectest.py | 2 -- 2 files changed, 74 deletions(-) diff --git a/framework/core.py b/framework/core.py

[Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

From: Marek Olšák marek.ol...@amd.com Somebody broke this. --- framework/status.py| 48 + framework/summary.py | 6 ++--- framework/tests/summary.py | 66 -- 3 files changed, 44 insertions(+), 76 deletions

Re: [Piglit] [PATCH 2/2] core: don't report warn if stderr is not empty

:33:34 PM Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com The usefulness of this is questionable to say the least. --- framework/core.py | 72 --- framework/exectest.py | 2 -- 2 files changed, 74 deletions(-) diff --git

Re: [Piglit] [PATCH 2/2] core: don't report warn if stderr is not empty

, November 19, 2013 02:57:33 AM Marek Olšák wrote: I don't understand your argument. This patch makes stderr to have no effect on test results, that is the only way to get warn is to have a test which actually returns PIGLIT_WARN. Marek On Tue, Nov 19, 2013 at 12:02 AM, Dylan Baker baker.dyla

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

On Thu, Nov 21, 2013 at 12:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday, November 18, 2013 03:33:33 PM Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Somebody broke this. --- framework/status.py| 48 + framework/summary.py

[Piglit] [PATCH 08/16] all.tests: make some shader tests concurrent

From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index f8e19d3..34f1705 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -265,21 +265,14

[Piglit] [PATCH 07/16] all.tests: make glsl-getactiveuniform-count tests concurrent

From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 4ff7f29..f8e19d3 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -215,10 +215,8 @@ shaders = Group() def

[Piglit] [PATCH 01/16] fbo-clear-formats: fix the stencil clear test

From: Marek Olšák marek.ol...@amd.com glBlitFramebuffer generates a GL error, good old glCopyPixels doesn't. --- tests/fbo/fbo-clear-formats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fbo/fbo-clear-formats.c b/tests/fbo/fbo-clear-formats.c index 7a68f23

[Piglit] [PATCH 05/16] all.tests: make fbo-rg tests concurrent

From: Marek Olšák marek.ol...@amd.com --- tests/all.tests| 2 +- tests/fbo/fbo-rg.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 6959ea7..cb5a6b2 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -204,7 +204,7 @@ def

[Piglit] [00/16] Enable concurrency for a lot of tests

This series enables concurrency for about one half of non-concurrent tests. The time it takes to run all of quick.tests improved from 14.5 minutes to 11.7 minutes on my Core i5 quad-core. The tests which examine a specific behavior of the window framebuffer are not changed, because concurrency

[Piglit] [PATCH 12/16] all.tests: cleanups

From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 110 ++-- 1 file changed, 43 insertions(+), 67 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 5b5e562..8cee978 100644 --- a/tests/all.tests +++ b/tests/all.tests

[Piglit] [PATCH 02/16] all.tests: make fbo-depthstencil tests concurrent

From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 24 +--- tests/fbo/fbo-depthstencil.c | 1 + 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index c4ebfa7..9f0971e 100644 --- a/tests/all.tests +++ b

[Piglit] [PATCH 04/16] all.tests: make fbo format tests concurrent

From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 31 +++ tests/fbo/fbo-alphatest-formats.c | 3 ++- tests/fbo/fbo-blending-formats.c | 3 ++- tests/fbo/fbo-clear-formats.c | 10 -- tests/fbo/fbo-colormask-formats.c | 3

[Piglit] [PATCH 06/16] all.tests: make multisample-formats tests concurrent

From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 5 ++--- tests/spec/ext_framebuffer_multisample/common.cpp | 8 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index cb5a6b2..4ff7f29 100644

  1   2   3   4   5   6   >