Shuffler revisited

2019-06-25 Thread Stephen R. van den Berg
Stephen R. van den Berg wrote: >I was then wondering if it is being used successfully anywhere already? I now know more about the Shuffler code than I ever wanted to know (obviously). However, armed with that knowledge I am reasonably surprised that anyone managed to use it in the old state

Shuffler revisited

2019-06-25 Thread Tobias S. Josefowitz @ Pike developers forum
>I don't use it myself in Pike 8.0, I use it in Pike 8.1 now. >But, in the interest of stabilty I can offer to port the fixes from >8.1 to 8.0 (which, I hope, should be reasonably straightforward, I haven't >looked yet). > >Should I? I am still seeing quite a few testsuite failures, like: Doing

Re: Shuffler revisited

2019-06-25 Thread Tobias S. Josefowitz @ Pike developers forum
>:-). Well, I don't think these problems touch the Shuffler. Oh I see, I thought FakePike would be using Shuffler...

Re: Shuffler revisited

2019-06-25 Thread Stephen R. van den Berg
Tobias S. Josefowitz @ Pike developers forum wrote: >I am still seeing quite a few testsuite failures, like: >Doing tests in modules/_Stdio/testsuite (181 tests, pid 12880) >Socket test >Child: Copying 19712 bytes of data on 14 fake pipes Failed to read >complete data, errno=0, "Success".

close callback on FakeFile

2019-06-25 Thread Stephen R. van den Berg
FakeFile is supposed to emulate a regular file. This would mean that whenever you reach the end of the file/string you are reading, you are supposed to signal a close callback because eof has been reached. I.e. the close callback on FakeFile should therefore not need to wait for an actual close

Re: Shuffler revisited

2019-06-25 Thread Stephen R. van den Berg
Tobias S. Josefowitz @ Pike developers forum wrote: >>:-). Well, I don't think these problems touch the Shuffler. >Oh I see, I thought FakePike would be using Shuffler... No, indeed. I fixed the FakePipe issue. It passes all tests, AFAICS. With regard to the Shuffler: the Pike 8.0 shuffler