Re: [Pixman] pixman-0.32.6 fails to build on mips32r2

Thank you very much :) On 09/15/2014 09:31 AM, Nemanja Lukic wrote: Hi Vincent, Thanks. I'll push it in the following days. Kind Regards, Nemanja Lukic -Original Message- From: Vicente Olivert Riera [mailto:vincent.ri...@imgtec.com] Sent: Friday, September 12, 2014 4:19 PM To: Nemanja

Re: [Pixman] pixman-0.32.6 fails to build on mips32r2

Hi Vincent, Thanks. I'll push it in the following days. Kind Regards, Nemanja Lukic -Original Message- From: Vicente Olivert Riera [mailto:vincent.ri...@imgtec.com] Sent: Friday, September 12, 2014 4:19 PM To: Nemanja Lukic Cc: pixman@lists.freedesktop.org Subject: Re: pixman-0.32.6 fai

Re: [Pixman] pixman-0.32.6 fails to build on mips32r2

Hello Nemanja, I have attached the new patch to the bug report: https://bugs.freedesktop.org/show_bug.cgi?id=83358#c1 Could you please commit it upstream? Thank you. On 09/11/2014 11:02 AM, Vicente Olivert Riera wrote: On 09/11/2014 10:57 AM, Nemanja Lukic wrote: Hi Vincent, Patch I sent t

Re: [Pixman] pixman-0.32.6 fails to build on mips32r2

On 09/11/2014 10:57 AM, Nemanja Lukic wrote: Hi Vincent, Patch I sent to you was not intended for pushing upstream :) It was just for check. Ah, ok, I see :P Sorry about that then. Your patch LGTM, and it should be pushed on Pixman trunk. Thanks! Could you please let me know when you push

Re: [Pixman] pixman-0.32.6 fails to build on mips32r2

Hi Vincent, Patch I sent to you was not intended for pushing upstream :) It was just for check. Your patch LGTM, and it should be pushed on Pixman trunk. Thanks, Nemanja Lukic -Original Message- From: Vicente Olivert Riera [mailto:vincent.ri...@imgtec.com] Sent: Thursday, September 11,

Re: [Pixman] pixman-0.32.6 fails to build on mips32r2

Hello Nemanja, yes, it works. But your patch wrong because it can't be applied without reverting your last commit which was already pushed upstream. So, the right solution would be to apply a new patch which removes the wrong lines and add the right lines. I have attached a valid patch to this

Re: [Pixman] pixman-0.32.6 fails to build on mips32r2

Hi Vincent, Please take a look at attached fix. This one should solve the problem, without duplicating LEAF_MIPS32R2 macro. Trick is to use pre-processor on the right level. Please check on your side, Nemanja Lukic -Original Message- From: Vicente Olivert Riera [mailto:vincent.ri...@imgt

[Pixman] pixman-0.32.6 fails to build on mips32r2

Could you please have a look to this bug report? https://bugs.freedesktop.org/show_bug.cgi?id=83358 Thank you. -- Vincent ___ Pixman mailing list Pixman@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pixman