Re: [pkg-discuss] Code review: apache test suite cleanup

2012-11-26 Thread Tim Foster
On 11/27/12 11:34 AM, Danek Duvall wrote: https://cr.opensolaris.org/action/browse/pkg/timf/apache-testsuite-cleanup Thanks for taking a look, pkg5unittest.py: - line 3222, et al: seems to me that "ac" should be a property of the class, doing the work of 3247-3250 on demand, rather t

Re: [pkg-discuss] Code review: apache test suite cleanup

2012-11-26 Thread Danek Duvall
Tim Foster wrote: > https://cr.opensolaris.org/action/browse/pkg/timf/apache-testsuite-cleanup pkg5unittest.py: - line 3222, et al: seems to me that "ac" should be a property of the class, doing the work of 3247-3250 on demand, rather than having that statically decided at registration

[pkg-discuss] Code review: apache test suite cleanup

2012-11-22 Thread Tim Foster
hi there, I'm doing this work as part of the http-depot work, but figured that landing it as a separate wad would make code review a bit easier. https://cr.opensolaris.org/action/browse/pkg/timf/apache-testsuite-cleanup The intent here is to make all tests that use Apache instances share a c