Re: [pkg-go] [RFC] honoring DH_GOLANG_EXCLUDES for sources ?

2018-02-15 Thread Michael Stapelberg
As per https://codesearch.debian.net/search?q=DH_GOLANG_EXCLUDES+path%3Adebian%2Frules=1, currently 161 packages use DH_GOLANG_EXCLUDES. On Thu, Feb 15, 2018 at 3:01 PM, Clément Hermann wrote: > Hi, > > On 15/02/2018 13:26, Michael Stapelberg wrote: > > Thinking about this

Re: [pkg-go] [RFC] honoring DH_GOLANG_EXCLUDES for sources ?

2018-02-15 Thread Clément Hermann
Hi, On 15/02/2018 13:26, Michael Stapelberg wrote: > Thinking about this some more, I think I now agree with the rationale. > > When building packages, we must honor DH_GOLANG_EXCLUDES, so it doesn’t > make sense to have the source files in the package. > > The next step is making sure that we

Re: [pkg-go] [RFC] honoring DH_GOLANG_EXCLUDES for sources ?

2018-02-15 Thread Michael Stapelberg
Thinking about this some more, I think I now agree with the rationale. When building packages, we must honor DH_GOLANG_EXCLUDES, so it doesn’t make sense to have the source files in the package. The next step is making sure that we can safely do this change without breaking anything. Clément,

Re: [pkg-go] [RFC] honoring DH_GOLANG_EXCLUDES for sources ?

2018-01-23 Thread Martín Ferrari
On 22/01/18 16:57, Michael Stapelberg wrote: > We should exclude examples from being installed as binaries (which the > example below does), but it’s not clear to me why we would exclude them > from being included in the sources. My rationale for that is that we ought to include them as examples

Re: [pkg-go] [RFC] honoring DH_GOLANG_EXCLUDES for sources ?

2018-01-22 Thread Michael Stapelberg
Sorry for the late reply. Answers inline: On Mon, Jan 22, 2018 at 5:46 PM, Clément Hermann wrote: > Hi there, > > Ping / reminder about this RFC - since I didn't get any feedback ;) > > Cheers, > > nodens > > On 21/12/2017 21:05, Clément Hermann wrote: > > Hi! > > > > I'm

Re: [pkg-go] [RFC] honoring DH_GOLANG_EXCLUDES for sources ?

2018-01-22 Thread Clément Hermann
Hi there, Ping / reminder about this RFC - since I didn't get any feedback ;) Cheers, nodens On 21/12/2017 21:05, Clément Hermann wrote: > Hi! > > I'm newly joined to the team, packaging some dependancies for LXD [0] > mainly. > > While working on golang-gopkg-lxc-go-lxc, Martin (Tincho)

[pkg-go] [RFC] honoring DH_GOLANG_EXCLUDES for sources ?

2017-12-21 Thread Clément Hermann
Hi! I'm newly joined to the team, packaging some dependancies for LXD [0] mainly. While working on golang-gopkg-lxc-go-lxc, Martin (Tincho) pointed to me that I should exclude examples from source - which surprised me, because I thought I did. But indeed, I misread the man page [1], which