[pkg-go] Bug#877146: update to runc (1.0.0~rc4) breaks docker
Hi Tianon, 2017-10-02 20:19 GMT+02:00 Tianon Gravi : > On 30 September 2017 at 08:37, Bálint Réczey wrote: >> Tianon, could you please switch to docker-runc in docker.io? >> >> I have the packaging commits in git for docker-runc but I did not want to >> push it to the go packages' area so when I get approved to the Docker >> Packaging Team I'll push the repo to their area and happily hand over >> the package. > > Your team application should be approved for creating that > "docker-runc" repo and pushing your sources. I pushed the repo here: https://anonscm.debian.org/cgit/docker/docker-runc.git > > I went to go try to update "src:docker.io", but I'm having trouble > pulling in the "golang-github-opencontainers-docker-runc-dev" > dependency (which is oddly named, but past the FTP team so I guess not > a big deal). I believe it needs to both "Provides:" and "Conflicts:" > of "golang-github-opencontainers-runc-dev" for the sake of > "golang-github-docker-containerd-dev" (which is very much > intertwined). > > We might end up needing to _also_ create a "docker-containerd" package > to get out of this, which would indirectly unblock > https://github.com/containerd/containerd/issues/1508 (updating > "containerd" to 1.x, which Docker doesn't support yet). I think it would be cleaner to go without the Provides: and adding docker-containerd build-depending on golang-github-opencontainers-docker-runc-dev, but feel free to go either way. I think the most efficient way forward would be if you could adopt the docker-runc package for the Docker Team and updating it as you please without waiting for me - and I'm perfectly OK with that. Cheers, Balint > > I'll push up my WIP changes now. > > > ♥, > - Tianon > 4096R / B42F 6819 007F 00F8 8E36 4FD4 036A 9C25 BF35 7DD4 ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#877146: update to runc (1.0.0~rc4) breaks docker
On 30 September 2017 at 08:37, Bálint Réczey wrote: > Tianon, could you please switch to docker-runc in docker.io? > > I have the packaging commits in git for docker-runc but I did not want to > push it to the go packages' area so when I get approved to the Docker > Packaging Team I'll push the repo to their area and happily hand over > the package. Your team application should be approved for creating that "docker-runc" repo and pushing your sources. I went to go try to update "src:docker.io", but I'm having trouble pulling in the "golang-github-opencontainers-docker-runc-dev" dependency (which is oddly named, but past the FTP team so I guess not a big deal). I believe it needs to both "Provides:" and "Conflicts:" of "golang-github-opencontainers-runc-dev" for the sake of "golang-github-docker-containerd-dev" (which is very much intertwined). We might end up needing to _also_ create a "docker-containerd" package to get out of this, which would indirectly unblock https://github.com/containerd/containerd/issues/1508 (updating "containerd" to 1.x, which Docker doesn't support yet). I'll push up my WIP changes now. ♥, - Tianon 4096R / B42F 6819 007F 00F8 8E36 4FD4 036A 9C25 BF35 7DD4 ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#877146: update to runc (1.0.0~rc4) breaks docker
Control: clone -1 -2 Control: reassign -2 docker.io 1.13.1~ds1-2 Control: retitle -2 docker.io: Please switch to using docker-runc Hi, I'm fixing the original bug by adding Breaks: with current docker.io version to runc, please switch to using docker-runc in docker.io. Thanks, Balint 2017-09-30 11:37 GMT-04:00 Bálint Réczey : > Hi Shengjing, > > 2017-09-30 2:34 GMT-04:00 Shengjing Zhu : I see activity in docker.io's packaging repository in the v17.05.0-ce.new which may work with rc4 but according to the control file it does not. How about I upload docker-runc with previous runc version shipping docker-runc binary and make docker.io use it by removing this patch hunk?: >>> >>> I have uploaded docker-runc to unstable (in NEW) for docker.io >>> containing previous runc version >>> with fixes to make it build. >> >> I really think uploading this is not a good approach. >> At least I find docker master branch is using a runc version newer >> than 1.0.0-rc4. >> Packaging the lasted docker release is hard, but eventually we will >> do. And the runc/docker-runc in Debian will become duplicated. >> >> CCing docker.io maintainers, so they will be aware of this. > > I agree that this is not an ideal approach due to duplication of code but > I think this is still the best approach since it allows following runc > upstream > in runc and freeze the version for docker the same way docker upstream does. > > When docker.io starts supporting latest runc in a timely manner it can > switch back from docker-runc and docker-runc can be removed from > the archive. > > Before uploading the package I discussed it with Tianon from the docker.io > maintainers and he agreed that this would be the way to go in Debian. > > Tianon, could you please switch to docker-runc in docker.io? > > I have the packaging commits in git for docker-runc but I did not want to > push it to the go packages' area so when I get approved to the Docker > Packaging Team I'll push the repo to their area and happily hand over > the package. > > Cheers, > Balint > >> >> -- >> Best regards, >> Shengjing Zhu ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#877146: update to runc (1.0.0~rc4) breaks docker
Hi Shengjing, 2017-09-30 2:34 GMT-04:00 Shengjing Zhu : >>> I see activity in docker.io's packaging repository in the v17.05.0-ce.new >>> which may work with rc4 but according to the control file it does not. >>> >>> How about I upload docker-runc with previous runc version shipping >>> docker-runc binary and make docker.io use it by removing this patch hunk?: >> >> I have uploaded docker-runc to unstable (in NEW) for docker.io >> containing previous runc version >> with fixes to make it build. > > I really think uploading this is not a good approach. > At least I find docker master branch is using a runc version newer > than 1.0.0-rc4. > Packaging the lasted docker release is hard, but eventually we will > do. And the runc/docker-runc in Debian will become duplicated. > > CCing docker.io maintainers, so they will be aware of this. I agree that this is not an ideal approach due to duplication of code but I think this is still the best approach since it allows following runc upstream in runc and freeze the version for docker the same way docker upstream does. When docker.io starts supporting latest runc in a timely manner it can switch back from docker-runc and docker-runc can be removed from the archive. Before uploading the package I discussed it with Tianon from the docker.io maintainers and he agreed that this would be the way to go in Debian. Tianon, could you please switch to docker-runc in docker.io? I have the packaging commits in git for docker-runc but I did not want to push it to the go packages' area so when I get approved to the Docker Packaging Team I'll push the repo to their area and happily hand over the package. Cheers, Balint > > -- > Best regards, > Shengjing Zhu ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#877146: update to runc (1.0.0~rc4) breaks docker
>> I see activity in docker.io's packaging repository in the v17.05.0-ce.new >> which may work with rc4 but according to the control file it does not. >> >> How about I upload docker-runc with previous runc version shipping >> docker-runc binary and make docker.io use it by removing this patch hunk?: > > I have uploaded docker-runc to unstable (in NEW) for docker.io > containing previous runc version > with fixes to make it build. I really think uploading this is not a good approach. At least I find docker master branch is using a runc version newer than 1.0.0-rc4. Packaging the lasted docker release is hard, but eventually we will do. And the runc/docker-runc in Debian will become duplicated. CCing docker.io maintainers, so they will be aware of this. -- Best regards, Shengjing Zhu ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#877146: update to runc (1.0.0~rc4) breaks docker
Hi, > update to runc (1.0.0~rc4) breaks docker I can confirm that downgrading to 1.0.0~rc2+git20170201.133.9df8b30-3 "fixed" this for me. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `- ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
[pkg-go] Bug#877146: update to runc (1.0.0~rc4) breaks docker
Package: runc Version: 1.0.0~rc4+dfsg1-1 Severity: critical Trying to `docker run` returns the following error: docker: Error response from daemon: oci runtime error: flag provided but not defined: -console. This might be related to: https://github.com/moby/moby/issues/30198 Cheers, Bastian -- System Information: Debian Release: buster/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.12.0-2-amd64 (SMP w/4 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) Versions of packages runc depends on: ii libapparmor1 2.11.0-11 ii libc6 2.24-17 ii libseccomp2 2.3.1-2.1 runc recommends no packages. runc suggests no packages. -- no debconf information -- Dr. Bastian Venthur http://venthur.de Debian Developer venthur at debian org ___ Pkg-go-maintainers mailing list Pkg-go-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
