Re: Comments regarding libowasp-antisamy-java_1.5.3+dfsg-1_amd64.changes

2014-06-02 Thread Matthew Vernon
Hi, On 30/05/14 18:33, Thorsten Alteholz wrote: Hi Matthew, I marked your package for accept now, but please take care of: W: libowasp-antisamy-java: copyright-refers-to-deprecated-bsd-license-file I've pushed a fix for this, but it doesn't seem worth minting a new package version for

Re: libowasp-antisamy-java_1.5.3-1_amd64.changes REJECTED

2014-05-30 Thread Matthew Vernon
Hi, On 22/05/14 14:00, Thorsten Alteholz wrote: Some js-files are licensed under MIT, GPL or Apache-2. These licenses are not mentioned in debian/copyright. Please also remove all minified js-files where no sources are provided. Right, I understand the problem now, and I'd like some advice,

Re: libowasp-esapi-java_2.1.0-1_amd64.changes REJECTED

2014-05-30 Thread Matthew Vernon
Hi, On 22/05/14 14:00, Thorsten Alteholz wrote: For example src/test/resources/log4j.dtd is licensed under Apache-2, which is not mentioned in debian/coypright. There might be other licenses missing! Well spotted; I rashly belived upstream's LICENSE-README :-/. I did some grepping and just

Re: libowasp-antisamy-java_1.5.3-1_amd64.changes REJECTED

2014-05-30 Thread Matthew Vernon
On 30/05/14 10:32, Emmanuel Bourg wrote: Le 30/05/2014 11:11, Matthew Vernon a écrit : What would you prefer? i) has the advantages of leaving the source as upstream have it in their SVN ; ii) is perhaps the right compromise option; iii) seems too extreme. IMHO if the minified JavaScript

Re: libowasp-antisamy-java_1.5.3-1_amd64.changes REJECTED

2014-05-30 Thread Matthew Vernon
On 30/05/14 10:47, Emmanuel Bourg wrote: Le 30/05/2014 11:37, Matthew Vernon a écrit : It's difficult to determine what license they might be covered by; AFAICT they are the result of pointing something like wget at a bunch of sites, namely: cnn.com, deadspin.com, fark.com, google.com

Bug#740826: libjgrapht0.8-java: packaging should be jar not pom

2014-03-05 Thread Matthew Vernon
Package: libjgrapht0.8-java Version: 0.8.3-4 Severity: important Hi, The POMs for libjgrapht0.8-java include the following: groupIdorg.jgrapht/groupId artifactIdjgrapht/artifactId packagingpom/packaging I think this latter should be jar not pom, since that's how the

Bug#740346: mh_installpom - will always exit non-zero if called with -n

2014-02-28 Thread Matthew Vernon
Package: maven-repo-helper Version: 1.8.7 Severity: normal Hi, the -n do nothing, print what would have been done argument to mh_installpom is mishandled. Specifically, what will happen is: mh_cleanpom is called with -n [correct] once with --keep-pom-version and once without. source

Bug#740347: mh_installpoms -n should output what it would have done, not just exit

2014-02-28 Thread Matthew Vernon
Package: maven-repo-helper Version: 1.8.7 Severity: important Hi, mh_installpoms has an -n argument, documented thus: -n --no-act: don't actually do anything, just print the results But in fact, if you use -n, it does nothing at all and prints nothing - line 96's check: if [ -z $NOACT

Bug#740360: Needs maven support

2014-02-28 Thread Matthew Vernon
Package: libjgrapht0.8-java Version: 0.8.3-3 Severity: normal Tags: patch Hi, The enclosed patch adds maven support (i.e. it installs relevant entries into /usr/share/maven-repo/), meaning that other java code that builds with maven and depends upon this package will build. Thanks, Matthew --

Bug#740368: libjargs-java: Needs maven support

2014-02-28 Thread Matthew Vernon
Package: libjargs-java Version: 1.0.0-3 Severity: normal Tags: patch Hi, The enclosed patch adds maven support (i.e. it installs relevant entries into /usr/share/maven-repo/), meaning that other java code that builds with maven and depends upon this package will build. Thanks, Matthew --