Bug#880886: maven-bundle-plugin FTBFS with libmaven-dependency-tree-java

[殷啟聰 | Kai-Chung Yan]

Control:  forwarded -1 https://issues.apache.org/jira/browse/FELIX-5795



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#880886: maven-bundle-plugin FTBFS with libmaven-dependency-tree-java

[殷啟聰 | Kai-Chung Yan]

forwarded -1 https://issues.apache.org/jira/browse/FELIX-5795



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#880886: maven-bundle-plugin FTBFS with libmaven-dependency-tree-java

[殷啟聰 | Kai-Chung Yan]

I removed the javadoc package now and it builds find in Sid. Shall I upload it 
right now?

(I still need the upload permission)



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#880886: maven-bundle-plugin FTBFS with libmaven-dependency-tree-java

[Emmanuel Bourg]

On 20/03/2018 16:29, 殷啟聰 | Kai-Chung Yan wrote:
> I adopted the patch from Fedora and it looks good. The package builds fine 
> now and 154 of its reverse-build-dependencies built successfully. 27 failed:

Great!


> They either failed in compilation due to Java 9 or failed in tests. But I 
> would say the result is confident enough to prove that the patch works.

I agree. An error in this plugin would have broken the build before the
test phase.


> However this package fails to build in Sid currently because of Java 9. I 
> attached the log. The Maven Javadoc Plugin failed to honor the compile 
> classpath.

The javadoc is useless for Maven plugins anyway, nobody codes against
their API. I suggest removing it.

Emmanuel Bourg

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#880886: maven-bundle-plugin FTBFS with libmaven-dependency-tree-java

[殷啟聰 | Kai-Chung Yan]

I adopted the patch from Fedora and it looks good. The package builds fine now 
and 154 of its reverse-build-dependencies built successfully. 27 failed:

* activemq-activeio
* activemq
* apache-directory-server
* dnssecjava
* istack-commons
* jackson-datatype-joda
* javassist
* jayway-jsonpath
* jboss-xnio
* jcommander
* jruby
* jsoup
* kryo-serializers
* libcommons-lang3-java
* libhtmlcleaner-java
* libitext5-java
* libpgjava
* libxbean-java
* libxml-security-java
* openhft-chronicle-bytes
* openhft-chronicle-core
* openhft-chronicle-wire
* openhft-lang
* openjpa
* sisu-ioc
* tika
* undertow

They either failed in compilation due to Java 9 or failed in tests. But I would 
say the result is confident enough to prove that the patch works.

However this package fails to build in Sid currently because of Java 9. I 
attached the log. The Maven Javadoc Plugin failed to honor the compile 
classpath.
I: Copying COW directory
I: forking: rm -rf /media/data/VMs/pbuilder/build/cow.29816
I: forking: cp -al /media/data/VMs/pbuilder/default.cow /media/data/VMs/pbuilder/build/cow.29816
I: removed stale ilistfile /media/data/VMs/pbuilder/build/cow.29816/.ilist
I: forking: chroot /media/data/VMs/pbuilder/build/cow.29816 cowdancer-ilistcreate /.ilist 'find . -xdev -path ./home -prune -o \( \( -type l -o -type f \) -a -links +1 -print0 \) | xargs -0 stat --format '%d %i ''
I: Invoking pbuilder
I: forking: pbuilder build --buildplace /media/data/VMs/pbuilder/build/cow.29816 --buildresult /var/cache/pbuilder/result/ --no-targz --internal-chrootexec 'chroot /media/data/VMs/pbuilder/build/cow.29816 cow-shell' /media/data/Documents/debian/maven-bundle-plugin_3.5.0-1.dsc
W: /home/seamlik/.pbuilderrc does not exist
I: Running in no-targz mode
I: using fakeroot in build.
I: pbuilder: network access will be disabled during build
I: Current time: Tue Mar 20 22:40:43 CST 2018
I: pbuilder-time-stamp: 1521556843
I: copying local configuration
W: No local /etc/mailname to copy, relying on /media/data/VMs/pbuilder/build/cow.29816/etc/mailname to be correct
I: mounting /proc filesystem
I: mounting /sys filesystem
I: creating /{dev,run}/shm
I: mounting /dev/pts filesystem
I: redirecting /dev/ptmx to /dev/pts/ptmx
I: Mounting /media/data/VMs/pbuilder/deb
I: policy-rc.d already exists
I: Using pkgname logfile
I: Current time: Tue Mar 20 22:40:43 CST 2018
I: pbuilder-time-stamp: 1521556843
I: Obtaining the cached apt archive contents
I: Copying source file
I: copying [/media/data/Documents/debian/maven-bundle-plugin_3.5.0-1.dsc]
I: copying [/media/data/Documents/debian/maven-bundle-plugin_3.5.0.orig.tar.xz]
I: copying [/media/data/Documents/debian/maven-bundle-plugin_3.5.0-1.debian.tar.xz]
I: Extracting source
dpkg-source: warning: extracting unsigned source package (maven-bundle-plugin_3.5.0-1.dsc)
dpkg-source: info: extracting maven-bundle-plugin in maven-bundle-plugin-3.5.0
dpkg-source: info: unpacking maven-bundle-plugin_3.5.0.orig.tar.xz
dpkg-source: info: unpacking maven-bundle-plugin_3.5.0-1.debian.tar.xz
dpkg-source: info: applying remove_bndlib_spring_support.diff
dpkg-source: info: applying support_plexus_utils_1_5.diff
dpkg-source: info: applying use-changelog-date-as-pom.properties-timestamp.patch
dpkg-source: info: applying maven-archiver3-869361.patch
dpkg-source: info: applying maven3-compatibility.patch
dpkg-source: info: applying 0001-Port-to-current-maven-dependency-tree.patch
I: Installing the build-deps
I: user script /media/data/VMs/pbuilder/build/cow.29816/tmp/hooks/D00deps starting
dpkg-scanpackages: info: Wrote 2 entries to output Packages file.

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

Get:1 file:/media/data/VMs/pbuilder/deb ./ InRelease
Ign:1 file:/media/data/VMs/pbuilder/deb ./ InRelease
Get:2 file:/media/data/VMs/pbuilder/deb ./ Release
Ign:2 file:/media/data/VMs/pbuilder/deb ./ Release
Get:3 file:/media/data/VMs/pbuilder/deb ./ Packages
Ign:3 file:/media/data/VMs/pbuilder/deb ./ Packages
Get:3 file:/media/data/VMs/pbuilder/deb ./ Packages
Ign:3 file:/media/data/VMs/pbuilder/deb ./ Packages
Get:3 file:/media/data/VMs/pbuilder/deb ./ Packages
Ign:3 file:/media/data/VMs/pbuilder/deb ./ Packages
Get:3 file:/media/data/VMs/pbuilder/deb ./ Packages
Ign:3 file:/media/data/VMs/pbuilder/deb ./ Packages
Get:3 file:/media/data/VMs/pbuilder/deb ./ Packages
Ign:3 file:/media/data/VMs/pbuilder/deb ./ Packages
Get:3 file:/media/data/VMs/pbuilder/deb ./ Packages [2786 B]
Get:4 http://cdn-fastly.deb.debian.org/debian sid InRelease [241 kB]
Get:5 http://cdn-fastly.deb.debian.org/debian sid/main amd64 Packages.diff/Index [27.9 kB]
Get:6 http://cdn-fastly.deb.debian.org/debian sid/main amd64 Packages 2018-03-20-0828.04.pdiff [29.6 kB]
Get:6 http://cdn-fastly.deb.debian.org/debian sid/main amd64 Packages 2018-03-20-0828.04.pdiff [29.6 kB]
Fetched 298 kB in 8s (37.7 kB/s)
Reading package lists...
Building dependency tree...
Reading state information...
11 packages can be upgraded. Run 'apt list 

Bug#880886: maven-bundle-plugin FTBFS with libmaven-dependency-tree-java

[Emmanuel Bourg]

Le 08/03/2018 à 13:29, 殷啟聰 | Kai-Chung Yan a écrit :

> I tried building Maven Dependency Tree 2.2 against Maven 3.x and found that 
> it uses removed APIs, and that patching it would make a huge code change. 
> Maybe someone else would have a better skill than me to do the job, but I 
> simply don't think this is a good or sustainable idea...

It looks like Fedora has already done the job:

https://src.fedoraproject.org/rpms/maven-plugin-bundle/blob/master/f/0001-Port-to-current-maven-dependency-tree.patch

With this patch they build the bundle plugin 3.5.0 with
maven-dependency-tree 3.0.

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#880886: maven-bundle-plugin FTBFS with libmaven-dependency-tree-java

[殷啟聰 | Kai-Chung Yan]

This is getting awkward... Maven Bundle Plugin does not only rely on old Maven 
Dependency Tree, but also targets Maven 2.x [1]. What's worse, Maven Dependency 
Tree 2.x also relies on Maven 2.x [2].

I tried building Maven Dependency Tree 2.2 against Maven 3.x and found that it 
uses removed APIs, and that patching it would make a huge code change. Maybe 
someone else would have a better skill than me to do the job, but I simply 
don't think this is a good or sustainable idea...

[1]: 
https://github.com/apache/felix/blob/ae8f8bbeb6ecaae8e2d27824077c5d39c54e54a5/pom.xml#L182
[2]: 
https://github.com/apache/maven-dependency-tree/blob/maven-dependency-tree-2.2/pom.xml#L53



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#880886: maven-bundle-plugin FTBFS with libmaven-dependency-tree-java

[Emmanuel Bourg]

Le 03/03/2018 à 14:50, Markus Koschany a écrit :

> If it helps with upgrading bnd to a more recent version I'm in favor of it.

Well, no objection unless it pulls a herd of Maven 2 dependencies :/

__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#880886: maven-bundle-plugin FTBFS with libmaven-dependency-tree-java

[Markus Koschany]

Am 03.03.2018 um 11:32 schrieb 殷啟聰 | Kai-Chung Yan:
> I propose to bring back Maven Dependency Tree 2.x as a new package that 
> coexists with its latest version.
> 
> Even in the latest (3.5.0) version, Maven Bundle Plugin still uses those 
> deprecated APIs in Maven Dependency Tree 2.x. These deprecated APIs have been 
> removed from Maven Dependency Tree 3.x. A fix to adapt to the new APIs would 
> be non-trivial (and potentially wasting energy of the maintainers), as I have 
> tried...
> 
> I have reported this issue upstream [1].
> 
> P.S.: Rebuilding Maven Bundle Plugin is needed for the "bnd" upgrade, that's 
> way I stumbled upon this...
> 
> [1]: https://issues.apache.org/jira/browse/FELIX-5795


If it helps with upgrading bnd to a more recent version I'm in favor of it.



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#880886: maven-bundle-plugin FTBFS with libmaven-dependency-tree-java

[殷啟聰 | Kai-Chung Yan]

I propose to bring back Maven Dependency Tree 2.x as a new package that 
coexists with its latest version.

Even in the latest (3.5.0) version, Maven Bundle Plugin still uses those 
deprecated APIs in Maven Dependency Tree 2.x. These deprecated APIs have been 
removed from Maven Dependency Tree 3.x. A fix to adapt to the new APIs would be 
non-trivial (and potentially wasting energy of the maintainers), as I have 
tried...

I have reported this issue upstream [1].

P.S.: Rebuilding Maven Bundle Plugin is needed for the "bnd" upgrade, that's 
way I stumbled upon this...

[1]: https://issues.apache.org/jira/browse/FELIX-5795



signature.asc
Description: OpenPGP digital signature
__
This is the maintainer address of Debian's Java team
. 
Please use
debian-j...@lists.debian.org for discussions and questions.