Re: [Pkg-javascript-devel] can we use my fork of node-findit?
On Oct 17, 2014 4:11 PM, Andrew Kelley superjo...@gmail.com wrote: Good idea. Done. On Fri, Oct 17, 2014 at 4:06 PM, Jérémy Lal kapo...@melix.org wrote: Maybe it can be written in the long description of the package ? This module is a backward-compatible rewrite of node-findit I found one more bug and fixed it upstream. Then updated the node-findit2 package which is ready for review and upload. Anything else you wanted me to do? ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] can we use my fork of node-findit?
On Thu, Oct 16, 2014 at 2:17 PM, Andrew Kelley superjo...@gmail.com wrote: On Wed, Oct 15, 2014 at 12:44 AM, Jérémy Lal kapo...@melix.org wrote: What should I do? Since both have same API, i'd add your patches as quilt patches to node-findit that is already in debian and add a binary package node-findit2 (symlinking /usr/lib/nodejs/findit to findit2). Or the reverse, change upstream and add binary node-findit to node-findit2. What about this? * Add patch as quilt patch to node-findit that is already in debian * When packaging other package updates that depend on findit2, patch them to depend on node-findit instead, since the patch provides the findit2 API and bug fixes. If you are OK with that strategy, then node-findit is ready for review and upload. Also if this strategy is OK, then node-multiparty is updated and ready for review and upload. Felipe, if Jérémy says that this strategy for node-findit is OK, then the groovebasin package is updated and ready for review and upload. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] can we use my fork of node-findit?
Le jeudi 16 octobre 2014 à 14:17 -0700, Andrew Kelley a écrit : On Wed, Oct 15, 2014 at 12:44 AM, Jérémy Lal kapo...@melix.org wrote: What should I do? Since both have same API, i'd add your patches as quilt patches to node-findit that is already in debian and add a binary package node-findit2 (symlinking /usr/lib/nodejs/findit to findit2). Or the reverse, change upstream and add binary node-findit to node-findit2. What about this? * Add patch as quilt patch to node-findit that is already in debian * When packaging other package updates that depend on findit2, patch them to depend on node-findit instead, since the patch provides the findit2 API and bug fixes. I agree up to that point where you imply that findit2 has a different API ? If that's the case then findit2 must be... findit2 ! Jérémy. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] can we use my fork of node-findit?
On Fri, Oct 17, 2014 at 12:15 AM, Jérémy Lal kapo...@melix.org wrote: Le jeudi 16 octobre 2014 à 14:17 -0700, Andrew Kelley a écrit : On Wed, Oct 15, 2014 at 12:44 AM, Jérémy Lal kapo...@melix.org wrote: What should I do? Since both have same API, i'd add your patches as quilt patches to node-findit that is already in debian and add a binary package node-findit2 (symlinking /usr/lib/nodejs/findit to findit2). Or the reverse, change upstream and add binary node-findit to node-findit2. What about this? * Add patch as quilt patch to node-findit that is already in debian * When packaging other package updates that depend on findit2, patch them to depend on node-findit instead, since the patch provides the findit2 API and bug fixes. I agree up to that point where you imply that findit2 has a different API ? If that's the case then findit2 must be... findit2 ! Hmm, in this case, since upstream seems to be ignoring my pull request, maybe I will * rename the module to a better fork name (as I did with formidable - multiparty) * add new node module to debian * update packages to depend on new module * delete node-findit from debian since nothing depends on it ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] can we use my fork of node-findit?
Le vendredi 17 octobre 2014 à 15:04 -0700, Andrew Kelley a écrit : On Fri, Oct 17, 2014 at 12:15 AM, Jérémy Lal kapo...@melix.org wrote: Le jeudi 16 octobre 2014 à 14:17 -0700, Andrew Kelley a écrit : On Wed, Oct 15, 2014 at 12:44 AM, Jérémy Lal kapo...@melix.org wrote: What should I do? Since both have same API, i'd add your patches as quilt patches to node-findit that is already in debian and add a binary package node-findit2 (symlinking /usr/lib/nodejs/findit to findit2). Or the reverse, change upstream and add binary node-findit to node-findit2. What about this? * Add patch as quilt patch to node-findit that is already in debian * When packaging other package updates that depend on findit2, patch them to depend on node-findit instead, since the patch provides the findit2 API and bug fixes. I agree up to that point where you imply that findit2 has a different API ? If that's the case then findit2 must be... findit2 ! Hmm, in this case, since upstream seems to be ignoring my pull request, maybe I will * rename the module to a better fork name (as I did with formidable - multiparty) * add new node module to debian * update packages to depend on new module * delete node-findit from debian since nothing depends on it If that's the case, then please keep a name close to the original one, so that when packaging a module depending on (old) findit, one can find easily the new findit to be a match. You might also want to commit to keep a backward-compatible API with node-findit. These are only suggestions. Jérémy. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] can we use my fork of node-findit?
On Fri, Oct 17, 2014 at 3:40 PM, Jérémy Lal kapo...@melix.org wrote: Le vendredi 17 octobre 2014 à 15:04 -0700, Andrew Kelley a écrit : On Fri, Oct 17, 2014 at 12:15 AM, Jérémy Lal kapo...@melix.org wrote: Le jeudi 16 octobre 2014 à 14:17 -0700, Andrew Kelley a écrit : On Wed, Oct 15, 2014 at 12:44 AM, Jérémy Lal kapo...@melix.org wrote: What should I do? Since both have same API, i'd add your patches as quilt patches to node-findit that is already in debian and add a binary package node-findit2 (symlinking /usr/lib/nodejs/findit to findit2). Or the reverse, change upstream and add binary node-findit to node-findit2. What about this? * Add patch as quilt patch to node-findit that is already in debian * When packaging other package updates that depend on findit2, patch them to depend on node-findit instead, since the patch provides the findit2 API and bug fixes. I agree up to that point where you imply that findit2 has a different API ? If that's the case then findit2 must be... findit2 ! Hmm, in this case, since upstream seems to be ignoring my pull request, maybe I will * rename the module to a better fork name (as I did with formidable - multiparty) * add new node module to debian * update packages to depend on new module * delete node-findit from debian since nothing depends on it If that's the case, then please keep a name close to the original one, so that when packaging a module depending on (old) findit, one can find easily the new findit to be a match. You might also want to commit to keep a backward-compatible API with node-findit. These are only suggestions. I have thought about it, and I decided to keep the name as findit2. Also I agree to commit to backward-compatible API with node-findit, so that debian packages can use findit2 instead. I should have a package done here shortly. One thing that is kind of funny, is that since I cleaned up the code considerably, the lines of code is now small enough that FTP masters might say it is too small!! But hopefully if we tell them we are going to remove node-findit and this package is intended to replace it, then they will be OK with it. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] can we use my fork of node-findit?
On Fri, Oct 17, 2014 at 3:43 PM, Andrew Kelley superjo...@gmail.com wrote: On Fri, Oct 17, 2014 at 3:40 PM, Jérémy Lal kapo...@melix.org wrote: Le vendredi 17 octobre 2014 à 15:04 -0700, Andrew Kelley a écrit : On Fri, Oct 17, 2014 at 12:15 AM, Jérémy Lal kapo...@melix.org wrote: Le jeudi 16 octobre 2014 à 14:17 -0700, Andrew Kelley a écrit : On Wed, Oct 15, 2014 at 12:44 AM, Jérémy Lal kapo...@melix.org wrote: What should I do? Since both have same API, i'd add your patches as quilt patches to node-findit that is already in debian and add a binary package node-findit2 (symlinking /usr/lib/nodejs/findit to findit2). Or the reverse, change upstream and add binary node-findit to node-findit2. What about this? * Add patch as quilt patch to node-findit that is already in debian * When packaging other package updates that depend on findit2, patch them to depend on node-findit instead, since the patch provides the findit2 API and bug fixes. I agree up to that point where you imply that findit2 has a different API ? If that's the case then findit2 must be... findit2 ! Hmm, in this case, since upstream seems to be ignoring my pull request, maybe I will * rename the module to a better fork name (as I did with formidable - multiparty) * add new node module to debian * update packages to depend on new module * delete node-findit from debian since nothing depends on it If that's the case, then please keep a name close to the original one, so that when packaging a module depending on (old) findit, one can find easily the new findit to be a match. You might also want to commit to keep a backward-compatible API with node-findit. These are only suggestions. I have thought about it, and I decided to keep the name as findit2. Also I agree to commit to backward-compatible API with node-findit, so that debian packages can use findit2 instead. I should have a package done here shortly. One thing that is kind of funny, is that since I cleaned up the code considerably, the lines of code is now small enough that FTP masters might say it is too small!! But hopefully if we tell them we are going to remove node-findit and this package is intended to replace it, then they will be OK with it. Alright, node-findit2 is packaged up and ready for review and upload. I think we should send a note to the FTP masters that it will replace node-findit. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] can we use my fork of node-findit?
Le vendredi 17 octobre 2014 à 16:03 -0700, Andrew Kelley a écrit : Alright, node-findit2 is packaged up and ready for review and upload. I think we should send a note to the FTP masters that it will replace node-findit. Maybe it can be written in the long description of the package ? This module is a backward-compatible rewrite of node-findit ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] can we use my fork of node-findit?
Good idea. Done. On Fri, Oct 17, 2014 at 4:06 PM, Jérémy Lal kapo...@melix.org wrote: Le vendredi 17 octobre 2014 à 16:03 -0700, Andrew Kelley a écrit : Alright, node-findit2 is packaged up and ready for review and upload. I think we should send a note to the FTP masters that it will replace node-findit. Maybe it can be written in the long description of the package ? This module is a backward-compatible rewrite of node-findit ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] can we use my fork of node-findit?
On Wed, Oct 15, 2014 at 12:44 AM, Jérémy Lal kapo...@melix.org wrote: What should I do? Since both have same API, i'd add your patches as quilt patches to node-findit that is already in debian and add a binary package node-findit2 (symlinking /usr/lib/nodejs/findit to findit2). Or the reverse, change upstream and add binary node-findit to node-findit2. What about this? * Add patch as quilt patch to node-findit that is already in debian * When packaging other package updates that depend on findit2, patch them to depend on node-findit instead, since the patch provides the findit2 API and bug fixes. If you are OK with that strategy, then node-findit is ready for review and upload. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
Re: [Pkg-javascript-devel] can we use my fork of node-findit?
Le mardi 14 octobre 2014 à 21:49 -0700, Andrew Kelley a écrit : I fixed all the bugs in node-findit and submitted the patch to upstream: https://github.com/substack/node-findit/pull/34 But I am afraid that upstream will not accept my code and I do not have time to wait. So I have forked findit to findit2 and started using that in my modules, because it fixes bugs. So now my question is, when packaging these modules, may I update node-findit, keeping the same package name, but use my fork instead? It keeps the same API and fixes all the findit bugs. Further, the only packages that depend on findit so far are mine: $ apt-cache rdepends node-findit node-findit Reverse Depends: groovebasin So far only groovebasin depends on node-findit. And this update happened upstream in groovebasin: groovebasin findit - findit2 connect-static findit - findit2 multiparty findit - findit2 So that's 3 places that need the fork instead of the original, and 0 places that need the original. What should I do? Since both have same API, i'd add your patches as quilt patches to node-findit that is already in debian and add a binary package node-findit2 (symlinking /usr/lib/nodejs/findit to findit2). Or the reverse, change upstream and add binary node-findit to node-findit2. Jérémy. ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
[Pkg-javascript-devel] can we use my fork of node-findit?
I fixed all the bugs in node-findit and submitted the patch to upstream: https://github.com/substack/node-findit/pull/34 But I am afraid that upstream will not accept my code and I do not have time to wait. So I have forked findit to findit2 and started using that in my modules, because it fixes bugs. So now my question is, when packaging these modules, may I update node-findit, keeping the same package name, but use my fork instead? It keeps the same API and fixes all the findit bugs. Further, the only packages that depend on findit so far are mine: $ apt-cache rdepends node-findit node-findit Reverse Depends: groovebasin So far only groovebasin depends on node-findit. And this update happened upstream in groovebasin: groovebasin findit - findit2 connect-static findit - findit2 multiparty findit - findit2 So that's 3 places that need the fork instead of the original, and 0 places that need the original. What should I do? ___ Pkg-javascript-devel mailing list Pkg-javascript-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel
