[Pkg-javascript-devel] Bug#740893: libjs-jquery-hotkeys: Incompatible ABI change

[Ben Finney]

Control: unblock 848188 by 740893
Control: summary 848188 0

Until the ‘libjs-jquery-hotkeys’ package resolves bug#740893, the
‘python-coverage’ packages should not use that library.

I will patch the ‘python-coverage’ source so it omits any use of that
library.

On 06-Apr-2017, Philipp Hahn wrote:
> 
> introduced an incompatible ABI change how events are registered:

Thanks again for the analysis, I hope this package can be fixed for
its dependents.

-- 
 \  “The trouble with the rat race is that even if you win, you're |
  `\   still a rat.” —Jane Wagner, via Lily Tomlin |
_o__)  |
Ben Finney 


signature.asc
Description: PGP signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#740893: libjs-jquery-hotkeys: Incompatible ABI change

[Philipp Matthias Hahn]

Hello Ben,

On Sun, Apr 09, 2017 at 12:41:50PM +1000, Ben Finney wrote:
> So the  and the
>  repositories have
> diverged, incompatibly. I didn't know that :-/
...
> I count 6 binary packages:
> 
> =
> $ apt-cache rdepends libjs-jquery-hotkeys
> libjs-jquery-hotkeys
> Reverse Depends:
>   libghc-gitit-data
>   python3-pytest-cov
>   python-pytest-cov
>   python3-coverage
>   python-coverage
>   prometheus
> =
> 
> The source packages are:
> 
> * gitit
> * python-coverage
> * python-pytest-cov
> * prometheus
> 
> Why are we getting different sets of packages that use
> ‘libjs-jquery-hotkeys’?

'python-pytest-cov' is a wrapper for 'py.test'; it uses
'python-coverage' internally and only the later one contains the JS
code.

> > Doing some source code `grep -n -r "[.]bind([\"']key"`:
> 
> When I use the pattern ‘[.]bind\(["']key’ for each of those source
> packages with , I get a different
> set.
> 
> These queries show matches:
> 
> 
> 
> 
> 
> This does not:
> 
> 
> 
> Does that mean ‘python-pytest-cov’ is not using the ‘jeresig’ API?

It only is a wrapper for 'pyhton-coverage', which is the real user.
(I did a `apt-get source python-pytest-cov`, which shows no direct
match, by it uses 'python-coverage' as a Build-Depends-Indep, so I
guesst it's pulled in that way.)

> Is there a better regex pattern to use to determine what API is used?
> 
> > So all of them use the "jeresig" API, but 'libjs-jquery-hotkeys'
> > packages the "tzuryby" API.
> 
> We get differing results, so I'd like to better understand before
> choosing how to resolve this.


shows more users and even users of the 'tzuryby' API, but they don't
seem to use your package but use their own packaging or it is some other
'bind' function not related to 'jquery-hotkeys' at all.

I think you can concentrate on those packages in Debian, which directly
depends on your package and just ignore the other hits of '.bind("key'.

Philipp
-- 
Philipp Matthias Hahn 
0xF50EFDCF8AD04B1A @ keyrings.debian.org

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] Bug#740893: libjs-jquery-hotkeys: Incompatible ABI change

[Ben Finney]

On 06-Apr-2017, Philipp Hahn wrote:

> today I spent some time on investigating this issue

Thank you!

> 
> introduced an incompatible ABI change how events are registered:

So the  and the
 repositories have
diverged, incompatibly. I didn't know that :-/

> So "coverage_html.js" uses the 'jeresig' API to pass the hotkey via
> "data", while the 'tzuryby' API "jquery.hotkeys.js" expects is via
> 'namespace'.

That's good investigation, thank you for that.

> libjs-jquery-hotkeys currently is used by 3 packages in Debian:
> - libghc-gitit-data
> - prometheus
> - python-pytest-cov

I count 6 binary packages:

=
$ apt-cache rdepends libjs-jquery-hotkeys
libjs-jquery-hotkeys
Reverse Depends:
  libghc-gitit-data
  python3-pytest-cov
  python-pytest-cov
  python3-coverage
  python-coverage
  prometheus
=

The source packages are:

* gitit
* python-coverage
* python-pytest-cov
* prometheus

Why are we getting different sets of packages that use
‘libjs-jquery-hotkeys’?

> Doing some source code `grep -n -r "[.]bind([\"']key"`:

When I use the pattern ‘[.]bind\(["']key’ for each of those source
packages with , I get a different
set.

These queries show matches:





This does not:



Does that mean ‘python-pytest-cov’ is not using the ‘jeresig’ API?

Is there a better regex pattern to use to determine what API is used?

> So all of them use the "jeresig" API, but 'libjs-jquery-hotkeys'
> packages the "tzuryby" API.

We get differing results, so I'd like to better understand before
choosing how to resolve this.

-- 
 \  “How many people here have telekenetic powers? Raise my hand.” |
  `\  —Emo Philips |
_o__)  |
Ben Finney 


signature.asc
Description: PGP signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel