Re: [Pkg-javascript-devel] RFS: node-parse-filepath 1.0.1

2016-12-13 Thread Paolo Greppi
On 13/12/2016 19:14, Pirate Praveen wrote:
> On ചൊവ്വ 13 ഡിസംബര്‍ 2016 10:57 വൈകു, Paolo Greppi wrote:
>> My next one is node-fined. It's ready on alioth, I can test here if I
>> install node-parse-filepath and node-lodash-packages with dpkg -i (and
>> everything seems fine).
>>
>> I cant' test yet with pkg-ruby-extras/build because those are still in
>> the NEW queue ...
> 
> autopkgtest is failing (you can use 'adt-run ./ --- null' from package
> source directory) because require('expect') fails, it should be
> require('expect.js').
> 
> I'm not sure what is the best solution here, to patch or to fix
> node-expect.js. For now, please patch and make autopkgtest pass.

There's expect and there's expect.js

In debian we already have the latter so I patch it to use what we have
https://anonscm.debian.org/git/pkg-javascript/node-fined.git/tree/debian/patches/00-expect.diff

P

-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] RFS: node-parse-filepath 1.0.1

2016-12-13 Thread Pirate Praveen
On ചൊവ്വ 13 ഡിസംബര്‍ 2016 10:57 വൈകു, Paolo Greppi wrote:
> My next one is node-fined. It's ready on alioth, I can test here if I
> install node-parse-filepath and node-lodash-packages with dpkg -i (and
> everything seems fine).
> 
> I cant' test yet with pkg-ruby-extras/build because those are still in
> the NEW queue ...

autopkgtest is failing (you can use 'adt-run ./ --- null' from package
source directory) because require('expect') fails, it should be
require('expect.js').

I'm not sure what is the best solution here, to patch or to fix
node-expect.js. For now, please patch and make autopkgtest pass.




signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] RFS: node-parse-filepath 1.0.1

2016-12-13 Thread Pirate Praveen
On ചൊവ്വ 13 ഡിസംബര്‍ 2016 10:01 വൈകു, Paolo Greppi wrote:
> Hi
> 
> I packaged node-parse-filepath as per this ITP:
> https://bugs.debian.org/847911, this is the repo:
> https://anonscm.debian.org/git/pkg-javascript/node-parse-filepath.git/
> 
> I patched away the dependency on is-absolute with node-path-is-absolute.
> 
> Please someone more experienced than me review it and if it's OK sponsor
> its upload.

Uploaded, thanks!



signature.asc
Description: OpenPGP digital signature
-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

Re: [Pkg-javascript-devel] RFS: node-parse-filepath 1.0.1

2016-12-13 Thread Paolo Greppi
On 13/12/2016 18:02, Pirate Praveen wrote:
> On ചൊവ്വ 13 ഡിസംബര്‍ 2016 10:01 വൈകു, Paolo Greppi wrote:
>> Hi
>>
>> I packaged node-parse-filepath as per this ITP:
>> https://bugs.debian.org/847911, this is the repo:
>> https://anonscm.debian.org/git/pkg-javascript/node-parse-filepath.git/
>>
>> I patched away the dependency on is-absolute with node-path-is-absolute.
>>
>> Please someone more experienced than me review it and if it's OK sponsor
>> its upload.
> 
> Uploaded, thanks!

My next one is node-fined. It's ready on alioth, I can test here if I
install node-parse-filepath and node-lodash-packages with dpkg -i (and
everything seems fine).

I cant' test yet with pkg-ruby-extras/build because those are still in
the NEW queue ...

Paolo


-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel

[Pkg-javascript-devel] RFS: node-parse-filepath 1.0.1

2016-12-13 Thread Paolo Greppi
Hi

I packaged node-parse-filepath as per this ITP:
https://bugs.debian.org/847911, this is the repo:
https://anonscm.debian.org/git/pkg-javascript/node-parse-filepath.git/

I patched away the dependency on is-absolute with node-path-is-absolute.

Please someone more experienced than me review it and if it's OK sponsor
its upload.

Thanks,

Paolo


-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-javascript-devel