[Pkg-lustre-maintainers] Bug#501427: is this RC as a bug of lustre-source?

2008-10-26 Thread Patrick Winnertz 
Hey
> It looks like that is a good option for lenny. Since I've been assigned
> this bug as part of the bug sprint  I
> hereby offer to NMU this fix using the attached patch.
Please do not NMU this package. A upload is already prepared. 
Thanks in advance.

Greetings
Winnie

-- 
 . '' ` .   Patrick Winnertz <[EMAIL PROTECTED]>
:  :'   :   proud Debian developer, author, administrator, and user
`. `'` http://people.debian.org/~winnie - http://www.der-winnie.de
  `-  Debian - when you have better things to do than fixing systems


signature.asc
Description: This is a digitally signed message part.
___
Pkg-lustre-maintainers mailing list
Pkg-lustre-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-lustre-maintainers

[Pkg-lustre-maintainers] Bug#501427: is this RC as a bug of lustre-source?

2008-10-26 Thread Dominic Hargreaves 
On Mon, Oct 20, 2008 at 08:19:00AM +0200, Thomas Viehmann wrote:
> On 2008-10-20 07:01:03.00 Patrick Winnertz <[EMAIL PROTECTED]> wrote:
> >So: In my eyes this is not a bug in lustre-source itself but in any  
> >other package. I would like to digg further before reassigning it  
> >again to another package. 
> That would be good medium term, but...
> 
> >Fixing it in lustre-source would be easy: Removing only the make -C  
> >$(KSRC) prepare call in debian/rules 
> 
> ... IMO, not using make -C $(KSRC) in lustre-source seems like a good  
> option for lenny because it is an inherently local fix (i.e. it only  
> changes the behavior for one module) where fixing make-kpkg or  
> anything else is necessarily less so.
> As such, what do you think about dropping make -C $(KSRC) and  
> downgrading the the severity of this bug after that has migrated to  
> lenny?

It looks like that is a good option for lenny. Since I've been assigned
this bug as part of the bug sprint  I
hereby offer to NMU this fix using the attached patch.

Dominic.

-- 
Dominic Hargreaves | http://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)
diff -u lustre-1.6.5.1/debian/changelog lustre-1.6.5.1/debian/changelog
--- lustre-1.6.5.1/debian/changelog
+++ lustre-1.6.5.1/debian/changelog
@@ -1,3 +1,12 @@
+lustre (1.6.5.1-3.1) unstable; urgency=medium
+
+  * Non-maintainer upload
+  * Urgency medium for RC bug fix
+  * Don't use make -C $(KSRC), since this will break other m-a builds
+(workaround for #501427)
+
+ -- Dominic Hargreaves <[EMAIL PROTECTED]>  Sun, 26 Oct 2008 16:56:27 +
+
 lustre (1.6.5.1-3) unstable; urgency=low
 
   * [dc55182] Updated patchless support patch to do not disable
diff -u lustre-1.6.5.1/debian/rules lustre-1.6.5.1/debian/rules
--- lustre-1.6.5.1/debian/rules
+++ lustre-1.6.5.1/debian/rules
@@ -257,7 +257,8 @@
 	# replaced the control file.
 	dpkg-checkbuilddeps
 	# Prepare the kernel to lustres' liking
-	-$(MAKE) -C $(KSRC) prepare scripts
+	# XXX Don't do this; workaound for #501427
+	#-$(MAKE) -C $(KSRC) prepare scripts
 	# touch files to same date, to avoid auto*
 	find . -type f -exec touch -r COPYING {} \;
 	# Doesn't seem possible to only build modules...
___
Pkg-lustre-maintainers mailing list
Pkg-lustre-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-lustre-maintainers

[Pkg-lustre-maintainers] Bug#501427: is this RC as a bug of lustre-source?

2008-10-19 Thread Thomas Viehmann 
Hi Patrick,

thanks for posting the state of your analysis.

On 2008-10-20 07:01:03.00 Patrick Winnertz <[EMAIL PROTECTED]> wrote:
> So: In my eyes this is not a bug in lustre-source itself but in any  
> other package. I would like to digg further before reassigning it  
> again to another package. 
That would be good medium term, but...

> Fixing it in lustre-source would be easy: Removing only the make -C  
> $(KSRC) prepare call in debian/rules 

... IMO, not using make -C $(KSRC) in lustre-source seems like a good  
option for lenny because it is an inherently local fix (i.e. it only  
changes the behavior for one module) where fixing make-kpkg or  
anything else is necessarily less so.
As such, what do you think about dropping make -C $(KSRC) and  
downgrading the the severity of this bug after that has migrated to  
lenny?

Kind regards

T.



___
Pkg-lustre-maintainers mailing list
Pkg-lustre-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-lustre-maintainers

[Pkg-lustre-maintainers] Bug#501427: is this RC as a bug of lustre-source?

2008-10-19 Thread Patrick Winnertz 
Thomas Viehmann wrote on Monday 20 October 2008 at 00:00:40:
> Hi,
>
> it seems that lustre-source builds fine in m-a, so is this bug really RC
> when considered to be lustre's problem?
No.. In my eyes this is not a bug of lustre-source itself but of make-kpkg or 
of kernel-source (but more probably the bug can be found in make-kpkg).

If I set the the append to version with --append-to-version "-foobar" with 
make-kpkg this string is added to UTS_RELEASE. 

But after a make -C . prepare this additional string is removed. As discussed 
with Bastian Blank in IRC it seems so that make-kpkg doesn't set this string 
correctly, therefore make -C . prepare ignores it and resets the utsrelease.h 
file.
(And this meant that with m-a it is not longer possible to build any module 
against this kernel. I consider this as RC, what do you think?)

So: In my eyes this is not a bug in lustre-source itself but in any other 
package. I would like to digg further before reassigning it again to another 
package. 

Fixing it in lustre-source would be easy: Removing only the make -C $(KSRC) 
prepare call in debian/rules 

Greetings
Winnie

-- 
 . '' ` .   Patrick Winnertz <[EMAIL PROTECTED]>
:  :'   :   proud Debian developer, author, administrator, and user
`. `'` http://people.debian.org/~winnie - http://www.der-winnie.de
  `-  Debian - when you have better things to do than fixing systems


signature.asc
Description: This is a digitally signed message part.
___
Pkg-lustre-maintainers mailing list
Pkg-lustre-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-lustre-maintainers

[Pkg-lustre-maintainers] Bug#501427: is this RC as a bug of lustre-source?

2008-10-19 Thread Thomas Viehmann 
Hi,

it seems that lustre-source builds fine in m-a, so is this bug really RC
when considered to be lustre's problem?

Kind regards

T.
-- 
Thomas Viehmann, http://thomas.viehmann.net/



___
Pkg-lustre-maintainers mailing list
Pkg-lustre-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-lustre-maintainers