Re: Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1

2011-02-21 Thread Hans de Goede

Hi all,

Note a patch fixing bswap.h to do things properly has now been
pushed to the libmms git repo on sourceforge.

Regards,

Hans

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers


Re: Bug#611791: [SRM] Approval for libmms_0.6-1squeeze1

2011-02-19 Thread Hans de Goede

Hi,

On 02/19/2011 10:05 PM, Fabian Greffrath wrote:

Dear Hans,

could you please comment on this? I'd like to backport this patch from
trunk to the version in Debian squeeze (libmms 0.6), because it is known
to fix the alignment bug on ARM, see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=611791



Oh, good catch. So the story goes like this, indeed the SAME_ENDIAN
and SWAP_ENDIAN macros should be called LITTLE_ENDIAN_TO_NATIVE resp.
BIG_ENDIAN_TO_NATIVE, iow they indeed will do the wrong thing
on bigendian if used as intended, but the WORDS_BIGENDIAN
define which is checked for does not get defined by standard
C headers, so we end up using the /* Little endian */ block
on big endian machines too. So this is a case were 2 wrongs
make a right.

I'll change this (really fix it) in git soonish, likely tomorrow.

BTW, note that I strongly believe that the 0.6.1 and 0.6.2 releases
are bugfix only releases, fixing a number of small but nice to
have fixed bugs. Ok I must admit that the ipv6 changes could be called
a feature, then again not supporting ipv6 now a days can also plainly
be called a bug. So I think it would be best to just rebase the packages
to 0.6.2, rather then do a backport.

Regards,

Hans

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers


Re: Bug#493735: libmms-dev: Incorrect use of this keyword in mmsx.h

2010-06-07 Thread Hans de Goede

On 06/02/2010 11:21 AM, Fabian Greffrath wrote:

Am 02.06.2010 10:58, schrieb Fabian Greffrath:

Am 02.06.2010 10:28, schrieb Hans de Goede:

Yes, as can #493735 of course.


Not entirely, the this keyword is still used in mmsh.h and mmsx.h.


I guess the attached patch for finally fix it.



Hi,

Sorry about this not being fixed in one go, and thanks for the patch.

Patch applied!

Regards,

Hans



___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers


Bug#493735: libmms-dev: Incorrect use of this keyword in mmsx.h

2010-05-31 Thread Hans de Goede

Hi,

On 05/31/2010 02:08 PM, Fabian Greffrath wrote:

Hi Hans,

Am 31.05.2010 12:44, schrieb Hans de Goede:

This is fixed in the latest upstream release:
http://downloads.sourceforge.net/project/libmms/libmms/0.6/libmms-0.6.tar.gz



does the new upstream version also include the patch that adds support
for extended stream properties, as requested here?

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=498174



Yes, not only does it contain that patch, but the patch has been ported to
the mmsh code as well. The code inside libmms is split in mmst and mmsh code,
and the patch linked from:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=498174

Only adds extended stream properties support to the mmst handling code,
I later ported this to the mmsh code as well. Thanks for the link
to the debian bug, now I've an uri to actually test this, and ...
it works :)

Regards,

Hans


p.s.

0.6 is fully ABI compatible with 0.4, so its a drop in replacement with
many bugfixes.



___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers