Re: uploaded 3 new pkgs: pd-arraysize, pd-beatpipe, pd-comport
On Sep 13, 2010, at 6:06 AM, IOhannes m zmoelnig wrote: On 2010-09-12 19:27, Alessio Treglia wrote: On Sun, Sep 12, 2010 at 7:08 PM, Hans-Christoph Steiner h...@at.or.at wrote: I noticed that you left debian/docs. Do you think that might conflict with the README.txt in debian/links? Fixed: http://git.debian.org/?p=pkg-multimedia/pd-arraysize.git;a=commitdiff;h=7a67 Excellent! I'll remove the override_dh_strip targets. Is this a product of using dh_auto_install instead of make? No, it isn't. The Makefile contains all that, dh_auto_install just runs 'make install'. sorry to interrupt, but as i see it, the build process now unconditionally strips the binaries, which violates the debian-policy (4.9.1 DEB_BUILD_OPTIONS nostrip) at least, if i compile with DEB_BUILD_OPTIONS=nostrip, the resulting binary arraysize.pd_linux will still be stripped. That seems like something that debhelper should handle. Does it need a separate install-strip Makefile target? .hc The arc of history bends towards justice. - Dr. Martin Luther King, Jr. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: uploaded 3 new pkgs: pd-arraysize, pd-beatpipe, pd-comport
On Mon, Sep 13, 2010 at 08:55:15AM -0400, Hans-Christoph Steiner wrote: On Sep 13, 2010, at 6:06 AM, IOhannes m zmoelnig wrote: On 2010-09-12 19:27, Alessio Treglia wrote: On Sun, Sep 12, 2010 at 7:08 PM, Hans-Christoph Steiner h...@at.or.at wrote: I noticed that you left debian/docs. Do you think that might conflict with the README.txt in debian/links? Fixed: http://git.debian.org/?p=pkg-multimedia/pd-arraysize.git;a=commitdiff;h=7a67 Excellent! I'll remove the override_dh_strip targets. Is this a product of using dh_auto_install instead of make? No, it isn't. The Makefile contains all that, dh_auto_install just runs 'make install'. sorry to interrupt, but as i see it, the build process now unconditionally strips the binaries, which violates the debian-policy (4.9.1 DEB_BUILD_OPTIONS nostrip) at least, if i compile with DEB_BUILD_OPTIONS=nostrip, the resulting binary arraysize.pd_linux will still be stripped. That seems like something that debhelper should handle. Does it need a separate install-strip Makefile target? debhelper optionally strips. It cannot un-strip if stripped by upstream build routines, as seems to be the case here. - Jonas -- * Jonas Smedegaard - idealist Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: uploaded 3 new pkgs: pd-arraysize, pd-beatpipe, pd-comport
On Mon, 2010-09-13 at 16:34 +0200, Jonas Smedegaard wrote: On Mon, Sep 13, 2010 at 08:55:15AM -0400, Hans-Christoph Steiner wrote: On Sep 13, 2010, at 6:06 AM, IOhannes m zmoelnig wrote: On 2010-09-12 19:27, Alessio Treglia wrote: On Sun, Sep 12, 2010 at 7:08 PM, Hans-Christoph Steiner h...@at.or.at wrote: I noticed that you left debian/docs. Do you think that might conflict with the README.txt in debian/links? Fixed: http://git.debian.org/?p=pkg-multimedia/pd-arraysize.git;a=commitdiff;h=7a67 Excellent! I'll remove the override_dh_strip targets. Is this a product of using dh_auto_install instead of make? No, it isn't. The Makefile contains all that, dh_auto_install just runs 'make install'. sorry to interrupt, but as i see it, the build process now unconditionally strips the binaries, which violates the debian-policy (4.9.1 DEB_BUILD_OPTIONS nostrip) at least, if i compile with DEB_BUILD_OPTIONS=nostrip, the resulting binary arraysize.pd_linux will still be stripped. That seems like something that debhelper should handle. Does it need a separate install-strip Makefile target? debhelper optionally strips. It cannot un-strip if stripped by upstream build routines, as seems to be the case here. Currently the strip is happening in the install target with the $(STRIP) variable. I suppose it would be possible to set $(STRIP) to touch, that would work with the current Makefile. All of these pd packages that I am uploading use the same Makefile template. We wrote this Makefile with the expressed intention of making it really easy to package properly. So what is debhelper looking for in order to have separate install and strip capabilities? .hc ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: uploaded 3 new pkgs: pd-arraysize, pd-beatpipe, pd-comport
On Sat, Sep 11, 2010 at 11:04 PM, Hans-Christoph Steiner h...@at.or.at wrote: Hey all, I justed ITP'ed and uploaded three new packages to git.debian.org: pd-arraysize, pd-beatpipe, pd-comport. Alessio said he was interested in sponsoring them, so I'll let him take it from here. Reviewed. Please test and let me know! -- Alessio Treglia ales...@debian.org Debian Ubuntu Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: uploaded 3 new pkgs: pd-arraysize, pd-beatpipe, pd-comport
On Sep 12, 2010, at 6:10 AM, Alessio Treglia wrote: On Sat, Sep 11, 2010 at 11:04 PM, Hans-Christoph Steiner h...@at.or.at wrote: Hey all, I justed ITP'ed and uploaded three new packages to git.debian.org: pd-arraysize, pd-beatpipe, pd-comport. Alessio said he was interested in sponsoring them, so I'll let him take it from here. Reviewed. Please test and let me know! Hey Alessio, I have a few questions about the changes. The debian/rules file has been fine tuned quite a bit, and *README.txt and LICENSE.txt are part of the upstream Pd library format, so they need to be included in the library folder (i.e. /usr/ lib/pd/extra/pd-arraysize). Jonas said the text file should be in the lib, and a symlink in /usr/share/doc since /usr/lib is required and / usr/share is optional. *does debhelper set $(STRIP) in the Makefile? if so, the override_dh_strip stuff is not necessary since, as you said in your commit comments, there is a $(STRIP) line in the upstream install target. *the debian/copyright file is fine, but really we (Pd upstream) have a library template that includes the Makefile and debian files, and we have released it into the public domain. http://puredata.info/docs/developer/LibraryTemplate .hc Using ReBirth is like trying to play an 808 with a long stick.- David Zicarelli ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: uploaded 3 new pkgs: pd-arraysize, pd-beatpipe, pd-comport
On Sun, Sep 12, 2010 at 5:25 PM, Hans-Christoph Steiner h...@at.or.at wrote: *README.txt and LICENSE.txt are part of the upstream Pd library format, so they need to be included in the library folder (i.e. /usr/lib/pd/extra/pd-arraysize). Jonas said the text file should be in the lib, and a symlink in /usr/share/doc since /usr/lib is required and /usr/share is optional. Well, I'll revert my changes. *does debhelper set $(STRIP) in the Makefile? if so, the override_dh_strip stuff is not necessary since, as you said in your commit comments, there is a $(STRIP) line in the upstream install target. Please have a look at this [1]: install -p -m 644 arraysize-meta.pd \ /tmp/buildd/pd-arraysize-0.1/debian/pd-arraysize/usr/lib/pd/extra/arraysize test -z arraysize.c || (\ install -p -m 644 arraysize.pd_linux /tmp/buildd/pd-arraysize-0.1/debian/pd-arraysize/usr/lib/pd/extra/arraysize \ strip --strip-unneeded -R .note -R .comment /tmp/buildd/pd-arraysize-0.1/debian/pd-arraysize/usr/lib/pd/extra/arraysize/arraysize.pd_linux) test -z || \ install -p -m 644 \ /tmp/buildd/pd-arraysize-0.1/debian/pd-arraysize/usr/lib/pd/extra/arraysize So there is no need to re-strip the binaries in debian/rules. [1] http://debomatic64.debian.net/unstable/pool/pd-arraysize_0.1-1/pd-arraysize_0.1-1.buildlog -- Alessio Treglia ales...@debian.org Debian Ubuntu Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: uploaded 3 new pkgs: pd-arraysize, pd-beatpipe, pd-comport
On Sun, Sep 12, 2010 at 7:08 PM, Hans-Christoph Steiner h...@at.or.at wrote: I noticed that you left debian/docs. Do you think that might conflict with the README.txt in debian/links? Fixed: http://git.debian.org/?p=pkg-multimedia/pd-arraysize.git;a=commitdiff;h=7a67 Excellent! I'll remove the override_dh_strip targets. Is this a product of using dh_auto_install instead of make? No, it isn't. The Makefile contains all that, dh_auto_install just runs 'make install'. -- Alessio Treglia ales...@debian.org Debian Ubuntu Developer | Homepage: http://www.alessiotreglia.com 0FEC 59A5 E18E E04F 6D40 593B 45D4 8C7C DCFC 3FD0 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: uploaded 3 new pkgs: pd-arraysize, pd-beatpipe, pd-comport
On Sun, 2010-09-12 at 19:27 +0200, Alessio Treglia wrote: On Sun, Sep 12, 2010 at 7:08 PM, Hans-Christoph Steiner h...@at.or.at wrote: I noticed that you left debian/docs. Do you think that might conflict with the README.txt in debian/links? Fixed: http://git.debian.org/?p=pkg-multimedia/pd-arraysize.git;a=commitdiff;h=7a67 Excellent! I'll remove the override_dh_strip targets. Is this a product of using dh_auto_install instead of make? No, it isn't. The Makefile contains all that, dh_auto_install just runs 'make install'. Right, I mean more that dh_auto_install sets STRIP when calling make install. .hc ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
uploaded 3 new pkgs: pd-arraysize, pd-beatpipe, pd-comport
Hey all, I justed ITP'ed and uploaded three new packages to git.debian.org: pd-arraysize, pd-beatpipe, pd-comport. Alessio said he was interested in sponsoring them, so I'll let him take it from here. These three are quite simple so they should be pretty easy to get thru. .hc ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
