Re: On commit messages... again

2011-01-08 Thread IOhannes m zmölnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/08/2011 01:05 AM, Felipe Sateler wrote: Please, be descriptive in the commit messages. A commit message saying add libblah-dev as build-depends is not really useful, as we can see that from the patch. The point of commit messages is to

Re: On commit messages... again

2011-01-08 Thread Jonas Smedegaard
On Sat, Jan 08, 2011 at 03:04:55PM +0100, IOhannes m zmölnig wrote: On 01/08/2011 01:05 AM, Felipe Sateler wrote: Please, be descriptive in the commit messages. A commit message saying add libblah-dev as build-depends is not really useful, as we can see that from the patch. The point of commit

Re: On commit messages... again

2011-01-08 Thread IOhannes m zmölnig
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/08/2011 03:19 PM, Jonas Smedegaard wrote: On Sat, Jan 08, 2011 at 03:04:55PM +0100, IOhannes m zmölnig wrote: On 01/08/2011 01:05 AM, Felipe Sateler wrote: Please, be descriptive in the commit messages. A commit message saying add

On commit messages... again

2011-01-07 Thread Felipe Sateler
Please, be descriptive in the commit messages. A commit message saying add libblah-dev as build-depends is not really useful, as we can see that from the patch. The point of commit messages is to explain why the changes are necessary (eg, Enable support for doing something, needs libblah). --