Bug#582784: patch to enable fribidi support in mplayer
On Mi, Mai 26, 2010 at 13:09:08 (CEST), Lior Kaplan wrote: > I'm sorry for the trouble you had, but as the debian package already build > depends on pkg-config, it seems legitimate. depending on pkg-config is acceptable for a debian package. requiring obscure configure paramters that rather work by accident is just not maintainable. > Could you send me your fix, in order to learn ? sure: http://comments.gmane.org/gmane.comp.video.mplayer.cvs/14541 http://comments.gmane.org/gmane.comp.video.mplayer.cvs/14544 -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#582784: patch to enable fribidi support in mplayer
On Wed, May 26, 2010 at 12:57 PM, Reinhard Tartler wrote: > On Sun, May 23, 2010 at 18:01:07 (CEST), Lior Kaplan wrote: > > > This is probably due to the an updated libfribidi package (version > 0.19.2-1) > > which has dropped fribidi-config that mplayer checks for. > > > > I'm attaching a patch to fix the configure script. Additionally the > > following > > configure option has to be added: > > "--with-fribidi-config=/usr/bin/pkg-config" > > I'm sorry that I haven't looked at your patch more closely before. I was > just to apply your patch, but this approach is not acceptable for > neither upstream nor the debian package. > > I've therefore invested some time to add pkg-config support > properly, commit it to svn trunk, backported to the mplayer package, got > flamed upstream for making pkg-config mandatory (breaks cygwin builds) > and eventually fixed that as well. > > Anyway, this should be fixed now in debian as well. > > I'm sorry for the trouble you had, but as the debian package already build depends on pkg-config, it seems legitimate. Could you send me your fix, in order to learn ? Kaplan ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#582784: patch to enable fribidi support in mplayer
On Sun, May 23, 2010 at 18:01:07 (CEST), Lior Kaplan wrote: > This is probably due to the an updated libfribidi package (version 0.19.2-1) > which has dropped fribidi-config that mplayer checks for. > > I'm attaching a patch to fix the configure script. Additionally the > following > configure option has to be added: > "--with-fribidi-config=/usr/bin/pkg-config" I'm sorry that I haven't looked at your patch more closely before. I was just to apply your patch, but this approach is not acceptable for neither upstream nor the debian package. I've therefore invested some time to add pkg-config support properly, commit it to svn trunk, backported to the mplayer package, got flamed upstream for making pkg-config mandatory (breaks cygwin builds) and eventually fixed that as well. Anyway, this should be fixed now in debian as well. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#582784: patch to enable fribidi support in mplayer
On Sun, May 23, 2010 at 10:54 PM, Reinhard Tartler wrote: > On Sun, May 23, 2010 at 18:01:07 (CEST), Lior Kaplan wrote: > > > Checking mplayer's build logs I noticed this line: > > > > Checking for fribidi with charsets ... no > > > > This is probably due to the an updated libfribidi package (version > 0.19.2-1) > > which has dropped fribidi-config that mplayer checks for. > > This has already been analyzed in ubuntu: > https://bugs.edge.launchpad.net/ubuntu/+source/mplayer/+bug/556200 > > Ah, I see that you have noticed that yourself :-) > I noticed it in Ubuntu, and figured it will be easier to get it fixed in Debian. > > > I'm attaching a patch to fix the configure script. Additionally the > > following > > configure option has to be added: > > "--with-fribidi-config=/usr/bin/pkg-config" > > > > As libfribidi-dev is already a build dependency, no other changes are > > needed. > > > > Expected result: > > > > Checking for fribidi with charsets ... yes > > okay, now we need to get that applied upstream :-) > > anyway, thanks for the patch, I'll apply it for the next upload. > Great. Thanks. ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#582784: patch to enable fribidi support in mplayer
On Sun, May 23, 2010 at 18:01:07 (CEST), Lior Kaplan wrote: > Checking mplayer's build logs I noticed this line: > > Checking for fribidi with charsets ... no > > This is probably due to the an updated libfribidi package (version 0.19.2-1) > which has dropped fribidi-config that mplayer checks for. This has already been analyzed in ubuntu: https://bugs.edge.launchpad.net/ubuntu/+source/mplayer/+bug/556200 Ah, I see that you have noticed that yourself :-) > I'm attaching a patch to fix the configure script. Additionally the > following > configure option has to be added: > "--with-fribidi-config=/usr/bin/pkg-config" > > As libfribidi-dev is already a build dependency, no other changes are > needed. > > Expected result: > > Checking for fribidi with charsets ... yes okay, now we need to get that applied upstream :-) anyway, thanks for the patch, I'll apply it for the next upload. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Bug#582784: patch to enable fribidi support in mplayer
Package: mplayer Version: 2:1.0~rc3+svn20100502-2 Severity: normal Tags: patch l10n Checking mplayer's build logs I noticed this line: Checking for fribidi with charsets ... no This is probably due to the an updated libfribidi package (version 0.19.2-1) which has dropped fribidi-config that mplayer checks for. I'm attaching a patch to fix the configure script. Additionally the following configure option has to be added: "--with-fribidi-config=/usr/bin/pkg-config" As libfribidi-dev is already a build dependency, no other changes are needed. Expected result: Checking for fribidi with charsets ... yes Thanks, Kaplan --- configure2010-05-01 21:51:08.0 +0300 +++ configure2010-05-23 18:36:21.0 +0300 @@ -6052,15 +6052,15 @@ } EOF _fribidi=no -cc_check `$_fribidiconfig --cflags` `$_fribidiconfig --libs` && tmp_run && _fribidi=yes +cc_check `$_fribidiconfig --cflags fribidi` `$_fribidiconfig --libs fribidi` && tmp_run && _fribidi=yes else _fribidi=no fi fi if test "$_fribidi" = yes ; then def_fribidi='#define CONFIG_FRIBIDI' -extra_cflags="$extra_cflags `$_fribidiconfig --cflags`" -extra_ldflags="$extra_ldflags `$_fribidiconfig --libs`" +extra_cflags="$extra_cflags `$_fribidiconfig --cflags fribidi`" +extra_ldflags="$extra_ldflags `$_fribidiconfig --libs fribidi`" else def_fribidi='#undef CONFIG_FRIBIDI' fi ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
