Re: Bug#493735: libmms-dev: Incorrect use of "this" keyword in mmsx.h

[Fabian Greffrath]

Am 07.06.2010 09:29, schrieb Hans de Goede:

Sorry about this not being fixed in one go, and thanks for the patch.
Patch applied!


Never mind, thank you very much!

BTW, I consider the libmms package ready for unstable now.


 - Fabian

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Re: Bug#493735: libmms-dev: Incorrect use of "this" keyword in mmsx.h

[Hans de Goede]

On 06/02/2010 11:21 AM, Fabian Greffrath wrote:

Am 02.06.2010 10:58, schrieb Fabian Greffrath:

Am 02.06.2010 10:28, schrieb Hans de Goede:

Yes, as can #493735 of course.


Not entirely, the "this" keyword is still used in mmsh.h and mmsx.h.


I guess the attached patch for finally fix it.



Hi,

Sorry about this not being fixed in one go, and thanks for the patch.

Patch applied!

Regards,

Hans



___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Re: Bug#493735: libmms-dev: Incorrect use of "this" keyword in mmsx.h

[Fabian Greffrath]

Am 02.06.2010 10:58, schrieb Fabian Greffrath:

Am 02.06.2010 10:28, schrieb Hans de Goede:

Yes, as can #493735 of course.


Not entirely, the "this" keyword is still used in mmsh.h and mmsx.h.


I guess the attached patch for finally fix it.

>From eb1312be01397a403f4fd80a3b5192cb2a53aa72 Mon Sep 17 00:00:00 2001
From: Fabian Greffrath 
Date: Wed, 2 Jun 2010 11:20:47 +0200
Subject: [PATCH] Do not incorrectly use the reserved keyword "this" as a variable name.

---
 src/mmsh.h |   12 ++--
 src/mmsx.h |6 +++---
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/mmsh.h b/src/mmsh.h
index 6a33f0c..b222eea 100644
--- a/src/mmsh.h
+++ b/src/mmsh.h
@@ -41,20 +41,20 @@ mmsh_t*   mmsh_connect (mms_io_t *io, void *data, const char *url_, int bandwidt
 
 int  mmsh_read (mms_io_t *io, mmsh_t *instance, char *data, int len);
 int  mmsh_time_seek (mms_io_t *io, mmsh_t *instance, double time_sec);
-mms_off_t mmsh_seek (mms_io_t *io, mmsh_t *this, mms_off_t offset, int origin);
+mms_off_t mmsh_seek (mms_io_t *io, mmsh_t *instance, mms_off_t offset, int origin);
 uint32_t mmsh_get_length (mmsh_t *instance);
-double   mmsh_get_time_length (mmsh_t *this);
-uint64_t mmsh_get_raw_time_length (mmsh_t *this);
+double   mmsh_get_time_length (mmsh_t *instance);
+uint64_t mmsh_get_raw_time_length (mmsh_t *instance);
 mms_off_t mmsh_get_current_pos (mmsh_t *instance);
 void mmsh_close (mmsh_t *instance);
 
 int  mmsh_peek_header (mmsh_t *instance, char *data, int maxsize);
 
-uint32_t mmsh_get_asf_header_len (mmsh_t *this);
+uint32_t mmsh_get_asf_header_len (mmsh_t *instance);
 
-uint32_t mmsh_get_asf_packet_len (mmsh_t *this);
+uint32_t mmsh_get_asf_packet_len (mmsh_t *instance);
 
-int  mmsh_get_seekable (mmsh_t *this);
+int  mmsh_get_seekable (mmsh_t *instance);
 
 #ifdef __cplusplus
 }
diff --git a/src/mmsx.h b/src/mmsx.h
index ed6837b..df4adfc 100644
--- a/src/mmsx.h
+++ b/src/mmsx.h
@@ -55,11 +55,11 @@ int   mmsx_peek_header (mmsx_t *instance, char *data, int maxsize);
 
 mms_off_t mmsx_get_current_pos (mmsx_t *instance);
 
-uint32_t  mmsx_get_asf_header_len (mmsx_t *this);
+uint32_t  mmsx_get_asf_header_len (mmsx_t *instance);
 
-uint64_t  mmsx_get_asf_packet_len (mmsx_t *this);
+uint64_t  mmsx_get_asf_packet_len (mmsx_t *instance);
 
-int   mmsx_get_seekable (mmsx_t *this);
+int   mmsx_get_seekable (mmsx_t *instance);
 
 #ifdef __cplusplus
 }
-- 
1.7.1

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Re: Bug#493735: libmms-dev: Incorrect use of "this" keyword in mmsx.h

[Fabian Greffrath]

Am 02.06.2010 10:28, schrieb Hans de Goede:

Yes, as can #493735 of course.


Not entirely, the "this" keyword is still used in mmsh.h and mmsx.h.


About the others, I've tried to reproduce them all with
Fedora-13 x86_64 (so a pretty brand spanking new gstreamer stack)
with libmms-0.6 installed, results below.


Wow, thank you very much for this quick analysis!


#517105
rhythmbox: Playing mms:// streams in Radio crashes Rhythmbox

The mms uri given in the bug works fine in both totem and rhythmbox.


Will close.


#552127
ruby-gnome2: segfaults opening mms:// with gst, after opening another
stream type

As indicated in the bug, this can be reproduced with python too, so I
tried to reproduce this with python using both a playbin and a
playbin2 element. In both cases things work fine (iow I cannot reproduce).


Will close.


#448559
totem: URL causing crash

I know this one is fixed, as there is a specific patch included in 0.6
addressing this issue. I also tested it and totem no longer crashes
(but the wrong url still does not play, which is not really surprising).


Will close.


#470806
Totem crash while playing norwegian broadcasting net tv

There are no valid uris inside the bug report, I tried playing various
mms streams from nrk.no (where the uris present in the bug point to),
for example:
http://www1.nrk.no/nett-tv/klipp/641089
And they work fine.


Will close.


#501068
gstreamer0.10-tools: crash when playing mms stream

gst-launch-0.10 playbin uri=mms://wms.webradio.antenne.de
Works fine for me.


Will close.


#362657
libmms-dev: needless dependency on glib.h

Good one, I just fixed this with this commit:
http://libmms.git.sourceforge.net/git/gitweb.cgi?p=libmms/libmms;a=commitdiff;h=144f65dbef2f273f4b235b618eb7aeb041949a8c

As for this breaking the libmms API, well those macros were never
intended to be part of the API and I doubt any libmms using apps
depend on them. If any apps do depend on them the apps should be
fixed. Note that this not change the ABI as there are macros not
exported functions.

Also the not being linked to glib of libmms has been fixed already.


I think I will pull in this commit and also close this bug.


I realize that for those who "work fine" with my setup there may still
be issues on Debian after upgrading to libmms-0.6, but these issues should
then be sought outside of libmms IMHO.


Thanks to clomo, Debian currently has a very recent gstreamer stack, 
too. I don't expect any further Debian-specific problems.


Thanks for your impressive work,
Fabian

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

Re: Bug#493735: libmms-dev: Incorrect use of "this" keyword in mmsx.h

[Fabian Greffrath]

Dear Hans,

Am 31.05.2010 14:14, schrieb Hans de Goede:

0.6 is fully ABI compatible with 0.4, so its a drop in replacement with
many bugfixes.


as Arthur agreed to add me as a co-maintainer for the libmms package, 
I would like to get through the open bugs currently filed against 
libmms in Debian with you and see which still apply and which don't:




At least #498174 can be closed with the new upload.

Cheers,
Fabian

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers