Re: Looking for sponsor or mentor for package crtmpserver
On Wed, Mar 16, 2011 at 10:59:55 (CET), Andriy Beregovenko wrote: >> it seems that Andriy's branch has not been developed using the >> git-buildpackage workflow, but he has rather just imported the contents >> of his package branch. >> >> Andriy, can you confirm? > You are absolutely right. I prepare sources, copy it to local git and > add+commit+push it. > if somewhere are any doc about "right way" to create repo and filling it, > please tell me where I can read/find it :) See here: http://wiki.debian.org/DebianMultimedia/DevelopPackaging#Howtohelpwithpackaging Please also tell us what information and links are missing so that we can improve it! -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Wed, Mar 16, 2011 at 11:59:55AM +0200, Andriy Beregovenko wrote: On Wed, Mar 16, 2011 at 10:24:23AM +0100, Reinhard Tartler wrote: it seems that Andriy's branch has not been developed using the git-buildpackage workflow, but he has rather just imported the contents of his package branch. Andriy, can you confirm? You are absolutely right. I prepare sources, copy it to local git and add+commit+push it. if somewhere are any doc about "right way" to create repo and filling it, please tell me where I can read/find it :) As I wrote to you on IRC please use git-buildpackage. A good starting point is "man git-buildpackage" - especially last line of it which points to the actual(!) documentation in an html file ;-) Personally I googled for info on git-buildpackage when I started using it myself. Now I have dropped using Google directly (I use DuckDuckGo) but that's another story... - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Wed, Mar 16, 2011 at 10:24:23AM +0100, Reinhard Tartler wrote: > On Tue, Mar 15, 2011 at 19:44:04 (CET), Alessandro Ghedini wrote: > > > On Tue, Mar 15, 2011 at 02:20:46PM +0200, Andriy Beregovenko wrote: > >> I'm already create repo and now preparing source files to initial commit :) > >> If somebody can check it, please do this :) I'll be very grateful :) > > > > I don't see any 'upstream' nor 'pristine-tar' branches. You should do > > 'git push --all' to properly create all the branches that git-buildpackage > > made, on the remote repository. > > it seems that Andriy's branch has not been developed using the > git-buildpackage workflow, but he has rather just imported the contents > of his package branch. > > Andriy, can you confirm? You are absolutely right. I prepare sources, copy it to local git and add+commit+push it. if somewhere are any doc about "right way" to create repo and filling it, please tell me where I can read/find it :) > > Can you please fix this, and also clarify what changes you did to the > originial sources. the version number needs to be adapted as well. > > -- > Gruesse/greetings, > Reinhard Tartler, KeyID 945348A4 > > ___ > pkg-multimedia-maintainers mailing list > pkg-multimedia-maintainers@lists.alioth.debian.org > http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Tue, Mar 15, 2011 at 07:44:04PM +0100, Alessandro Ghedini wrote:
> On Tue, Mar 15, 2011 at 02:20:46PM +0200, Andriy Beregovenko wrote:
> > I'm already create repo and now preparing source files to initial commit :)
> > If somebody can check it, please do this :) I'll be very grateful :)
>
> I don't see any 'upstream' nor 'pristine-tar' branches. You should do
> 'git push --all' to properly create all the branches that git-buildpackage
> made, on the remote repository.
Please tell me, where I can read complete manual about basic requirements to
repo.
> Also, since you have repackaged the orig.tar archive, you have also to
> document it properly in the d/copyright (you can use a 'Comment:' field), or
> in the d/README.source file, telling what and why you have removed (like
> [0]).
What do you mean under "orig.tar archive"? Archive from project owner ?
It does not exist. There is only svn repo. But ok, I'll document "what and
why" I remove or move.
> As per Debian Policy you also have to provide a 'get-orig-source' target
> in the d/rules file, which builds properly the new tarball (without the
> files you decided to remove). This makes easier for future maintainance
> (you won't have to repack the tarball manually every time you update the
> package).
>
> Actually, the get-orig-source rule would have been required anyway, since
> you are using directly the sources from a SVN repository (I have not much
> experience in packaging directly from svn, so I missed this at the
> beginning). Have a look at [1] for an example of what you should do.
Right now I have sh-script which automate all this routine(i mean create
from original sources debian tree), but I do not know how I can include it.
And this script is present in original svn-repo:
http://trac.rtmpd.com/browser/trunk/builders/packing/debian
But I have some doubts about repacking. Currentrly I rebuild all tree for
debian project. But original project have entirely different structure.
(You can see it here: http://trac.rtmpd.com/browser/trunk)
The main reason for this step was "too many unnecessary in builders dir and
several not needed dirs", so I create source tree for deb package in
"traditional cmake style". So I need advice on this issue.
> Another requirement for the repackaged upstream tarball is to add something
> like '~dfsg' to both the source and binary packages version just to make
> clear to everyone that you have modified it. The package versions would
> look something like:
>
>0.0~dfsg+revNNN for the source package
>0.0~dfsg+revNNN-1 for the binary package
>
> Finally, you don't need to Build-Depend on quilt, since it is implied by
> the 3.0 (quilt) source format (was it there also in the previous versions
> of the package? I think I missed it...).
Ok, I'll do this. Also I remove quilt from deps.
> Oh, and you didn't need to remove the lualib sources completely, since
> they are DFSG-compliant. You just needed to patch the sources to use the
> system-provided one and the build system to not build the local copy.
> Since you would have repackaged the orig tarball anyway, IMHO, is not a
> grave issue (but I may be wrong).
Mostly lualib is needed to build embeded version of crtmpserver(not in
debian environment). I do not see any reason to keep lualib sourses in
project tree.
> Cheers
>
> [0]
> http://git.debian.org/?p=pkg-multimedia/deadbeef.git;a=blob;f=debian/README.source;h=ea7bb6b1dd7368aa7c5cd8813cf8996dc4e8b6ae;hb=HEAD
> [1] http://wiki.debian.org/SandroTosi/Svn_get-orig-source
>
> --
> perl -E'$_=q;$/= @{[@_]};and s;\S+;;eg;say~~reverse'
>
> ___
> pkg-multimedia-maintainers mailing list
> pkg-multimedia-maintainers@lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Tue, Mar 15, 2011 at 19:44:04 (CET), Alessandro Ghedini wrote: > On Tue, Mar 15, 2011 at 02:20:46PM +0200, Andriy Beregovenko wrote: >> I'm already create repo and now preparing source files to initial commit :) >> If somebody can check it, please do this :) I'll be very grateful :) > > I don't see any 'upstream' nor 'pristine-tar' branches. You should do > 'git push --all' to properly create all the branches that git-buildpackage > made, on the remote repository. it seems that Andriy's branch has not been developed using the git-buildpackage workflow, but he has rather just imported the contents of his package branch. Andriy, can you confirm? Can you please fix this, and also clarify what changes you did to the originial sources. the version number needs to be adapted as well. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Tue, Mar 15, 2011 at 08:39:43PM +0100, Jonas Smedegaard wrote:
> Generally fine points, but some of them are exxaggerating and can
> thus be misleading even if not totally wrong:
>
> On Tue, Mar 15, 2011 at 07:44:04PM +0100, Alessandro Ghedini wrote:
> >Also, since you have repackaged the orig.tar archive, you have
> >also to document it properly in the d/copyright (you can use a
> >'Comment:' field), or in the d/README.source file, telling what
> >and why you have removed (like [0]).
>
> Notes on uncommon packaging procedures (which creating of tarballs
> from SVN falls under) belong in debian/README.source only.
>
> What should be mentioned in debian/copyright is documenting parts of
> upstream source stripped or in other ways avoided from Debian
> redistribution.
>
>
> >As per Debian Policy you also have to provide a 'get-orig-source'
> >target in the d/rules file, which builds properly the new tarball
> >(without the files you decided to remove). This makes easier for
> >future maintainance (you won't have to repack the tarball manually
> >every time you update the package).
>
> You don't "have to" provide a get-orig-source target, but yes, you
> are encouraged to do so.
>
>
> >Actually, the get-orig-source rule would have been required
> >anyway, since you are using directly the sources from a SVN
> >repository (I have not much experience in packaging directly from
> >svn, so I missed this at the beginning). Have a look at [1] for an
> >example of what you should do.
>
> Again, this does not make get-orig-source a _requirement_.
>
>
> >Another requirement for the repackaged upstream tarball is to add
> >something like '~dfsg' to both the source and binary packages
> >version just to make clear to everyone that you have modified it.
> >The package versions would look something like:
> >
> > 0.0~dfsg+revNNN for the source package
> > 0.0~dfsg+revNNN-1 for the binary package
>
> This is no requirement (for the reasons described above): A dfsg in
> the version number indicated that the source has been repackaged in
> order to comply with "Debian Free Software Guidelines" which is
> independent from creating a tarball due to upstream distributing in
> other forms than by tarballs.
Upstream sources *have* been repackaged due to some binary files not in the
"preferred form of modification". But I understand (and agree with) your
other points.
Cheers
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
Generally fine points, but some of them are exxaggerating and can thus be misleading even if not totally wrong: On Tue, Mar 15, 2011 at 07:44:04PM +0100, Alessandro Ghedini wrote: Also, since you have repackaged the orig.tar archive, you have also to document it properly in the d/copyright (you can use a 'Comment:' field), or in the d/README.source file, telling what and why you have removed (like [0]). Notes on uncommon packaging procedures (which creating of tarballs from SVN falls under) belong in debian/README.source only. What should be mentioned in debian/copyright is documenting parts of upstream source stripped or in other ways avoided from Debian redistribution. As per Debian Policy you also have to provide a 'get-orig-source' target in the d/rules file, which builds properly the new tarball (without the files you decided to remove). This makes easier for future maintainance (you won't have to repack the tarball manually every time you update the package). You don't "have to" provide a get-orig-source target, but yes, you are encouraged to do so. Actually, the get-orig-source rule would have been required anyway, since you are using directly the sources from a SVN repository (I have not much experience in packaging directly from svn, so I missed this at the beginning). Have a look at [1] for an example of what you should do. Again, this does not make get-orig-source a _requirement_. Another requirement for the repackaged upstream tarball is to add something like '~dfsg' to both the source and binary packages version just to make clear to everyone that you have modified it. The package versions would look something like: 0.0~dfsg+revNNN for the source package 0.0~dfsg+revNNN-1 for the binary package This is no requirement (for the reasons described above): A dfsg in the version number indicated that the source has been repackaged in order to comply with "Debian Free Software Guidelines" which is independent from creating a tarball due to upstream distributing in other forms than by tarballs. Regards, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Tue, Mar 15, 2011 at 02:20:46PM +0200, Andriy Beregovenko wrote:
> I'm already create repo and now preparing source files to initial commit :)
> If somebody can check it, please do this :) I'll be very grateful :)
I don't see any 'upstream' nor 'pristine-tar' branches. You should do
'git push --all' to properly create all the branches that git-buildpackage
made, on the remote repository.
Also, since you have repackaged the orig.tar archive, you have also to
document it properly in the d/copyright (you can use a 'Comment:' field), or
in the d/README.source file, telling what and why you have removed (like
[0]).
As per Debian Policy you also have to provide a 'get-orig-source' target
in the d/rules file, which builds properly the new tarball (without the
files you decided to remove). This makes easier for future maintainance
(you won't have to repack the tarball manually every time you update the
package).
Actually, the get-orig-source rule would have been required anyway, since
you are using directly the sources from a SVN repository (I have not much
experience in packaging directly from svn, so I missed this at the
beginning). Have a look at [1] for an example of what you should do.
Another requirement for the repackaged upstream tarball is to add something
like '~dfsg' to both the source and binary packages version just to make
clear to everyone that you have modified it. The package versions would
look something like:
0.0~dfsg+revNNN for the source package
0.0~dfsg+revNNN-1 for the binary package
Finally, you don't need to Build-Depend on quilt, since it is implied by
the 3.0 (quilt) source format (was it there also in the previous versions
of the package? I think I missed it...).
Oh, and you didn't need to remove the lualib sources completely, since
they are DFSG-compliant. You just needed to patch the sources to use the
system-provided one and the build system to not build the local copy.
Since you would have repackaged the orig tarball anyway, IMHO, is not a
grave issue (but I may be wrong).
Cheers
[0]
http://git.debian.org/?p=pkg-multimedia/deadbeef.git;a=blob;f=debian/README.source;h=ea7bb6b1dd7368aa7c5cd8813cf8996dc4e8b6ae;hb=HEAD
[1] http://wiki.debian.org/SandroTosi/Svn_get-orig-source
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Tue, Mar 15, 2011 at 12:18:46PM +0100, Jonas Smedegaard wrote: > On Tue, Mar 15, 2011 at 07:17:48AM +0100, Reinhard Tartler wrote: >> On Tue, Mar 15, 2011 at 02:29:35 (CET), Jonas Smedegaard wrote: >> >>> On Mon, Mar 14, 2011 at 11:09:20PM +0200, Andriy Beregovenko wrote: So, if you can, please review my package via mentors.debian.net >>> >>> You have joined a team here, and now participating in teamwork - >>> which os different from solo work needing mentoring. :-) >>> >>> So please instead of using that mentors site upload to collab-maint >>> so that we can properly maintain this together. >> >> I guess Jonas means a pkg-multimedia git repository instead of >> collab-maint. >> >> But staging in collab-maint makes migration to pkg-multimedia trivial, >> so this is good advice in any case! > > Sorry - thanks for correcting me: I totally forgot that we use an own > access group (and no, I had no political message hidden in that!). > > I actually disagree that collab-maint makes a good staging area: It > requires different access rights and there is no benefit IMO to cause > noise there first - mess can just as well be poured into pkg-multimedia > directly (or ideally avoided, obviously). I'm already create repo and now preparing source files to initial commit :) If somebody can check it, please do this :) I'll be very grateful :) > Or please elaborate on why you find it good to use both? > > > - Jonas > > -- > * Jonas Smedegaard - idealist & Internet-arkitekt > * Tlf.: +45 40843136 Website: http://dr.jones.dk/ > > [x] quote me freely [ ] ask before reusing [ ] keep private > ___ > pkg-multimedia-maintainers mailing list > pkg-multimedia-maintainers@lists.alioth.debian.org > http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Tue, Mar 15, 2011 at 12:29:51PM +0100, Reinhard Tartler wrote: On Tue, Mar 15, 2011 at 12:18:46 (CET), Jonas Smedegaard wrote: Sorry - thanks for correcting me: I totally forgot that we use an own access group (and no, I had no political message hidden in that!). heh, no problem. I actually disagree that collab-maint makes a good staging area: It requires different access rights and there is no benefit IMO to cause noise there first - mess can just as well be poured into pkg-multimedia directly (or ideally avoided, obviously). Or please elaborate on why you find it good to use both? I was talking about the case that one has access to collab-maint but not for pkg-multimedia yet. Or one is unsure if it fits into pkg-multimedia and solicits for supporters in the team. AFAIUI both reasons apply to the case at hand. Ok, makes sense then. I was unaware that Andriy already had write access to collab-maint. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Tue, Mar 15, 2011 at 12:18:46 (CET), Jonas Smedegaard wrote: > Sorry - thanks for correcting me: I totally forgot that we use an own > access group (and no, I had no political message hidden in that!). heh, no problem. > I actually disagree that collab-maint makes a good staging area: It > requires different access rights and there is no benefit IMO to cause > noise there first - mess can just as well be poured into pkg-multimedia > directly (or ideally avoided, obviously). > > > Or please elaborate on why you find it good to use both? I was talking about the case that one has access to collab-maint but not for pkg-multimedia yet. Or one is unsure if it fits into pkg-multimedia and solicits for supporters in the team. AFAIUI both reasons apply to the case at hand. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Tue, Mar 15, 2011 at 07:17:48AM +0100, Reinhard Tartler wrote: On Tue, Mar 15, 2011 at 02:29:35 (CET), Jonas Smedegaard wrote: On Mon, Mar 14, 2011 at 11:09:20PM +0200, Andriy Beregovenko wrote: So, if you can, please review my package via mentors.debian.net You have joined a team here, and now participating in teamwork - which os different from solo work needing mentoring. :-) So please instead of using that mentors site upload to collab-maint so that we can properly maintain this together. I guess Jonas means a pkg-multimedia git repository instead of collab-maint. But staging in collab-maint makes migration to pkg-multimedia trivial, so this is good advice in any case! Sorry - thanks for correcting me: I totally forgot that we use an own access group (and no, I had no political message hidden in that!). I actually disagree that collab-maint makes a good staging area: It requires different access rights and there is no benefit IMO to cause noise there first - mess can just as well be poured into pkg-multimedia directly (or ideally avoided, obviously). Or please elaborate on why you find it good to use both? - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Tue, Mar 15, 2011 at 02:29:35 (CET), Jonas Smedegaard wrote: > On Mon, Mar 14, 2011 at 11:09:20PM +0200, Andriy Beregovenko wrote: >>So, if you can, please review my package via mentors.debian.net > > You have joined a team here, and now participating in teamwork - which > os different from solo work needing mentoring. :-) > > So please instead of using that mentors site upload to collab-maint so > that we can properly maintain this together. I guess Jonas means a pkg-multimedia git repository instead of collab-maint. But staging in collab-maint makes migration to pkg-multimedia trivial, so this is good advice in any case! -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
Hi, thanks for the explanation:) I'll do it:) Now must read some docs/wiki/faq :) On Tue, Mar 15, 2011 at 02:29:35AM +0100, Jonas Smedegaard wrote: > On Mon, Mar 14, 2011 at 11:09:20PM +0200, Andriy Beregovenko wrote: >> So, if you can, please review my package via mentors.debian.net > > You have joined a team here, and now participating in teamwork - which > os different from solo work needing mentoring. :-) > > So please instead of using that mentors site upload to collab-maint so > that we can properly maintain this together. > > > Regards, > > - Jonas > > -- > * Jonas Smedegaard - idealist & Internet-arkitekt > * Tlf.: +45 40843136 Website: http://dr.jones.dk/ > > [x] quote me freely [ ] ask before reusing [ ] keep private > ___ > pkg-multimedia-maintainers mailing list > pkg-multimedia-maintainers@lists.alioth.debian.org > http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
On Mon, Mar 14, 2011 at 11:09:20PM +0200, Andriy Beregovenko wrote: So, if you can, please review my package via mentors.debian.net You have joined a team here, and now participating in teamwork - which os different from solo work needing mentoring. :-) So please instead of using that mentors site upload to collab-maint so that we can properly maintain this together. Regards, - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
Hi, Let me to summarize: - fixed init script name - fixed licenses: * added body of GPL3, GPL3 with Openssl exclusion, BSD, zlib * specified licenses of files * removed MIT license(due to lua remove) - removed "custom snapshot" of lua, now use system lua(detect via cmake) - copyright moved to DEP5 format - removed not needed htmls and other "garbage"(now only clean sources left) As I can see 2 lintian message left: no-upstream-changelog debian-watch-file-is-missing As I understand this is not a problem thing but is not so important for binary package. So, if you can, please review my package via mentors.debian.net On Mon, Mar 14, 2011 at 06:30:17PM +0100, Alessandro Ghedini wrote: > On Mon, Mar 14, 2011 at 11:32:18AM +0200, Andriy Beregovenko wrote: > > > - debian/init.d should be named debian/[package].init (have a look at the > > > dh_installinit manpage) > > Ok, I fix this now :) > > Good. > > > > - debian/copyright looks wrong. There are many files licensed BSD-3-clause > > > and zlib/libpng. You should include them in the copyright as well. > > > Also, you may want to convert d/copyright to use the DEP5 format [0] > > > (not strictly needed, but very appreciated) > > I do not see any BSD-licensed files > > % licensecheck -R --copyright . | grep BSD > ./common/src/platform/solaris/timegm.cpp: BSD (3 clause) > ./common/src/platform/windows/strncasecmp.cpp: BSD (3 clause) > ./common/src/platform/windows/timegm.cpp: BSD (3 clause) > ./common/src/platform/windows/strptime.cpp: BSD (3 clause) > ./common/src/platform/android/timegm.cpp: BSD (3 clause) > > Look at these files. > > > > - Missing debian/watch file (I'm not sure if this can be fixed) > > Right now watch file is not added cause original project do not have any > > release and have every day commits. So, imo, there is not any practical > > reason to track version. > > Agree. > > > > - If you don't use the Vcs-* fields in debian/control you should remove > > > them (they are currently commented-out) > > Ok. > > > - There are many lintian I, P and even E tags. Please fix them (and use > > > lintian -IE --pedantic to check your package). For example: > > > > > > P: crtmpserver source: source-contains-svn-control-dir ... > > > E: crtmpserver: copyright-should-refer-to-common-license-file-for-gpl > > > .. > > > E: crtmpserver: possible-gpl-code-linked-with-openssl ... > > > I: crtmpserver: copyright-with-old-dh-make-debian-copyright ... > > > I: crtmpserver: spelling-error-in-binary ... > > > [...] > > I'm novice in debian policies and need some help as for > > "possible-gpl-code-linked-with-openssl". > > This means that a GPLed software is linking against openssl (which has a > gpl-incompatible license) and is, therefore, illegal. See [0]. > > >From the d/copyright of the latest version of the package I see: > > GPL-3.0+ with OpenSSL exception > > What does it mean? Where is the "OpenSSL exception" documented? In the > copyright you should point to the proper documentation. > > > Also what version of dh_make i must > > to use ? Currently I use 0.58 (squeeze). > > It's not a matter of which dh-make version you use. It simply says that the > debian/copyright template, which has been created by an older version of > dh-make have to be updated. Now you use DEP5 so there is no problem (note > that newer dh-make version from sid creates a DEP5 template). > > > > Please also consider joining the Debian Multimedia Maintainers team to > > > (co-)maintain this and (when you'll feel comfortable) other > > > multimedia-related packages. > > > In the team you'll find valuable mentors that'll guide and help you in > > > the process of maintaining this and other (multimedia-related) packages. > > > > > > Have a look at the team's wiki [0], if you agree with our policies (e.g. > > > using git to co-maintain packages, using quilt for managing patches, > > > etc...) > > > you are very welcome. :) > > > > > > (if you accept let us know your account name on alioth.debian.org so that > > > I > > > or someone else can add you to the pkg-multimedia project and setup a git > > > repository for your package) > > Yes, I agree and want to join your team :) > > My nick is jet-guest on alioth. > > I added you to the group on alioth.d.o :) > > Also note that I'm not a DD (maybe I should have said this before), > therefore I can't upload your package, but I am sure you'll find someone > in the team to do so (when the package will be in a proper shape, of > course). > > On Mon, Mar 14, 2011 at 01:31:27PM +0200, Andriy Beregovenko wrote: > > I update package and looks like lintian clean(except no-upstream-changelog > > and some info as for libs). > > Not quite true, I still see many spelling-error-in-binary. You should > patch the source files fixing those spelling errors. > > I've also spotted some more issues: > - In debian/control the long description starts with a '.'. It is not > necessary
Re: Looking for sponsor or mentor for package crtmpserver
On Mon, Mar 14, 2011 at 11:32:18AM +0200, Andriy Beregovenko wrote:
> > - debian/init.d should be named debian/[package].init (have a look at the
> > dh_installinit manpage)
> Ok, I fix this now :)
Good.
> > - debian/copyright looks wrong. There are many files licensed BSD-3-clause
> > and zlib/libpng. You should include them in the copyright as well.
> > Also, you may want to convert d/copyright to use the DEP5 format [0]
> > (not strictly needed, but very appreciated)
> I do not see any BSD-licensed files
% licensecheck -R --copyright . | grep BSD
./common/src/platform/solaris/timegm.cpp: BSD (3 clause)
./common/src/platform/windows/strncasecmp.cpp: BSD (3 clause)
./common/src/platform/windows/timegm.cpp: BSD (3 clause)
./common/src/platform/windows/strptime.cpp: BSD (3 clause)
./common/src/platform/android/timegm.cpp: BSD (3 clause)
Look at these files.
> > - Missing debian/watch file (I'm not sure if this can be fixed)
> Right now watch file is not added cause original project do not have any
> release and have every day commits. So, imo, there is not any practical
> reason to track version.
Agree.
> > - If you don't use the Vcs-* fields in debian/control you should remove
> > them (they are currently commented-out)
> Ok.
> > - There are many lintian I, P and even E tags. Please fix them (and use
> > lintian -IE --pedantic to check your package). For example:
> >
> > P: crtmpserver source: source-contains-svn-control-dir ...
> > E: crtmpserver: copyright-should-refer-to-common-license-file-for-gpl ..
> > E: crtmpserver: possible-gpl-code-linked-with-openssl ...
> > I: crtmpserver: copyright-with-old-dh-make-debian-copyright ...
> > I: crtmpserver: spelling-error-in-binary ...
> > [...]
> I'm novice in debian policies and need some help as for
> "possible-gpl-code-linked-with-openssl".
This means that a GPLed software is linking against openssl (which has a
gpl-incompatible license) and is, therefore, illegal. See [0].
>From the d/copyright of the latest version of the package I see:
GPL-3.0+ with OpenSSL exception
What does it mean? Where is the "OpenSSL exception" documented? In the
copyright you should point to the proper documentation.
> Also what version of dh_make i must
> to use ? Currently I use 0.58 (squeeze).
It's not a matter of which dh-make version you use. It simply says that the
debian/copyright template, which has been created by an older version of
dh-make have to be updated. Now you use DEP5 so there is no problem (note
that newer dh-make version from sid creates a DEP5 template).
> > Please also consider joining the Debian Multimedia Maintainers team to
> > (co-)maintain this and (when you'll feel comfortable) other
> > multimedia-related packages.
> > In the team you'll find valuable mentors that'll guide and help you in
> > the process of maintaining this and other (multimedia-related) packages.
> >
> > Have a look at the team's wiki [0], if you agree with our policies (e.g.
> > using git to co-maintain packages, using quilt for managing patches, etc...)
> > you are very welcome. :)
> >
> > (if you accept let us know your account name on alioth.debian.org so that I
> > or someone else can add you to the pkg-multimedia project and setup a git
> > repository for your package)
> Yes, I agree and want to join your team :)
> My nick is jet-guest on alioth.
I added you to the group on alioth.d.o :)
Also note that I'm not a DD (maybe I should have said this before),
therefore I can't upload your package, but I am sure you'll find someone
in the team to do so (when the package will be in a proper shape, of
course).
On Mon, Mar 14, 2011 at 01:31:27PM +0200, Andriy Beregovenko wrote:
> I update package and looks like lintian clean(except no-upstream-changelog
> and some info as for libs).
Not quite true, I still see many spelling-error-in-binary. You should
patch the source files fixing those spelling errors.
I've also spotted some more issues:
- In debian/control the long description starts with a '.'. It is not
necessary (you can remove it).
- The package includes and compiles the whole liblua sources. It should
rely on libraries provided by the system rather than build and link
against local copies. You should patch the building system if possible, to
use the Debian provided liblua (from the liblua5.1-0-dev and liblua5.1-0
packages).
- Under applications/applestreamingclient/flex/html-template there is a
playerProductInstall.swf binary file, which is not in the "preferred form
of modification". Proper sources should be provided, or the file should
be removed by the orig.tar archive (there may be other files in the same
condition, please have a closer look and fix/remove all the problematic
files).
I've also noticed that the empty debian/docs file is still there (please
remove it).
Cheers
[0] http://ftp-master.debian.org/REJECT-FAQ.html
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;;eg;say~~reverse'
_
Re: Looking for sponsor or mentor for package crtmpserver
Hi,
I update package and looks like lintian clean(except no-upstream-changelog
and some info as for libs).
Already uploaded to mentors.debian.net
On Mon, Mar 14, 2011 at 10:16:01AM +0100, Alessandro Ghedini wrote:
> Hello Andriy,
>
> On Mon, Mar 14, 2011 at 02:01:45AM +0200, Andriy Beregovenko wrote:
> > I'm looking for sponsor or mentor to my package crtmpserver.
> > Here is ITP:
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=617641
> > and package on mentors.debian.net:
> > http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=crtmpserver
> > In two words:
> > crmpserver is high performance streaming server. It support several
> > protocols family like: RTMP, RTSP/RTCP/RTP, MPEG-TS, plain flv publishing.
> > Also it is generic network platform, and creating custom protocols with it
> > is
> > really easy. In future plans are implement next protocols: gearman(already
> > exist but not too clean, so not included yet), memcached, possible redis.
> > Also there is some implementation of RTMFP protocol, but still not clean.
> > This allow use crtmpserver as universal network media streaming platform.
> > Licensed under GNU GPLv3.
>
> Here is a quick review of your package :)
>
> - debian/init.d should be named debian/[package].init (have a look at the
> dh_installinit manpage)
> - debian/copyright looks wrong. There are many files licensed BSD-3-clause
> and zlib/libpng. You should include them in the copyright as well.
> Also, you may want to convert d/copyright to use the DEP5 format [0]
> (not strictly needed, but very appreciated)
> - Missing debian/watch file (I'm not sure if this can be fixed)
> - If you don't use the Vcs-* fields in debian/control you should remove
> them (they are currently commented-out)
> - There are many lintian I, P and even E tags. Please fix them (and use
> lintian -IE --pedantic to check your package). For example:
>
> P: crtmpserver source: source-contains-svn-control-dir ...
> E: crtmpserver: copyright-should-refer-to-common-license-file-for-gpl ..
> E: crtmpserver: possible-gpl-code-linked-with-openssl ...
> I: crtmpserver: copyright-with-old-dh-make-debian-copyright ...
> I: crtmpserver: spelling-error-in-binary ...
> [...]
>
> Please also consider joining the Debian Multimedia Maintainers team to
> (co-)maintain this and (when you'll feel comfortable) other
> multimedia-related packages.
> In the team you'll find valuable mentors that'll guide and help you in
> the process of maintaining this and other (multimedia-related) packages.
>
> Have a look at the team's wiki [0], if you agree with our policies (e.g.
> using git to co-maintain packages, using quilt for managing patches, etc...)
> you are very welcome. :)
>
> (if you accept let us know your account name on alioth.debian.org so that I
> or someone else can add you to the pkg-multimedia project and setup a git
> repository for your package)
>
> Cheers
>
> [0] http://wiki.debian.org/DebianMultimedia/DevelopPackaging
>
> --
> perl -E'$_=q;$/= @{[@_]};and s;\S+;;eg;say~~reverse'
>
> ___
> pkg-multimedia-maintainers mailing list
> pkg-multimedia-maintainers@lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
Hi,
On Mon, Mar 14, 2011 at 10:16:01AM +0100, Alessandro Ghedini wrote:
> Hello Andriy,
>
> On Mon, Mar 14, 2011 at 02:01:45AM +0200, Andriy Beregovenko wrote:
> > I'm looking for sponsor or mentor to my package crtmpserver.
> > Here is ITP:
> > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=617641
> > and package on mentors.debian.net:
> > http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=crtmpserver
> > In two words:
> > crmpserver is high performance streaming server. It support several
> > protocols family like: RTMP, RTSP/RTCP/RTP, MPEG-TS, plain flv publishing.
> > Also it is generic network platform, and creating custom protocols with it
> > is
> > really easy. In future plans are implement next protocols: gearman(already
> > exist but not too clean, so not included yet), memcached, possible redis.
> > Also there is some implementation of RTMFP protocol, but still not clean.
> > This allow use crtmpserver as universal network media streaming platform.
> > Licensed under GNU GPLv3.
>
> Here is a quick review of your package :)
>
> - debian/init.d should be named debian/[package].init (have a look at the
> dh_installinit manpage)
Ok, I fix this now :)
> - debian/copyright looks wrong. There are many files licensed BSD-3-clause
> and zlib/libpng. You should include them in the copyright as well.
> Also, you may want to convert d/copyright to use the DEP5 format [0]
> (not strictly needed, but very appreciated)
I do not see any BSD-licensed files
> - Missing debian/watch file (I'm not sure if this can be fixed)
Right now watch file is not added cause original project do not have any
release and have every day commits. So, imo, there is not any practical
reason to track version.
> - If you don't use the Vcs-* fields in debian/control you should remove
> them (they are currently commented-out)
Ok.
> - There are many lintian I, P and even E tags. Please fix them (and use
> lintian -IE --pedantic to check your package). For example:
>
> P: crtmpserver source: source-contains-svn-control-dir ...
> E: crtmpserver: copyright-should-refer-to-common-license-file-for-gpl ..
> E: crtmpserver: possible-gpl-code-linked-with-openssl ...
> I: crtmpserver: copyright-with-old-dh-make-debian-copyright ...
> I: crtmpserver: spelling-error-in-binary ...
> [...]
I'm novice in debian policies and need some help as for
"possible-gpl-code-linked-with-openssl". Also what version of dh_make i must
to use ? Currently I use 0.58 (squeeze).
> Please also consider joining the Debian Multimedia Maintainers team to
> (co-)maintain this and (when you'll feel comfortable) other
> multimedia-related packages.
> In the team you'll find valuable mentors that'll guide and help you in
> the process of maintaining this and other (multimedia-related) packages.
>
> Have a look at the team's wiki [0], if you agree with our policies (e.g.
> using git to co-maintain packages, using quilt for managing patches, etc...)
> you are very welcome. :)
>
> (if you accept let us know your account name on alioth.debian.org so that I
> or someone else can add you to the pkg-multimedia project and setup a git
> repository for your package)
Yes, I agree and want to join your team :)
My nick is jet-guest on alioth.
>
> Cheers
>
> [0] http://wiki.debian.org/DebianMultimedia/DevelopPackaging
>
> --
> perl -E'$_=q;$/= @{[@_]};and s;\S+;;eg;say~~reverse'
>
> ___
> pkg-multimedia-maintainers mailing list
> pkg-multimedia-maintainers@lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
Re: Looking for sponsor or mentor for package crtmpserver
Hello Andriy,
On Mon, Mar 14, 2011 at 02:01:45AM +0200, Andriy Beregovenko wrote:
> I'm looking for sponsor or mentor to my package crtmpserver.
> Here is ITP:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=617641
> and package on mentors.debian.net:
> http://mentors.debian.net/cgi-bin/sponsor-pkglist?action=details;package=crtmpserver
> In two words:
> crmpserver is high performance streaming server. It support several
> protocols family like: RTMP, RTSP/RTCP/RTP, MPEG-TS, plain flv publishing.
> Also it is generic network platform, and creating custom protocols with it
> is
> really easy. In future plans are implement next protocols: gearman(already
> exist but not too clean, so not included yet), memcached, possible redis.
> Also there is some implementation of RTMFP protocol, but still not clean.
> This allow use crtmpserver as universal network media streaming platform.
> Licensed under GNU GPLv3.
Here is a quick review of your package :)
- debian/init.d should be named debian/[package].init (have a look at the
dh_installinit manpage)
- debian/copyright looks wrong. There are many files licensed BSD-3-clause
and zlib/libpng. You should include them in the copyright as well.
Also, you may want to convert d/copyright to use the DEP5 format [0]
(not strictly needed, but very appreciated)
- Missing debian/watch file (I'm not sure if this can be fixed)
- If you don't use the Vcs-* fields in debian/control you should remove
them (they are currently commented-out)
- There are many lintian I, P and even E tags. Please fix them (and use
lintian -IE --pedantic to check your package). For example:
P: crtmpserver source: source-contains-svn-control-dir ...
E: crtmpserver: copyright-should-refer-to-common-license-file-for-gpl ..
E: crtmpserver: possible-gpl-code-linked-with-openssl ...
I: crtmpserver: copyright-with-old-dh-make-debian-copyright ...
I: crtmpserver: spelling-error-in-binary ...
[...]
Please also consider joining the Debian Multimedia Maintainers team to
(co-)maintain this and (when you'll feel comfortable) other
multimedia-related packages.
In the team you'll find valuable mentors that'll guide and help you in
the process of maintaining this and other (multimedia-related) packages.
Have a look at the team's wiki [0], if you agree with our policies (e.g.
using git to co-maintain packages, using quilt for managing patches, etc...)
you are very welcome. :)
(if you accept let us know your account name on alioth.debian.org so that I
or someone else can add you to the pkg-multimedia project and setup a git
repository for your package)
Cheers
[0] http://wiki.debian.org/DebianMultimedia/DevelopPackaging
--
perl -E'$_=q;$/= @{[@_]};and s;\S+;;eg;say~~reverse'
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
