[DRE-maint] Some comments on the redmine package
Hi, Here are some comments and thoughts about the Richard Hurt's redmine package Richard Hurt. My mail server is broken and I am unable to answer to one of his mail, please excuse me for the disturbance. First, I have to say that I'm very glad and grateful to see that rails apps are being packaged in Debian. It seems Passenger will also be packaged in Debian soon, and it will make deployments and maintenance of rails app really easy. However, since this is the first rails app that will be package in Debian, I think that others will take it as an example, and I fear that if the package has a few things to fix, these few things will have to be fixed in more that one package. AFAIK redmine won't be in lenny, so I'd rather see the first rails package to be as good as possible. Anyway, here is what I've seen so far: * Use debconf in your postinst, to ask the user if * he wants to configure the database.yml file * he wants to create the db * he wants to load default data * he wants to configure a webserver (apache2 fcgid / apache2 mod_rails / …) * The sample apache configuration you provide has AFAIK the following problems: * It will not work out of the box. If you do not wish to use debconf to ask the user which way he wants, you should add in the apache2.conf a working configuration (e.g. with mod_fcgid), and in comments other working configurations (e.g. with mod_rails). * Why put a VirtualHost with a DocumentRoot? This is confusing, the Alias alone would work better IHMO. * The commented VirtualHost DocumentRoot lacks “/public” at the end. * The README.Debian files contains requirements for running redmine. They are IMHO useless, because it is the job of the package to ensure the requirements are fullfilled (except for optionnal stuff like db and webserver configuration). Thus, I think removing the first two lines and modifying debian/control to add dependency on ruby1.8 and rails (= 2.1), rails (= 2.2) is better. * The debian/redmine.lintian-overrides overrides things that should not be overriden, and hides bugs. * The “script-not-executable” warnings: having a shebang and not being executable is contradictory. Either the script can be used as a binary, and should be executable, or it is not and then the shebang useless. * The ”package-contains-empty-directory”: your comment says “These directories hold temporary data”. However, /usr/share is meant to be read-only, and shipping empty directories there is a bug. Either the program write something in the directory, and this is a bug, or the program doesn't write anything and the directory is useless. * I think the “public” directory should go in /usr/share, because AFAIK it is not meant to be changed, neither at runtime nor by the user. * Plugins should go in separate Debian packages. I am against a package in Debian which ships totally different and independant software. * In the “debian/redmine.logrotate” file, you create the log files in mode 0666. I think it should be 0644, or maybe 0640. Also, according to man page, the create option has no effect when copytruncate is used, so maybe you should just remove the create option. * You are using the svn version of redmine to build the package. I am not sure, but I think the 0.7.4 release will not be a snapshot of the svn, but rather backporting bugfixes without introducing new features. Thus, if you ship the svn now, and then the 0.7.4 when it is released, there might be regression features. It might be better to use 0.7.3 and backport patches for rails 2.1. * In the “debian/copyright” file, remove references to “vendor/rails”, since they are not shipped in the Debian package. * You mix in the debian/patches/dispatch.patch two different things: using /usr/bin/env instead of calling ruby directly, and fixing the path to RAILS_ROOT. I think it should be splitted in two, with a short comment of what the patch does and why. * The patch also contains whitespace changes (adding a newline at the end of files). * I think symlinking directories in /usr/share is not, as a user's point of view, the best thing to do. I prefer to have on my system a clean directory structure, rather that symlinks everywhere to fix software not respecting the FHS. This seems to me more like a workaround instead of a real fix, and I think we should try to see how much work it is to patch things to allow configurating the different paths. Some work would need to be done directly in Rails, but if a clean patch is made and applied upstream, this would fix it for other packages and distributions. I'm willing to help fixing these issues, however, I'm in the middle of fixing my computer for the moment and I
Re: [DRE-maint] Lenny release team summary (important! read this!)
Hi!
Another update. We should finish our release tasks this weekend
by a big mail to debian-release.
On Sat, Aug 16, 2008 at 02:36:51PM +0200, Paul van Tilburg wrote:
On Sun, Aug 10, 2008 at 05:19:07PM +0200, Paul van Tilburg wrote:
The summary (information gathered from QA report, PTS, BTS):
| Newer upstream available (7)
| libdb4.2-ruby 0.6.2-3 0.6.5
| libdb4.3-ruby 0.6.2-2 0.6.5
| libdb4.4-ruby 0.6.2-1 0.6.5
Michael Schutte is working on it. The libdb-ruby is already on 0.6.5 in
sid, not in testing just yet. These source pakages should be removed and
libdb-ruby's libdbX.Y-ruby package should provide for a transition.
Status of this work? Anyone?
Done! Also the breaking reverse depends (gonzui) have been taken
care of.
| NEW and incoming (1)
| libcairo-ruby S #487204 pending
This bug, severity serious, has been fixed in 1.6.3. However, 1.5.1
is in Lenny. I worked for months on the new upstream. I'd really like
to have 1.6.3 in Lenny. If we cannot get the exeception, then we have
a 1.5.1+bugfix in the branches.
The 1.6.3 upstream is in Sid now. A release block exception should
be requested.
Ok, we decided to go with 1.5.1-1+lenny1 which contains a specific
fix for this RC bug and no more. It's in testing-proposed-updates.
| Ready for upload (1)
| libgd-rubyI #472438
svn-released:pending
All fixed and ready. Except it segfaults on amd64! I would appreciate some
help here, because we need to have this version in Lenny IMO.
Still need help here.
Still need help!
| Work in progress (2)
| libgems-ruby#403407 wontfix
| #485739
| #448639
| #405789
| #466189
All normal or wishlist bugs. Though, a few seem important to me, but ok.
Two questions.
1. RubyGems 1.2.0 is not in Lenny, I think it should be? Or not?
If so, we need an exception.
2. The libgems-ruby package doesn't seem to contain a 'rubygems' dummy
package to depend on 'rubygems1.8'. Is this not a RC bug?
More bugreports were filed, mostly related to (2). This needs to
be addressed. I am sure it is a RC bug now (grave - #495320).
These bugs do not occur in the testing version of libgems-ruby (Lenny
also does not contain the reworked rubygems packages, just 1.1.1-1.
There seems to be an agreement to keep it as it is, because new upstream
(1.2.0, containing the reworked pkg structure) is too big a difference
in upstream any.
The rev. depends are currently fixed in Sid, but not broken in Lenny either
before it was before the rework.
| liblocale-ruby I? #470798
This bug should be severity important. Antonio and I agree that the
easiest solution would be to have it removed from Lenny and really solve
it well for Lenny +1. Note that liblocale-ruby{,1.8} have no
reverse depends.
The release team should be asked to remove it for Lenny.
Still needs to happen, yes.
| libxtemplate-ruby1.8 I #472430
Gotta work on this and straighten it out. Not much work though.
Handled by Gunnar and solved in Sid. A release block exception
should be requested.
Indeed.
| ruby-gnome2 I #493063
A recent important bug, haven't investigated it. May be inreproducible.
More grave/important bugs were filed! One of them is another
objects creation during garbage collection phase problem.
Sjoerd suggested that he has a few patches for this. These should be
applied and tested. Afterwards a release exception block should be
requested.
The RC bug has been fixed in 0.17.0~rc1-4, which is in Sid.
What about #493063?
Paul
--
PhD Student @ Eindhoven | email: [EMAIL PROTECTED]
University of Technology, The Netherlands | JID: [EMAIL PROTECTED]
Using the Power of Debian GNU/Linux | GnuPG key ID: 0x50064181
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-ruby-extras-maintainers
[DRE-maint] Bug#497191: libgd-ruby1.8: interlace option segfaults on amd64
Package: libgd-ruby1.8
Version: 0.7.4.1-6
Severity: normal
Tags: patch
When using interlace option, ruby segfaults:
--8-8---8--
[EMAIL PROTECTED]:~$ irb -rGD
image = GD::Image.new(100,100)
= #GD::Image:0x2b85b01eb9a8
image.interlace = true
(irb):2: [BUG] Segmentation fault
ruby 1.8.7 (2008-06-20 patchlevel 22) [x86_64-linux]
Abortado
--8-8---8--
This problem was already reported and fixed in Gentoo, cf.
http://bugs.gentoo.org/166527
According to the bug report the problem may also affect other 64-bit
architectures.
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Kernel: Linux 2.6.22-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages libgd-ruby1.8 depends on:
ii libc6 2.7-13GNU C Library: Shared libraries
ii libfreetype6 2.3.7-2 FreeType 2 font engine, shared lib
ii libgd2-xpm 2.0.36~rc1~dfsg-3 GD Graphics Library version 2
ii libjpeg62 6b-14 The Independent JPEG Group's JPEG
ii libpng12-0 1.2.27-1 PNG library - runtime
ii libruby1.8 1.8.7.22-3Libraries necessary to run Ruby 1.
ii libx11-6 2:1.1.4-2 X11 client-side library
ii libxpm41:3.5.7-1 X11 pixmap library
ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime
libgd-ruby1.8 recommends no packages.
libgd-ruby1.8 suggests no packages.
-- no debconf information
--- /home/graaff/playground/ruby-GD-0.7.4/GD.c 2001-05-30 16:14:17.0
+0200
+++ GD.c2007-04-19 08:53:47.0 +0200
@@ -1374,6 +1374,7 @@
static VALUE
img_set_interlace(img, val)
+VALUE img, val;
{
gdImagePtr im;
___
Pkg-ruby-extras-maintainers mailing list
Pkg-ruby-extras-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/pkg-ruby-extras-maintainers
[DRE-maint] Processed: found 497191 in 0.7.4.1-5
Processing commands for [EMAIL PROTECTED]: # Automatically generated email from bts, devscripts version 2.10.35 found 497191 0.7.4.1-5 Bug#497191: libgd-ruby1.8: interlace option segfaults on amd64 Bug marked as found in version 0.7.4.1-5. End of message, stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) ___ Pkg-ruby-extras-maintainers mailing list Pkg-ruby-extras-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-ruby-extras-maintainers
