Bug#791944: My workaround

[Theppitak Karoonboonyanan]

On Sun, Oct 16, 2016 at 12:56 AM, Guilhem Moulin  wrote:
> On Sat, 15 Oct 2016 at 08:13:27 +0700, Theppitak Karoonboonyanan wrote:
>> Reassigning the bug to udev to hear its maintainer's opinion.
>
> I think this is a initscripts bug, not a udev bug.  Both the
> ‘cryptdisks-early’ and ‘cryptdisks’ LSB init scripts have had a
> “Should-Stop: udev” header.  Shouldn't this be enough to have udevd
> still running during cryptdisks shutdown?  If that's the case then the
> culprit is sendsigs as it violates shutdown dependencies.

Given its function to "killall5", how can sendsigs discriminate
between processes to be killed and those to be preserved?
How can it know which daemons were started by a named service
(udev in this case) so it can skip sending SIGTERM to them?

I think what sendsigs has provided for this purpose is the
/run/sendsigs.omit.d/ directory, as documented in
/usr/share/doc/initscripts/README.Debian.

And to add a process to the omission list, a most appropriate
place to do so is udev's init script itself, where the daemon was
started. That's why I reassign the bug to it.

Regards,
-- 
Theppitak Karoonboonyanan
http://linux.thai.net/~thep/


___
Pkg-systemd-maintainers mailing list
Pkg-systemd-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-systemd-maintainers

Bug#791944: My workaround

[Guilhem Moulin]

On Sat, 15 Oct 2016 at 08:13:27 +0700, Theppitak Karoonboonyanan wrote:
> Reassigning the bug to udev to hear its maintainer's opinion.

I think this is a initscripts bug, not a udev bug.  Both the
‘cryptdisks-early’ and ‘cryptdisks’ LSB init scripts have had a
“Should-Stop: udev” header.  Shouldn't this be enough to have udevd
still running during cryptdisks shutdown?  If that's the case then the
culprit is sendsigs as it violates shutdown dependencies.

-- 
Guilhem.

PS. pkg-cryptsetup-de...@lists.alioth.debian.org added to X-Debbugs-CC.


signature.asc
Description: PGP signature
___
Pkg-systemd-maintainers mailing list
Pkg-systemd-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-systemd-maintainers

Bug#791944: My workaround

[Theppitak Karoonboonyanan]

On Sat, Oct 15, 2016 at 8:40 AM, Michael Biebl  wrote:

> Can you elaborate on why cryptsetup needs a running udevd?

Please see Guilhem Moulin's messages #72, #77, #86:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=791944#72
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=791944#77
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=791944#86

In short, sendsigs appears to kill systemd-udevd before
cryptdisks[-early] shuts down, and the system hangs at
'cryptsetup luksClose "$dst"'. Keeping the daemon running does
solve the problem.

That's all I know for now, with the black box tests.

Yeah, your question is good, in case we can investigate for a deeper
solution, which my knowledge is too shallow in this area to provide.

So, I Cc: Guilhem Moulin and the cryptsetup team for their input.

>> Reassigning the bug to udev to hear its maintainer's opinion.
>
> If you want input from the maintainer, you should CC them when reassigning.

OK. I assumed that the bug control would automatically do so.
I guess later messages are now sent to them.

> That said, with your patch, udevd is no longer stopped on shutdown.
> How do you ensure that the file system(s) can be cleanly unmounted?

Under /etc/rc[0,6].d/, K08umountfs and K11umountroot should
already do the file system unmounts. If udevd is still needed to be
stopped for other cleanups, probably we should add K11udev
to be run after K10cryptdisks-early?

Regards,
-- 
Theppitak Karoonboonyanan
http://linux.thai.net/~thep/


___
Pkg-systemd-maintainers mailing list
Pkg-systemd-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-systemd-maintainers

Bug#791944: My workaround

[Michael Biebl]

Control: tags -1 = moreinfo

On Sat, 15 Oct 2016 08:13:27 +0700 Theppitak Karoonboonyanan
 wrote:
> Control: reassign -1 udev 231-9
> Control: tag -1 + patch
> 
> On Mon, Oct 10, 2016 at 10:03 AM, Theppitak Karoonboonyanan
>  wrote:
> 
> > With this patch to /etc/init.d/udev, my machine (using sysvinit)
> > shuts down successfully again.
> >
> > Is the fix reasonable for udev?

Can you elaborate on why cryptsetup needs a running udevd?

> Reassigning the bug to udev to hear its maintainer's opinion.

If you want input from the maintainer, you should CC them when reassigning.

That said, with your patch, udevd is no longer stopped on shutdown.
How do you ensure that the file system(s) can be cleanly unmounted?


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature
___
Pkg-systemd-maintainers mailing list
Pkg-systemd-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-systemd-maintainers