Re: [Pki-devel] [PATCH] Fixed pylint errors (re-sent)

2017-06-01 Thread Christian Heimes
On 2017-06-01 01:47, Endi Sukma Dewata wrote: > Just one thing, I was under the impression that we're supposed to remove > PKIServerUpgradeScriptlet.__init__() altogether. > > Christian, could you take a look a this? Yes, you can safely drop PKIServerUpgradeScriptlet.__init__(). The method

Re: [Pki-devel] [PATCH] Fixed pylint errors (re-sent)

2017-05-31 Thread Endi Sukma Dewata
On 5/31/2017 6:30 PM, Matthew Harmsen wrote: The attached patch was altered to change "args" ==> "argv" rather than "argv" ==> "args" since it was discovered that a number of the routines utilized "args" as a local variable that would have to be changed since if the "argv" input parameter were

[Pki-devel] [PATCH] Fixed pylint errors (re-sent)

2017-05-31 Thread Matthew Harmsen
The attached patch was altered to change "args" ==> "argv" rather than "argv" ==> "args" since it was discovered that a number of the routines utilized "args" as a local variable that would have to be changed since if the "argv" input parameter were changed to "args". Consequently, this patch