Re: Review Request: Move activation of Present Windows effect to WindowsEffects

2009-10-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1852/#review2653 --- Ship it! this is a thing that was on my todo list, +20 grom me :D -

Re: Review Request: Move activation of Present Windows effect to WindowsEffects

2009-10-15 Thread Artur de Souza (MoRpHeUz)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1852/#review2654 --- Ship it! Besides from the comment below it seems great. We really

Re: Review Request: Kineticscrolling: a zero api approach

2009-10-15 Thread Adenilson Cavalcanti
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1840/#review2660 --- I tested it today with the following results: - uBlog X

Re: Review Request: Kineticscrolling: a zero api approach

2009-10-15 Thread Adenilson Cavalcanti
On 2009-10-15 16:32:57, Adenilson Cavalcanti wrote: I tested it today with the following results: - uBlog X plasma-desktop = works fine - webview X plasma-desktop = kinetic scrolling is broken - plasma-netbook = works fine - uBlog X plasma-netbook = broken, is non longer possible to

Re: Forecast-only weather ion

2009-10-15 Thread Shawn Starr
On October 9, 2009 07:11:38 pm Thilo-Alexander Ginkel wrote: On Thursday 01 October 2009 01:48:29 Shawn Starr wrote: Now that my Weather Ion is mostly feature-complete, how does the further process look like? Should I submit a review request? Should it first go to the playground? (Feel

Re: playground/base/nepomuk-kde/usercontext/plasmoid

2009-10-15 Thread Aaron J. Seigo
On October 15, 2009, Sebastian Trueg wrote: SVN commit 1035530 by trueg: updated label and comment to more readable values M +7 -11 plasma-applet-nepomukcontextchooser.desktop [TRAILING SPACE] --- trunk/playground/base/nepomuk-kde/usercontext/plasmoid/plasma-applet-nepom

Re: Review Request: Plasma + Qt Kinetic GSoC Project - Attempt 2

2009-10-15 Thread Adenilson Cavalcanti
On 2009-10-14 12:31:38, Adenilson Cavalcanti wrote: /trunk/KDE/kdelibs/plasma/animations/animation.h, line 83 http://reviewboard.kde.org/r/1512/diff/1/?file=10972#file10972line83 It should return a QAbstractAnimation so it covers the case that the animation is complex and it

Re: plasma+nepomuk activities, take N

2009-10-15 Thread Sebastian Kügler
On Tuesday 13 October 2009 10:16:32 Ivan Čukić wrote: I've seen the thread about the activities overview. Since there are bound to be some changes in the concepts behind activities, virtual desktops etc. I'll postpone the plasma+nepomuk integration in order to introduce it alongside the new

Re: plasma+nepomuk activities, take N

2009-10-15 Thread Ivan Čukić
I'd still like to see a minimal implementation of this to already get used to having this kind of stuff. So please, don't postpone. Plasma is not the only potential user of this ... Heh, Sebas, you haven't read the rest of the mails :) I was talking about the plasma-ui integration (the

Re: Review Request: Plasma + Qt Kinetic GSoC Project - Attempt 2

2009-10-15 Thread Adenilson Cavalcanti
On 2009-10-14 12:31:38, Adenilson Cavalcanti wrote: /trunk/KDE/kdelibs/plasma/animations/animation.h, line 83 http://reviewboard.kde.org/r/1512/diff/1/?file=10972#file10972line83 It should return a QAbstractAnimation so it covers the case that the animation is complex and it

Re: Moved kill runner to kdereview

2009-10-15 Thread Aaron J. Seigo
On October 15, 2009, Jan Gerrit Marker wrote: Hello you, I moved my runner called Kill to kdereview in order to get it into the KDE libs. It's in the folder plasma/runners/kill. I added the directory of i've made a few changes to it, but i think it's ready to go now. i'd like to see this in