Re: Review Request: plasmapkg & wallpaper

2009-11-02 Thread Petri Damstén
On Friday 30 October 2009 10:07:28 Petri Damstén wrote: > (Updated 2009-10-30 08:07:28.008673) > > > Review request for Plasma. > > > Changes > --- > > * --type wallpaper works for both wallpaper plugin and wallpaper image > packages. * install / upgrade reverted to original Is there som

Re: setData & QVariant

2009-11-02 Thread Petri Damstén
On Monday 02 November 2009 22:38:53 Aaron J. Seigo wrote: > On October 31, 2009, Petri Damstén wrote: > > On Friday 30 October 2009 19:53:29 Aaron J. Seigo wrote: > > > On October 30, 2009, Petri Damstén wrote: > > > > I'm trying to fix BUG 212342. It seems like if variable is put to > > > > QVaria

RFC: Add ISO Currency Code support to KLocale

2009-11-02 Thread John Layt
Hi, I am proposing to change KLocale to support the ISO 4217 Currency Code standard (http://en.wikipedia.org/wiki/ISO_4217). The existing currency support is based on a free-text currency symbol field. This leaves applications such as KSpread, KMyMoney, Skrooge, Kraft, KEuroCalc, and various P

Re: Review Request: wetter.com Weather Ion

2009-11-02 Thread Will Stephenson
> On 2009-11-01 08:46:19, Will Stephenson wrote: > > I don't see a reason for the first leak you highlight in your code. You > > should create the url using QLatin1String as this saves QString having to > > guess the encoding -see > > http://labs.trolltech.com/blogs/2008/04/28/string-theory/

Re: Review Request: Make the microblog applet easier on the eyes

2009-11-02 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2048/#review2896 --- screenshots? :) - Aaron On 2009-11-02 20:13:27, Trever Fischer wrot

Re: Review Request: wetter.com Weather Ion

2009-11-02 Thread Thilo-Alexander Ginkel
On Monday 02 November 2009 21:46:12 Aaron Seigo wrote: > > I have removed the QObject inheritance in my current working copy. > > the Ions are QObjects primarily for memory management; since the Ion > plugins tend to have signal/slot connections they'd end up subclassing > QObject and so it just

Re: Firefox Bookmark runner

2009-11-02 Thread Aaron J. Seigo
On November 2, 2009, Eduardo Robles Elvira wrote: > http://github.com/edulix/gsoc/blob/master/kdebase-bookmarks.patch, > take a look only at the workspace/plasma part of it). In case this new > bookmarks system ships in, I don't know if mixing the firefox and > konqueror bookmarks in nepomuk runner

Re: Review Request: wetter.com Weather Ion

2009-11-02 Thread Aaron Seigo
> On 2009-11-01 08:46:19, Will Stephenson wrote: > > I don't see a reason for the first leak you highlight in your code. You > > should create the url using QLatin1String as this saves QString having to > > guess the encoding -see > > http://labs.trolltech.com/blogs/2008/04/28/string-theory/

Review Request: Make the microblog applet easier on the eyes

2009-11-02 Thread Trever Fischer
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2048/ --- Review request for Plasma. Summary --- This patch makes the microblog apple

Re: Review Request: wetter.com Weather Ion

2009-11-02 Thread Armin Berres
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2026/#review2878 --- First: Awesome :) Finally I can abandon the website. I did not do a p

Re: setData & QVariant

2009-11-02 Thread Aaron J. Seigo
On October 31, 2009, Petri Damstén wrote: > On Friday 30 October 2009 19:53:29 Aaron J. Seigo wrote: > > On October 30, 2009, Petri Damstén wrote: > > > I'm trying to fix BUG 212342. It seems like if variable is put to > > > QVariant and then as a parameter to setData it does not work. If same > >

Re: wikipedia runner crasher, was: Re: runners: same .so, different configs?

2009-11-02 Thread Aaron J. Seigo
On October 31, 2009, Sebastian Kügler wrote: > I've tried different variants, a QMutex to lock access to the shared class > for example, but nothing would really help. Can anyone tell me how I can > fix this in the right way? a few things jump out at me: * m_mediaWiki is being shared by all thr

Re: runners: same .so, different configs?

2009-11-02 Thread Aaron J. Seigo
On October 31, 2009, Sebastian Kügler wrote: > On Tuesday 27 October 2009 20:53:31 Sebastian Kügler wrote: > > On Tuesday 27 October 2009 18:36:35 Aaron J. Seigo wrote: > > > On October 27, 2009, Marco Martin wrote: > > > > simply having 2 desktop files with different plugin names that load > > > >

Re: Review Request: Add "reply" and "retweet" buttons in each tweet/dent of the microblog applet to quickly reply someone or retweet some message.

2009-11-02 Thread Nicolas Réau
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2032/ --- (Updated 2009-11-02 19:11:15.641060) Review request for Plasma. Changes --

Re: Review Request: Embed related kcms in the device notifier configuration dialog

2009-11-02 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1979/#review2894 --- Ship it! "what is the situation with the device-automounter? I could

Re: Review Request: Add "reply" and "retweet" buttons in each tweet/dent of the microblog applet to quickly reply someone or retweet some message.

2009-11-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2032/#review2893 --- Ship it! apart some minor issues i think it's fine /trunk/KDE/kdepl

Re: Activities service in KDEreview

2009-11-02 Thread Ivan Čukić
Updated version in kdereview - it uses nepomuk in a much better way. Since the ontology is not yet written, it uses a dummy link http://www.kde.org/ontologies/activities#Activity which can later be changed or made to redirect to a real rdf. If anyone (Sebastian) has a better idea for the url, ple

Re: How to get Akonadi notes onto Plasma?

2009-11-02 Thread Marco Martin
On Monday 02 November 2009, Stephen Kelly wrote: > Marco Martin wrote: > > On Monday 02 November 2009, Stephen Kelly wrote: > >> Aaron J. Seigo wrote: > >> > On October 30, 2009, Stephen Kelly wrote: > >> >> would prefer to only show the actual notes in the stack on click so > >> >> they could be d

Re: Firefox Bookmark runner

2009-11-02 Thread Sebastian Kügler
On Monday 02 November 2009 13:53:35 Sebastian Kügler wrote: > On Monday 02 November 2009 13:24:03 Jan Gerrit Marker wrote: > > Am Montag 02 November 2009 10:24:05 schrieb Marco Martin: > > > hmm, not sure if having something installed by default specific for > > > firefox would be a soo good idea,

Re: Firefox Bookmark runner

2009-11-02 Thread Will Stephenson
On Monday 02 November 2009 15:53:24 Eduardo Robles Elvira wrote: > BTW, I'm working on the new konqueror bookmarks system. I'm not sure > if it will be finally in KDE 4.4 because it still needs some work. In > this bookmarks system, bookmarks are going to be stored in Nepomuk. > Hence, I have a pat

Re: Firefox Bookmark runner

2009-11-02 Thread Sebastian Kügler
On Monday 02 November 2009 15:02:30 Jan Gerrit Marker wrote: > Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler: > > No problem. You can just make the changes to the runner (and possibly > > give it a more generic name). If you got it working, post the patch to > > reviewboard. Assuming

Re: Firefox Bookmark runner

2009-11-02 Thread Eduardo Robles Elvira
On Mon, Nov 2, 2009 at 3:02 PM, Jan Gerrit Marker wrote: > Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler: >> No problem. You can just make the changes to the runner (and possibly give >>  it a more generic name). If you got it working, post the patch to >>  reviewboard. Assuming it'

Re: How to get Akonadi notes onto Plasma?

2009-11-02 Thread Stephen Kelly
Sebastian Kügler wrote: > On Monday 02 November 2009 15:08:31 Stephen Kelly wrote: >> Marco Martin wrote: >> Yeah, that sounds pretty good. This is the kind of thing I meant when I >> wrote about a master applet with satellites applets, which Aaron wrote >> would fail in some situations. I'm not

Re: Firefox Bookmark runner

2009-11-02 Thread Jan Gerrit Marker
Am Montag 02 November 2009 14:48:27 schrieb Sebastian Kügler: > No problem. You can just make the changes to the runner (and possibly give > it a more generic name). If you got it working, post the patch to > reviewboard. Assuming it's OK, we'll merge it. I think the right runner is this one: KDE

Re: Firefox Bookmark runner

2009-11-02 Thread Sebastian Kügler
On Monday 02 November 2009 14:05:39 Jan Gerrit Marker wrote: > Am Montag 02 November 2009 13:53:35 schrieb Sebastian Kügler: > > > You could have two methods: > > > QList firefoxBookmarks(QString& term); > > > QList konquerorBookmarks(QString& term); > > > > > > The match Method tests if Firefox or

Re: How to get Akonadi notes onto Plasma?

2009-11-02 Thread Sebastian Kügler
On Monday 02 November 2009 15:08:31 Stephen Kelly wrote: > Marco Martin wrote: > Yeah, that sounds pretty good. This is the kind of thing I meant when I > wrote about a master applet with satellites applets, which Aaron wrote > would fail in some situations. I'm not certain if this is what he mean

Re: How to get Akonadi notes onto Plasma?

2009-11-02 Thread Stephen Kelly
Marco Martin wrote: > On Monday 02 November 2009, Stephen Kelly wrote: >> Aaron J. Seigo wrote: >> > On October 30, 2009, Stephen Kelly wrote: >> >> would prefer to only show the actual notes in the stack on click so >> >> they could be dragged elsewhere. Obviously the background svg of it >> >> s

Re: Firefox Bookmark runner

2009-11-02 Thread Jan Gerrit Marker
Am Montag 02 November 2009 13:53:35 schrieb Sebastian Kügler: > > You could have two methods: > > QList firefoxBookmarks(QString& term); > > QList konquerorBookmarks(QString& term); > > > > The match Method tests if Firefox or Konqueror should be asked for > > bookmark information and runs the me

Re: Firefox Bookmark runner

2009-11-02 Thread Sebastian Kügler
On Monday 02 November 2009 13:24:03 Jan Gerrit Marker wrote: > Am Montag 02 November 2009 10:24:05 schrieb Marco Martin: > > hmm, not sure if having something installed by default specific for > > firefox would be a soo good idea, what would be cool is having a single > > bookmark runner that would

Re: Firefox Bookmark runner

2009-11-02 Thread Jan Gerrit Marker
Am Montag 02 November 2009 12:06:29 schrieb Sebastian Kügler: > On Monday 02 November 2009 11:38:57 Will Stephenson wrote: > > On Sunday 01 November 2009 22:49:04 Eduardo Robles Elvira wrote: > > > I have some questions about the runner. It seems to access to firefox > > > places sqlite database. W

Re: Firefox Bookmark runner

2009-11-02 Thread Jan Gerrit Marker
Am Montag 02 November 2009 10:24:05 schrieb Marco Martin: > hmm, not sure if having something installed by default specific for firefox > would be a soo good idea, what would be cool is having a single bookmark > runner that would search in firefox if it's the default browser otherwise > in konque

Re: Firefox Bookmark runner

2009-11-02 Thread Sebastian Kügler
On Monday 02 November 2009 11:38:57 Will Stephenson wrote: > On Sunday 01 November 2009 22:49:04 Eduardo Robles Elvira wrote: > > I have some questions about the runner. It seems to access to firefox > > places sqlite database. What happens if (much likely if you use this > > runner) firefox is run

Re: Firefox Bookmark runner

2009-11-02 Thread Will Stephenson
On Sunday 01 November 2009 22:49:04 Eduardo Robles Elvira wrote: > I have some questions about the runner. It seems to access to firefox > places sqlite database. What happens if (much likely if you use this > runner) firefox is running and thus also connected to the sqlite > database, can't the da

Re: How to get Akonadi notes onto Plasma?

2009-11-02 Thread Marco Martin
On Monday 02 November 2009, Stephen Kelly wrote: > Aaron J. Seigo wrote: > > On October 30, 2009, Stephen Kelly wrote: > >> would prefer to only show the actual notes in the stack on click so they > >> could be dragged elsewhere. Obviously the background svg of it should > >> not be as it is, or th

Re: How to get Akonadi notes onto Plasma?

2009-11-02 Thread Stephen Kelly
Aaron J. Seigo wrote: > On October 30, 2009, Stephen Kelly wrote: >> would prefer to only show the actual notes in the stack on click so they >> could be dragged elsewhere. Obviously the background svg of it should not >> be as it is, or the size it currently is. Additionally I need to give >> s

Re: Firefox Bookmark runner

2009-11-02 Thread Marco Martin
On Sunday 01 November 2009, Jan Gerrit Marker wrote: > Hello, > today I moved a runner called "Firefox Bookmarks" to playground. This > runner allows you to search through the bookmarks of the default Firefox > profile. In order to get enough time to add it to KDE 4.4 I want to add it > to the f