---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106448/#review19150
---
wow, what a large patch :-) I still see a lot of code written
On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote:
Patch looks good now, thanks a lot!
Please commit it to KDE/4.9 and master.
Sebastian Kügler wrote:
Ah, crap. I missed your question about the possible BIC issue. Can
someone answer this question?
Is it
On Sept. 18, 2012, 11:32 p.m., Aaron J. Seigo wrote:
mainwindow.cpp, line 488
http://git.reviewboard.kde.org/r/106479/diff/1/?file=85743#file85743line488
this looks incorrect; probably what is missing is an || !m_part
it works with !m_part
- Giorgos
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106479/
---
(Updated Sept. 19, 2012, 11:03 a.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106478/#review19154
---
This review has been submitted with commit
On Sept. 17, 2012, 4:13 p.m., Sebastian Kügler wrote:
mainwindow.cpp, line 975
http://git.reviewboard.kde.org/r/106477/diff/1/?file=85740#file85740line975
Do we setVisible(true) it when we change package?
I don't see this in the code, but haven't tried. Something to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106477/
---
(Updated Sept. 19, 2012, 11:13 a.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106504/
---
Review request for Plasma.
Description
---
krunner crashes due to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106504/#review19156
---
Why the if(m_favicon)? You could just delete m_favicon and set
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106477/#review19157
---
Ship it!
Ship It!
- Sebastian Kügler
On Sept. 19, 2012,
Assigned the Picture Frame for myself, I was going to do the Calculator
instead but I found a blogpost by Davide saying that he was going to do it.
So, last call... is anyone porting Picture Frame?
Cheerz !
___
Plasma-devel mailing list
On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote:
That's pretty bonkers. This class was never meant to be used like that.
Holding an object in two threads is not going to work unless you make the
entire communication synchronous effectively reducing all the
multi-threading aspects to a
On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote:
That's pretty bonkers. This class was never meant to be used like that.
Holding an object in two threads is not going to work unless you make the
entire communication synchronous effectively reducing all the
multi-threading aspects to a
On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote:
That's pretty bonkers. This class was never meant to be used like that.
Holding an object in two threads is not going to work unless you make the
entire communication synchronous effectively reducing all the
multi-threading aspects to a
On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote:
That's pretty bonkers. This class was never meant to be used like that.
Holding an object in two threads is not going to work unless you make the
entire communication synchronous effectively reducing all the
multi-threading aspects to a
On Sept. 15, 2012, 9:23 a.m., Martin Gräßlin wrote:
given that everything else uses the optional macro that sounds like a valid
improvement to me
Great - if nobody objects, I'll push this tomorrow evening.
- Ralf
---
This is an
On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote:
Patch looks good now, thanks a lot!
Please commit it to KDE/4.9 and master.
Sebastian Kügler wrote:
Ah, crap. I missed your question about the possible BIC issue. Can
someone answer this question?
Is it
On Sept. 11, 2012, 7:39 p.m., Zack Rusin wrote:
That's pretty bonkers. This class was never meant to be used like that.
Holding an object in two threads is not going to work unless you make the
entire communication synchronous effectively reducing all the
multi-threading aspects to a
18 matches
Mail list logo
