Help with fixing a notifications issue

2013-05-16 Thread Daniel Vrátil
Heya, I've been playing with notifications in KDE Telepathy again and run into some issues with implementation of the Notifications applet in Plasma and KNotifications in general. After some debugging I realized that one of the problems is bigger than I though and since I haven't worked with no

Re: Review Request 110475: Fixed::Bug 319626 - Can't remove an another song from playlist without stopping the current media.

2013-05-16 Thread Akshay Ratan
Hi, Yes I think it would be perfect if you commit it for me. I dont yet have KDE Developers Right. Also, my reason for commenting the line was if in future somebody wants to code some added feature regarding the playlist, the line might be of some help. Anyways, should I remove it if you say ?

Re: Review Request 110475: Fixed::Bug 319626 - Can't remove an another song from playlist without stopping the current media.

2013-05-16 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110475/#review32660 --- Ship it! Looks good. Should I commit this for you? mediaelem

Review Request 110475: Fixed::Bug 319626 - Can't remove an another song from playlist without stopping the current media.

2013-05-16 Thread Akshay Ratan
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110475/ --- Review request for Plasma, Marco Martin, Shantanu Tushar, and Sinny Kumari.

Re: Review Request 110420: Bugfix for bug #311364

2013-05-16 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420/ --- (Updated May 16, 2013, 4:56 p.m.) Review request for kde-workspace and Pla

Re: Review Request 110431: Improve battery monitor with multiple batteries

2013-05-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110431/ --- (Updated May 16, 2013, 3:55 p.m.) Status -- This change has been mark

Re: Review Request 110431: Improve battery monitor with multiple batteries

2013-05-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110431/#review32653 --- This review has been submitted with commit 6fea11b80b78c6b734f

Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

2013-05-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/ --- (Updated May 16, 2013, 3:09 p.m.) Status -- This change has been mark

Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

2013-05-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/#review32649 --- This review has been submitted with commit 72db566f4bf40b79aca

Re: Review Request 110453: Order tasks by activity in tasks applet

2013-05-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110453/ --- (Updated May 16, 2013, 2:27 p.m.) Status -- This change has been mark

Re: Review Request 110453: Order tasks by activity in tasks applet

2013-05-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110453/#review32647 --- This review has been submitted with commit ffbc90c634527d00dc8

Re: Review Request 110453: Order tasks by activity in tasks applet

2013-05-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110453/#review32645 --- Ship it! Looks good, and a nice feature to have in there. li

Re: Review Request 110431: Improve battery monitor with multiple batteries

2013-05-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110431/#review32644 --- Ship it! Ship It! - Aaron J. Seigo On May 15, 2013, 3:04 p.

Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

2013-05-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110427/#review32643 --- Ship it! Ship It! - Aaron J. Seigo On May 15, 2013, 2:50 p.

Re: Default activity naming issues

2013-05-16 Thread Kevin Ottens
On Thursday 16 May 2013 14:01:17 Aaron J. Seigo wrote: > On Thursday, May 16, 2013 11:01:10 Kevin Ottens wrote: > > Only the "emptying" part would be in this magical first activity > > (otherwise > > as you point out it is exactly duplicate). That's the only thing which > > makes me uneasy with the

Re: Default activity naming issues

2013-05-16 Thread Aaron J. Seigo
On Thursday, May 16, 2013 11:01:10 Kevin Ottens wrote: > Only the "emptying" part would be in this magical first activity (otherwise > as you point out it is exactly duplicate). That's the only thing which > makes me uneasy with the idea in its current state: having a magical first > activity which

Re: Default activity naming issues

2013-05-16 Thread Aaron J. Seigo
On Thursday, May 16, 2013 11:50:06 Djuro Drljaca wrote: > maybe a small modification to the idea. Instead of a special activity all > of them could support this feature to copy/move/clone/whatever-you-call-it > or at least to have the ability to clone an activity and also to > clear/clean it. yes,

Re: Review Request 110465: Plasma Wallpaper BackgroundListModel: Remember to clear the caches

2013-05-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110465/#review32636 --- Ship it! Ship It! - Marco Martin On May 16, 2013, 9:57 a.m.

Re: Review Request 110467: Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo

2013-05-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110467/#review32635 --- Ship it! Ship It! - Marco Martin On May 16, 2013, 9:57 a.m.

Review Request 110465: Plasma Wallpaper BackgroundListModel: Remember to clear the caches

2013-05-16 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110465/ --- Review request for Plasma. Description --- Don't just clear m_pac

Review Request 110467: Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo

2013-05-16 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110467/ --- Review request for Plasma. Description --- Plasma Wallpaper Backg

Re: Default activity naming issues

2013-05-16 Thread Djuro Drljaca
Hello, maybe a small modification to the idea. Instead of a special activity all of them could support this feature to copy/move/clone/whatever-you-call-it or at least to have the ability to clone an activity and also to clear/clean it. Maybe there could even be a feature to make a "snapshot" of t

Re: kde-workspace and plasma2

2013-05-16 Thread Marco Martin
On Thu, May 16, 2013 at 10:35 AM, Aaron J. Seigo wrote: > On Wednesday, May 15, 2013 18:36:27 Marco Martin wrote: > > On Tuesday 14 May 2013, Aaron J. Seigo wrote: > > > Even porting a few of the plasmoids wouldn't be the worst of ideas. (I > > > expect the icon one to be interesting ...) Not eve

Re: Default activity naming issues

2013-05-16 Thread Kevin Ottens
On Thursday 16 May 2013 10:40:09 Aaron J. Seigo wrote: > On Wednesday, May 15, 2013 16:19:07 Kevin Ottens wrote: > > On Wednesday 15 May 2013 15:31:16 Ivan Čukić wrote: > > > Welcome is nice, but again, not a real activity (link to Welcome and > > > similar). > > > > Yeah, I guess it comes from

Re: Default activity naming issues

2013-05-16 Thread Aaron J. Seigo
On Wednesday, May 15, 2013 16:45:51 Martin Graesslin wrote: > On Wednesday 15 May 2013 16:21:28 Aaron J. Seigo wrote: > > On Wednesday, May 15, 2013 15:31:16 Ivan Čukić wrote: > > > Welcome is nice, but again, not a real activity (link to Welcome and > > > similar). > > > > If we want a meanging

Re: Default activity naming issues

2013-05-16 Thread Aaron J. Seigo
On Wednesday, May 15, 2013 16:19:07 Kevin Ottens wrote: > On Wednesday 15 May 2013 15:31:16 Ivan Čukić wrote: > > Welcome is nice, but again, not a real activity (link to Welcome and > > similar). > > Yeah, I guess it comes from some of the adjustments I have in mind for the > overall activity w

Re: PotD Headers

2013-05-16 Thread Aaron J. Seigo
On Wednesday, May 15, 2013 11:27:35 David Narvaez wrote: > to develop PotD providers? If so, then we need to take those decisions > (who, how, when) in some order, and face the matter below: that issue is irrelevant if we do not use a C++ API for that. please see my email in this thread for why a

Re: kde-workspace and plasma2

2013-05-16 Thread Aaron J. Seigo
On Wednesday, May 15, 2013 18:36:27 Marco Martin wrote: > On Tuesday 14 May 2013, Aaron J. Seigo wrote: > > Even porting a few of the plasmoids wouldn't be the worst of ideas. (I > > expect the icon one to be interesting ...) Not everything needs to be > > ported right now, however, especially not