---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118824/
---
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Bugs:
See http://build.kde.org/job/plasma-workspace_master_qt5/478/changes
Changes:
[scripty] SVN_SILENT made messages (.desktop file)
--
[...truncated 1200 lines...]
Generating moc_statusnotifieritemsource.cpp
[ 18%] [ 18%] Generated
On June 18, 2014, 9:14 p.m., Hrvoje Senjan wrote:
in the end this causes massive issues on startup - kdeinit blocks as it
waits on PA, which i guess is tried to initialize too early. meaning the
whole startup is 'freezed' (you can interact with shell, but everything
else is kapput)
See http://build.kde.org/job/plasma-desktop_master_qt5/334/changes
Changes:
[notmart] use new icons
--
[...truncated 816 lines...]
http://build.kde.org/job/plasma-desktop_master_qt5/ws/kcms/kfontinst/kcmfontinst/ActionLabel.cpp:0:
Note: No relevant
On June 18, 2014, 7:14 p.m., Hrvoje Senjan wrote:
in the end this causes massive issues on startup - kdeinit blocks as it
waits on PA, which i guess is tried to initialize too early. meaning the
whole startup is 'freezed' (you can interact with shell, but everything
else is kapput)
On June 18, 2014, 7:14 p.m., Hrvoje Senjan wrote:
in the end this causes massive issues on startup - kdeinit blocks as it
waits on PA, which i guess is tried to initialize too early. meaning the
whole startup is 'freezed' (you can interact with shell, but everything
else is kapput)
On June 17, 2014, 11:31 a.m., Marco Martin wrote:
as gut feeling, i think results pages that show too many things at once
could be overwhelming, but it can be tried and see how it works, just one
thing tough..
I don't think you can be completely sure that the results will fit the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118791/#review60501
---
Ship it!
Ship It!
- Marco Martin
On June 17, 2014, 4:46
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118804/
---
(Updated June 19, 2014, 12:01 p.m.)
Review request for Plasma.
Changes
On June 18, 2014, 4:28 p.m., David Edmundson wrote:
ksmserver/screenlocker/logind.cpp, lines 92-93
https://git.reviewboard.kde.org/r/118804/diff/1/?file=282063#file282063line92
This doesn't make sense.
you have if the reply is invalid, print the value in the reply
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118804/
---
(Updated June 19, 2014, 12:05 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118804/
---
(Updated June 19, 2014, 12:15 p.m.)
Review request for Plasma.
Changes
See http://build.kde.org/job/plasma-workspace_master_qt5/479/changes
Changes:
[aleixpol] Improve battery state string
--
[...truncated 1220 lines...]
[ 18%] Automatic moc for target kde
Automatic moc for target drkonqi_backtrace_parser
Generating
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118791/
---
(Updated June 19, 2014, 12:32 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118791/#review60507
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118636/#review60509
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118838/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118665/#review60510
---
Ship it!
Ship It!
- David Edmundson
On June 13, 2014,
On 06/17/2014 10:56 AM, Marco Martin wrote:
On Thu, May 29, 2014 at 3:09 PM, Marco Martin notm...@gmail.com
mailto:notm...@gmail.com wrote:
On Thursday 15 May 2014 11:39:00 Jens Reuterberg wrote:
Ok so after the feedback from the Beta Release an issue that we
knew was
coming
See http://build.kde.org/job/plasma-workspace_master_qt5/482/changes
Changes:
[aleixpol] Small code cleanup
--
[...truncated 1206 lines...]
[ 18%] [ 18%] Built target plasma_engine_soliddevice_automoc
Built target kded_remotedirnotify_automoc
Generating
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118838/#review60511
---
yeah, the code was wrong, just a small issue on the patch
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118838/
---
(Updated June 19, 2014, 1:07 p.m.)
Review request for KDE Frameworks and
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118838/#review60512
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On June 19, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118838/#review60514
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118838/
---
(Updated June 19, 2014, 1:11 p.m.)
Status
--
This change has been
On June 19, 2014, 8:16 a.m., Shantanu Tushar wrote:
Good analysis and fix. It is still broken if you do the following-
1. Have multiple playlists
2. Remove a playlist
3. Add a playlist
After this the highlight again stops to work, can you check?
Hmm I can no longer reproduce this,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118824/#review60517
---
Ship it!
Ship It!
- Shantanu Tushar
On June 19, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118804/
---
(Updated June 19, 2014, 2:06 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118824/#review60520
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118665/
---
(Updated June 19, 2014, 2:30 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118665/#review60524
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118804/
---
(Updated June 19, 2014, 2:35 p.m.)
Review request for Plasma.
Changes
I guess I am sooo not the dude to say this as it's technical in
nature but Aurorae theme is, as far as I recall, out as it has some
issues speed wise (?) it was too taxing if I recall correctly (I'm sure
I don't Martin G gave a handful of really good reasons why we
shouldn't use it)
But I
Hi all,
in thinking about this bug
https://bugs.kde.org/show_bug.cgi?id=336246
i started to wonder, what is the proper-proper solution?
or better, what is actually the real problem behind the bug?
in the end, we want to know where a widget is, in order to decide what colors
to use.
the partly
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118840/
---
Review request for Plasma, Jonathan Riddell and Peter Penz.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118840/
---
(Updated June 19, 2014, 8:26 a.m.)
Review request for Plasma, Frank
See http://build.kde.org/job/plasma-workspace_master_qt5/483/changes
Changes:
[kde] Use a proper scrollbar
--
[...truncated 1228 lines...]
[ 18%] Automatic moc for target crashtest
Generating progresslistmodel.moc
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote:
I really like the idea. I think we should keep our Scroll* components in to
ease porting, but move away from using it for our own stuff first, and
then, before a first API promise, revisit if we can remove our own
implementation
See http://build.kde.org/job/plasma-workspace_master_qt5/484/changes
Changes:
[notmart] make use of the concept of ColorScope
--
[...truncated 1270 lines...]
Automatic moc for target kglobalaccel5
[ 19%] Built target backtraceparsertest_manual_automoc
[
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114283/#review60536
---
This patch doesn't include Plasma's SectionScroller, so it
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118840/#review60537
---
Ship it!
Thanks for the patch! I could not reproduce the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118767/
---
(Updated June 19, 2014, 10 p.m.)
Review request for Plasma, Bhushan
On June 19, 2014, 4:26 p.m., David Edmundson wrote:
This patch doesn't include Plasma's SectionScroller, so it would be a
regression.
However I'm not entirely sure what SectionScroller actually does, so
possibly not an important one.
Shouldn't we either commit to the review request
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118840/
---
(Updated June 19, 2014, 9:38 a.m.)
Review request for Dolphin, Plasma,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118767/#review60539
---
Ship it!
Looks good to me.
- Sinny Kumari
On June 19,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118767/#review60540
---
Ship it!
Looks good to me.
- Sinny Kumari
On June 19,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118767/#review60541
---
Ship it!
Seems to work correctly, just a minor nitpick and
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote:
I really like the idea. I think we should keep our Scroll* components in to
ease porting, but move away from using it for our own stuff first, and
then, before a first API promise, revisit if we can remove our own
implementation
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote:
I really like the idea. I think we should keep our Scroll* components in to
ease porting, but move away from using it for our own stuff first, and
then, before a first API promise, revisit if we can remove our own
implementation
On June 19, 2014, 4:26 p.m., David Edmundson wrote:
This patch doesn't include Plasma's SectionScroller, so it would be a
regression.
However I'm not entirely sure what SectionScroller actually does, so
possibly not an important one.
Aleix Pol Gonzalez wrote:
Shouldn't we
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote:
I really like the idea. I think we should keep our Scroll* components in to
ease porting, but move away from using it for our own stuff first, and
then, before a first API promise, revisit if we can remove our own
implementation
On June 19, 2014, 4:48 p.m., Shantanu Tushar wrote:
libs/mediacenter/playlistmodel.cpp, line 56
https://git.reviewboard.kde.org/r/118767/diff/2/?file=282626#file282626line56
The explicit call to QVariant should not be needed
I have just one issue in this. This is how I tested it.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118767/
---
(Updated June 19, 2014, 5:14 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118767/#review60548
---
This review has been submitted with commit
Hi Harish,
This is a known issue and is due to the fact that we don't save state while
switching the playlists. Maybe someone should report a bug if not already.
On Thu, Jun 19, 2014 at 10:44 PM, R.Harish Navnit harishnav...@gmail.com
wrote:
This is an automatically generated e-mail. To
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote:
I really like the idea. I think we should keep our Scroll* components in to
ease porting, but move away from using it for our own stuff first, and
then, before a first API promise, revisit if we can remove our own
implementation
See http://build.kde.org/job/plasma-workspace_master_qt5/485/changes
Changes:
[me] KRunner: Auto restart on crash
--
[...truncated 1228 lines...]
[ 18%] Built target crashtest_automoc
Scanning dependencies of target backtraceparsertest_automoc
Generating
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote:
I really like the idea. I think we should keep our Scroll* components in to
ease porting, but move away from using it for our own stuff first, and
then, before a first API promise, revisit if we can remove our own
implementation
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote:
I really like the idea. I think we should keep our Scroll* components in to
ease porting, but move away from using it for our own stuff first, and
then, before a first API promise, revisit if we can remove our own
implementation
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114283/
---
(Updated June 19, 2014, 6 p.m.)
Review request for KDE Frameworks and
On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote:
I really like the idea. I think we should keep our Scroll* components in to
ease porting, but move away from using it for our own stuff first, and
then, before a first API promise, revisit if we can remove our own
implementation
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114283/#review60553
---
Ship it!
Ship It!
- Marco Martin
On June 19, 2014, 6
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114283/#review60554
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114283/
---
(Updated June 19, 2014, 6:09 p.m.)
Status
--
This change has been
See http://build.kde.org/job/plasma-workspace_master_qt5/486/changes
Changes:
[notmart] default icon for windows
--
[...truncated 1207 lines...]
Generating kuiservertest.moc
See http://build.kde.org/job/plasma-workspace_master_qt5/487/changes
Changes:
[notmart] show the remove button on mouse over
[aleixpol] Breeze theme LogoutOptions component
--
[...truncated 1222 lines...]
Generating wallpaperpackage.moc
See http://build.kde.org/job/plasma-workspace_master_qt5/488/changes
Changes:
[kde] Revert Use a proper scrollbar
--
[...truncated 1232 lines...]
[ 18%] [ 18%] Built target kuiservertest_automoc
Automatic moc for target crashtest
Generating
See http://build.kde.org/job/plasma-desktop_master_qt5/335/changes
Changes:
[kde] Print warnings and useful error if component cannot be created
[kde] Fallback to loginname if no fullname is set in kickoff header
--
[...truncated 779 lines...]
See http://build.kde.org/job/plasma-desktop_master_qt5/336/changes
Changes:
[mklapetek] [folder] Format file sizes in tooltip using KFormat
--
[...truncated 778 lines...]
Generating moc_krunnermodel.cpp
Generating moc_kuserproxy.cpp
Generating
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118804/
---
(Updated June 19, 2014, 7:03 p.m.)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117540/
---
(Updated June 19, 2014, 7:56 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117542/
---
(Updated June 19, 2014, 7:56 p.m.)
Status
--
This change has been
See http://build.kde.org/job/plasma-desktop_master_qt5/337/changes
Changes:
[0inkane] Prevent use after free in kcm-keyboard
--
[...truncated 787 lines...]
Generating moc_workspaceoptions.cpp
[ 22%] Built target kcm_workspaceoptions_automoc
Scanning
See http://build.kde.org/job/plasma-desktop_master_qt5/338/changes
Changes:
[notmart] enable the apply button only when something changes
--
[...truncated 804 lines...]
Generating FontinstIface.moc
See http://build.kde.org/job/plasma-workspace_master_qt5/489/changes
Changes:
[notmart] make sure the slidewindow atom is always set
[notmart] don't emit useless colorChanged signals
--
[...truncated 1201 lines...]
Generating moc_soliddeviceservice.cpp
On Thu, Jun 19, 2014 at 10:47 PM, Shantanu Tushar Jha shant...@kde.org
wrote:
Hi Harish,
This is a known issue and is due to the fact that we don't save state
while switching the playlists. Maybe someone should report a bug if not
already.
Alright, I'll report this one ! :)
Warm Regards.
See http://build.kde.org/job/plasma-desktop_master_qt5/339/changes
Changes:
[kde] adjust to changes in ScrollArea
--
[...truncated 758 lines...]
Generating moc_icons.cpp
Generating moc_iconthemes.cpp
Generating workspaceoptions.moc
Generating
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114283/#review60561
---
Note: The property names don't line up 100% in the merge.
On June 19, 2014, 8:42 p.m., David Edmundson wrote:
Note: The property names don't line up 100% in the merge.
flickableItem has now become contentItem (which is a default property)
All instances in plasma-workspace/plasma-desktop are now updated.
That doesn't matter: flickableItem:
On June 19, 2014, 8:42 p.m., David Edmundson wrote:
Note: The property names don't line up 100% in the merge.
flickableItem has now become contentItem (which is a default property)
All instances in plasma-workspace/plasma-desktop are now updated.
Kai Uwe Broulik wrote:
That
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116874/
---
(Updated June 19, 2014, 9:04 p.m.)
Review request for Plasma, Shantanu
See http://build.kde.org/job/plasma-workspace_master_qt5/490/changes
Changes:
[kde] Don't show tooltips for expanded plasmoids
--
[...truncated 1208 lines...]
Scanning dependencies of target drkonqi_automoc
Generated
See http://build.kde.org/job/plasma-workspace_master_qt5/491/changes
Changes:
[kde] Move comment to the right position and cleanup
[kde] Fix initial brightness slider position
--
[...truncated 1197 lines...]
Generating moc_soliddeviceservice.cpp
On June 19, 2014, 8:42 p.m., David Edmundson wrote:
Note: The property names don't line up 100% in the merge.
flickableItem has now become contentItem (which is a default property)
All instances in plasma-workspace/plasma-desktop are now updated.
Kai Uwe Broulik wrote:
That
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118841/
---
Review request for KDE Frameworks and Plasma.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118841/#review60565
---
Fixes for me these messages from battery monitor:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118841/#review60566
---
Ship it!
Ship It!
- Marco Martin
On June 19, 2014, 9:34
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118841/#review60567
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118841/
---
(Updated June 19, 2014, 10:20 p.m.)
Status
--
This change has been
See http://build.kde.org/job/plasma-desktop_master_qt5/340/changes
Changes:
[mklapetek] [pager] Add changing desktops by scrolling mouse wheel
--
[...truncated 779 lines...]
[ 21%] [ 21%] Built target kcm_icons_automoc
Built target
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118842/
---
Review request for KDE Frameworks and Plasma.
Repository: kdeclarative
See http://build.kde.org/job/plasma-desktop_master_qt5/341/changes
Changes:
[hein] Configurable text color in containment case.
--
[...truncated 771 lines...]
Generating kcm_componentchooser.moc
Generating ktimerdialog.moc
See http://build.kde.org/job/plasma-workspace_master_qt5/492/changes
Changes:
[kde] Always show vertical scrollbar in image selection
--
[...truncated 1227 lines...]
[ 18%] Automatic moc for target crashtest
[ 18%] Built target crashtest_automoc
93 matches
Mail list logo
