Review Request 120878: Remove unused header

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120878/ --- Review request for KDE Frameworks, kdewin and Plasma. Repository: krunner

Review Request 120877: Convert switch statements to if/else due to MSVC limitation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120877/ --- Review request for kdewin and Plasma. Repository: plasma-framework Desc

Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120876/ --- Review request for Plasma, Ben Cooksley, Ian Wadham, and Thomas Lübking.

Re: Review Request 120849: [tabbox] Try locating the WindowSwitcher QML through configured lnf package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120849/#review69364 --- Ship it! Lol, the patch looks pretty scary compared to the ac

Re: Gerrit: merging feature branches

On Tuesday 28 October 2014, Marco Martin wrote: > > in the end the nearest i could get is > https://gerrit.vesnicky.cesnet.cz/r/#/c/130 and don't think that one is really usable, since it generated a review request per commit. -- Marco Martin ___ Pl

Gerrit: merging feature branches

Hi all, Gerrit question: I have a feature branch in plasma-framework (mart/basicDeleteUndo), and i wanted to do the review process with gerrit. now i tried the following 3 approaches, that all fail miserably: * from my branch: git push gerrit HEAD:refs/for/master gives [remote rejected] master -

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:50 p.m.) Review request for KDEPIM, KDEPIM-Libr

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120806/ --- (Updated Oct. 28, 2014, 11:48 a.m.) Review request for Plasma and David E

Re: Review Request 120806: Port fifteenPuzzle applet to qml and plasma 5.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120806/ --- (Updated Oct. 28, 2014, 11:47 a.m.) Review request for Plasma and David E

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

> On Oct. 28, 2014, 5:34 p.m., Aleix Pol Gonzalez wrote: > > I'm sorry if it's off-topic, but shouldnt' this be using KAccounts? > > Ashish Bansal wrote: > Well I don't know about KAccounts(Just heard once about it from here : > http://lists.kde.org/?l=kde-devel&m=141434675118408&w=2). Is t

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

> On Oct. 28, 2014, 5:34 p.m., Aleix Pol Gonzalez wrote: > > I'm sorry if it's off-topic, but shouldnt' this be using KAccounts? Well I don't know about KAccounts(Just heard once about it from here : http://lists.kde.org/?l=kde-devel&m=141434675118408&w=2). Is there any limitation of libkgapi2

Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69309 --- I'm sorry if it's off-topic, but shouldnt' this be using KAcco

Review Request 120855: Add Google two-step verification support to PMC Picasa login

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and

Re: Review Request 120850: Move KWin's window switcher "sidebar" to Look'n'Feel package

> On Oct. 28, 2014, 5:04 p.m., David Edmundson wrote: > > I'm not sure what I should do with your comments :-) I'm only moving the code, it's not new. If you think this needs improvement I suggest to just come up with the patch once it's merged. After all it looks like you are way more into t

Re: Review Request 120850: Move KWin's window switcher "sidebar" to Look'n'Feel package

> On Oct. 28, 2014, 5:26 p.m., Marco Martin wrote: > > Still related to the comment of the previous review request.. > > If the l&f package actually provides the qml files of the switcher, kindof > > removes the point of the defaults file... > > or is it still possible to set a different switcxh

Re: Review Request 120850: Move KWin's window switcher "sidebar" to Look'n'Feel package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/#review69304 --- Still related to the comment of the previous review request..

[plasmashell] [Bug 328593] Dual screen has regressed in plasma-shell

https://bugs.kde.org/show_bug.cgi?id=328593 Bug 328593 depends on bug 335710, which changed state. Bug 335710 Summary: Plasma shell randomly swaps screen panels on login https://bugs.kde.org/show_bug.cgi?id=335710 What|Removed |Added

Re: Review Request 120850: Move KWin's window switcher "sidebar" to Look'n'Feel package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/#review69299 --- Ship it! lookandfeel/contents/windowswitcher/WindowSwitcher.

Review Request 120850: Move KWin's window switcher "sidebar" to Look'n'Feel package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120850/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 120849: [tabbox] Try locating the WindowSwitcher QML through configured lnf package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120849/ --- Review request for kwin and Plasma. Repository: kwin Description --

Re: Review Request 120847: [kcm/lookandfeel] Add support for changing WindowSwitcher

> On Oct. 28, 2014, 3:23 p.m., Marco Martin wrote: > > kcms/lookandfeel/kcm.cpp, line 218 > > > > > > just out of curiosity: > > window switchers are still shipped as separate packages (as this line > > sugg

Re: Review Request 120847: [kcm/lookandfeel] Add support for changing WindowSwitcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120847/#review69289 --- Ship it! kcms/lookandfeel/kcm.cpp

Re: Review Request 120842: [kcm-effects] Use Loader for the Video Item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/ --- (Updated Oct. 28, 2014, 2:01 p.m.) Status -- This change has been ma

Review Request 120847: [kcm/lookandfeel] Add support for changing WindowSwitcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120847/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 120842: [kcm-effects] Use Loader for the Video Item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/#review69284 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 28, 2014, 11:5

Re: Review Request 120842: [kcm-effects] Use Loader for the Video Item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/ --- (Updated Oct. 28, 2014, 12:58 p.m.) Review request for kwin, Plasma and M

Re: Review Request 120842: [kcm-effects] Use Loader for the Video Item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/#review69255 --- kcmkwin/kwincompositing/qml/Effect.qml

Re: Review Request 120842: [kcm-effects] Use Loader for the Video Item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/#review69253 --- Ship it! Looks good! - Martin Klapetek On Oct. 28, 2014, 1

Review Request 120842: [kcm-effects] Use Loader for the Video Item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120842/ --- Review request for kwin, Plasma and Martin Klapetek. Repository: kwin D