Re: Review Request 121365: Update brightness availability at runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121365/#review71682 --- Ship it! Looks good. dataengines/powermanagement/powermanag

Re: Review Request 121419: Improve Capslock Enabled warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121419/#review71681 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 9, 2014, 10

Re: Review Request 121421: Make the OSD timeout a bit shorter

> On Dec. 9, 2014, 10:56 p.m., Kai Uwe Broulik wrote: > > +1 > > > > 1000ms is too short > > 1500ms feels weird, it's *tick*, wait, …… ad OCD. > > 2500ms is just too long, especially with this huge (almost) opaque box of > > an OSD. I don't really have an opinion, still wanted to remind th

Re: Review Request 121419: Improve Capslock Enabled warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121419/#review71679 --- +1 from me - Lukáš Tinkl On Pro. 9, 2014, 11:15 odp., Kai U

Re: New framework to review: KPackage

El Dimecres, 3 de desembre de 2014, a les 16:29:11, Marco Martin va escriure: > Hi all, > > In the past weeks I have been working on a new framework, called KPackage. > (during Akademy seemed there was some interest for applications to use it) > It comes from the old classes Plasma::Package, so is

Re: kdeplasma-addons

Kai Uwe Broulik ha scritto: > Hi everyone, > > I just noticed that there are no translations whatsoever for > kdeplasma-addons, > at least the German repository I checked [1] has an empty kdeplasma-addons > folder. > > What's wrong there? :) > > [1] svn://anonsvn.kde.org/home/kde/trunk/l10n-k

Re: Review Request 121421: Make the OSD timeout a bit shorter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121421/#review71678 --- +1 1000ms is too short 1500ms feels weird, it's *tick*, wait,

kdeplasma-addons

Hi everyone, I just noticed that there are no translations whatsoever for kdeplasma-addons, at least the German repository I checked [1] has an empty kdeplasma-addons folder. What's wrong there? :) [1] svn://anonsvn.kde.org/home/kde/trunk/l10n-kf5/de/messages Cheers, Kai Uwe ___

Review Request 121421: Make the OSD timeout a bit shorter

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121421/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 121071: Give undo notification a title

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121071/ --- (Updated Dec. 9, 2014, 10:24 p.m.) Status -- This change has been ma

Review Request 121419: Improve Capslock Enabled warning

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121419/ --- Review request for Plasma and Daniel Vrátil. Repository: plasma-workspace

Re: Review Request 121417: Fix scaling progress bar and slider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121417/ --- (Updated Dec. 9, 2014, 9:47 p.m.) Status -- This change has been mar

Re: Review Request 121417: Fix scaling progress bar and slider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121417/#review71674 --- Ship it! Ship It! - Marco Martin On Dec. 9, 2014, 9:42 p.m

Re: Review Request 121417: Fix scaling progress bar and slider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121417/ --- (Updated Dez. 9, 2014, 9:42 nachm.) Review request for Plasma and Marco M

Re: Review Request 121417: Fix scaling progress bar and slider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121417/#review71673 --- progressbar change is ok, the slider problem is caused by the

Re: Review Request 121417: Fix scaling progress bar and slider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121417/ --- (Updated Dez. 9, 2014, 9:31 nachm.) Review request for Plasma and Marco M

Review Request 121417: Fix scaling progress bar and slider

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121417/ --- Review request for Plasma and Marco Martin. Repository: plasma-framework

Re: Review Request 121411: Don't trigger animation if size changed.

> On Dec. 9, 2014, 6:11 p.m., Kai Uwe Broulik wrote: > > Wasn't that part of the idea? Having it scale up the pixmap first when > > resizing and then re-rendering it later? 1. icon size (the widget size) doesn't change frequently. Usually it only happens when user resize the UI or changes the

Re: Review Request 121365: Update brightness availability at runtime

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121365/ --- (Updated Dez. 9, 2014, 6:25 nachm.) Review request for Plasma. Changes

Re: Review Request 121365: Update brightness availability at runtime

> On Dez. 8, 2014, 2:09 nachm., Sebastian Kügler wrote: > > dataengines/powermanagement/powermanagementengine.cpp, line 74 > > > > > > I suppose this change comes from powerdevil itself? (Please check, you > > pr

Change in plasma-framework[master]: plasma_containmentactions_test: Link to KI18n

Heiko Becker has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/210 Change subject: plasma_containmentactions_test: Link to KI18n .. plasma_containmentactions_test: Link to KI18n I get "CMakeFiles/plasm

Re: Review Request 121411: Don't trigger animation if size changed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/#review71665 --- Wasn't that part of the idea? Having it scale up the pixmap fi

Change in plasma-framework[master]: Testing the CI integration, ignore this

Jan Kundrát has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/209 Change subject: Testing the CI integration, ignore this .. Testing the CI integration, ignore this Checking whether a CI tooling can ve

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

> On Dec. 8, 2014, 11:20 p.m., Aleix Pol Gonzalez wrote: > > +1 > > > > Looks good to me > > Kai Uwe Broulik wrote: > I now experience a lot of situtations where icons start blurry and fade > to their full size again, like when opening systray for the first time or > locking the session w

Review Request 121411: Don't trigger animation if size changed.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121411/ --- Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Kai Uwe

Re: Review Request 121396: fix touchpad scrolling on task manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121396/ --- (Updated Dec. 9, 2014, 3:35 p.m.) Status -- This change has been mar

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/#review71648 --- ksmserver/screenlocker/kcm/selectimagebutton.cpp

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

> On Dec. 9, 2014, 12:01 p.m., Martin Gräßlin wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 36 > > > > > > shouldn't you compare whether backgroundPath is empty? That's checking > > whether the

Re: Review Request 121396: fix touchpad scrolling on task manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121396/#review71629 --- Ship it! Ship It! - Eike Hein On Dec. 8, 2014, 9:44 p.m.,

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/ --- (Updated Dec. 9, 2014, 12:29 p.m.) Review request for Plasma. Repositor

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

> On Dec. 9, 2014, 11:52 a.m., Kai Uwe Broulik wrote: > > lookandfeel/contents/lockscreen/LockScreen.qml, line 40 > > > > > > if (status === Image.Error) > > > > You also might want to avoid an endless lo

Re: Review Request 121396: fix touchpad scrolling on task manager

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121396/#review71625 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 8, 2014, 9:

Re: Review Request 121396: fix touchpad scrolling on task manager

> On Dec. 9, 2014, 12:36 a.m., Aleix Pol Gonzalez wrote: > > applets/taskmanager/package/contents/code/tools.js, line 22 > > > > > > so why don't you use the angleDelta? > > Xuetian Weng wrote: > It's not Whe

Minutes Monday Plasma Hangout

Minutes Plasma Hangout, 9-12-2014 (weekly monday meeting was postponed one day since Spain had yesterday off) Present: David, Jens, Marco, Martin G., Martin K., Kai Uwe, Vishesh, Sebastian David: - Patch for wallpaper in lockscreen https://git.reviewboard.kde.org/r/121402/ Marco: - KPackage - q

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/#review71621 --- ksmserver/screenlocker/kcm/selectimagebutton.h

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

> On Dec. 9, 2014, 11:01 a.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/kcm/kcm.ui, lines 84-104 > > > > > > How does one switch back to the default background? left click the button, you get a menu with

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/#review71619 --- ksmserver/screenlocker/kcm/kcm.ui

Re: Review Request 121402: Allow user to customise wallpaper used in the lock screen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/#review71618 --- +1 for me - Marco Martin On Dec. 9, 2014, 10:56 a.m., David

Review Request 121402: Allow user to customise wallpaper used in the lock screen.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121402/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 121396: fix touchpad scrolling on task manager

> On Dez. 9, 2014, 12:36 vorm., Aleix Pol Gonzalez wrote: > > applets/taskmanager/package/contents/code/tools.js, line 22 > > > > > > so why don't you use the angleDelta? > > Xuetian Weng wrote: > It's not Wh

Re: Review Request 121219: Load IconItem immediately upon componentComplete()

> On Dez. 8, 2014, 11:20 nachm., Aleix Pol Gonzalez wrote: > > +1 > > > > Looks good to me I now experience a lot of situtations where icons start blurry and fade to their full size again, like when opening systray for the first time or locking the session where it's quite severe. :/ - Kai

Re: Review Request 121396: fix touchpad scrolling on task manager

> On Dec. 9, 2014, 12:36 a.m., Aleix Pol Gonzalez wrote: > > applets/taskmanager/package/contents/code/tools.js, line 22 > > > > > > so why don't you use the angleDelta? > > Xuetian Weng wrote: > It's not Whe

Re: Review Request 121398: Drop configuration page that does nothing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121398/#review71612 --- I think this means we can kill a bit more. But +1 to everythin