Re: Review Request 122745: Monitor baloo for new media files

2015-02-27 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122745/#review76752 --- Ship it! Ship It! - Shantanu Tushar On Feb. 27, 2015,

Re: Review Request 122745: Monitor baloo for new media files

2015-02-27 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122745/ --- (Updated Feb. 28, 2015, 6:46 a.m.) Status -- This change has been

Re: Review Request 122717: Improve tooltip layouting

2015-02-27 Thread Sebastian Kügler
On Feb. 26, 2015, 10:10 p.m., Kai Uwe Broulik wrote: I'm now getting most of my headlines elided or wrapped: K-\n Menü 99%. Wird\n geladen (battery) Aktualisierung... (updater) KM... (rather than KMail) Volume at\n 45% (kmix) Donnerst... (rather than Donnerstag, digitalclock)

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Gräßlin
On Feb. 27, 2015, 1:13 p.m., Myriam Schweingruber wrote: I didn't give a ship it yet as I want to get Amarok 2.9 beta out first. I don't get this argument. It would be very important if we get this change into the beta and best also in stable releases. - Martin

Jenkins build is still unstable: kde-gtk-config_stable_qt5 #7

2015-02-27 Thread KDE CI System
See http://build.kde.org/job/kde-gtk-config_stable_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is still unstable: kde-gtk-config_master_qt5 #9

2015-02-27 Thread KDE CI System
See http://build.kde.org/job/kde-gtk-config_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is still unstable: kde-gtk-config_master_qt5 #7

2015-02-27 Thread KDE CI System
See http://build.kde.org/job/kde-gtk-config_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Papercuts from review at sprint

2015-02-27 Thread Sebastian Kügler
On Thursday, February 26, 2015 16:16:59 Martin Gräßlin wrote: On Thursday 26 February 2015 16:01:57 Sebastian Kügler wrote: On Thursday, February 26, 2015 08:30:46 Martin Gräßlin wrote: On Wednesday 25 February 2015 18:45:27 Sebastian Kügler wrote: To explain how this works: the

Re: ISO for 2015-02-27

2015-02-27 Thread Bhushan Shah
On Fri, Feb 27, 2015 at 6:57 PM, Harald Sitter sit...@kde.org wrote: - plasma wallpaper thumbnailing is broken; cause unknown https://bugs.kde.org/show_bug.cgi?id=344355 -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___

Review Request 122745: Monitor baloo for new media files

2015-02-27 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122745/ --- Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Vishesh

[kio-extras] [Bug 344355] Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation

2015-02-27 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=344355 Christoph Feck cf...@kde.org changed: What|Removed |Added CC||cf...@kde.org,

Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO

2015-02-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/#review76732 --- a general suggestion: use KConfigXT for wrapping the config

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Martin Gräßlin
On Feb. 27, 2015, 10:42 a.m., Jan Grulich wrote: dataengines/geolocation/location_ip.cpp, line 149 https://git.reviewboard.kde.org/r/122736/diff/1/?file=351954#file351954line149 SSID is never empty (at least it shouldn't be), if it would be a hidden AP it wouldn't be listed

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Gräßlin
On Feb. 27, 2015, 11:40 a.m., Vishesh Handa wrote: src/ActionClasses.cpp, line 174 https://git.reviewboard.kde.org/r/122450/diff/1/?file=347185#file347185line174 Do we need to explicitly call `setGlobalShortcut( KShortcut() )` or can one just omit it alltogether? Martin

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Martin Gräßlin
On Feb. 27, 2015, 11:48 a.m., Martin Klapetek wrote: Can this be configured? I for sure don't want to be sending all my surroundings somewhere Yes it probably even has to be configured. I think we need to present the privacy contract of the service and have the user acknowledge it. -

Re: Review Request 122738: Make sure the OSD is not bigger than 1/3 of the screen

2015-02-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/ --- (Updated Feb. 27, 2015, 2:11 p.m.) Review request for Plasma. Changes

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/ --- (Updated Feb. 27, 2015, 12:50 p.m.) Status -- This change has been

ISO for 2015-02-27

2015-02-27 Thread Harald Sitter
http://files.kde.org/snapshots/unstable-amd64-latest.iso.mirrorlist # changes - kdenlive is now correctly installable - kate plasmoid being broken and showing up by default issue resolved - clipboard should be working as expected [1] - adding default widgets shouldn't crash the shell anymore #

Jenkins build is still unstable: kde-gtk-config_master_qt5 #8

2015-02-27 Thread KDE CI System
See http://build.kde.org/job/kde-gtk-config_master_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to stable : kde-gtk-config_master_qt5 #10

2015-02-27 Thread KDE CI System
See http://build.kde.org/job/kde-gtk-config_master_qt5/10/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-02-27 Thread Sebastian Kügler
On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: where do you want to use it? Iirc Bhushan is working o a global way to make series of kcms accessible from plasmoids David Edmundson wrote: Generic is always better. KDeclarative is used from places outside Plasma.

Re: Review Request 122738: Make sure the OSD is not bigger than 1/3 of the screen

2015-02-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/#review76722 --- lookandfeel/contents/osd/OsdItem.qml

Re: Review Request 122738: Make sure the OSD is not bigger than 1/3 of the screen

2015-02-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/ --- (Updated Feb. 27, 2015, 1:16 p.m.) Status -- This change has been

Jenkins build is still unstable: kde-gtk-config_stable_qt5 #9

2015-02-27 Thread KDE CI System
See http://build.kde.org/job/kde-gtk-config_stable_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Myriam Schweingruber
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76721 --- Ship it! because a) I can't review the code and b) I need to

Re: Review Request 122738: Make sure the OSD is not bigger than 1/3 of the screen

2015-02-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/#review76724 --- Ship it! Ship It! - Sebastian Kügler On Feb. 27, 2015,

Jenkins build is still unstable: kde-gtk-config_stable_qt5 #8

2015-02-27 Thread KDE CI System
See http://build.kde.org/job/kde-gtk-config_stable_qt5/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to stable : kde-gtk-config_stable_qt5 #10

2015-02-27 Thread KDE CI System
See http://build.kde.org/job/kde-gtk-config_stable_qt5/10/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122740: set QT_DEVICE_PIXEL_RATIO on startup loaded from a config file

2015-02-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122740/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Dan Meltzer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76726 --- I'm a little late to the party, but this seems like it would

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

2015-02-27 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/#review76740 --- Ship it! +1 from me - Lukáš Tinkl On Úno. 11, 2015, 3:51

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

2015-02-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Feb. 27, 2015, 7:02 p.m.) Status -- This change has been

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

2015-02-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/#review76738 --- bump, or I'm going to push it anyway. - David Edmundson On

Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO

2015-02-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/ --- Review request for Plasma. Repository: kscreen Description ---

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Gräßlin
On Feb. 27, 2015, 3:51 p.m., Dan Meltzer wrote: I'm a little late to the party, but this seems like it would cause a regression for anyone not using plasma workspace... right? Isn't it a kded bug that the shortcuts don't get forwarded to the active window? I'm a little late to the

Review Request 122741: Prefer exposing lists to QML with QJsonArray

2015-02-27 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Build failed in Jenkins: plasma-desktop_master_qt5 #1043

2015-02-27 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_master_qt5/1043/changes Changes: [kde] Abstract dateandtime saving [kde] Add systemd support into the clock KCM as an optional dependency -- [...truncated 1651 lines...] ^

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

2015-02-27 Thread manciuleas
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #11 from manciul...@yahoo.com --- Hi Lukas, I'm trying to help Eric sort out this issue on our Slackware systems. polkit-kde-authentication-agent-1 is indeed running, but according to my .xsession-errors (attached) it is started by

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

2015-02-27 Thread manciuleas
https://bugs.kde.org/show_bug.cgi?id=344456 manciul...@yahoo.com changed: What|Removed |Added CC||manciul...@yahoo.com --- Comment #10

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

2015-02-27 Thread Lukáš Tinkl
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #12 from Lukáš Tinkl lu...@kde.org --- Hmm, that could indeed be the problem. polkit-kde-authentication-agent-1 is started by the session which is always after kded modules (powerdevil being one)... I wonder what happens when you restart

Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/ --- Review request for Plasma, Jan Grulich and Lukáš Tinkl. Repository:

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #3 from Pulfer pul...@list.ru --- (In reply to Martin Gräßlin from comment #2) I do not really see the need. We communicated for at least a year now that Plasma 4 and 5 are not co-installable And there's nothing good in it. It's a bug,

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76703 --- ping, anyone? - Martin Gräßlin On Feb. 6, 2015, 9:06 a.m.,

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread David Edmundson
https://bugs.kde.org/show_bug.cgi?id=344612 David Edmundson k...@davidedmundson.co.uk changed: What|Removed |Added CC|

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76704 --- dataengines/geolocation/location_ip.cpp

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #5 from Martin Gräßlin mgraess...@kde.org --- (In reply to Pulfer from comment #3) On the other hand, if no applications should use these libraries, I can do the job downstream. well it was a workspace library which means that we never

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Martin Klapetek
On Feb. 27, 2015, 11:40 a.m., Vishesh Handa wrote: src/ActionClasses.cpp, line 174 https://git.reviewboard.kde.org/r/122450/diff/1/?file=347185#file347185line174 Do we need to explicitly call `setGlobalShortcut( KShortcut() )` or can one just omit it alltogether? This way it

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76711 --- Can this be configured? I for sure don't want to be sending

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #12 from Martin Gräßlin mgraess...@kde.org --- (In reply to Pulfer from comment #11) Can be libksgrd5.so with /usr/include/ksysguard5 then. Anything but file conflicts with kde-frameworks. I really do not understand the need. From what

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Luca Beltrame
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #7 from Luca Beltrame lbeltr...@kde.org --- In data venerdì 27 febbraio 2015 09:49:54, Pulfer ha scritto: kdebase4-workspace FWIW: in openSUSE we have split the libraries from the workspace, so that installing a 5.x workspace will not

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

2015-02-27 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76707 --- dataengines/geolocation/location_ip.cpp

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #8 from Martin Gräßlin mgraess...@kde.org --- (In reply to Pulfer from comment #6) At least these apps used KDE4 version of ksysguard libraries: kdebase4-workspace kdevelop4 knemo plasma-applet-fancytasks sentinella The only

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #9 from Pulfer pul...@list.ru --- Created attachment 91314 -- https://bugs.kde.org/attachment.cgi?id=91314action=edit Quick patch to rename libksgrd to libKF5ksgrd I'll likely go this way with my downstream Plasma 5 packaging. Because I

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #6 from Pulfer pul...@list.ru --- (In reply to David Edmundson from comment #4) What app is using it? At least these apps used KDE4 version of ksysguard libraries: kdebase4-workspace kdevelop4 knemo plasma-applet-fancytasks sentinella

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Martin Gräßlin
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #10 from Martin Gräßlin mgraess...@kde.org --- (In reply to Pulfer from comment #9) Created attachment 91314 [details] Quick patch to rename libksgrd to libKF5ksgrd this renaming is wrong as it's not a frameworks library and also not

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #11 from Pulfer pul...@list.ru --- (In reply to Martin Gräßlin from comment #10) (In reply to Pulfer from comment #9) Created attachment 91314 [details] Quick patch to rename libksgrd to libKF5ksgrd this renaming is wrong as it's not

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76709 --- src/ActionClasses.cpp

[Breeze] [Bug 343659] crash when open a new sheet when using Breeze Qt 4

2015-02-27 Thread Tomas Mecir
https://bugs.kde.org/show_bug.cgi?id=343659 Tomas Mecir mec...@gmail.com changed: What|Removed |Added Component|general |general

[Powerdevil] [Bug 344456] Plasma 5 desktop does not suspend with only upower, no systemd

2015-02-27 Thread manciuleas
https://bugs.kde.org/show_bug.cgi?id=344456 --- Comment #13 from manciul...@yahoo.com --- (In reply to Lukáš Tinkl from comment #12) Hmm, that could indeed be the problem. polkit-kde-authentication-agent-1 is started by the session which is always after kded modules (powerdevil being one)...

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=344612 Hrvoje Senjan hrvoje.sen...@gmail.com changed: What|Removed |Added CC||hrvoje.sen...@gmail.com

Review Request 122738: Make sure the OSD is not bigger than 1/3 of the screen

2015-02-27 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122738/ --- Review request for Plasma. Repository: plasma-workspace Description

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #14 from Pulfer pul...@list.ru --- (In reply to Martin Gräßlin from comment #12) I really do not understand the need. From what Luca wrote the library can be co-installed on openSUSE. Also the so-version changed. The need is to avoid any

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Pulfer
https://bugs.kde.org/show_bug.cgi?id=344612 --- Comment #15 from Pulfer pul...@list.ru --- RPM package (spec and patches) that doesn't conflict with KDE4 stuff: https://abf.io/import/libksysguard ksysguard from Plasma 5.2.1 build fine with this package installed. -- You are receiving this mail

Re: Review Request 122450: Do not set global shortcuts for the Media keys

2015-02-27 Thread Myriam Schweingruber
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122450/#review76713 --- I didn't give a ship it yet as I want to get Amarok 2.9 beta