Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Martin Klapetek
On May 18, 2015, 4:15 p.m., Aleix Pol Gonzalez wrote: This fixes my boot. I wasn't able to boot for the whole day because it was showing a QWidget from the wrong thread. On a related note, let's port away from QDesktopWidget, it has these things... Ok, QScreen then? - Martin

Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123836/ --- (Updated May 18, 2015, 3:34 p.m.) Status -- This change has been

Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Aleix Pol Gonzalez
On May 18, 2015, 4:15 p.m., Aleix Pol Gonzalez wrote: This fixes my boot. I wasn't able to boot for the whole day because it was showing a QWidget from the wrong thread. On a related note, let's port away from QDesktopWidget, it has these things... Martin Klapetek wrote:

Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123836/#review80575 --- Ship it! This fixes my boot. I wasn't able to boot for the

Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123836/ --- Review request for KDE Frameworks and Plasma. Repository: knotifications

Re: Review Request 123381: Fallback to AttentionIcon for SNI when animations are disabled

2015-05-18 Thread Martin Klapetek
On April 16, 2015, 1:43 p.m., Kai Uwe Broulik wrote: I think we should always pulse, and if available, use the needs attention icon (but don't cycle between normal and attention icon) Martin Klapetek wrote: If you don't cycle it's quite easy to miss, so I think there'd be very

Re: Review Request 122648: Make notifications --reverse aware

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122648/ --- (Updated May 18, 2015, 12:54 p.m.) Status -- This change has been

Re: Review Request 123731: Cleanup handling of notifications closing

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123731/ --- (Updated May 18, 2015, 2:14 p.m.) Review request for KDE Frameworks and

Review Request 123834: Switch the login sound to Phonon directly...for now

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123834/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 123817: Device notifier: Refresh the space indicator every 5 seconds.

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123817/#review80566 --- Fwiw, I think it would be much better if the dataengine

Re: Plasma 5 is awesome...and some help required with build instructions

2015-05-18 Thread David Edmundson
Just setting up on a new machine and thought I'd try following these instructions exactly, the way a new developer would. I got stuck on something I don't know how to solve. Under Kubuntu because Qt is compiled with a hardcoded plugindir for some reason. This means setting QT_PLUGIN_PATH env

Re: Review Request 123836: Ensure KNotification can be used from a non-GUI thread

2015-05-18 Thread Martin Klapetek
On May 18, 2015, 4:15 p.m., Aleix Pol Gonzalez wrote: This fixes my boot. I wasn't able to boot for the whole day because it was showing a QWidget from the wrong thread. On a related note, let's port away from QDesktopWidget, it has these things... Martin Klapetek wrote:

Re: Review Request 123807: Fix popup menu items getting stray highlighted

2015-05-18 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123807/#review80582 --- Ship it! Ship It! - Lukáš Tinkl On Kvě. 16, 2015, 12:39

Re: Plasma 5 is awesome...and some help required with build instructions

2015-05-18 Thread David Edmundson
On Mon, May 18, 2015 at 7:05 PM, Aleix Pol aleix...@kde.org wrote: On Mon, May 18, 2015 at 7:28 PM, David Edmundson da...@davidedmundson.co.uk wrote: Just setting up on a new machine and thought I'd try following these instructions exactly, the way a new developer would. I got stuck on

Re: Review Request 123783: Adjust showing desktop behavior

2015-05-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123783/#review80595 --- Ship it! Ship It! - Martin Gräßlin On May 14, 2015, 12:21

Re: Review Request 123783: Adjust showing desktop behavior

2015-05-18 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123783/#review80594 --- Plasma workspace 5.3.1 is tagged *Thu 2015-05-21*, 3 days

Re: Plasma 5 is awesome...and some help required with build instructions

2015-05-18 Thread Aleix Pol
On Mon, May 18, 2015 at 7:28 PM, David Edmundson da...@davidedmundson.co.uk wrote: Just setting up on a new machine and thought I'd try following these instructions exactly, the way a new developer would. I got stuck on something I don't know how to solve. Under Kubuntu because Qt is

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 18, 2015, 7:09 p.m.) Review request for KDE Frameworks and

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 18, 2015, 7:02 p.m.) Review request for KDE Frameworks and

Re: Review Request 123783: Adjust showing desktop behavior

2015-05-18 Thread Thomas Pfeiffer
On May 14, 2015, 11:23 p.m., Thomas Pfeiffer wrote: 1) The minimizability of windows is ignored. It's a cornercase, but the former behavior was a side-effect of the implementation. (At least I don't know a reason to keep them) Could you explain what minimizability of windows

Planning merging the single qqml engine

2015-05-18 Thread Marco Martin
Hi all, I think the branches for the single shared qqmlengine are pretty much ready (few cleanups upcoming days), seems pretty stable here.. did someone ran the branch for a while as well? In the end i managed to get a single engine for the whole session, views included (had to duplicate the

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/#review80600 --- src/quickaddons/quickviewsharedengine.cpp (lines 35 - 39)

Re: Review Request 123738: Use column major in the taskbar when Force row settings is set

2015-05-18 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123738/ --- (Updated maj 18, 2015, 7:40 e.m.) Review request for Plasma and Eike

Re: Planning merging the single qqml engine

2015-05-18 Thread Mark Gaiser
On Mon, May 18, 2015 at 9:28 PM, Marco Martin notm...@gmail.com wrote: Hi all, I think the branches for the single shared qqmlengine are pretty much ready (few cleanups upcoming days), seems pretty stable here.. did someone ran the branch for a while as well? In the end i managed to get a

Re: Planning merging the single qqml engine

2015-05-18 Thread Marco Martin
On Monday 18 May 2015, Mark Gaiser wrote: Anyway, with that attribute you let the applet developer OPT-IN in for shared engine. Setting that attribute can be easily forgotten. If anything, they should OPT-OUT thus by default use the shared engine. Perhaps a attribute like this is more

Re: Review Request 123735: version of QmlObject with a static engine

2015-05-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735/ --- (Updated May 18, 2015, 8 p.m.) Review request for KDE Frameworks and

Re: Planning merging the single qqml engine

2015-05-18 Thread Kai Uwe Broulik
Hi, That's running: kdeclarative - your branch plasma-framework - your branch plsama-workspace - master (which is pretty close to running latest frameworks with Plasma 5.3) Are there any significant changes in plasma-workspace and plasma-desktop, other than applet migration, since there's

Re: Planning merging the single qqml engine

2015-05-18 Thread Marco Martin
On Monday 18 May 2015, Kai Uwe Broulik wrote: What I found interesting that you changed import plasmapkg:/code/logic.js to import logic.js although the qml file is in a different folder, why does that work? since it can still figure out the package, the url interceptor takes js files from

Re: Planning merging the single qqml engine

2015-05-18 Thread Ivan Čukić
While I'm usually more conservative, I do think that something more decisive should be done in this case (and cases like these). While we do not want to break everything with each new release (wink wink ghm ghm nudge nudge), I don't think we want to support every

Re: Plasma 5 is awesome...and some help required with build instructions

2015-05-18 Thread Aleix Pol
On Mon, May 18, 2015 at 8:07 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Mon, May 18, 2015 at 7:05 PM, Aleix Pol aleix...@kde.org wrote: On Mon, May 18, 2015 at 7:28 PM, David Edmundson da...@davidedmundson.co.uk wrote: Just setting up on a new machine and thought I'd try

Re: Planning merging the single qqml engine

2015-05-18 Thread Ivan Čukić
The ironic thing here is that something would have to be introduced that will be deprecated Not really. It would deprecate the old qml engine per plasmoid. It is not about deprecating the opt-in thing. The ideal is to achieve 100% opt-in, that is, for all plugins to eventually get the

Re: Planning merging the single qqml engine

2015-05-18 Thread Mark Gaiser
On Mon, May 18, 2015 at 9:53 PM, Marco Martin notm...@gmail.com wrote: On Monday 18 May 2015, Mark Gaiser wrote: Anyway, with that attribute you let the applet developer OPT-IN in for shared engine. Setting that attribute can be easily forgotten. If anything, they should OPT-OUT thus by

Re: Plasma 5 is awesome...and some help required with build instructions

2015-05-18 Thread Siddhartha
On 18 May 2015 at 22:58, David Edmundson da...@davidedmundson.co.uk wrote: Just setting up on a new machine and thought I'd try following these instructions exactly, the way a new developer would. I got stuck on something I don't know how to solve. Under Kubuntu because Qt is compiled with

Re: Review Request 123846: Enable translations for devicenotifications dataengine

2015-05-18 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123846/#review80611 --- Ship it! Thanks - Burkhard Lück On Mai 18, 2015, 11:21

Review Request 123846: Enable translations for devicenotifications dataengine

2015-05-18 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123846/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Planning merging the single qqml engine

2015-05-18 Thread David Edmundson
On Mon, May 18, 2015 at 8:28 PM, Marco Martin notm...@gmail.com wrote: Hi all, I think the branches for the single shared qqmlengine are pretty much ready (few cleanups upcoming days), seems pretty stable here.. did someone ran the branch for a while as well? Thanks for doing all that.

[Plasma Workspace Wallpapers] [Bug 347532] preferencias de escritorio no permite establecer fondo de pantalla ni individual ni en presentacion solo las del sistenma

2015-05-18 Thread Sebastian Kügler
https://bugs.kde.org/show_bug.cgi?id=347532 Sebastian Kügler se...@kde.org changed: What|Removed |Added CC||se...@kde.org

Minutes Monday Plasma Hangout

2015-05-18 Thread Sebastian Kügler
Present: Antonis, Marco, Martin G., Sebastian, Kai Uwe, Vishesh, David Date: 18 May, 2015 Next week: no hangout on Monday, but on Tuesday due to public holiday in relevant regions Antonis: - Working on bugs in https://codereview.qt-project.org/#/c/112296/ - Will fix issues pointed out in