Re: Review Request 123992: Use upcoming version of libdbusmenu-qt

2015-07-06 Thread David Edmundson
On June 4, 2015, 10:33 p.m., Sebastian Kügler wrote: 5.4 or 5.3.2? I've noticed that a bunch of smaller things could be improved, though they might well be in the original code already, so can be pushed upstream independently. I'm OK with shipping this as-is, since this is

Minutes Monday Plasma Hangout

2015-07-06 Thread Sebastian Kügler
Present: Bhushan, Martin G., Sebastian, Kai Uwe, David Date: 6 July, 2015 Bhushan: * Working demo of PMC's widget explorer here https://www.youtube.com/watch?v=J82iPaYA8jE Kai Uwe * various bugfixes, fallout from shared qml engine patches * fixed dropping folder on desktop creates

Re: Review Request 124250: Add screenlocker docbook

2015-07-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124250/#review82114 --- Ship it! - Martin Gräßlin On July 6, 2015, 11:54 a.m.,

Re: Review Request 124250: Add screenlocker docbook

2015-07-06 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124250/ --- (Updated July 6, 2015, 10:42 a.m.) Status -- This change has been

Re: Review Request 124250: Add screenlocker docbook

2015-07-06 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124250/ --- (Updated Juli 6, 2015, 9:54 vorm.) Review request for Documentation and

Re: Review Request 124250: Add screenlocker docbook

2015-07-06 Thread Burkhard Lück
On Juli 5, 2015, 12:59 nachm., Martin Gräßlin wrote: This adds a new directory called kcontrol. Would it not be better to drop this KDE 3.5 term and replace it with what it's about? E.g. lockscreen or screenlocker? No, because 1) The new directory called kcontrol is consistent with

Re: Review Request 123992: Use upcoming version of libdbusmenu-qt

2015-07-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123992/ --- (Updated July 6, 2015, 8:55 a.m.) Status -- This change has been

Re: Review Request 124255: keyboard: do not reset shortcut for changing layout

2015-07-06 Thread Ivan Romanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124255/ --- (Updated July 6, 2015, 2:21 p.m.) Review request for Plasma.

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 60 - Still Failing!

2015-07-06 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/60/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jul 2015 08:34:24 + Build duration: 10 min CHANGE SET Revision

Re: Review Request 124268: [kcms/kcmstyle] Drop setting _QT_DESKTOP_PROPERTIES code path

2015-07-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124268/ --- (Updated July 6, 2015, 1:46 p.m.) Review request for Plasma.

Review Request 124268: [kcms/kcmstyle] Drop setting _QT_DESKTOP_PROPERTIES code path

2015-07-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124268/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Minutes Monday Plasma Hangout

2015-07-06 Thread Eike Hein
Eike * Finished refactoring the Kicker backend to (among other things) allow favorite'ing arbitrary things like contacts with realtime status information: http://wstaw.org/m/2015/07/05/contactfaves.png * Ongoing: Lean fullscreen launcher interface (to make up for old Homerun) using this

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 61 - Fixed!

2015-07-06 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/61/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 06 Jul 2015 11:58:17 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 124268: [kcms/kcmstyle] Drop setting _QT_DESKTOP_PROPERTIES code path

2015-07-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124268/#review82118 --- +1 - Aleix Pol Gonzalez On July 6, 2015, 1:46 p.m., Martin

Review Request 124269: [kcms/access] Do nothing on non X11 platforms

2015-07-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124269/ --- Review request for Plasma. Repository: plasma-desktop Description

Review Request 124270: [kcms/input] Ensure X11 specific code doesn't crash on other platforms

2015-07-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124270/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 124269: [kcms/access] Do nothing on non X11 platforms

2015-07-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124269/#review82119 --- kcms/access/kaccess.cpp (line 147)

Re: Review Request 124267: Use KWin to lower/raiser panel in windows can cover mode with edge activation

2015-07-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124267/#review82123 --- shell/panelview.cpp (line 342)

Re: Review Request 124267: Use KWin to lower/raiser panel in windows can cover mode with edge activation

2015-07-06 Thread David Edmundson
On July 6, 2015, 12:51 p.m., Kai Uwe Broulik wrote: shell/panelview.cpp, line 348 https://git.reviewboard.kde.org/r/124267/diff/1/?file=383465#file383465line348 if (!(foo || bar)) makes my head explode yeah, seems not just overly complicated but also completely wrong. - David

Review Request 124273: Unfocus applet when clicking empty desktop area

2015-07-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124273/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 124236: More sensible sizing for containment configuration

2015-07-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124236/ --- (Updated July 6, 2015, 4:58 p.m.) Status -- This change has been

Review Request 124275: Allow building kcminput without libusb-compat

2015-07-06 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/ --- Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Martin

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/#review82147 --- Looks good to me - Martin Gräßlin On July 6, 2015, 8:41

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/#review82157 --- Looks good to me too, as long as it works. OTOH, it looks

Re: Review Request 124246: Improve sticky notes

2015-07-06 Thread Thomas Pfeiffer
On July 4, 2015, 9:01 p.m., Heiko Tietze wrote: Didn't test the workflow so just about the screenshot. Alignment looks somewhat strange. According https://techbase.kde.org/Projects/Usability/HIG/Alignment the right position is left for the longest label and all other to its right

Re: Review Request 124236: More sensible sizing for containment configuration

2015-07-06 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124236/#review82138 --- Ship it! Ship It! - Bhushan Shah On July 3, 2015, 12:24