Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 176 - Fixed!

2015-09-14 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/176/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:44 + Build duration: 6 min 2 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 176 - Fixed!

2015-09-14 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/176/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:44 + Build duration: 6 min 2 sec CHANGE SET No changes JUNIT RESULTS

Review Request 125222: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125222/ --- Review request for Plasma. Repository: kdeplasma-addons Description

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125174/ --- (Updated Sept. 14, 2015, 11:11 a.m.) Status -- This change has been

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 178 - Fixed!

2015-09-14 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/178/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:41 + Build duration: 16 min CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 178 - Fixed!

2015-09-14 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/178/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 14 Sep 2015 10:21:41 + Build duration: 16 min CHANGE SET No changes JUNIT RESULTS Name:

Re: Review Request 125187: Stop requiring Frameworks 5.15

2015-09-14 Thread Sebastian Kügler
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > >

Re: Review Request 125187: Stop requiring Frameworks 5.15

2015-09-14 Thread Marco Martin
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. > >

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/ --- (Updated Sept. 14, 2015, 1:19 p.m.) Review request for kwin, Plasma and

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-14 Thread Marco Martin
> On Sept. 10, 2015, 6:33 a.m., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, lines 433-434 > > > > > > on X11 the time might also come from the property. > > Marco Martin wrote: > for

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Marco Martin
> On Sept. 14, 2015, 12:43 p.m., Martin Gräßlin wrote: > > effects/slidingpopups/slidingpopups.cpp, line 436 > > > > > > are you going to do the un-duplications? moved the identical part in a private function

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

2015-09-14 Thread Takahiro Hashimoto
> On 9月 14, 2015, 8:12 p.m., Aleix Pol Gonzalez wrote: > > Do you have a developer account? Otherwise I'll submit the patch for you. Yes I got it a few days ago :) I'd like to submit this by myself. Thanks again. - Takahiro --- This is

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/#review85376 --- The change for findWindow(Surface) looks good.

Re: Review Request 125120: [wip] support for the slide protocol

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/ --- (Updated Sept. 14, 2015, 12:11 p.m.) Review request for kwin, Plasma and

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/ --- (Updated Sept. 14, 2015, 12:11 p.m.) Review request for kwin, Plasma and

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

2015-09-14 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/ --- (Updated Sept. 14, 2015, 12:39 p.m.) Status -- This change has been

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

2015-09-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/#review85371 --- Ship it! Do you have a developer account? Otherwise I'll

Re: State of Plasma with Qt 5.6

2015-09-14 Thread Aleix Pol
On Tue, Sep 1, 2015 at 6:35 PM, Aleix Pol wrote: > Hi, > For reasons [1] I've had to change to Qt 5.6 today. I wanted to make > sure everyone knows what's the status, hence this e-mail. > > I've been experiencing a small issue [2] on start, so we can't expect > Plasma 5.4.0 to

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Marco Martin
> On Sept. 14, 2015, 2:16 p.m., Martin Gräßlin wrote: > > Ship It! ah, to properly work will also need https://git.reviewboard.kde.org/r/125131/ - Marco --- This is an automatically generated e-mail. To reply, visit:

minutes monday plasma hangout

2015-09-14 Thread Sebastian Kügler
Present: Bhushan, David, Kai Uwe, Marco, Martin G., Ozark, Ovidiu, sebas Date: 14 September, 2015 Bhushan: - worked on packaging telepathy bits for Plasma aarch - it have pkgbuilds but just needs creating packages in order - https://notes.kde.org/p/plasma-bugs collects David: -

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/#review85378 --- Ship it! Ship It! - Martin Gräßlin On Sept. 14, 2015,

Review Request 125223: Add support for transient to ShellSurface(Interface)

2015-09-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125223/ --- Review request for Plasma and Sebastian Kügler. Repository: kwayland

Re: Review Request 125120: support for the slide protocol

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125120/ --- (Updated Sept. 14, 2015, 2:40 p.m.) Status -- This change has been

Re: Review Request 125222: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125222/ --- (Updated Sept. 14, 2015, 3:54 p.m.) Review request for Plasma. Changes

Re: Review Request 125195: Update the GTK icon cache when installing.

2015-09-14 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125195/#review85383 --- >From packagers POV Shouldn't this be handled by packages at

Re: Review Request 125222: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125222/#review85380 --- applets/quicklaunch/package/contents/code/layout.js (line

Re: Review Request 125195: Update the GTK icon cache when installing.

2015-09-14 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125195/ --- (Updated Sept. 14, 2015, 4:10 p.m.) Status -- This change has been

Re: Review Request 125195: Update the GTK icon cache when installing.

2015-09-14 Thread Bhushan Shah
> On Sept. 14, 2015, 9:47 p.m., Bhushan Shah wrote: > > From packagers POV > > > > Shouldn't this be handled by packages at post-install time? For example > > packages already update xdg icon resource cache in post install > > > > I understand that on normal developers machine this

Re: Review Request 125222: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca
> On Sept. 14, 2015, 4:09 p.m., Marco Martin wrote: > > applets/quicklaunch/package/contents/code/layout.js, line 39 > > > > > > can you verify that if grid.count changes dinamically, this cols() gets > >

Review Request 125226: move EventForge from the desktop containment

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- Review request for KDE Frameworks, Plasma and Eike Hein. Repository:

Re: Review Request 125222: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin
> On Sept. 14, 2015, 4:09 p.m., Marco Martin wrote: > > applets/quicklaunch/package/contents/code/layout.js, line 39 > > > > > > can you verify that if grid.count changes dinamically, this cols() gets > >

Re: Review Request 125222: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125222/#review85391 --- Ship it! Ship It! - Marco Martin On Sept. 14, 2015, 3:54

Re: Review Request 125226: move EventForge from the desktop containment

2015-09-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/#review85410 --- src/qmlcontrols/kquickcontrolsaddons/eventforge.h (line 27)

Re: Review Request 125199: change KCM behavior as the ksmserver default for session restore changed

2015-09-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125199/#review85342 --- +1 - that also needs to be reflected in ksmserver? - Martin

Re: Review Request 125222: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125222/ --- (Updated Sept. 14, 2015, 5:48 p.m.) Status -- This change has been

Re: Review Request 125190: Daemonize the forked kwalletd process.

2015-09-14 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125190/ --- (Updated Sept. 14, 2015, 6:46 p.m.) Status -- This change has been

Re: Review Request 125198: by default do not restore the previous session on next login

2015-09-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125198/#review85343 --- +1 - as a note: in openSUSE users were quite angry that we

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125174/#review85351 --- Provided this gets maintained, I'm in favor of this (perhaps

Re: Review Request 125187: Stop requiring Frameworks 5.15

2015-09-14 Thread Armin K.
> On Sept. 12, 2015, 10:14 a.m., David Edmundson wrote: > > We depend on git master of frameworks in Plasma master quite often, and our > > build instructions for Plasma include frameworks. > > > > Is this causing a problem somewhere? Well, I just upgraded to newly released frameworks 5.14,

Re: Review Request 125187: Stop requiring Frameworks 5.15

2015-09-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125187/#review85353 --- -2, a change for a month in the devel branch doesn't make

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca
> On Sept. 14, 2015, 8:24 a.m., Marco Martin wrote: > > Provided this gets maintained, I'm in favor of this (perhaps in > > kdeplasma-addons instead of a main workspace feature). > > Since the behavior of a pure launcher is quite different from both a > > taskbar entry or a dock icon, so some

Re: Review Request 125187: Stop requiring Frameworks 5.15

2015-09-14 Thread David Faure
> On Sept. 14, 2015, 8:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. As you want. You're raising the bar for new contributors, who can't work on your code using the latest KDE Frameworks release. You and me might compile everything,

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin
> On Sept. 14, 2015, 8:24 a.m., Marco Martin wrote: > > Provided this gets maintained, I'm in favor of this (perhaps in > > kdeplasma-addons instead of a main workspace feature). > > Since the behavior of a pure launcher is quite different from both a > > taskbar entry or a dock icon, so some

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125174/#review85360 --- applets/quicklaunch-qml/package/contents/code/layout.js

Re: Review Request 125178: Don't fade animate icon in plasma tooltips

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125178/#review85354 --- Ship it! Ship It! - Marco Martin On Sept. 11, 2015, 9:06

Re: Review Request 125198: by default do not restore the previous session on next login

2015-09-14 Thread Marco Martin
> On Sept. 14, 2015, 6:05 a.m., Martin Gräßlin wrote: > > +1 - as a note: in openSUSE users were quite angry that we had broken > > session management, they won't be glad about the choice. My personal > > opinion is (as many probably known) that I would drop all session > > management support

Re: Review Request 125199: change KCM behavior as the ksmserver default for session restore changed

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125199/#review85357 --- Ship it! Ship It! - Marco Martin On Sept. 12, 2015, 3:36

Re: Review Request 125195: Update the GTK icon cache when installing.

2015-09-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125195/#review85358 --- Ship it! Ship It! - Marco Martin On Sept. 12, 2015, 12:45

Re: Review Request 125178: Don't fade animate icon in plasma tooltips

2015-09-14 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125178/ --- (Updated Sept. 14, 2015, 9:12 a.m.) Status -- This change has been

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-14 Thread David Rosca
> On Sept. 14, 2015, 9:35 a.m., Marco Martin wrote: > > applets/quicklaunch-qml/package/contents/code/layout.js, line 23 > > > > > > I guess the spacing here is half because it's used as margins for the > >

Re: Review Request 125187: Stop requiring Frameworks 5.15

2015-09-14 Thread Martin Gräßlin
> On Sept. 14, 2015, 10:44 a.m., Martin Gräßlin wrote: > > -2, a change for a month in the devel branch doesn't make much sense. > > David Faure wrote: > As you want. You're raising the bar for new contributors, who can't work > on your code using the latest KDE Frameworks release. >