Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

2015-11-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125892/#review87870 --- Ship it! Ship It! - David Edmundson On Nov. 2, 2015, 7:44

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

2015-11-02 Thread David Rosca
> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote: > > I don't like this change, as it introduces a magic constant for a value > > that we completely control our own. (Well, to the degree that we say "a > > gridUnit is roughly the height of a line of text". The 1.6 constant looks > >

Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

2015-11-02 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125892/ --- (Updated Nov. 2, 2015, 2:57 p.m.) Status -- This change has been

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 116 - Still Unstable!

2015-11-02 Thread Marco Martin
On Monday 02 November 2015, David Faure wrote: > On Monday 02 November 2015 12:44:12 no-re...@kde.org wrote: > > https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFOR > > M=Linux,compiler=gcc/31/ Name: (root) Failed: 1 test(s), Passed: 10 > > test(s), Skipped: 0 test(s), Total:

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

2015-11-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125006/#review87872 --- Ship it! Ship It! - Marco Martin On Nov. 2, 2015, 11:49

Re: Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets

2015-11-02 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125887/ --- (Updated Nov. 2, 2015, 1:01 p.m.) Status -- This change has been

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

2015-11-02 Thread Sebastian Kügler
> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote: > > I don't like this change, as it introduces a magic constant for a value > > that we completely control our own. (Well, to the degree that we say "a > > gridUnit is roughly the height of a line of text". The 1.6 constant looks > >

Review Request 125921: Don't rely graphic objects in panel script engine

2015-11-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125921/ --- Review request for Plasma. Repository: plasma-workspace Description

[Differential] [Closed] D409: new mobile components

2015-11-02 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. mart marked 4 inline comments as done. Closed by commit rPLASMAMOBILEd3b28119a79f: new mobile components (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D409?vs=1110=1141#toc REPOSITORY

[kio-extras] [Bug 349795] nfs kio produces "Internal error in server RPC error 3"

2015-11-02 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=349795 quentin.de...@gmail.com changed: What|Removed |Added Severity|normal |crash Version|5.3.1

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

2015-11-02 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125006/ --- (Updated Nov. 3, 2015, 6:50 a.m.) Status -- This change has been

Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

2015-11-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125892/#review87848 --- looks good to me. Not giving a ship it as I want to have at

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

2015-11-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125898/#review87850 --- Thanks for looking into it! I'm not experienced enough to do

[Differential] [Accepted] D409: new mobile components

2015-11-02 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAMOBILE plasma-mobile REVISION DETAIL https://phabricator.kde.org/D409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, Plasma:

Re: Review Request 125817: Add plugin system for Calendar events

2015-11-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/ --- (Updated Nov. 2, 2015, 6:35 p.m.) Review request for KDE Frameworks,

Re: Review Request 125817: Add plugin system for Calendar events

2015-11-02 Thread Martin Klapetek
> On Oct. 31, 2015, 2:08 a.m., David Edmundson wrote: > > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h, > > line 202 > > > > > > rather than this much docs, would it make

Review Request 125920: Fix setting alignment for panel scriptengine even if PanelView is not created yet

2015-11-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125920/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 125921: Don't rely graphic objects in panel script engine

2015-11-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125921/#review87882 --- good direction, just a little point below

Re: Review Request 125817: Add plugin system for Calendar events

2015-11-02 Thread Martin Klapetek
> On Oct. 31, 2015, 2:08 a.m., David Edmundson wrote: > > src/declarativeimports/calendar/plasmacalendarintegration/calendareventsplugin.h, > > line 180 > > > > > > I'd add a dpointer here, even though you

Re: Review Request 125920: Fix setting alignment for panel scriptengine even if PanelView is not created yet

2015-11-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125920/#review87881 --- Ship it! Ship It! - Marco Martin On Nov. 2, 2015, 4:13

Re: Review Request 125920: Fix setting alignment for panel scriptengine even if PanelView is not created yet

2015-11-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125920/ --- (Updated Nov. 2, 2015, 4:41 p.m.) Status -- This change has been

Re: Review Request 125926: [Image Wallpaper] Take into account orientation

2015-11-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125926/#review87889 --- Damn, of course, it should take the non-fitting orientation

Review Request 125926: [Image Wallpaper] Take into account orientation

2015-11-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125926/ --- Review request for Plasma. Bugs: 352555

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

2015-11-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125898/#review87859 --- applets/clipboard/contents/ui/ClipboardItemDelegate.qml

Re: Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets

2015-11-02 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125887/ --- (Updated Nov. 2, 2015, 10:11 a.m.) Review request for Plasma. Changes

Re: Review Request 125886: drkonqi: Drop KF5::WebKit dependency

2015-11-02 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125886/ --- (Updated Nov. 2, 2015, 9:42 a.m.) Status -- This change has been

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux, All, gcc - Build # 116 - Still Unstable!

2015-11-02 Thread Albert Astals Cid
El Monday 02 November 2015, a les 14:56:15, Marco Martin va escriure: > On Monday 02 November 2015, David Faure wrote: > > On Monday 02 November 2015 12:44:12 no-re...@kde.org wrote: > > > https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFO > > > R > > >

Re: Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets

2015-11-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125887/#review87862 --- Ship it! Ship It! - Martin Gräßlin On Nov. 2, 2015, 11:11

minutes monday plasma hangout

2015-11-02 Thread Sebastian Kügler
Present: sebas, bhushan, david, jens, marco, martin g, ovidiu Date: 2 Nov, 2015 Bhushan: * working on splitting screenlocker * https://git.reviewboard.kde.org/r/125892/ * https://quickgit.kde.org/?p=scratch%2Fbshah%2Fscreenlocker.git * will result in libksld, which can be linked from

Re: Review Request 125006: Add individual monitor for each cpu option for system load viewer

2015-11-02 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125006/ --- (Updated Nov. 2, 2015, 11:49 a.m.) Review request for Plasma, David

Re: minutes monday plasma hangout

2015-11-02 Thread Kai Uwe Broulik
Hi, - merged new session model and user switcher plasmoid, migrated lock screen to it (thanks Bhushan for merging) - not sure if new user switcher makes it for 5 Nov - various bug fixes (back mouse button support in Kickoff, changing applet visibility in systray) I also fixed notification

[Breeze] [Bug 351875] Some drop-down menus don't inherit the correct color value from Breeze-Dark theme.

2015-11-02 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=351875 k...@binarycharly.com changed: What|Removed |Added CC||k...@binarycharly.com --- Comment #7

Review Request 125927: Unbox QJSValue in config property map

2015-11-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125927/ --- Review request for Plasma. Repository: kdeclarative Description

Re: Review Request 125927: Unbox QJSValue in config property map

2015-11-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125927/#review87896 --- Ship it! Makes sense to me. - Aleix Pol Gonzalez On Nov.

Re: Review Request 124536: Expose immutable config options in ConfigPropertyMap

2015-11-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124536/#review87895 --- src/kdeclarative/configpropertymap.cpp (line 45)

Re: Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux, All, gcc - Build # 116 - Still Unstable!

2015-11-02 Thread David Faure
On Monday 02 November 2015 12:44:12 no-re...@kde.org wrote: > https://build.kde.org/job/frameworkintegration%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/31/ > Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), > Total: 11 test(s)Failed: TestSuite.dialognativetest Is

Re: minutes monday plasma hangout

2015-11-02 Thread Martin Graesslin
On Monday, November 2, 2015 12:54:17 PM CET Kai Uwe Broulik wrote: > Hi, > > - merged new session model and user switcher plasmoid, migrated lock screen > to it (thanks Bhushan for merging) - not sure if new user switcher makes it > for 5 Nov please note that Nov 5 is not the feature freeze, but

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

2015-11-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125773/#review87864 --- I don't like this change, as it introduces a magic constant

Re: Review Request 125773: Fix units.gridSize and theme.mSize for some fonts

2015-11-02 Thread David Rosca
> On Nov. 2, 2015, 12:05 p.m., Sebastian Kügler wrote: > > I don't like this change, as it introduces a magic constant for a value > > that we completely control our own. (Well, to the degree that we say "a > > gridUnit is roughly the height of a line of text". The 1.6 constant looks > >