[Differential] [Commented On] D797: Require user to authenticate when trying to change lock screen settings

graesslin added a comment. On X11 I agree, there is no point in this change. On Wayland there is, because on Wayland attacking the lock screen is the best way to gain user's password. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D797 EMAIL

[Differential] [Closed] D858: [server] Expose executable path in ClientConnection

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLANDaefcc51d0727: [server] Expose executable path in ClientConnection (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE

Re: Review Request 126848: Remove unused dependency in kgamma

> On Jan. 25, 2016, 2:41 p.m., Aleix Pol Gonzalez wrote: > > Such patches could go in automatically, no need to get them in a RR. Suits me fine, but some people did ask for RR in the past. - Michael --- This is an automatically

[Differential] [Request, 15 lines] D861: Port away from kdelibs4support

graesslin created this revision. graesslin added a reviewer: bshah. graesslin added a subscriber: plasma-devel. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH drop-kdelibs4support REVISION DETAIL https://phabricator.kde.org/D861 AFFECTED FILES CMakeLists.txt EMAIL PREFERENCES

Review Request 126883: Add Package::cryptographicHash(QCryptographicHash::Algorithm)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126883/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository:

Re: Review Request 126848: Remove unused dependency in kgamma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126848/#review91578 --- Ship it! Such patches could go in automatically, no need

Re: Review Request 126848: Remove unused dependency in kgamma

> On gen. 25, 2016, 3:41 p.m., Aleix Pol Gonzalez wrote: > > Such patches could go in automatically, no need to get them in a RR. > > Michael Palimaka wrote: > Suits me fine, but some people did ask for RR in the past. Ok, then keep them coming :) - Aleix

Minutes Monday Plasma Hangout

Minutes Plasma 'hangout', 25-1-2016, 12:00 CET Present: notmart, kbroulik, mgraesslin, bshah, sebas, jens kbroulik: * Unity Launcher and Application Job support for Task Manager has landed, you now get download progress in eg. Chrome/ium in task manager, as well as eg. when copying files in

[Differential] [Accepted] D861: Port away from kdelibs4support

apol accepted this revision. apol added a reviewer: apol. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH drop-kdelibs4support REVISION DETAIL https://phabricator.kde.org/D861 EMAIL PREFERENCES

[Powerdevil] [Bug 358531] New: Dual-Screen only wake up external Screen after system sleep

https://bugs.kde.org/show_bug.cgi?id=358531 Bug ID: 358531 Summary: Dual-Screen only wake up external Screen after system sleep Product: Powerdevil Version: 5.5.3 Platform: Archlinux Packages OS: Linux

[Differential] [Updated] D861: Port away from kdelibs4support

graesslin added a project: Plasma. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D861 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah Cc: plasma-devel ___

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126879/#review91586 --- Ship it! Looks good, thanks! - Martin Klapetek On Jan.

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 15, 2016, 4:04 nachm., Lamarque Souza wrote: > > kded/notification.cpp, line 56 > > > > > > It would be safer to add an inhibit to guarantee onPrepareForSleep() > > has finished before letting

Re: Review Request 126848: Remove unused dependency in kgamma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126848/ --- (Updated Jan. 25, 2016, 3:59 p.m.) Status -- This change has been

[Differential] [Commented On] D797: Require user to authenticate when trying to change lock screen settings

ahartmetz added a comment. A good rule is that if you want to protect against a security issue, you must first explain why the user is not already screwed. If a malicious app is running and can disable the screen locker (or not), the security state transition is from "the user is

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91599 --- Ship it! Looks good to me, thanks! - Martin Klapetek

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126748/#review91598 --- Ship it! Ship It! - Lamarque Souza On Jan. 15, 2016,

Re: Review Request 126748: [Plasma-NM] Don't emit connection deactivated message on suspending

> On Jan. 15, 2016, 4:04 p.m., Lamarque Souza wrote: > > kded/notification.cpp, line 56 > > > > > > It would be safer to add an inhibit to guarantee onPrepareForSleep() > > has finished before letting

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- (Updated Jan. 25, 2016, 7:48 p.m.) Review request for Plasma and Martin

Re: Review Request 126870: Tooltip animation transition in the panel decrease it performance after continous usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126870/#review91561 --- Pointing out the obvious: though shall not animate window

[Differential] [Updated] D827: Suspend/Hibernate through daemon instead of greeter

graesslin marked 3 inline comments as done. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah, Plasma, broulik Cc: plasma-devel

[Differential] [Updated, 461 lines] D827: Suspend/Hibernate through daemon instead of greeter

graesslin updated this revision to Diff 2085. graesslin added a comment. Fixed issues outlined by Kai. REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D827?vs=1980=2085 BRANCH powermanagement-daemon REVISION DETAIL

[Differential] [Accepted] D827: Suspend/Hibernate through daemon instead of greeter

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH powermanagement-daemon REVISION DETAIL https://phabricator.kde.org/D827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

> On Jan. 22, 2016, 10:33 p.m., Xuetian Weng wrote: > > pam_kwallet_init.desktop.cmake, line 7 > > > > > > Why limit to these desktop anyway? I don't see why this is necessary. > > (e.g. why not lxqt?) > > Armin

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

> On Jan. 21, 2016, 11:06 a.m., Marco Martin wrote: > > I'm in general in favor of that, mostly for the scenario we find some > > actual rendering bug in the svg rendering code, that then gets cached > > Kai Uwe Broulik wrote: > Is there a better way to store the version? I recall in

[Differential] [Request, 23 lines] D858: [server] Expose executable path in ClientConnection

graesslin created this revision. graesslin added reviewers: sebas, mart. graesslin added a subscriber: plasma-devel. REVISION SUMMARY Convenient API to get the absolute executable path for the pid. REPOSITORY rKWAYLAND KWayland BRANCH executable-path REVISION DETAIL

Re: Review Request 126851: Places data engine: Rename model role name "index" to "id"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126851/#review91568 --- Ship it! on the fence about this. it's a rename of a semi

[Differential] [Closed] D787: Properly set modality on AuthDialog

This revision was automatically updated to reflect the committed changes. Closed by commit rPOLKITKDEAGENT2abe1fe105d0: Properly set modality on AuthDialog (authored by graesslin). REPOSITORY rPOLKITKDEAGENT Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE

Re: Review Request 126642: [Theme] Take Plasma Framework version into account in theme cache

> On Jan. 21, 2016, 11:06 a.m., Marco Martin wrote: > > I'm in general in favor of that, mostly for the scenario we find some > > actual rendering bug in the svg rendering code, that then gets cached > > Kai Uwe Broulik wrote: > Is there a better way to store the version? I recall in

[Differential] [Commented On] D858: [server] Expose executable path in ClientConnection

bshah added a comment. +1, Looks good to me. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D858 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas, mart Cc: bshah, plasma-devel

[Differential] [Updated] D859: [processui] Safety checks for platform != x11

graesslin added a project: Plasma. REPOSITORY rLIBKSYSGUARD KSysguard Library REVISION DETAIL https://phabricator.kde.org/D859 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, mart, sebas Cc: plasma-devel

[Differential] [Request, 31 lines] D859: [processui] Safety checks for platform != x11

graesslin created this revision. graesslin added reviewers: mart, sebas. graesslin added a subscriber: plasma-devel. REVISION SUMMARY Starting Ksysguard on Wayland resulted in a crash as it unconditionally calls into X11. This change performs some sanity checks and hides the X11 specific

[Differential] [Accepted] D859: [processui] Safety checks for platform != x11

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rLIBKSYSGUARD KSysguard Library BRANCH fix-on-wayland REVISION DETAIL https://phabricator.kde.org/D859 EMAIL PREFERENCES

[Differential] [Accepted] D827: Suspend/Hibernate through daemon instead of greeter

broulik accepted this revision. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH powermanagement-daemon REVISION DETAIL https://phabricator.kde.org/D827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, bshah, broulik Cc: plasma-devel

[Differential] [Closed] D827: Suspend/Hibernate through daemon instead of greeter

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENLOCKERa04768901ac1: Suspend/Hibernate through daemon instead of greeter (authored by graesslin). REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE

[Differential] [Closed] D859: [processui] Safety checks for platform != x11

This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSYSGUARDb57c7ca54609: [processui] Safety checks for platform != x11 (authored by graesslin). REPOSITORY rLIBKSYSGUARD KSysguard Library CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D858: [server] Expose executable path in ClientConnection

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH executable-path REVISION DETAIL https://phabricator.kde.org/D858 EMAIL PREFERENCES