Kirigami 1.0 feedback

Hi Marco, I have spent quite a few hours on porting Subsurface-mobile to Kirigami 1.0 and playing with the new features and options. I think this is coming along nicely. Many of the new things I like, the new naming feels natural, this is really a huge step forward. But of course, if I'm writing

Review Request 127549: const

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127549/ --- Review request for KDE Frameworks and Plasma. Repository:

[Differential] [Accepted] D1283: ASCII-art output platform

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. INLINE COMMENTS backends/caca/caca_backend.cpp:57 .arg("a","b") is almost always better than .arg("a").arg("b) otherwise if a translator puts %1 in the

first attempt of Kirigami gallery for Android

Hi all, I've made a first rough attempt at a package for android of the gallery for Kirigami components, still has a lot of bugs (like all icons missing still) if someone wants to play with it over the weekend, is at http://notmart.org/misc/kirigami/QtApp-debug.apk -- Marco Martin

[Differential] [Commented On] D1283: ASCII-art output platform

ivan added a comment. You just created an excuse for NVidia not to support wayland-proper-opengl in their future driver releases. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1283 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: Review Request 127260: Experiment: cache svg icons from icon theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/ --- (Updated April 1, 2016, 4:20 p.m.) Review request for Plasma.

[Differential] [Changed Subscribers] D1289: Use default output device when changing global volume

drosca added a subscriber: plasma-devel. drosca added a project: Plasma. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1289 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc: plasma-devel,

Plasma Mobile meeting : doodle

Hello, So during Plasma 5.7 kickoff meeting it was suggested that we should have another meeting to put some more steam into Plasma mobile development, and decide on what basics we are missing. I've created a doodle with some possible dates. http://doodle.com/poll/8x983kg6s5p6hw48 We will have

[Differential] [Updated] D1231: Add Krfb interface to KWayland

graesslin added a comment. Implementation of the protocol looks good, but please see my comment on whether the interface has a correct semantic. I fear it cannot properly handle the case that the compositor produces several buffers before the client consumed them. Please also add an

Re: Review Request 127260: Experiment: cache svg icons from icon theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/#review94188 --- Ok, I think I'm happy. Latest diff has missed out the new

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 8 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/8/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 01 Apr 2016 14:24:33 + Build duration: 16 min CHANGE SET Revision

[ksysguard] [Bug 361281] New: migrate away from qtwebkit (gui)

https://bugs.kde.org/show_bug.cgi?id=361281 Bug ID: 361281 Summary: migrate away from qtwebkit (gui) Product: ksysguard Version: 5.6.1 Platform: Other OS: Linux Status: UNCONFIRMED Severity: wishlist

[Differential] [Closed] D1279: Add a template for Weather Ion dataengines

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe3a8bc4f6efd: Add a template for Weather Ion dataengines (authored by kossebau). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D1279: Add a template for Weather Ion dataengines

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH iontemplate REVISION DETAIL https://phabricator.kde.org/D1279 EMAIL PREFERENCES

Re: remove khelpcenter from next Plasma release?

Hi Yuri, On Wednesday, March 09, 2016 06:37:09 PM Yuri Chornoivan wrote: > Yes. That's what I meant. > > But generally, I cannot say that I like the way the things are going. The > UserBase project does not have significant updates on applications pages > (although it was claimed that users

Re: Review Request 127260: Experiment: cache svg icons from icon theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/#review94185 --- still wondering about if it could make sense having instead

Re: Review Request 127260: Experiment: cache svg icons from icon theme

> On March 31, 2016, 3:34 p.m., David Edmundson wrote: > > src/plasma/svg.cpp, line 233 > > > > > > Don't we need someone to call discardCache somewhere if the icon > > changes? > > (in other words,

Re: Review Request 127260: Experiment: cache svg icons from icon theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/ --- (Updated April 1, 2016, 1:19 p.m.) Review request for Plasma. Changes

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

https://bugs.kde.org/show_bug.cgi?id=358957 --- Comment #8 from Bas Zoetekouw --- I like the idea of using "suspend to disk/mem/both", although I'm not sure what the best UI is to express this choice (using a dropdown with the three options, or using two checkboxes). In any

[Differential] [Commented On] D1283: ASCII-art output platform

graesslin added a comment. F102841: Spectacle.C19902.png kwin_wayland rendering glxgears on the ascii art output REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1283 EMAIL PREFERENCES

[Differential] [Request, 397 lines] D1283: ASCII-art output platform

graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY A new platform: render to ascii art output. It's based on libcaca which is now an optional dependency to KWin. To run use:

[Differential] [Updated] D1279: Add a template for Weather Ion dataengines

apol added a comment. LGTM REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1279 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, apol Cc: plasma-devel, sebas

Re: Review Request 127260: Experiment: cache svg icons from icon theme

> On March 31, 2016, 3:34 p.m., David Edmundson wrote: > > autotests/themetest.cpp, line 71 > > > > > > We need to test the cache aspect of everything, as that's really the > > entire point. > > > > >

Re: Review Request 127260: Experiment: cache svg icons from icon theme

> On March 31, 2016, 3:34 p.m., David Edmundson wrote: > > src/plasma/svg.cpp, line 229 > > > > > > I added a debug line in here, and got nothing in plasmashell actually > > enters here. (the test does though)

Re: Review Request 127498: Cleanup warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127498/ --- (Updated April 1, 2016, 8:47 a.m.) Status -- This change has been

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/ --- (Updated April 1, 2016, 11:47 a.m.) Status -- This change has been

Re: Review Request 127485: KCM: Add button to set default devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127485/ --- (Updated April 1, 2016, 8:47 a.m.) Status -- This change has been

Re: Review Request 127507: VolumeObject: Add channels and channelVolumes properties

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127507/ --- (Updated April 1, 2016, 11:47 a.m.) Status -- This change has been

Re: Review Request 127487: Fix bindings in KCM MuteButton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127487/ --- (Updated April 1, 2016, 11:47 a.m.) Status -- This change has been

[Differential] [Updated] D1282: Subcompositor support in KWin

graesslin added dependencies: D1281: [server] Add damage tracking feature to SurfaceInterface, D1261: [server] Don't emit unmapped if the Surface wasn't mapped, D1250: [server] Workaround for QtWayland bug https://bugreports.qt.io/browse/QTBUG-52192. REPOSITORY rKWIN KWin REVISION DETAIL

[Differential] [Updated] D1261: [server] Don't emit unmapped if the Surface wasn't mapped

graesslin added a dependent revision: D1282: Subcompositor support in KWin. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1261 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas

[Differential] [Updated] D1281: [server] Add damage tracking feature to SurfaceInterface

graesslin added a dependent revision: D1282: Subcompositor support in KWin. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1281 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas

[Differential] [Updated] D1250: [server] Workaround for QtWayland bug https://bugreports.qt.io/browse/QTBUG-52192

graesslin added a dependent revision: D1282: Subcompositor support in KWin. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1250 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, sebas

[Differential] [Updated] D1282: Subcompositor support in KWin

graesslin retitled this revision from "Consider change in sub-surface tree as a full damage" to "Subcompositor support in KWin". REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1282 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 299 lines] D1282: Consider change in sub-surface tree as a full damage

graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY A sub-surface changed in a way which needs a repaint. Of course only if the surface is mapped. Make Scene::Window::window() and

[Differential] [Closed] D1271: Use a QTabWidget for the different modes in DebugConsole

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN90b9b08d7acd: Use a QTabWidget for the different modes in DebugConsole (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1271?vs=3041=3054

Re: Review Request 127540: [plasma-pa] Don't show virtual streams which aren't displayed correctly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127540/#review94176 --- Thanks for the patch, but I don't really think we need

Re: Review Request 127485: KCM: Add button to set default devices

> On March 24, 2016, 9:37 p.m., Kai Uwe Broulik wrote: > > I like the RadioButton but it should say "Default" or "Default Device" (if > > we could depend on Qt 5.7 we could also add a tooltip explaining what that > > means... :/ ) > > > > Can you perhaps also have a look at the OSD/volume

[Differential] [Request, 107 lines] D1281: [server] Add damage tracking feature to SurfaceInterface

graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This change introduces a damage tracking feature in SurfaceInterface. So far the SurfaceInterface only exposes the damage compared to

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

> On March 25, 2016, 7:24 p.m., Thomas Pfeiffer wrote: > > Two questions: > > 1. If there is only one device, are the comoboxes hidden (they should be)? > > 2. If I change the default device, are all streams automatically switched > > to that device? > > David Rosca wrote: > 1. Yes >