This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE30b7e3f2423b: DesktopView: Don't call
ensureWindowType on FocusIn event (authored by drosca).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2121?vs=5026&id=5888#toc
REPOSITORY
rP
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/
---
(Updated Авг. 13, 2016, 8:17 преди обяд)
Review request for kwin, Plasma,
> On Авг. 12, 2016, 2:31 след обяд, Martin Gräßlin wrote:
> > Could someone please test, whether this works?
> >
> > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
> > index 14a25af..38c6621 100644
> > --- a/shell/desktopview.cpp
> > +++ b/shell/desktopview.cpp
> >
Thank you, I didn't realize ECM was connected to KDE. That connection
was good. Running this command solved the problem:
$ sudo apt install extra-cmake-modules
Which made it available in /usr/share/ECM/toolchain/Android.cmake
And now I also had to add a switch to cmake:
-DANDROID_NDK=...
How
Am 2016-08-12 19:36, schrieb Marco Martin:
On Friday 12 August 2016 16:11:50 Martin Graesslin wrote:
Credits!
Credits go to Kai for complaining about screenedges on X11 stealing
mouse
clicks while I was fixing a bug in the XInput2 polling code which made
me
realize that we can raw events for
On Friday 12 August 2016 16:11:50 Martin Graesslin wrote:
> Credits!
> Credits go to Kai for complaining about screenedges on X11 stealing mouse
> clicks while I was fixing a bug in the XInput2 polling code which made me
> realize that we can raw events for way more than just mouse position
> track
Hi,
glad that you find Kirigami interesting!
Admittedly, we're not very used to our frameworks being used by people with no
prior KDE experience, so yes, we should provide more instructions there.
ECM stands for Extra CMake Modules. Our wiki [1] explains where to get them (if
you are using L
On Friday 12 August 2016 18:06:00 Police Terror wrote:
> Hello,
>
> I'm excited by the slick looking Kirigami and the possibility of
> building applications to deploy on Linux, Android, and Windows with
> C++.
>
> Unfortunately the documentation is very sparse!
>
> The GitHub says:
>
> cmake ..
On 05/08/16 15:06, Sebastian Kügler wrote:
> On dinsdag 2 augustus 2016 02:35:30 CEST Aleix Pol wrote:
>> On Mon, Aug 1, 2016 at 12:19 PM, Eike Hein wrote:
>>> On 07/28/2016 07:11 PM, Jonathan Riddell wrote:
There's also the issue that if we move for one distro we'll end up
with accusati
Hello,
I'm excited by the slick looking Kirigami and the possibility of
building applications to deploy on Linux, Android, and Windows with C++.
Unfortunately the documentation is very sparse!
The GitHub says:
cmake ..
-DCMAKE_TOOLCHAIN_FILE=/path/to/share/ECM/toolchain/Android.cmake -DQT
ANDRO
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When changing some setting and
> On Aug. 12, 2016, 1:31 p.m., Martin Gräßlin wrote:
> > Could someone please test, whether this works?
> >
> > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
> > index 14a25af..38c6621 100644
> > --- a/shell/desktopview.cpp
> > +++ b/shell/desktopview.cpp
> > @@
> On Aug. 12, 2016, 11:31 vorm., Martin Gräßlin wrote:
> > Could someone please test, whether this works?
> >
> > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
> > index 14a25af..38c6621 100644
> > --- a/shell/desktopview.cpp
> > +++ b/shell/desktopview.cpp
> > @
> On Авг. 12, 2016, 2:31 след обяд, Martin Gräßlin wrote:
> > Could someone please test, whether this works?
> >
> > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
> > index 14a25af..38c6621 100644
> > --- a/shell/desktopview.cpp
> > +++ b/shell/desktopview.cpp
> >
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This way the shortcut cat
> On Aug. 12, 2016, 1:31 p.m., Martin Gräßlin wrote:
> > Could someone please test, whether this works?
> >
> > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
> > index 14a25af..38c6621 100644
> > --- a/shell/desktopview.cpp
> > +++ b/shell/desktopview.cpp
> > @@
Hi Plasma devs,
I just created an RFC-phab request: https://phabricator.kde.org/D2425
This implements modifier-only global shortcuts on X11 reusing KWin's internal
architecture written for Wayland.
What I want to know is whether it's worth something to follow up. We know that
this is a feature
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
ksmserver-logout-greeter-per-screen
REVISION DETAIL
https://phabricator.kde.org/D2264
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128475/
---
(Updated Aug. 12, 2016, 2:02 p.m.)
Status
--
This change has been ma
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/332/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 12 Aug 2016 13:36:45 +
Build duration: 14 min
CHANGE SET
Revision 49fa60258391ab322b7118943bb8b3b692c
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/332/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 12 Aug 2016 13:36:45 +
Build duration: 14 min
CHANGE SET
Revision 49fa60258391ab322b7118943bb8b3b692c
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/331/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 12 Aug 2016 13:33:04 +
Build duration: 2 min 19 sec
CHANGE SET
Revision 9413404fb29e6f57ac85a86453647
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE9413404fb29e: Share logic for passing
AbstractTasksModelIface methods to source model (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2381?vs=5795&id=587
> On Авг. 12, 2016, 2:31 след обяд, Martin Gräßlin wrote:
> > Could someone please test, whether this works?
> >
> > diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
> > index 14a25af..38c6621 100644
> > --- a/shell/desktopview.cpp
> > +++ b/shell/desktopview.cpp
> >
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2121
EMAIL PREFERENCES
https://phabricator.kde.org/settings/p
drosca added a comment.
In https://phabricator.kde.org/D2121#45267, @graesslin wrote:
> Patch for setting through surface event:
No, that doesn't help, nor does calling ensureWindowType in QEvent::Expose.
As it is now, calling ensureWindowType in QEvent::FocusIn is pointless (
graesslin added a comment.
Patch for setting through surface event:
diff --git a/shell/desktopview.cpp b/shell/desktopview.cpp
index 14a25af..38c6621 100644
--- a/shell/desktopview.cpp
+++ b/shell/desktopview.cpp
@@ -226,6 +226,7 @@ bool DesktopView::event(QEvent *e)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98334
---
Could someone please test, whether this works?
diff --gi
> On Авг. 12, 2016, 2:05 след обяд, Anthony Fieroni wrote:
> > I can't see bug in Qt implementaion of setFlags
> > https://code.woboq.org/qt5/qtbase/src/plugins/platforms/xcb/qxcbwindow.cpp.html#1130
> > xcb plugin bug?
>
> Thomas Lübking wrote:
> Afaik the entire thing operates on an undoc
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Qt already did the right
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This flips the tooltip wh
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128662/
---
Review request for Plasma.
Repository: plasma-framework
Description
---
> On Aug. 12, 2016, 11:05 vorm., Anthony Fieroni wrote:
> > I can't see bug in Qt implementaion of setFlags
> > https://code.woboq.org/qt5/qtbase/src/plugins/platforms/xcb/qxcbwindow.cpp.html#1130
> > xcb plugin bug?
Afaik the entire thing operates on an undocumented string property to carry th
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
X and Y coordinates are not mi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128038/#review98331
---
Ping
- Anthony Fieroni
On Авг. 9, 2016, 8:25 след обяд, An
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128647/#review98330
---
I can't see bug in Qt implementaion of setFlags
https://code
davidedmundson abandoned this revision.
davidedmundson added a comment.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1946
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: hein, pl
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP56a21fe0ec12: [Task Manager] Allow dropping
files onto tasks (authored by broulik).
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2392?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE4a8877bab222: [Libtaskmanager] Add
"requestOpenUrls" to open given URLs with the associated… (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2391?vs=5863&id=586
hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2391
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: brou
hein accepted this revision.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2392
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma:_design, #plasma, hein
Cc: hein, plasma-devel, lesliezhai, ali-mohame
hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2392
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik,
broulik updated this revision to Diff 5865.
broulik added a comment.
- Fix comments punctuation
- Use JS every() and forEach() instead of hand-rolled loops
- Check hoveredItem before accessing it
Did not change the QUrl validation as that's been like this before and I
don't know how t
broulik updated this revision to Diff 5863.
broulik added a comment.
- Throw a bunch of full stops at the code
- Remove copy-paste error about base impl that does nothing
- Use KWindowSystem::isPlatformX11
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE9b546d9310f6: [Containment Actions
ContextMenu] Port to KGlobalAccel::globalShortcut() (authored by broulik).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
http
hein added inline comments.
INLINE COMMENTS
> main.qml:247
> +onUrlsDropped: {
> +// if all dropped URLs point to application desktop files, we'll
> add a launcher for each of them
> +var createLaunchers = true;
I know this is nitpicky, but could you make sure co
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOPb2f7422862d8: [Task Manager ToolTipDelegate] If
there's room, show two lines of window title (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D2404?vs=5824&id=5861#
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAPHONECOMPONENTSb536182f01ae: Remove clone of battery
monitor from plasma-phone-components (authored by bshah).
REPOSITORY
rPLASMAPHONECOMPONENTS plasma-phone-components
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE030dc1f566f4: [applets] Show battery monitor
on all platforms and not just desktop (authored by bshah).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://ph
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128660/#review98328
---
Sorry, found two issues.
src/declarativeimports/plasmacompo
hein added inline comments.
INLINE COMMENTS
> broulik wrote in Task.qml:390
> Should we perhaps keep the Loader for optimizing the icon-tasks case, or does
> that introduce too much overhead/code maintenance?
I think it's a wash. If we add the Loader, we have an extra QObject, an extra
QML fil
hein added a comment.
Needs merge coordination with https://phabricator.kde.org/D2381
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2391
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc:
hein accepted this revision.
hein added a reviewer: hein.
hein added a comment.
This revision is now accepted and ready to land.
Needs merge coordination with https://phabricator.kde.org/D2391
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricato
hein added inline comments.
INLINE COMMENTS
> abstracttasksmodel.h:119
> + * Requests to open the given URLs with the application backing the task
> + * at the given index
> + *
Missing period, also elsewhere
> abstracttasksmodel.h:121
> + *
> + * The base implementation doe
hein accepted this revision.
hein added a reviewer: hein.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D2404
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik,
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2416
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefere
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128660/#review98326
---
Fix it, then Ship it!
Neat.
Some minor nitpicks below.
A
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
show-battery-on-phone (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D2412
EMAIL PREFERENCES
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAPHONECOMPONENTS plasma-phone-components
BRANCH
use-normal-batterymonitor
REVISION DETAIL
https://phabricator.kde.org/D2411
EMAIL PREFERENCES
https:
This revision was automatically updated to reflect the committed changes.
Closed by commit rPOWERDEVIL567c25786113: [backlight helper] Support setting
backlight through leds subclass (authored by bshah).
REPOSITORY
rPOWERDEVIL Powerdevil
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/
hein added a comment.
David, can you close/abandon this? Window geo is in libtm these days.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1946
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rPOWERDEVIL Powerdevil
BRANCH
add-led-brightness-support (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D2419
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emai
bshah updated this revision to Diff 5857.
bshah marked 3 inline comments as done.
bshah added a comment.
- use constFirst instead of first
- prefer led backlights first if available
- simplify QStringLiteral
REPOSITORY
rPOWERDEVIL Powerdevil
CHANGES SINCE LAST UPDATE
https://phabricat
broulik added a comment.
Fixes:
- Bug 346050: No subpixel rendering in task manager
- Bug 360119: Task manager text is blurry
and because we no longer have a shadow to begin with:
- Bug 357242: se theme-defined color for task label shadow
INLINE COMMENTS
> Task.qml:390
>
>
broulik added inline comments.
INLINE COMMENTS
> backlighthelper.cpp:102
> +ledsFilters << QStringLiteral("*lcd*") << QStringLiteral("*wled*");
> +ledsDir.setNameFilters(ledsFilters);
> +
You could simplify this to ledsDir.setNameFilters({QStringLiteral("*lcd*"),
QStringLiteral("*wled*"
bshah added inline comments.
INLINE COMMENTS
> backlighthelper.cpp:121-124
> +if (!ledInterfaces.isEmpty()) {
> +m_dirname = LED_SYSFS_PATH + ledInterfaces.first();
> return;
> }
Still, Due to ledInterfaces being last this won't work on Nexus 5 I fear,
mostly because i
bshah created this revision.
bshah added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Some devices uses simple leds to provide the backlight to display, one
such example is Nexus 5, which u
hein created this revision.
hein added reviewers: Plasma, broulik.
hein added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.
REVISION SUMMARY
After https://phabricator.kde.org/D2281 set the stage, this change drops the
C++ label in favor
of the PlasmaComponents-ba
broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Implements the FIXME ther
broulik updated the summary for this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2416
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jens
70 matches
Mail list logo
