[Differential] [Closed] D3095: Implement cursor shape tracking on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN5b9da55e75e1: Implement cursor shape tracking on Wayland (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3095?vs=7499=7558 REVISION DETAIL

[Differential] [Closed] D3093: Add a PlatformCursorImage to Platform and EffectsHandler

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINea52ef9e572b: Add a PlatformCursorImage to Platform and EffectsHandler (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3093?vs=7491=7557

Re: Review Request 129230: Count only applications in memory usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129230/ --- (Updated Oct. 19, 2016, 10:07 p.m.) Status -- This change has been

[Differential] [Request, 237 lines] D3117: allow changing an output's modelist at runtimeThis should fix running Plasma in a windowed virtual machine, when the window is resized, the mode list changes

sebas created this revision. sebas added a reviewer: Plasma. sebas added a subscriber: graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY - make Output::modes() non CONSTANT, add modesChanged() signal - compare

Re: Review Request 129230: Count only applications in memory usage

> On Oct. 19, 2016, 8:45 p.m., David Edmundson wrote: > > Thanks > > > > Do you have commit access? > > Also there's a bug report on this that should be closed with this commit. I don't have commit access. Do you mean bug #366342 ? - Miklós

Re: Review Request 129230: Count only applications in memory usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129230/#review100147 --- Ship it! Thanks Do you have commit access? Also there's

Review Request 129230: Count only applications in memory usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129230/ --- Review request for Plasma. Repository: kdeplasma-addons Description

[Differential] [Closed] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP05c3125cd831: Launchers set new bool in plasma-frameworks to toggle expanded (authored by subdiff). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129204/ --- (Updated Oct. 19, 2016, 7:09 p.m.) Status -- This change has been

[Differential] [Accepted] D3114: [Session Model] Show new session entry only if we actually can

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3114 EMAIL PREFERENCES

[Differential] [Request, 4 lines] D3114: [Session Model] Show new session entry only if we actually can

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When canStartNewSession

[Differential] [Updated] D3085: RFC: Use DBusMenu if available

broulik updated the test plan for this revision. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3085 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: graesslin,

[Differential] [Updated, 1,622 lines] D3085: RFC: Use DBusMenu if available

broulik updated the summary for this revision. broulik updated the test plan for this revision. broulik updated this revision to Diff 7549. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3085?vs=7457=7549

[Differential] [Accepted] D3093: Add a PlatformCursorImage to Platform and EffectsHandler

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH platform-cursor-image REVISION DETAIL https://phabricator.kde.org/D3093 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D3095: Implement cursor shape tracking on Wayland

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH cursor-tracking-wayland REVISION DETAIL https://phabricator.kde.org/D3095 EMAIL PREFERENCES

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

ivan added inline comments. INLINE COMMENTS > broulik wrote in ContextMenu.qml:413 > Imho this should be a regular function() like the others I didn't want to pollute the outside world - it should be as efficient as if it was a regular function (if qt jit is sane - it could even be inlined).

[Differential] [Updated, 87 lines] D3106: Replaced the launcher pinning action with a per-activity meny

ivan updated this revision to Diff 7548. ivan marked 3 inline comments as done. ivan added a comment. - Created a special case for when there is only one activity REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3106?vs=7525=7548 BRANCH

[Differential] [Accepted] D3113: Pass transient parent window to KToolTipWindow

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKINFOCENTER KInfoCenter BRANCH wayland-fix-tooltips REVISION DETAIL https://phabricator.kde.org/D3113 EMAIL PREFERENCES

[Differential] [Accepted] D3079: Adapt Dashboard: Connect to new toggled signal instead of activated signal in order to initiate state change

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3079 EMAIL PREFERENCES

[Differential] [Request, 22 lines] D3113: Pass transient parent window to KToolTipWindow

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes tooltips on Wayland. We need the relationship to the transient parent window - tooltips are

[Differential] [Accepted] D3112: Pass transient parent window to KToolTipWindow

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rSYSTEMSETTINGS System Settings BRANCH wayland-fix-tooltips REVISION DETAIL https://phabricator.kde.org/D3112 EMAIL PREFERENCES

[Differential] [Request, 22 lines] D3112: Pass transient parent window to KToolTipWindow

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes tooltips on Wayland. We need the relationship to the transient parent window - tooltips are

[Differential] [Updated] D3112: Pass transient parent window to KToolTipWindow

graesslin added a reviewer: bcooksley. REPOSITORY rSYSTEMSETTINGS System Settings REVISION DETAIL https://phabricator.kde.org/D3112 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, bcooksley Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

broulik added a comment. >> probably in that case there should be the simple "add launcher when not running" > > Yes, and adding to all activities would be the smartest choice I'd say. +1 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

ivan added a comment. > probably in that case there should be the simple "add launcher when not running" Yes, and adding to all activities would be the smartest choice I'd say. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3106 EMAIL

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 519 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/519/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 19 Oct 2016 11:04:38 + Build duration: 15 min CHANGE SET Revision

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

graesslin added a comment. Trying to apply the patch results in conflicts in autotests/CMakeLists.txt Trying to compile nevertheless without autotests gives me a compile error: /home/martin/src/kf5/kde/workspace/plasma-integration/src/platformtheme/kdeplatformtheme.cpp:47:36:

[Differential] [Closed] D3100: Expose GLRenderTarget::virtualScreenGeometry

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINf4627e38f182: Expose GLRenderTarget::virtualScreenGeometry (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3100?vs=7510=7544 REVISION DETAIL

[Differential] [Closed] D3101: Adjust blur and contrast for multi-output rendering on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINbef9c9c8c589: Adjust blur and contrast for multi-output rendering on Wayland (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3099: Fix viewport restore in GLRenderTarget::popRenderTarget

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN1708278a451e: Fix viewport restore in GLRenderTarget::popRenderTarget (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3099?vs=7509=7543

[Differential] [Closed] D3109: [shell] Create panelshadow in surfacecreated event instead of show event

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE59733c21a4bb: [shell] Create panelshadow in surfacecreated event instead of show event (authored by graesslin). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D3099: Fix viewport restore in GLRenderTarget::popRenderTarget

graesslin added inline comments. INLINE COMMENTS > broulik wrote in kwinglutils.cpp:1181 > I don't understand the maths, why is the "x" the negative > virtualScreenGeometry and "y" some formula? OpenGL has a different coordinate system. The 0/0 is on the bottom left corner unlike our own

[Differential] [Changed Subscribers] D3099: Fix viewport restore in GLRenderTarget::popRenderTarget

broulik added inline comments. INLINE COMMENTS > kwinglutils.cpp:1181 > } else { > -glViewport (0, 0, s_virtualScreenSize.width(), > s_virtualScreenSize.height()); > +glViewport (-s_virtualScreenGeometry.x(), > s_virtualScreenGeometry.height() -

[Differential] [Accepted] D3099: Fix viewport restore in GLRenderTarget::popRenderTarget

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH render-target-viewport REVISION DETAIL https://phabricator.kde.org/D3099 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D3102: Do not ask for root permissions when it's unnecessary

mart added inline comments. INLINE COMMENTS > accountmodel.cpp:165 > > -m_dbus->UncacheUser(acc->userName()).waitForFinished(); > -m_dbus->CacheUser(acc->userName()); is there absolutely nothing left needing this? REPOSITORY rUSERMANAGER User Manager REVISION

Re: Review Request 129204: Add toggle signal for applet de-/activation in order to fix non-closing launchers on Meta (and also on Active Screenedges)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129204/#review100131 --- Ship it! Ship It! - Marco Martin On Oct. 18, 2016,

[Differential] [Updated] D3106: Replaced the launcher pinning action with a per-activity meny

mart added a comment. In https://phabricator.kde.org/D3106#57642, @broulik wrote: > What happens if there is only one activity? I don't use activities and I don't want a complicated submenu for pinning applications in this case. probably in that case there should be the simple

[Differential] [Commented On] D3109: [shell] Create panelshadow in surfacecreated event instead of show event

graesslin added a comment. In https://phabricator.kde.org/D3109#57649, @broulik wrote: > Works on X11 as well. > > plasma-frameworks dialog probably also needs this treatment (also does it in showEvent) for whatever reason it works with dialogs *shrug* REPOSITORY

Re: KCM for network configuration

On 10/13/2016 10:57 AM, Jan Grulich wrote: > So what do you think? > > [1] - https://jgrulich.fedorapeople.org/kcm_network.png Awesome, really nice! A few nitpicks: * a little bit more vertical space between the controls * the checkbox needs a label like "[ ] Enable" or better "Visibility: [

Re: KCM for network configuration

Am Donnerstag, 13. Oktober 2016, 16:03:51 CEST schrieb Heiko Tietze: > On 10/13/2016 10:57 AM, Jan Grulich wrote: > > So what do you think? > > > > [1] - https://jgrulich.fedorapeople.org/kcm_network.png > > Awesome, really nice! > > A few nitpicks: > * a little bit more vertical space between

[Differential] [Commented On] D3106: Replaced the launcher pinning action with a per-activity meny

broulik added a comment. What happens if there is only one activity? I don't use activities and I don't want a complicated submenu for pinning applications in this case. INLINE COMMENTS > ContextMenu.qml:413 > + > +var createNewItem = function(id, title, url, activities) { >

[Differential] [Accepted] D3109: [shell] Create panelshadow in surfacecreated event instead of show event

broulik accepted this revision. broulik added a reviewer: broulik. broulik added a comment. This revision is now accepted and ready to land. Works on X11 as well. plasma-frameworks dialog probably also needs this treatment (also does it in showEvent) REPOSITORY rPLASMAWORKSPACE Plasma

Re: Breakout: UI and user vision for cloud services

On Wed, Oct 19, 2016 at 5:17 AM, Martin Klapetek wrote: > On Mon, Oct 17, 2016 at 12:54 PM, Jonathan Riddell wrote: >> >> * Services integration - I see more and more users who have >> data locked up in clouds (GDrive, etc.) and rely on accessing it

[Differential] [Request, 2 lines] D3109: [shell] Create panelshadow in surfacecreated event instead of show event

graesslin created this revision. graesslin added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In the show event the Wayland implementation does not pick up the shadow at all. BUG: 368885