Re: Plasma Mobile: Nexus 5 / Multirom

2016-11-03 Thread Bhushan Shah
Hello, On Thu, Nov 03, 2016 at 01:41:58PM +0100, Tobias Girstmair wrote: > Using pm-flashtool/flash-multirom, it sucessfully downloads, pushes and > extracts the archives to the phone, but (both the patched and original) > MultiRom Manager and TWRP recovery can't see it. Can you tell me which

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-03 Thread colomar (Thomas Pfeiffer)
colomar added a comment. If I understood it correctly (that there is only a checkbox "Only show full scrollbar on mouse over" added to the config) then that is exactly what I had in mind. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3210 EMAIL PREFERENCES

[Differential] [Commented On] D3085: RFC: Use DBusMenu if available

2016-11-03 Thread dmitryshachnev (Dmitry Shachnev)
dmitryshachnev added a comment. > in KXMLGui applications you still get a traditional menu bar in addition to the global menu, it seems it explicitly sets visible true on the menu bar - in VLC it hides its own menu bar. This will be fixed in Qt 5.7.1, see this commit

[Differential] [Closed] D3220: Introduce new pre-layout script hook

2016-11-03 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb9760e852042: Introduce new pre-layout script hook (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3247: Invert the scroll direction for wheel events on internal windows

2016-11-03 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Verified that horizontal scrolling also scrolls correctly (dragged one TreeWidget colum super wide to have it scroll) REPOSITORY rKWIN KWin BRANCH

[Differential] [Accepted] D3244: Internal windows cannot be minimized

2016-11-03 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH internal-window-non-minimize-5.8 REVISION DETAIL https://phabricator.kde.org/D3244 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated, 92 lines] D3210: make scrollbar size configurable

2016-11-03 Thread mart (Marco Martin)
mart updated this revision to Diff 7870. mart added a comment. - make the scrollbar size config a simple checkbox REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3210?vs=7783=7870 BRANCH arcpatch-D3210 REVISION DETAIL

[Differential] [Updated, 3 lines] D3231: [Lock Screen] Show "Switch User" button only if allowed

2016-11-03 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 7866. broulik added a comment. Take into account canSwitchUser REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3231?vs=7834=7866 REVISION DETAIL https://phabricator.kde.org/D3231 AFFECTED FILES

[Differential] [Closed] D3232: [Lock Screen] Don't assume last user is "New Session" entry

2016-11-03 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd1133288c335: [Lock Screen] Don't assume last user is "New Session" entry (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Affenfels: Plasma Sprint 6-12 Feb 2017

2016-11-03 Thread Jonathan Riddell
Come one and all and sign up for the Plasma Sprint, 6-12 Feb 2017 in Stuttgart. https://community.kde.org/Plasma/Affenfels https://reimbursements.kde.org/events/25 Includes the option of a road trip from FOSDEM if you're going to both. Jonathan

[Differential] [Commented On] D3247: Invert the scroll direction for wheel events on internal windows

2016-11-03 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D3247#60362, @broulik wrote: > How does that affect horizontal scrolling? The same: as we multiple by -1 it's also corrected now. Though I admit to not have tested it (yet) > Also, does that already take into account

Re: Review Request 129321: Don't redeclare signal and then not use it anyway

2016-11-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129321/#review100538 --- Ship it! Ship It! - Marco Martin On Nov. 3, 2016,

[Differential] [Request, 26 lines] D3250: Use Plasma tooling for installing plasmoids

2016-11-03 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Uses plasma_install_package() instead of doing it separately TEST PLAN still works REPOSITORY

[Differential] [Request, 14 lines] D3249: Use our tooling for installing plasmoids

2016-11-03 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY use kpackage/plasma macros to install the files. This way we get all the features provided by the macro.

Review Request 129321: Don't redeclare signal and then not use it anyway

2016-11-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129321/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 128793: [kio_mtp] Improve warning message

2016-11-03 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128793/ --- (Updated Nov. 3, 2016, 1:21 p.m.) Status -- This change has been

[Differential] [Updated] D3247: Invert the scroll direction for wheel events on internal windows

2016-11-03 Thread broulik (Kai Uwe Broulik)
broulik added a comment. How does that affect horizontal scrolling? Also, does that already take into account scroll direction "natural"/normal (or was that maybe the case for it being wrong in the first place?)? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3247

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-03 Thread hpereiradacosta (Hugo Pereira Da Costa)
hpereiradacosta added a comment. > personally, (and would be good if thomas, jens or alex from the cdg weigh on that) I would have the default as: > > - small scrollbar > - show on mouseover enabled > - no arrow buttons +1 on this. Been using this setup for few days now

Re: Review Request 129315: Don't install plasmoid desktop files as services

2016-11-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129315/#review100537 --- I'm in favor of this, let's wait to 5.29 tough - Marco

Plasma Mobile: Nexus 5 / Multirom

2016-11-03 Thread Tobias Girstmair
Hi, I tried to install Plasma Mobile using both of these methods: * https://community.kde.org/Plasma/Mobile/MultiROM * https://plasma-mobile.org/multirom/ However, I failed. Using the patched MultiRom Manager (downloading from http://kubuntu.plasma-mobile.org/pool/), it fails with

[Differential] [Request, 4 lines] D3247: Invert the scroll direction for wheel events on internal windows

2016-11-03 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, broulik. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY For whatever reason Qt scrolled the wrong way on internal

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-03 Thread mart (Marco Martin)
mart added a comment. In https://phabricator.kde.org/D3210#60230, @hpereiradacosta wrote: > So, just to make sure I understand: > > - 1 option to "only show full scrollbar on mouse over" (as we have now) > - 1 option to "use slim scrollbar" (with reduced width handle) Is that what

[Differential] [Updated] D3242: Add an option to context menu to launch the application on a discrete graphics card

2016-11-03 Thread hein (Eike Hein)
hein added a comment. I'm not sure this is the right approach. If we add this to Kicker, it won't work in any of these other ways to launch an app: - KRunner - "Start New Instance" in the Task Manager - The Icon applet in the panel or on the desktop - The menu desktop containment

[Differential] [Accepted] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

2016-11-03 Thread hpereiradacosta (Hugo Pereira Da Costa)
hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. ship-it REPOSITORY rBREEZE Breeze BRANCH unpolish-app-5.8 REVISION DETAIL https://phabricator.kde.org/D3240 EMAIL PREFERENCES

[Differential] [Updated, 22 lines] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

2016-11-03 Thread Martin Gräßlin
graesslin updated this revision to Diff 7858. graesslin added a comment. Implement a private cleanup method invoked by dtor and unpolish REPOSITORY rBREEZE Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3240?vs=7849=7858 BRANCH unpolish-app-5.8 REVISION DETAIL

Stepping down as KGlobalAccel maintainer

2016-11-03 Thread Martin Graesslin
Hi frameworks developers, I decided to step down as the maintainer of KGlobalAccel. I haven't done any work on KGlobalAccel this year and bug reports just linger. A big problem for me maintaining KGlobalAccel is that most work is needed in the X11 implementation. As I no longer use X11 and

[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

2016-11-03 Thread hpereiradacosta (Hugo Pereira Da Costa)
hpereiradacosta added a comment. > I don't like calling virtual methods from a dtor, always a mess. agreed > But we can do a private cleanup method and call it from both dtor and unpolish. Would that be OK to you? yes REPOSITORY rBREEZE Breeze REVISION DETAIL

[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

2016-11-03 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D3240#60309, @hpereiradacosta wrote: > > For the general case you are right. Unpolish is only called from QApplication::setStyle when the old style gets destroyed. On Application tear-down it's not called. > > To be honest, I

[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

2016-11-03 Thread hpereiradacosta (Hugo Pereira Da Costa)
hpereiradacosta added a comment. > For the general case you are right. Unpolish is only called from QApplication::setStyle when the old style gets destroyed. On Application tear-down it's not called. To be honest, I am a bit uneasy about this change. Sounds somewhat like abusing

[Differential] [Commented On] D3242: Add an option to context menu to launch the application on a discrete graphics card

2016-11-03 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D3242#60307, @graesslin wrote: > In https://phabricator.kde.org/D3242#60294, @davidedmundson wrote: > > > According to our bug report on this: https://bugs.kde.org/show_bug.cgi?id=371497 one also needs to restart kwin in

[Differential] [Commented On] D3242: Add an option to context menu to launch the application on a discrete graphics card

2016-11-03 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D3242#60294, @davidedmundson wrote: > According to our bug report on this: https://bugs.kde.org/show_bug.cgi?id=371497 one also needs to restart kwin in xrender and mess about with some other things. Eh no, that seems to

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 534 - Fixed!

2016-11-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/534/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 03 Nov 2016 10:29:45 + Build duration: 5 min 55 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 534 - Fixed!

2016-11-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/534/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 03 Nov 2016 10:29:45 + Build duration: 5 min 55 sec CHANGE SET Revision

[Differential] [Commented On] D3244: Internal windows cannot be minimized

2016-11-03 Thread Martin Gräßlin
graesslin added a comment. F396413: kwin_screenshot_f29787.png REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D3244 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin,

[Differential] [Request, 4 lines] D3244: Internal windows cannot be minimized

2016-11-03 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, broulik. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY This change ensures that the DebugConsole does not have a

[Differential] [Commented On] D3242: Add an option to context menu to launch the application on a discrete graphics card

2016-11-03 Thread jgrulich (Jan Grulich)
jgrulich added a comment. I tested this on my laptop where I have both intel and nvidia cards and it seems to working without any issue for me. Note that in Fedora 25 here have been many improvements regarding dual graphics support so that may be the reason why it works for me. Another

[Differential] [Closed] D3229: Disable starting kactivitymanagerd throughout launchertasksmodeltest

2016-11-03 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb63b2924254a: Disable starting kactivitymanagerd throughout launchertasksmodeltest (authored by davidedmundson). CHANGED PRIOR TO COMMIT

[Differential] [Commented On] D3242: Add an option to context menu to launch the application on a discrete graphics card

2016-11-03 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. According to our bug report on this: https://bugs.kde.org/show_bug.cgi?id=371497 one also needs to restart kwin in xrender and mess about with some other things. Have you tested this on a real dual machine? and did you have those problems? REVISION

[Differential] [Updated, 107 lines] D3242: Add an option to context menu to launch the application on a discrete graphics card

2016-11-03 Thread jgrulich (Jan Grulich)
jgrulich removed rPLASMADESKTOP Plasma Desktop as the repository for this revision. jgrulich updated this revision to Diff 7852. jgrulich marked an inline comment as done. jgrulich added a comment. Use KWindowSystem::isPlatformX11() instead of QX11Info::isPlatformX11(). CHANGES SINCE LAST

[Differential] [Request, 241 lines] D3243: [kioslave/remote] Port away from kdelibs4support

2016-11-03 Thread elvisangelaccio (Elvis Angelaccio)
elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The `remote:/` kioslave now builds without kdelibs4support. The second commit also removes

[Differential] [Changed Subscribers] D3242: Add an option to context menu to launch the application on a discrete graphics card

2016-11-03 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > runnermatchesmodel.cpp:169 > +#if HAVE_X11 > +if (QX11Info::isPlatformX11()) { > +timeStamp = QX11Info::appUserTime(); Please use KWindowSystem::isPlatformX11. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

Re: Review Request 129318: Add an option to context menu to launch the application on a discrete graphics card

2016-11-03 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129318/ --- (Updated Lis. 3, 2016, 10:09 dop.) Status -- This change has been

[Differential] [Request, 110 lines] D3242: Add an option to context menu to launch the application on a discrete graphics card

2016-11-03 Thread jgrulich (Jan Grulich)
jgrulich created this revision. jgrulich added reviewers: hein, Plasma. jgrulich set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY In Fedora 25 there

[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

2016-11-03 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D3240#60265, @hpereiradacosta wrote: > In https://phabricator.kde.org/D3240#60257, @hpereiradacosta wrote: > > > Did you test whether unpolish is actually called ? Last time I tried, it was not, at least not always. (depending

[Differential] [Updated] D3239: [kstyle] Delay init of Wayland setup till next event cycle

2016-11-03 Thread Martin Gräßlin
graesslin added a comment. see also https://phabricator.kde.org/D3241 and https://phabricator.kde.org/D3240 REPOSITORY rBREEZE Breeze BRANCH delay-init-wayland-shadow-5.8 REVISION DETAIL https://phabricator.kde.org/D3239 EMAIL PREFERENCES

[Differential] [Commented On] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

2016-11-03 Thread hpereiradacosta (Hugo Pereira Da Costa)
hpereiradacosta added a comment. In https://phabricator.kde.org/D3240#60257, @hpereiradacosta wrote: > Did you test whether unpolish is actually called ? Last time I tried, it was not, at least not always. (depending on whether you run a QApplication, KApplication, etc.) > This is

[Differential] [Request, 8 lines] D3241: Unpolish QStyle on QApp prior to destroying internal Wayland connection

2016-11-03 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The QStyle might interact with our internal Wayland connection. If

[Differential] [Updated] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

2016-11-03 Thread hpereiradacosta (Hugo Pereira Da Costa)
hpereiradacosta added a comment. Did you test whether unpolish is actually called ? Last time I tried, it was not, at least not always. (depending on whether you run a QApplication, KApplication, etc.) This is what led to the mess of destroying the singleton style in the plugin helper,

[Differential] [Request, 11 lines] D3240: [kstyle] Implement application unpolish to delete ShadowHelper

2016-11-03 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, broulik, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Another change mostly for KWin (Wayland compositor). KWin destroys it's

[Differential] [Accepted] D3239: [kstyle] Delay init of Wayland setup till next event cycle

2016-11-03 Thread hpereiradacosta (Hugo Pereira Da Costa)
hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. No objection, you're the expert ! Thanks ! REPOSITORY rBREEZE Breeze BRANCH delay-init-wayland-shadow-5.8 REVISION DETAIL https://phabricator.kde.org/D3239

[Differential] [Request, 9 lines] D3239: [kstyle] Delay init of Wayland setup till next event cycle

2016-11-03 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, broulik, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a change mostly for KWin (the Wayland compositor). The internal

Re: Review Request 129318: Add an option to context menu to launch the application on a discrete graphics card

2016-11-03 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129318/ --- (Updated Lis. 3, 2016, 9:21 dop.) Review request for Plasma and Eike

Review Request 129318: Add an option to context menu to launch the application on a discrete graphics card

2016-11-03 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129318/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-03 Thread hpereiradacosta (Hugo Pereira Da Costa)
hpereiradacosta added a comment. In https://phabricator.kde.org/D3210#60184, @colomar wrote: > It does make sense to me to give the option to turn the slim scroll bar as such on and off. I can imagine some people being uncomfortable with the animation on mouseover. > Being able to

Re: DrKonqi and BKO

2016-11-03 Thread René J . V . Bertin
Martin Klapetek wrote: >> Bug trackers are not trace trackers. Spending time on solving the >> actual problem is the best thing https://retrace.fedoraproject.org/ >> https://errors.ubuntu.com/ > > > They're not, yet we're using it as one. So might as well improve > the experience at least a

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2016-11-03 Thread Jannis Mast
https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #8 from Jannis Mast --- (In reply to Jannis Mast from comment #7) > Same problem here on Gentoo, running Linux 4.7.10, KDE frameworks 5.26.0 and > Plasma 5.7.5. I have first seen this after upgrading from Plasma 5.6

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2016-11-03 Thread Jannis Mat
https://bugs.kde.org/show_bug.cgi?id=350365 Jannis Mat changed: What|Removed |Added CC||jan...@hackbraten.men ---

[Differential] [Closed] D3227: [helpers/killer] Use instead of

2016-11-03 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN7681e312c580: [helpers/killer] Use instead of (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3227?vs=7829=7846 REVISION DETAIL

[Differential] [Closed] D3225: Don't snap to auto-hidden panels

2016-11-03 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN679e41780888: Don't snap to auto-hidden panels (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3225?vs=7822=7845 REVISION DETAIL