D6401: [platforms/x11] Request OpenGL 2.1 instead of 1.2

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Mismatch in the major/minor version. Requesting 1.2 doesn't make any sense given that KWin requires 2.1. REPOSITORY R108 KWin

D6396: Refactor the specification of OpenGL context attributes

This revision was automatically updated to reflect the committed changes. Closed by commit R108:3f4995fb9b4f: Refactor the specification of OpenGL context attributes (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6396?vs=15894=15900

D6373: [libksysguard] Fix text color in memory html view

anthonyfieroni added a comment. In https://phabricator.kde.org/D6373#119529, @broulik wrote: > Doesn't CSS have "System Colors"? They are deprecated in CSS 3 but might still work here: https://www.w3.org/TR/2003/CR-css3-color-20030514/#css2-system It does not work :) REPOSITORY

D6373: [libksysguard] Fix text color in memory html view

anthonyfieroni updated this revision to Diff 15899. anthonyfieroni added a comment. Use fixed colors. REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6373?vs=15827=15899 REVISION DETAIL https://phabricator.kde.org/D6373 AFFECTED FILES

D6400: Set correct icons for plasma config windows on wayland

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D6400 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D6396: Refactor the specification of OpenGL context attributes

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in egl_context_attribute_builder.cpp:50 > Do you have some sort of checklist of C++11 features to use? > > For a single integer, emplace_back is going to do the exact same thing as the > standard push_back. If one always

D6400: Set correct icons for plasma config windows on wayland

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Opened config window. Saw icons Checked autostart still worked with the Hidden=true entry REPOSITORY R120 Plasma Workspace BRANCH

D6396: Refactor the specification of OpenGL context attributes

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > egl_context_attribute_builder.cpp:50 > +if (isRobust()) { > +attribs.emplace_back(EGL_CONTEXT_OPENGL_ROBUST_ACCESS_EXT); > +

D6396: Refactor the specification of OpenGL context attributes

graesslin marked an inline comment as done. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D6396 To: graesslin, #kwin, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,

D6396: Refactor the specification of OpenGL context attributes

graesslin updated this revision to Diff 15894. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Fix missing haveCreateContext - good spot Sir! REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6396?vs=15885=15894

D6047: WIP: Support XDG v6

graesslin added a comment. In https://phabricator.kde.org/D6047#119698, @mart wrote: > trying to implement the kwin part of ping btw, will do in a branch of the branch kwin/xdgv6 no need to hurry with it. IMHO the way ping works is completely broken and won't work. At least Qt

D6344: [platforms/x11] Add support for GLX_NV_robustness_video_memory_purge

This revision was automatically updated to reflect the committed changes. Closed by commit R108:97fa72ee48b7: [platforms/x11] Add support for GLX_NV_robustness_video_memory_purge (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D6304: Properly block the edge also for touch screen edges

This revision was automatically updated to reflect the committed changes. Closed by commit R108:6267d597311c: Properly block the edge also for touch screen edges (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6304?vs=15663=15893

D6047: WIP: Support XDG v6

davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Done all comments except ping/pong. Marco, ping me if you ever want this updating. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: graesslin,

D6047: WIP: Support XDG v6

davidedmundson updated this revision to Diff 15889. davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - cleanups REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

Zren marked 3 inline comments as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6392 To: Zren, #plasma Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

Zren updated this revision to Diff 15888. Zren added a comment. Jump by 2px. Jump by __ clicks. Make sure thickness is even. Hide thickness in button after 1 second. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6392?vs=15873=15888 REVISION

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

Zren added a comment. Great idea about using a timer in the binding. I can probably keep the onThicknessChanged binding since it does change size when moved from left/right to top/bottom. As far as I can tell, the `wheel.delta` is only using the hardcoded jumps of ±120 (on click) (or

D6396: Refactor the specification of OpenGL context attributes

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstract_egl_backend.cpp:235 > } > - > -if (ctx == EGL_NO_CONTEXT && haveRobustness && haveCreateContext) { > -

D6389: [xembedsniproxy] Free windowAttributes in every case

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d45584d1de4f: [xembedsniproxy] Free windowAttributes in every case (authored by wbauer). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D6047: WIP: Support XDG v6

mart added a comment. trying to implement the kwin part of ping btw, will do in a branch of the branch kwin/xdgv6 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff,

D6396: Refactor the specification of OpenGL context attributes

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The current way to specify the OpenGL context attributes does no longer scale as can be seen in https://phabricator.kde.org/D6344.

D6389: [xembedsniproxy] Free windowAttributes in every case

davidedmundson accepted this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6389 To: wbauer, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6389: [xembedsniproxy] Free windowAttributes in every case

wbauer updated this revision to Diff 15883. wbauer edited the summary of this revision. wbauer added a comment. Use a QScopedPointer instead of manually calling free() REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6389?vs=15869=15883 REVISION

[kio-extras] [Bug 369850] Can't browse samba workgroups

https://bugs.kde.org/show_bug.cgi?id=369850 Nate Graham changed: What|Removed |Added CC||c537...@mvrht.com ---

Minutes Monday Plasma Hangout

Here you go! -- sebas http://www.kde.org | http://vizZzion.orgPlasma Meeting 26-7-2017 Present: Sho, notmart, kbroulik, bshah Sho: * [TM] Fixed launchers not causing startup notifications * [TM] Fixed launchers not contributing to recent/most used applications * [TM] Cleaned up app-launching

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

davidedmundson added inline comments. INLINE COMMENTS > SizeHandle.qml:125 > +if (wheel.delta > 0) { > +panel.thickness = Math.max(units.gridUnit, panel.thickness + > 1); > +} else if (wheel.delta < 0) { You need to make it by 2. See

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

broulik added a comment. I like the idea of showing the thickness in the button. My suggestion would be add a `Timer` which you `restart()` when you change the panel thickness (you need to try whether in `onThicknessChanged` is sufficient or doing that explicitly in `onWheelEvent` and/or

D6344: [platforms/x11] Add support for GLX_NV_robustness_video_memory_purge

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. Tested, works fine. I get the "Desktop effects were restarted due to a graphic reset" notification every time I switch from any tty back to tty1. REPOSITORY R108 KWin

D6392: [Panel Config] Scrolling over size button increments size by 1 and shows current thickness

Zren created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The current thickness is also shown when dragging as well. Closing the ruler thing and reopening will recreate the component, so the

D3805: Per-activity favorites (Final, again?)

mart added a comment. api-wise i like the concept of initForClient, +1 REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D3805: Per-activity favorites (Final, again?)

ivan edited the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D3805: Per-activity favorites (Final, again?)

ivan edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D3805 To: ivan, mart, hein Cc: Zren, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D3805: Per-activity favorites (Final, again?)

ivan updated this revision to Diff 15872. ivan added a comment. I realized I can be quite thick. After I created a new level of indirection so that each applet can have its own favourite ordering (as requested), I realized I reimplemented most of the logic of `KAStats::ResultModel`

D6390: WIP: Add remote runners over DBus

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This patch allows adding runners which, rather than being in-process receive a search term and provide results

D6389: [xembedsniproxy] Free windowAttributes in every case

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Urgh, how did I not catch that last review. Might be better to just swap with: QScopedPointer =

D6389: [xembedsniproxy] Free windowAttributes in every case

wbauer created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The structure was only freed in case the XTest method was chosen. But it should always be freed of course (as long as it isn't NULL). TEST

D6387: Also try application.name to get iconName

drosca accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D6387 To: broulik, #plasma, drosca Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D6388: Don't use plasma theme icons for stream/device icons

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D6388 To: broulik, #plasma, drosca, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6388: Don't use plasma theme icons for stream/device icons

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN VLC has a Plasma icon now and we get a mix of apps and plasma icons. We typically don't use plasma theme for app-heavy things like task manager,

D6387: Also try application.name to get iconName

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN I can now add an icon for "speech-dispatcher" to catch them all, the binaries of all four kinds are different, starting with "sd_" REPOSITORY

D6267: Use appstream-qt insted of glib based one

This revision was automatically updated to reflect the committed changes. Closed by commit R134:dd26366277ea: Use appstream-qt insted of glib based one (authored by jgrulich). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6267?vs=15567=15865

D6386: [Digital Clock] Allow speaking out loud current time

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This re-introduces the ability to automatically speak out loud the current time in intervals configured by the user (between every minute and

D6313: WIP: Support device pixel ratio in icon loader and engine

mart added a comment. In https://phabricator.kde.org/D6313#118285, @kvermette wrote: > Behaviorally speaking there's justification for ensuring SVGs are treated the same as PNGs in this case. Looking at the code we aren't shimming the SVGs specifically (unless I'm missing something),

D6373: [libksysguard] Fix text color in memory html view

broulik added a comment. Doesn't CSS have "System Colors"? They are deprecated in CSS 3 but might still work here: https://www.w3.org/TR/2003/CR-css3-color-20030514/#css2-system REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D6373 To: anthonyfieroni,