Re: cmake magic for documentation

<3 On Thu, Aug 3, 2017 at 2:09 PM, Jonathan Riddell wrote: > On Mon, Jul 24, 2017 at 12:57:43PM +0200, Harald Sitter wrote: >> hola! >> >> Currently releaseme pulls off a whole bunch of tricks to get first >> level conditional magic working for documentation. >> >> Since you

T6720: system setting sidebar view

andreaska created this task. andreaska added a project: Plasma. TASK DESCRIPTION My idea about System Setting Overview Sidebar Layout: F3829957: SidebarView.jpg It's the same layout than now in master the difference is that you choose the main

Re: Splash screen translation

Thx for your answer. I was expecting something like this : let's see what the French team says :) Cheers Olivier Le 3 août 2017 22:29:57 GMT+02:00, Marco Martin a écrit : >On Thursday 03 August 2017 21:00:26 Olivier Churlaud wrote: >> I've seen on my French version of

Re: Splash screen translation

On Thursday 03 August 2017 21:00:26 Olivier Churlaud wrote: > I've seen on my French version of Plasma that the string "Plasma, made by > KDE" on the loading screen (after entering your credentials) was translated > in French. I think it's a mistake to translate this, because it just > doesn't

Splash screen translation

[English below, for plasma people] Bonjour, J'ai vu que récemment la string "Plasma, made by KDE" a été traduit en "Plasma, fait par KDE". Mon avis n'est peut-être pas partagé, mais je trouve que ça en jette moins. Revenir vers du made by KDE serait préférable, non? Qu'en pensez vous? Si

Re: kwin_wayland xdgv6: crash on ping

Am 3. August 2017 17:45:53 MESZ schrieb Marco Martin : >On Thursday 03 August 2017 16:02:20 David Edmundson wrote: >> ::Private::unbind(wl_resource) { //TODO: implement} >> >> we should probably implement it in global.cpp, like we do for >resources. >> but probably without

Re: Implementing a plasma colorscheme generator

On Thu, Aug 3, 2017 at 5:48 PM, Marco Martin wrote: > On Thursday 03 August 2017 11:51:08 Sebastian Kügler wrote: >> > That said, I would suggest thinking through how a user would be using >> > that feature in the end. It could be really cool if the usage doesn't >> > feel too

Re: kwin_wayland xdgv6: crash on ping

On 3 Aug 2017 4:46 p.m., "Marco Martin" wrote: On Thursday 03 August 2017 16:02:20 David Edmundson wrote: > ::Private::unbind(wl_resource) { //TODO: implement} > > we should probably implement it in global.cpp, like we do for resources. > but probably without the call to

D7086: [Wallpaper Configuration] Hide Get New Stuff if disabled by KIOSK

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7086 To: broulik, #plasma, dknorr, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D7077: Drop Client::cap_deco as it's nowhere used

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH client-no-cap-deco REVISION DETAIL https://phabricator.kde.org/D7077 To: graesslin, #kwin, #plasma, mart Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7073: [Wallpaper Configuration] Make Get New Stuff dialog modal to config window

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7073 To: broulik, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

Re: Implementing a plasma colorscheme generator

On Thursday 03 August 2017 11:51:08 Sebastian Kügler wrote: > > That said, I would suggest thinking through how a user would be using > > that feature in the end. It could be really cool if the usage doesn't > > feel too clunky. > > Perhaps a nice addition to plasma-sdk? We already have

Re: kwin_wayland xdgv6: crash on ping

On Thursday 03 August 2017 16:02:20 David Edmundson wrote: > ::Private::unbind(wl_resource) { //TODO: implement} > > we should probably implement it in global.cpp, like we do for resources. > but probably without the call to q->deleteLater() that resources have. your latest patch fixes the crash

D7097: Forward showing desktop only to rootInfo if it changed

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY There was a property change for whenever a window gets activated although that doesn't change the state. In addition a nullptr

Re: kwin_wayland xdgv6: crash on ping

> > > So far we never send requests on the global, so it's possible that we > don't track the unbinding of the resource correctly there. We don't implement unbind. Almost every global in kwayland has the exact same ::Private::unbind(wl_resource) { //TODO: implement} we should probably implement

D7096: Only send active window changes to X11 root window if the X11 window changed

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far KWin always updated the active window property even if the actual window id hasn't changed. E.g. if a Wayland window was active

Re: kwin_wayland xdgv6: crash on ping

> > I can imagine this crash if we have two windows belonging to the same > process, and the client dies. We handle the first one closing (frame 18) > and in doing so activate the second window of that now disconnected app. > Under X that situation would just be a harmless BadWindow error. >

D6549: Look for QtGraphicalEffects, so packagers don't forget it

apol planned changes to this revision. apol added a comment. Need to be rebased on top of https://phabricator.kde.org/D7094 when it's merged. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D6549 To: apol, #kirigami, sitter, mart Cc: plasma-devel, apol, mart

Re: kwin_wayland xdgv6: crash on ping

Am 2017-08-02 18:44, schrieb Marco Martin: Hi all, reporting it here my latest findings on a crash in the xdgv6 branch in kwin, which i think it *may* reveal something else wrong besides the implementation of the thing that it's crashing in particular (ping) when there are many windows

D7077: Drop Client::cap_deco as it's nowhere used

graesslin updated this revision to Diff 17626. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Fixup arc REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7077?vs=17607=17626 BRANCH client-no-cap-deco REVISION

D7093: Implement the shortcut caption suffix for Wayland windows

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The generation of the shortcut caption part is moved from Client to AbstractClient. The ShellClient also has a captionSuffix and

D7089: [Breeze Style] Fix flickering during KPageTreeView animation

This revision was automatically updated to reflect the committed changes. Closed by commit R31:09e09a9cd885: [Breeze Style] Fix flickering during KPageTreeView animation (authored by broulik). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7089?vs=17624=17625

D7089: [Breeze Style] Fix flickering during KPageTreeView animation

hpereiradacosta added a comment. In https://phabricator.kde.org/D7089#131793, @broulik wrote: > > PS: same fix should probably go to oxygen :) > > Oxygen always paints a frame around side panels, no? Also, given it has a *gradient* background, you probably cannot avoid this as Qt

D7089: [Breeze Style] Fix flickering during KPageTreeView animation

broulik added a comment. > PS: same fix should probably go to oxygen :) Oxygen always paints a frame around side panels, no? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7089 To: broulik, #plasma, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff,

D7089: [Breeze Style] Fix flickering during KPageTreeView animation

hpereiradacosta added a comment. PS: same fix should probably go to oxygen :) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7089 To: broulik, #plasma, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D7089: [Breeze Style] Fix flickering during KPageTreeView animation

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Thanks ! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7089 To: broulik, #plasma, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff,

D7089: [Breeze Style] Fix flickering during KPageTreeView animation

broulik updated this revision to Diff 17624. broulik added a comment. - Explicitly check for `QTreeView` - Only if `QTreeView::isAnimated()` REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7089?vs=17614=17624 REVISION DETAIL

Re: KDE neon LTS value

On donderdag 3 augustus 2017 14:15:45 CEST Jonathan Riddell wrote: > At neon headquarters we're pondering the value of our LTS edition. We > currently recompile all our packages again for a user-lts edition > which uses Plasma 5.8 LTS. It also uses Qt 5.7 because Plasma 5.8 > doesn't compile

D7089: [Breeze Style] Fix flickering during KPageTreeView animation

hpereiradacosta added inline comments. INLINE COMMENTS > breezestyle.cpp:407 > +pal.setColor( QPalette::Active, QPalette::Base, > scrollArea->palette().color( scrollArea->backgroundRole() ) ); > +scrollArea->setPalette(pal); > } Setting palettes

Re: KDE neon LTS value

It's ... sort of dumb, but sometimes the value of advertising an LTS branch is psychological. "Does this have an LTS branch for when I need it, e.g. because I get more busy" seems to be on the minds of many people making a distro choice these days, even if they don't use it immediately or not for

D7092: Keep fallback icon updated

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY Windows we can't find an app icon for using the normal means get the icon used by the windowing system in the Task Manager. This fallback icon was then not updated when changed on the window, only

Re: cmake magic for documentation

On Mon, Jul 24, 2017 at 12:57:43PM +0200, Harald Sitter wrote: > hola! > > Currently releaseme pulls off a whole bunch of tricks to get first > level conditional magic working for documentation. > > Since you probably have no clue what that means. Go looky here: >

uncommited patches on phab

Hi, Albert sent a list of patches that are on phabricator, Accepted, but uncommited. That's often work done but forgotten. With very little effort, we can possibly merge quite a bunch of fixes into Plasma to make our users happy -- it's low-hanging fruit to pick.

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi added a comment. In https://phabricator.kde.org/D7087#131726, @sebas wrote: > In https://phabricator.kde.org/D7087#131719, @gregormi wrote: > > > In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote: > > > > > Why not just a "Copy to clipboard" button

D7089: [Breeze Style] Fix flickering during KPageTreeView animation

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QTreeView animates expanding/collapsing of branches. It renders the widget into a temporary pixmap for speed which is then animated. The

Re: Implementing a plasma colorscheme generator

On woensdag 2 augustus 2017 16:18:09 CEST Aleix Pol wrote: > On Tue, Aug 1, 2017 at 10:05 PM, Andrew wrote: > > > > I have made a simple program that generates a plasma colorscheme from an > > image. I am hoping to integrate it into plasma, making it so it takes the > >

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

elvisangelaccio added a comment. In https://phabricator.kde.org/D7087#131719, @gregormi wrote: > In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote: > > > Why not just a "Copy to clipboard" button (without a menu)? > > > I thought that might look too obstrusive

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

sebas added a comment. In https://phabricator.kde.org/D7087#131719, @gregormi wrote: > In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote: > > > Why not just a "Copy to clipboard" button (without a menu)? > The current button / menu looks out of place to me,

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130208/ --- (Updated Aug. 3, 2017, 9:43 a.m.) Status -- This change has been

Re: Review Request 130208: Add menu with "Copy to Clipboard" to the About System module

> On July 31, 2017, 3:59 a.m., Anthony Fieroni wrote: > > Modules/about-distro/src/Module.cpp, line 198 > > > > > > Plasma now depends on minimum 5.30, you can remove this check. Plasma > > team now use

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi updated this revision to Diff 17613. gregormi added a comment. - remove obsolete KCOREADDONS_VERSION check REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=17611=17613 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7087

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi added a comment. In https://phabricator.kde.org/D7087#131708, @elvisangelaccio wrote: > Why not just a "Copy to clipboard" button (without a menu)? I thought that might look too obstrusive for those who just what to see the version without a copy intent. > I see

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

elvisangelaccio added a comment. Why not just a "Copy to clipboard" button (without a menu)? I see that you are adding also the "About KDE" action in the menu, but that action is already in the Help menu from the toolbar. What's the point of adding it twice? REPOSITORY R102 KInfoCenter

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

gregormi retitled this revision from "WIP: Add menu with "Copy to Clipboard" to the About System module ui change" to "WIP: Add menu with "Copy to Clipboard" to the About System module". gregormi edited the summary of this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL

D7087: WIP: Add menu with "Copy to Clipboard" to the About System moduleui change

gregormi created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY debug clipboard proto complete (with debug stuff) revert .desktop file ready for review move to popup menu

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

matank added a comment. Calling syncToMainItemSize() in componentComplete() seems to solve the issue , so I checked what is being done in syncToMainItemSize() that affects the issue. I found that resizing the dialog is what seems to resolve the issue so I copied the relevant code from

Re: kwin_wayland xdgv6: crash on ping

> do this theory makes any sense or the cause should be found elsewhere? > (also, > Martin, any idea? or i just talked nonsense? :p) > > That theory makes a lot of sense. takeActive previously didn't do any talking to the client we were taking so it could have been always broken and we wouldn't

D7086: [Wallpaper Configuration] Hide Get New Stuff if disabled by KIOSK

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KCMs can be individually disabled by KIOSK if desired but wallpaper configuration cannot (unless you lock down Plasma completely). Hence, at

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

davidedmundson added a comment. Can you explain the logic behind adding the code you've added. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7071 To: matank, #plasma, davidedmundson Cc: plasma-devel, davidedmundson, ltoscano, #frameworks,

D7071: Fix issue where notifications will show as 1 pixel line if primary screen wasn't the leftmost one

matank updated this revision to Diff 17609. matank added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. - Fix issue where notifications will show as 1 pixel line Sets the dialog to his correct size to prevent it showing