ngraham removed a subscriber: Dolphin.
REPOSITORY
R128 User Manager
BRANCH
arcpatch-D8793_2
REVISION DETAIL
https://phabricator.kde.org/D8793
To: ngraham, apol, #plasma, mlaurent, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts,
ngraham updated this revision to Diff 22377.
ngraham added a comment.
Restore correct diff
REPOSITORY
R128 User Manager
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8793?vs=22375=22377
BRANCH
arcpatch-D8793_2
REVISION DETAIL
https://phabricator.kde.org/D8793
AFFECTED
ngraham updated this revision to Diff 22375.
ngraham added a comment.
Restricted Application added a subscriber: Dolphin.
Rely on KF 5.40 and simplify the code a ton
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8793?vs=22374=22375
BRANCH
ngraham updated this revision to Diff 22374.
ngraham added a comment.
Consider any source file in /tmp/ to be a temp file that we should clear, so
we don't leak files when run by kcmshell5 (or anything similar)
REPOSITORY
R128 User Manager
CHANGES SINCE LAST UPDATE
davidedmundson added a comment.
Not really. "Kcmshell5 usermanager" will still then leak.
Do you have any other ideas for solutions?
REPOSITORY
R128 User Manager
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8793
To: ngraham, apol, #plasma, mlaurent, davidedmundson
ngraham added a comment.
@davidedmundson, does your approval still hold with the new change to clean
up /tmp?
REPOSITORY
R128 User Manager
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8793
To: ngraham, apol, #plasma, mlaurent, davidedmundson
Cc: plasma-devel, ZrenBot,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
windowgeometry-delay-effectframe
REVISION DETAIL
https://phabricator.kde.org/D8821
To: graesslin, #kwin, #plasma, broulik
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff,
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Without Xwayland KWin starts so fast that the creation of the EffectFrame
triggers a crash in
apol updated this revision to Diff 22368.
apol added a comment.
Remove debug variable
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8820?vs=22359=22368
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8820
AFFECTED FILES
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:5313b8564680: Support modifier+mouse button on window
decoration (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8758?vs=22183=22366
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:9a965405e3ea: Support updating deco for changes of
borderless maximize windows config (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8095?vs=20206=22364#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:188491d39221: Support user fullscreen for
XdgShellSurfaces (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8169?vs=20422=22365
REVISION
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8661
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
broulik added inline comments.
INLINE COMMENTS
> platformtheme.cpp:159
> +if (!d->m_init) {
> +static int i = 0;
> +emit colorSetChanged(colorSet);
Unused
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8820
To: apol, #frameworks
Cc: broulik,
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:42b2daaec407: [server] Support inhibiting the
IdleInterface (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8383?vs=21016=22363#toc
REPOSITORY
R127 KWayland
CHANGES
graesslin added a comment.
ping
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8396
To: graesslin, #frameworks, #kwin, #plasma_on_wayland
Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol,
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:02c3c22c76ae: Only notify if the property changes
(authored by apol).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8819?vs=22349=22361
REVISION DETAIL
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Since we are using the timer, it will make the UI react to it at some point
despite it not really
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
signals
REVISION DETAIL
https://phabricator.kde.org/D8819
To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,
apol updated this revision to Diff 22349.
apol added a comment.
Oops
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8819?vs=22347=22349
BRANCH
signals
REVISION DETAIL
https://phabricator.kde.org/D8819
AFFECTED FILES
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Concept is fine.
I think you have a typo in the last method.
INLINE COMMENTS
> notificationsapplet.cpp:137
> +if (newPopupPosition != m_popupPosition) {
> +
davidedmundson added reviewers: guoyunhe, ngraham.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8807
To: apol, #plasma, guoyunhe, ngraham
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R120 Plasma Workspace
BRANCH
signals
REVISION DETAIL
https://phabricator.kde.org/D8819
AFFECTED FILES
mart updated this revision to Diff 22345.
mart added a comment.
- partial support for weights
- make the item with more weigth "win"
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8641?vs=22324=22345
BRANCH
mart/formlayout
REVISION DETAIL
davidedmundson added a comment.
I like the idea of the attached mnemonic handler, it's good that you've kept
it separate from the form layout.
> i'll look at the algorythm to see if is reusable
Can we try to avoid having a diff that keeps growing and growing with
features.
We'll
amantia updated this revision to Diff 22344.
amantia added a comment.
Restoring previous version overwritten by mistake.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=22342=22344
BRANCH
master
REVISION DETAIL
amantia updated this revision to Diff 22342.
amantia added a comment.
- WIP: Multiscreen drag and drop support in folder view
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=22313=22342
BRANCH
arcpatch-D8598_1
REVISION DETAIL
amantia requested changes to this revision.
amantia added a comment.
This revision now requires changes to proceed.
Unfortunately the current approach fails when the folderview points to
desktop:/ . In that case the targetUrl in the copyJobStarted is different
("desktop:/foo") from the url
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:6e68b3f0a351: Make sure we load everything in correct
order (authored by jgrulich).
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R134 Discover Software Store
BRANCH
flatpak-order
REVISION DETAIL
https://phabricator.kde.org/D8815
To: jgrulich, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
amantia closed this revision.
amantia added a comment.
https://commits.kde.org/plasma-framework/eab03787350a6c8cf56b1bf95f89b360c6633de3
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:eab03787350a: Add signals indicating if a screen was
added or removed (authored by amantia).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
lopatin created this revision.
lopatin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
For some reason kicker appsmodel ignores root items (apps and separators).
This patch added support for
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130247/#review103843
---
Please use
apol added a comment.
> If we're doing some caching in there now anyway, can we perhaps add
individual signals for the margins or is it not worth it?
No, we don't have any caching. Also they never seem to change, on my system
it goes from 0 (default) to 6 for all of them (whatever is in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130247/
---
Review request for Plasma.
Repository: plasma-desktop
Description
broulik added a comment.
Good idea with the RAII class.
If we're doing some caching in there now anyway, can we perhaps add
individual signals for the margins or is it not worth it?
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8809
To:
This revision was automatically updated to reflect the committed changes.
Closed by commit R526:cc1019e2938a: fix overlapping labels on systems with
different window sizes (authored by sitter).
REPOSITORY
R526 Breeze theme for Plymouth
CHANGES SINCE LAST UPDATE
jgrulich updated this revision to Diff 22335.
jgrulich added a comment.
Fix comparing of appstream ids
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8815?vs=22334=22335
BRANCH
flatpak-order
REVISION DETAIL
jgrulich created this revision.
jgrulich added a reviewer: apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
We need to be sure that all apps are reloaded first before checking for
updates. This might
be
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:745c65b4b5f2: Fix disclaimer scaling and add installed
skills visual indicator (authored by Aiix).
REPOSITORY
R846 Mycroft Plasma integration
CHANGES SINCE LAST UPDATE
Aiix created this revision.
Aiix added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Ref https://phabricator.kde.org/T7439, https://phabricator.kde.org/T7175
Fixed: disclaimer message scaling
mart added a comment.
In https://phabricator.kde.org/D8641#167459, @hein wrote:
> So if I understand correctly, the Mnemonic stuff currently doesn't seem to
have the same aims as KAcceleratorManager does ...
>
> KAcceleratorManager acts on a hierarchy of widgets, traverses it,
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in FormLayout.qml:121
> In general with text, I think it's better to set the item to occupy the whole
> space it /can/ take up, then use the Text.Alignment property to position the
> text within it.
>
> Otherwise if this
mart updated this revision to Diff 22324.
mart added a comment.
- an early prototype of a FormLayout
- Form->FormData
- add gallery page
- make FormLayout a template
- use Headings for all the titles
- remove some redundant code
- support for dynamic elements
- add heuristic to
mart reopened this revision.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D8641
To: mart, #plasma, #kirigami, hein
Cc: colomar, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, hein
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8a1e6fc77848: Revert text 100% wide (authored
by mart).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8641?vs=22277=22322#toc
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
amantia updated this revision to Diff 22313.
amantia marked 2 inline comments as done.
amantia added a comment.
Implement changes requested by anthonyfieroni
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=22312=22313
BRANCH
master
amantia updated this revision to Diff 22312.
amantia added a comment.
Handle the case when the folder view's path changes on one of the desktops
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=21838=22312
BRANCH
master
REVISION DETAIL
49 matches
Mail list logo
