This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b8c6a6969b00: Remove i18n() calls from iconSource names
(authored by lueck).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9232?vs=23577=23598
REVISION
anthonyfieroni added inline comments.
INLINE COMMENTS
> arichardson wrote in kdeplatformfiledialoghelper.cpp:365-370
> I don't think we can depend on that yet, can we? Also I'm not sure we really
> need that runtime check. How likely is it that someone compiles plasma
> integration against Qt
ngraham added a comment.
@anthonyfieroni and @anthonyfieroni, looks like there are some inline
questions for you guys.
REPOSITORY
R135 Integration for Qt applications in Plasma
REVISION DETAIL
https://phabricator.kde.org/D4193
To: arichardson, #plasma
Cc: ngraham, krzyc,
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:19784bfc4b9c: [comic] Make sure KNS download dialog is
destroyed (authored by anthonyfieroni).
REPOSITORY
R114 Plasma Addons
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:84a29ef86380: [widgetexplorer] Make sure KNS download
dialog is destroyed (authored by anthonyfieroni).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9232
To: lueck, #plasma_workspaces, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
lueck created this revision.
lueck added a reviewer: Plasma: Workspaces.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
trunk has already 18 translations for application-menu
I really doubt that it will work with
hpereiradacosta added a comment.
I thought (but might be wrong) that you could create an icon with already the
right pixmap in there (QIcon::addPixmap( QPixmap, QIcon::Mode, QIcon::State ))
for a given state and mode, which will get picked (as opposed to calculated on
fly) whenever called.
broulik added a comment.
Doesn't the icon not matter but it creates a pixmap with the given (wrong)
state? If you find a better / easier solution I'm all for it ;)
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9227
To: broulik, #plasma, #vdg, hpereiradacosta
Cc:
hpereiradacosta added a comment.
In https://phabricator.kde.org/D9227#176763, @broulik wrote:
> The problem is that the button is entirely custom-painted by Qt:
>
> void QLineEditIconButton::paintEvent(QPaintEvent *)
> {
> [...]
>
> // Note isDown should
fvogt added a comment.
In https://phabricator.kde.org/D9225#176791, @graesslin wrote:
> I think you also need to adjust the actual seccomp filtering. I don't know
whether the filter works at all if the syscalls don't exist.
It uses SCMP_SYS to get the syscall nrs. So it would
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
I think you also need to adjust the actual seccomp filtering. I don't know
whether the filter works at all if the syscalls don't exist.
REPOSITORY
R133 KScreenLocker
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
In https://phabricator.kde.org/D8652#176706, @davidedmundson wrote:
> The comment about being static needs to be in the protocol xml too. Then
this is good to go.
>
> ( though
broulik added a comment.
The problem is that the button is entirely custom-painted by Qt:
void QLineEditIconButton::paintEvent(QPaintEvent *)
{
[...]
// Note isDown should really use the active state but in most styles
// this has no proper feedback
hpereiradacosta added a comment.
Hi Kai,
Thanks for the patch.
Just to make sure: can't we just manually modify the toolbuttons (well
qlineediticonbutton) once and for all in say "::polish", so that the selected
state == active state ? this would make the whole thing more robust I guess,
broulik created this revision.
broulik added reviewers: Plasma, VDG, hpereiradacosta.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Qt internally uses `QIcon::Selected` for when the action button in a line
edit is
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9130
To: anthonyfieroni, davidedmundson, broulik, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This would cause the rubberband to become invisible and not match any items.
TEST PLAN
This is what
anthonyfieroni added a reviewer: mart.
anthonyfieroni added a comment.
Anyone against?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9130
To: anthonyfieroni, davidedmundson, broulik, mart
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
dvratil added a comment.
@sebas suggested we approach it as an OSD that would appear on screen and
allow the user to select an action they want to take. I think it's a good
approach, even more flexible than an option in the KCM. And IIRC it was also
what we planned long time ago when I was
bshah added inline comments.
INLINE COMMENTS
> davidedmundson wrote in seccomp_test.cpp:97
> Why is this not guarded?
Those methods are available in fcntl whether syscalls are defined or not.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D9225
To: bshah,
davidedmundson accepted this revision.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
The comment about being static needs to be in the protocol xml too. Then this
is good to go.
( though what's your reasoning for not just
davidedmundson added inline comments.
INLINE COMMENTS
> seccomp_test.cpp:97
> QVERIFY(open(createPathChar, O_RDONLY | O_CREAT, 0) == -1 && errno ==
> EPERM);
> QVERIFY(openat(AT_FDCWD, createPathChar, O_RDONLY | O_CREAT, 0) == -1 &&
> errno == EPERM);
> +#ifdef SYS_open
Why is this
mvourlakos added inline comments.
INLINE COMMENTS
> appmenu.cpp:211
> hideMenu(); // hide window decoration menu if exists
> -
> +return;
> KConfigGroup
> config(KSharedConfig::openConfig(QStringLiteral("kdeglobals")),
> QStringLiteral("Appmenu Style"));
is this ok? isnt that return
davidedmundson added a comment.
It was semi broken. Behavior was arbitrary on size, but there's no ui
pretending it's anything else.
I'd be happy with this patch if it extended from an in-built monitor (you
can't use primary here as we're the ones setting that) instead of biggest.
mwolff added a comment.
In https://phabricator.kde.org/D8444#173635, @davidedmundson wrote:
> I left a comment a month ago. It has not been addressed.
>
> > there's one part that's going to appear very confusing.
>
>
>
> > I have my (small) laptop. Lets say I want any new
bshah created this revision.
bshah added reviewers: Plasma, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
On arm64 e.g SYS_open and few more syscalls are not available, this
results in build failure.
TEST PLAN
broulik created this revision.
broulik added reviewers: Plasma, graesslin.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
It spends 160ms in total on plasmashell startup for me here.
TEST PLAN
My
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9222
To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When removing a widget it turns system immutable, when undoing it regains its
old immutability
mvourlakos added a comment.
+1 very good...
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9215
To: mart, #plasma
Cc: mvourlakos, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
broulik added a comment.
+1 to the idea
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D9215
To: mart, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
32 matches
Mail list logo
