D9752: Add contextual actionbar

2018-01-08 Thread Aditya Mehra
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:a4b518df223f: Add contextual actionbar (authored by Aiix). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE

D9752: Add contextual actionbar

2018-01-08 Thread Aditya Mehra
Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY REF https://phabricator.kde.org/T7175 Add contextuall actionbar to results

D9751: [weather] Add configuration option which weather services providers to use

2018-01-08 Thread Friedrich W . H . Kossebau
kossebau added a comment. Drop-down menu looks like this (first item selected, hovering over second): F5631180: Screenshot_20180109_081008.png Additional advantage of the menu: makes it more transparent what services providers are currrently

D9751: [weather] Add configuration option which weather services providers to use

2018-01-08 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY When searching a weather station/location to select for the

D9713: Add script to unlock a broken session via ConsoleKit.

2018-01-08 Thread Tobias C . Berner
tcberner added inline comments. INLINE COMMENTS > graesslin wrote in abstractlocker.cpp:53 > I think this needs to be runtime detected. So something ala - if logingd-runing then logindmessage - if consolekit-running then consolekitmessage - else falback message REPOSITORY R133 KScreenLocker

D9713: Add script to unlock a broken session via ConsoleKit.

2018-01-08 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstractlocker.cpp:53 > +#if HAVE_CONSOLEKIT > +auto text = ki18n("The screen locker is broken and unlocking is not > possible anymore.\n" > +

D9726: Change device "master volume" to be the max of all channels instead of the avg

2018-01-08 Thread Chris Holland
Zren added a comment. > one channel is 0%, second is 100% and merged volume now shows 100% If you lower the volume on a speaker, you care more about what the volume of the louder speaker is. It's weird if the OSD shows 50% when the right speaker is blaring at 100% and annoying my

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 60 - Fixed!

2018-01-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/60/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 01:41:42 + Build duration: 3 min 31 sec and counting JUnit Tests Name:

KDE CI: Plasma discover kf5-qt5 FreeBSDQt5.9 - Build # 59 - Failure!

2018-01-08 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20discover%20kf5-qt5%20FreeBSDQt5.9/59/ Project: Plasma discover kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 09 Jan 2018 01:03:16 + Build duration: 6 min 30 sec and counting CONSOLE OUTPUT

D9633: Add a private libPlasmaWeatherSolar for the ion data engines

2018-01-08 Thread Friedrich W . H . Kossebau
kossebau abandoned this revision. kossebau added a comment. Discarding this one and instead went the route of async querying from the time dataengine... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9633 To: kossebau, #plasma, jriddell Cc: plasma-devel,

D9033: man ioslave: asserts trying to display pam(8)

2018-01-08 Thread Luigi Toscano
ltoscano added a project: Documentation. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9033 To: marten, #plasma Cc: apol, plasma-devel, ZrenBot, skadinna, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9746: openconnect: support MFA

2018-01-08 Thread Andrea Scarpino
scarpino created this revision. scarpino added a reviewer: jgrulich. Restricted Application added a project: Plasma. scarpino requested review of this revision. REVISION SUMMARY support MFA authentication in openconnect TEST PLAN build and tested REPOSITORY R116 Plasma Network Management

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

2018-01-08 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts, rkflx Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9726: Change device "master volume" to be the max of all channels instead of the avg

2018-01-08 Thread David Rosca
drosca added a comment. Well, this was actually intended to work like that. In case of split channels, I would say "avg" describes the merged volume better than "max", because with "max" you can have situation where one channel is 0%, second is 100% and merged volume now shows 100% which is

D9738: Support font/ttf and font/otf mimetypes in kfontinst

2018-01-08 Thread Fabian Vogt
fvogt added inline comments. INLINE COMMENTS > anthonyfieroni wrote in Misc.cpp:293 > So why not > > return CFontList::fontMimeTypes.contains(mime); > > In other places too. It's probably not linked together. Anyway, this is just supposed to be a simple fix and not a refactor, stuff like

D9738: Support font/ttf and font/otf mimetypes in kfontinst

2018-01-08 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > Misc.cpp:293 > { > -return "application/x-font-type1"==mime || > "application/x-font-ttf"==mime || > +return "font/otf"==mime || "font/ttf"==mime || > + "application/x-font-type1"==mime || >

D9738: Support font/ttf and font/otf mimetypes in kfontinst

2018-01-08 Thread Fabian Vogt
fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY Those mimetypes are new and kfontinst/kfontview/fontthumbnail weren't aware of that. As the old types are aliases of the new

D9735: [Notifications] Don't restart hide timer on reposition while dragging

2018-01-08 Thread Kai Uwe Broulik
broulik added a comment. > We're starting a drag; if the drag's blocking we won't be processing onYChanged? > If it's not blocking..then what's the drag got to do with this? If I drop, then it tries to access the drag area or drag to get the data or emit signals and then it blows up

D9735: [Notifications] Don't restart hide timer on reposition while dragging

2018-01-08 Thread David Edmundson
davidedmundson added a comment. I don't understand how this relates to the bug. We're starting a drag; if the drag's blocking we won't be processing onYChanged? If it's not blocking..then what's the drag got to do with this? And as a behavioural change, why wouldn't you want the

D9521: Pass SwitchEvent from LibInput through KWin and add to DebugConsole

2018-01-08 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH switch-event REVISION DETAIL https://phabricator.kde.org/D9521 To: graesslin, #kwin, #plasma, mart Cc: ngraham,

D9735: [Notifications] Don't restart hide timer on reposition while dragging

2018-01-08 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY We checked for dragging in `onContainsMouseChanged` but not here.

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

2018-01-08 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:e2b7c395ecdb: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get() (authored by maciejsitarz, committed by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

2018-01-08 Thread Maciej Sitarz
maciejsitarz marked an inline comment as done. maciejsitarz added a comment. @davidedmundson I don't have commit access (I'm not sure if you were asking me or @broulik) INLINE COMMENTS > broulik wrote in sniproxy.cpp:292 > Just do > > if (image) { > > The indentation seems a little

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

2018-01-08 Thread Maciej Sitarz
maciejsitarz updated this revision to Diff 24944. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9732?vs=24940=24944 REVISION DETAIL https://phabricator.kde.org/D9732 AFFECTED FILES xembed-sni-proxy/sniproxy.cpp To: maciejsitarz, #plasma, davidedmundson Cc: broulik, plasma-devel,

D9733: Display exclusive actions correctly in systray menus

2018-01-08 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9733 To: volkov, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

2018-01-08 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks. Do you have commit access. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9732 To: maciejsitarz, #plasma, davidedmundson Cc:

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

2018-01-08 Thread Kai Uwe Broulik
broulik added a comment. Thanks for your patch! I'll let David have a look at it who maintains xembedsniproxy. INLINE COMMENTS > sniproxy.cpp:292 > +QImage naiveConversion; > + if (nullptr != image) { > + naiveConversion = QImage(image->data, image->width, >

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

2018-01-08 Thread Kai Uwe Broulik
broulik added reviewers: Plasma, davidedmundson. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9732 To: maciejsitarz, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9733: Display exclusive actions correctly in systray menus

2018-01-08 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Feel free to commit your example into the tests folder. It's useful when people ineviatibly change stuff. REPOSITORY R135 Integration for Qt applications in Plasma

D9733: Display exclusive actions correctly in systray menus

2018-01-08 Thread Alexander Volkov
volkov added a comment. Testing example: F5629785: tray-exclusive-actions.tar.xz REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9733 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff,

D9733: Display exclusive actions correctly in systray menus

2018-01-08 Thread Alexander Volkov
volkov added a reviewer: Plasma. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9733 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9732: Fix for xembedsniproxy crash due to NULL returned from xcb_image_get()

2018-01-08 Thread Maciej Sitarz
maciejsitarz created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. maciejsitarz requested review of this revision. REVISION SUMMARY In my environment (Fedora 27, plasma-workspace-5.11.4-1.fc27.x86_64) xembedsniproxy

D9733: Display exclusive actions correctly in systray menus

2018-01-08 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Add exclusive actions to their own action groups so that they could be diplayed as radio buttons by

D9033: man ioslave: asserts trying to display pam(8)

2018-01-08 Thread Jonathan Marten
marten added a comment. Ping anyone - is the updated diff enough for review? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9033 To: marten, #plasma Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D7820: man ioslave: spurious numbers included in clang(1) man page

2018-01-08 Thread Jonathan Marten
marten added a comment. Ping - anyone able to review? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7820 To: marten, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9684: Load config specified by the LnF theme

2018-01-08 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R133:e36101cd1b48: Load config specified by the LnF theme (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9684?vs=24791=24938#toc REPOSITORY R133 KScreenLocker

D9677: Remove unused class SelectImageButton

2018-01-08 Thread David Edmundson
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R133:d0db15779275: Remove unused class SelectImageButton (authored by davidedmundson). REPOSITORY R133 KScreenLocker

D9689: Add a per-process CPU usage graph shown in the process list

2018-01-08 Thread Fabian Vogt
fvogt updated this revision to Diff 24935. fvogt added a comment. Rebase on current master. (Apparently my local master wasn't setup to follow origin...) REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9689?vs=24921=24935 BRANCH history

D9684: Load config specified by the LnF theme

2018-01-08 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > lnf_integration.cpp:62 > + > +qDebug() << m_package.isValid() << xmlPath; > +const KConfigGroup cfg = m_config->group("Greeter").group("LnF"); Maybe it should be deleted. REPOSITORY R133 KScreenLocker BRANCH master REVISION

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Michael Heidelbach
michaelh added a comment. Sorry, we were overlapping. I should have hit the update page link in the lower left. BTW: Mind to explain this "Restricted Application added a project:" to me? Please. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614

D9643: Support submenus in context menu for systray icon

2018-01-08 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin, davidedmundson Cc: broulik, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9643: Support submenus in context menu for systray icon

2018-01-08 Thread Alexander Volkov
volkov added a comment. Thanks for the real-world example. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin, davidedmundson Cc: broulik, davidedmundson, plasma-devel, ZrenBot,

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > michaelh wrote in baloofilepropertiesplugin.desktop:3 > That's was also my first thought. Not sure, but it might appear in dolphin > settings > services Btw you can submit multiple comments at once, this way I don't get a gazillion emails each

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > broulik wrote in baloofilepropertiesplugin.desktop:3 > I don't think this icon is visible in the UI anywhere, certainly not in the > properties dialog That's was also my first thought. Not sure, but it might appear in dolphin settings >

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Kai Uwe Broulik
broulik updated this revision to Diff 24934. broulik added a comment. - Show also for directories REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4614?vs=24928=24934 REVISION DETAIL https://phabricator.kde.org/D4614 AFFECTED FILES

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > michaelh wrote in baloofilepropertiesplugin.desktop:3 > The baloo icon has a magnifying glass in it which is associated with > searching. > The tag-properties icon may be more appropriate. I don't think this icon is visible in the UI anywhere,

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > broulik wrote in baloofilepropertiesplugin.desktop:9 > The widget is primarily for showing additional file metadata (such as image > sizes), there's no such extra information for folders, so I chose not to show > it in this case. I tag and

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > baloofilepropertiesplugin.desktop:3 > +Type=Service > +Icon=baloo > +Name=File Meta Data Properties Page The baloo icon has a magnifying glass in it which is associated with searching. The tag-properties icon may be more appropriate. REPOSITORY

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > michaelh wrote in baloofilepropertiesplugin.desktop:9 > MimeType=inode/directory;application/octet-stream ? The widget is primarily for showing additional file metadata (such as image sizes), there's no such extra information for folders, so I

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > baloofilepropertiesplugin.desktop:9 > +X-KDE-ServiceTypes=KPropertiesDialog/Plugin > +MimeType=application/octet-stream MimeType=inode/directory;application/octet-stream ? REPOSITORY R824 Baloo Widgets REVISION DETAIL

D9638: [effects] add 'Slide Desktops' effect

2018-01-08 Thread Vlad Zagorodniy
zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Added 'Slide docks' option: F5629578: new-option.png We need to disable sliding docks, for example, when using latte-dock. F5629577:

D9638: [effects] add 'Slide Desktops' effect

2018-01-08 Thread Vlad Zagorodniy
zzag updated this revision to Diff 24932. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. Updating https://phabricator.kde.org/D9638: [effects] add 'Slide Desktops' effect - Add 'Slide docks' option REPOSITORY R108 KWin CHANGES SINCE LAST

D9685: Add config for the lockscreen to toggle media controls

2018-01-08 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R120:7878c9988d10: Add config for the lockscreen to toggle media controls (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9685?vs=24790=24931#toc REPOSITORY R120

Minutes Monday Plasma Hangout

2018-01-08 Thread Sebastian Kügler
Minutes and log of today's meeting -- sebas http://www.kde.org | http://vizZzion.orgPlasma Team Meeting, 8 january 2018 Present: romangg, notmart, bshah, d__ed, kbroulik, Sho, sebas romangg: * there is a patch to be reviewed which needs to go in 5.12: https://phabricator.kde.org/D9352 * Diff

D9685: Add config for the lockscreen to toggle media controls

2018-01-08 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D9685 To: davidedmundson, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9684: Load config specified by the LnF theme

2018-01-08 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D9684 To: davidedmundson, #plasma, broulik Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai,

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Kai Uwe Broulik
broulik updated this revision to Diff 24928. broulik added a comment. - Rebase on master - Just use `MimeType=application/octet-stream` REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4614?vs=11528=24928 REVISION DETAIL

D4614: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata

2018-01-08 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D4614 To: broulik, #vdg, #plasma, aacid, dfaure Cc: michaelh, ngraham, cfeck, fabianr, ltoscano, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,

D9352: [libcolorcorrect] Send auto location updates only when desirable

2018-01-08 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9352 To: romangg, #plasma, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D9684: Load config specified by the LnF theme

2018-01-08 Thread Kai Uwe Broulik
broulik added a comment. I like that a lot. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9684 To: davidedmundson, #plasma Cc: broulik, graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: detecting tablet mode

2018-01-08 Thread Marco Martin
On Mon, Jan 8, 2018 at 11:06 AM, Sebastian Kügler wrote: > > FWIW, I have two X1 Yoga laptops (gen1 and gen2) with recent kernels at my > disposal that I could probably test this feature on. to see if it "just works", can you try to just put some dobug output in connection.cpp

Re: detecting tablet mode

2018-01-08 Thread Marco Martin
On Fri, Jan 5, 2018 at 6:24 PM, Martin Flöser wrote: > Am 2018-01-05 16:11, schrieb Marco Martin: >> >> debugging a bit what happens currently on my machine, i don't seem to >> have any event device which libinput_device_switch_has_switch, >> however, when i flip it, i do get

Re: detecting tablet mode

2018-01-08 Thread Sebastian Kügler
On Friday, January 5, 2018 6:24:38 PM CET Martin Flöser wrote: > Am 2018-01-05 16:11, schrieb Marco Martin: > > debugging a bit what happens currently on my machine, i don't seem to > > have any event device which libinput_device_switch_has_switch, > > however, when i flip it, i do get an event,

D9689: Add a per-process CPU usage graph shown in the process list

2018-01-08 Thread Fabian Vogt
fvogt retitled this revision from "[WIP] Add a per-process CPU usage graph shown in the process list" to "Add a per-process CPU usage graph shown in the process list". fvogt edited the test plan for this revision. REPOSITORY R111 KSysguard Library REVISION DETAIL

D9689: [WIP] Add a per-process CPU usage graph shown in the process list

2018-01-08 Thread Fabian Vogt
fvogt updated this revision to Diff 24921. fvogt added a comment. Address review comments. Set a unified alpha for percentage marker and history graph to avoid sudden changes: 33%: Percentage marker 66%: History graph 100%: Text Screenshot is linked in the test plan.

D9678: Delay loading most used model

2018-01-08 Thread David Edmundson
davidedmundson requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D9678 To: broulik, #plasma, mart, davidedmundson Cc: davidedmundson, ngraham, plasma-devel, ZrenBot, progwolff,

D9225: Fix building autotest on platforms where syscalls are not available

2018-01-08 Thread David Edmundson
davidedmundson accepted this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9225 To: bshah, #plasma, fvogt, graesslin, davidedmundson Cc: davidk, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9678: Delay loading most used model

2018-01-08 Thread David Edmundson
davidedmundson added a comment. It's not graphics. I had a working system settings, applied this got a crash #0 QQmlData::wasDeleted (object=0xfffefffe) at ../../include/QtQml/5.10.0/QtQml/private/../../../../../../../qt5/qtdeclarative/src/qml/qml/qqmldata_p.h:301

D9651: [Icons KCM] Construct QUrl from local file

2018-01-08 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:08c0a73303dc: [Icons KCM] Construct QUrl from local file (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9651?vs=24704=24920 REVISION

D9651: [Icons KCM] Construct QUrl from local file

2018-01-08 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9651 To: broulik, #plasma, fvogt, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

2018-01-08 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R108:7ca8771d129f: [TabBox] Dont show Show desktop window when cycling through application… (authored by broulik). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin

D9689: [WIP] Add a per-process CPU usage graph shown in the process list

2018-01-08 Thread Kai Uwe Broulik
broulik added a comment. Screenshot? :) INLINE COMMENTS > ProcessModel.cpp:804 > + * didn't change though. */ > +if(mMapProcessCPUHistory.contains(process)) { > +auto = mMapProcessCPUHistory[process]; Use `find()` to avoid double lookup (contains+operator[]) >

D9678: Delay loading most used model

2018-01-08 Thread Kai Uwe Broulik
broulik added a comment. The crashes I was seeing were graphics hardware issues, shouldn't be caused by this patch. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D9678 To: broulik, #plasma, mart Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,