Re: KDE and Google Summer of Code 2018

Yes, Jan 23 is the deadline for the Org application. Of course we can continue to add, edit and tinker around the edges until the students begin to apply. But we want a lovely list by the 23rd. -v On Wed, Jan 17, 2018 at 9:18 AM, Roman Gilg wrote: > Hi, > > Valorie, do we

Re: Re: KDE and Google Summer of Code 2018

On Jan 19, 2018 6:11 PM, "pointedstick" wrote: > > While we're at it, let's not only re-work existing KCMs, but try to take the opportunity to simplify and consolidate where possible. For example, the Launch Feedback KCM consists only of two checkboxes that could easily be

D9974: Improve header and metadata display

This revision was automatically updated to reflect the committed changes. Closed by commit R134:93bd781900b5: Improve header and metadata display (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9974?vs=25665=25668

D9974: Improve header and metadata display

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska Cc:

D9974: Improve header and metadata display

ngraham marked 2 inline comments as done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska Cc: matheusm, andreaska, januz, romangg, plasma-devel, ZrenBot, progwolff,

D9974: Improve header and metadata display

ngraham updated this revision to Diff 25665. ngraham added a comment. Removed the "Details" header text to prevent string changes so this can go into 5.12 REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9974?vs=25664=25665 BRANCH

D9974: Improve header and metadata display

ngraham updated this revision to Diff 25664. ngraham added a comment. Re-add logic for handling source switcher in description that was mistakenly removed REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9974?vs=25620=25664 BRANCH

Re: Plasma-Mycroft is in kdereview

On Wed, Jan 17, 2018 at 10:26 PM, Marco Martin wrote: > On mercoledì 17 gennaio 2018 06:46:16 CET Aditya Mehra wrote: >> Hi all, >> >> Plasma-Mycroft has been in KDE review over a month, there have been a few >> additions and bug fixes to the plasmoid but nothing major, all

D9974: Improve header and metadata display

matheusm added a comment. What about removing the application name from the header, to avoid redundancy? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska Cc: matheusm,

KDE CI: Plasma libksysguard kf5-qt5 SUSEQt5.9 - Build # 20 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20SUSEQt5.9/20/ Project: Plasma libksysguard kf5-qt5 SUSEQt5.9 Date of build: Fri, 19 Jan 2018 21:31:03 + Build duration: 1 min 16 sec and counting CONSOLE OUTPUT

Fwd: KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Failing!

Hi Laurent, Looks like your commit here introduced a breakage as well. Can you please fix this one too? Regards, Ben -- Forwarded message -- From: CI System Date: Sat, Jan 20, 2018 at 10:30 AM Subject: KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build #

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/8/ Project: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 19 Jan 2018 21:29:36 + Build duration: 59 sec and counting CONSOLE OUTPUT

KDE CI: Plasma libksysguard kf5-qt5 SUSEQt5.9 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20SUSEQt5.9/19/ Project: Plasma libksysguard kf5-qt5 SUSEQt5.9 Date of build: Fri, 19 Jan 2018 21:11:19 + Build duration: 2 min 2 sec and counting CONSOLE OUTPUT

KDE CI: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20libksysguard%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Plasma libksysguard kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 19 Jan 2018 21:11:19 + Build duration: 1 min 29 sec and counting CONSOLE OUTPUT

D9974: Improve header and metadata display

ngraham added inline comments. INLINE COMMENTS > apol wrote in ApplicationPage.qml:227 > This is a new string. Can't have new strings for 5.12. Aww darn. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar,

D9980: Do not reset the size of window once we move it to an edge

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please also add a test case exposing the problem. INLINE COMMENTS > shell_client.cpp:300-301 > connect(this, ::activeChanged, this, configure); > -

Re: KDE and Google Summer of Code 2018

Am 2018-01-18 23:05, schrieb Roman Gilg: Yea, I thought that we could find maybe some intermediate state/goal for the parallel rendering to which we can fallback when the overall goal can't be achieved. I would add a line about the difficulty of this project to the idea list. What do you think

D9944: [WIP]expose if the tablet mode switch is available

graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > mart wrote in tabletmodemanager.cpp:87 > which, would make sense api-wise even if something different than libinput > was used underneath makes sense. VirtualKeyboard also

D9974: Improve header and metadata display

apol requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska Cc: andreaska, januz, romangg,

D9974: Improve header and metadata display

apol added a comment. I like it, some nitpicking: F5664327: Screenshot_20180119_204906.png This is the application delegate, I think it would make sense to do the same use of the blue line that is here. Also I would remove the blue line under

D9974: Improve header and metadata display

colomar accepted this revision. colomar added a comment. This is a clear improvement from my perspective, and I don't see it introducing any usability issues. REPOSITORY R134 Discover Software Store BRANCH combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9974

D9976: Display version alongside source, and use a combobox to switch between them

colomar added a comment. I think that when at the bottom, having the combobox is okay because it's not too prominent. The only problem I see is that it means that changing a combobox changes the content above it, which is not usually expected behavior for a combobox. REPOSITORY R134

D9976: Display version alongside source, and use a combobox to switch between them

andreaska accepted this revision. andreaska added a comment. This revision is now accepted and ready to land. Design look good REPOSITORY R134 Discover Software Store BRANCH actually-use-combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9976 To: ngraham, apol,

D9976: Display version alongside source, and use a combobox to switch between them

colomar added a comment. I think this is a significant improvement. I'm not sure if it's ideal to have the re-layout of the whole page together with the change to the combo box in the same patch, but that's for @apol to decide. REPOSITORY R134 Discover Software Store REVISION DETAIL

Re: Re: KDE and Google Summer of Code 2018

While we're at it, let's not only re-work existing KCMs, but try to take the opportunity to simplify and consolidate where possible. For example, the Launch Feedback KCM consists only of two checkboxes that could easily be moved elsewhere (the cursor part into the Cursors KCM, and the Task

D9965: Provide a tooltip for the main action

apol updated this revision to Diff 25655. apol added a comment. No tooltip on mobile REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9965?vs=25653=25655 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9965 AFFECTED FILES

D9965: Provide a tooltip for the main action

apol updated this revision to Diff 25653. apol added a comment. Make it work for the other actions as well REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9965?vs=25601=25653 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9965 AFFECTED

D9792: even slimmer scrollbars

rikmills added a comment. In Neon and Kubuntu CI with Qt 5.9.3 https://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/186/console 17:55:15 /workspace/build/kstyle/breezestyle.cpp: In member function ‘virtual bool Breeze::Style::drawScrollBarSliderControl(const

Re: KDE and Google Summer of Code 2018

On Fri, Jan 19, 2018 at 4:41 PM, Marco Martin wrote: > On venerdì 19 gennaio 2018 13:42:25 CET David Edmundson wrote: > > Note that they'll be finishing GSOC around the same time as 5.14, so that > > potentially means GSOC work released in 5.15. > > We shouldn't pick high

Re: KDE and Google Summer of Code 2018

On venerdì 19 gennaio 2018 13:42:25 CET David Edmundson wrote: > Note that they'll be finishing GSOC around the same time as 5.14, so that > potentially means GSOC work released in 5.15. > We shouldn't pick high priority ones that we want done before then. basing on the priorities recorded in

D9984: WIP: Add bookmarks runner

broulik created this revision. broulik added reviewers: Plasma, VDG, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This finds bookmarks by querying the browser

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25643. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Moved a shader variable to a uniform, so that the calculation can be done on the CPU instead. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9976: Display version alongside source, and use a combobox to switch between them

ngraham edited reviewers, added: andreaska; removed: andreask. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9976 To: ngraham, apol, colomar, abetts, #discover_software_store, #vdg, andreaska Cc: plasma-devel, romangg, ZrenBot, progwolff, lesliezhai,

D9974: Improve header and metadata display

ngraham removed a reviewer: andreask. REPOSITORY R134 Discover Software Store BRANCH combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, #discover_software_store, #vdg, andreaska Cc: andreaska, januz, romangg, plasma-devel,

D9974: Improve header and metadata display

andreaska accepted this revision. andreaska added a comment. This revision is now accepted and ready to land. Big improvement from design and usability. Top the app information and bottom tecnical stuff REPOSITORY R134 Discover Software Store BRANCH combobox-to-choose-source REVISION

D9974: Improve header and metadata display

januz added a comment. +1 Looks way more organized, and it's easier to grasp what application you're seeing and what it does on a quick glance. Minor nitpick: I'd add more margin around the summary text (to separate it better from screenshots and the summary link). REPOSITORY R134

D9967: Acknowledge the server side deco mode in WaylandServer not ShellClient

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH deco-acknowledge-server-5.12 REVISION DETAIL https://phabricator.kde.org/D9967 To: graesslin, #kwin, #plasma, davidedmundson Cc: ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,

D9974: Improve header and metadata display

ngraham edited the test plan for this revision. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9974 To: ngraham, apol, abetts, colomar, andreask, #discover_software_store, #vdg Cc: romangg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9976: Display version alongside source, and use a combobox to switch between them

ngraham marked 4 inline comments as done. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D9976 To: ngraham, apol, colomar, abetts, andreask, #discover_software_store, #vdg Cc: plasma-devel, romangg, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9976: Display version alongside source, and use a combobox to switch between them

ngraham updated this revision to Diff 25640. ngraham added a comment. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Make state() into const functions REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D9965: Provide a tooltip for the main action

mart added inline comments. INLINE COMMENTS > apol wrote in ActionButton.qml:115 > We can create a new Kirigami.Units.toolTipDelay +1, and the desktop style could use the value provided by qwidgets (while for the other ones is fine a sensible-looking hardcoded value) REPOSITORY R169

D9965: Provide a tooltip for the main action

mart added a comment. in general, +1, tough there is something more to do here. it already shown a notification on press and hold with the text, which should be ported to qqc2 tooltips instead of both things on top of each other. also, should depend from Settings.isMobile: when false, it

D9945: Don't close plasmoid when closing a subdialog

hein added a comment. Sorry, please ignore the .desktop noise in review. I'll fix it on push. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9945 To: hein, #plasma Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9945: Don't close plasmoid when closing a subdialog

hein retitled this revision from "Don't close plasmoid when closing a subdialog via index change in a parent subdialog" to "Don't close plasmoid when closing a subdialog". hein edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9945: Don't close plasmoid when closing a subdialog via index change in a parent subdialog

hein updated this revision to Diff 25639. hein added a comment. Address both bugs in one. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9945?vs=25541=25639 BRANCH fixfocushandover REVISION DETAIL https://phabricator.kde.org/D9945 AFFECTED

D9945: Don't close plasmoid when closing a subdialog via index change in a parent subdialog

hein added a comment. @ngraham: I guess both work but the non-space one is the historical one ... oh well :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9945 To: hein, #plasma Cc: ngraham, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25638. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Fixed a bug where updating the blur strength would not update the blurred area. With this fix every window gets updated when the blur strength is

Re: KDE and Google Summer of Code 2018

> * wacom tablet support (libinput in KWin, useful support in KWin, KWayland > protocol, QtWayland protocol) > Good idea, I'd be happy to mentor that. I'll write it up. David

Re: KDE and Google Summer of Code 2018

On Fri, Jan 19, 2018 at 9:42 AM, Marco Martin wrote: > On Mon, Jan 15, 2018 at 8:15 PM, Nate Graham > wrote: > > I've submitted an idea for System Settings: Improve handling for > touchpads > > and mice with Libinput > > Speaking of systemsettings,

D9414: Implement OSD to select action when unknown monitors is connected

dvratil updated this revision to Diff 25635. dvratil added a comment. Please disregard the noise in this patch, sebas merged master into the dvratil/osd branch so I can't generate a proper diff against the base revision without the noise from master. REPOSITORY R104 KScreen CHANGES SINCE

D9414: Implement OSD to select action when unknown monitors is connected

dvratil marked 15 inline comments as done. dvratil added inline comments. INLINE COMMENTS > broulik wrote in osdmanager.cpp:60 > Shouldn't it rather do that in the plugin's `registerTypes`? We don't have a QML plugin :( This is the only C++ class that is exposed to the OSD QML. > broulik

D9980: Do not reset the size of window once we move it to an edge

jgrulich added a subscriber: plasma-devel. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9980 To: jgrulich, graesslin Cc: plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D9967: Acknowledge the server side deco mode in WaylandServer not ShellClient

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH deco-acknowledge-server-5.12 REVISION DETAIL https://phabricator.kde.org/D9967 To: graesslin, #kwin,

Re: Allow removal of taskbbar panel shadow in Wayland?

​Just change the plasma theme. David

Re: KDE and Google Summer of Code 2018

On Mon, Jan 15, 2018 at 8:15 PM, Nate Graham wrote: > I've submitted an idea for System Settings: Improve handling for touchpads > and mice with Libinput Speaking of systemsettings, would be a good fit porting to qml some medium-to-big kcm? -- Marco Martin

Allow removal of taskbbar panel shadow in Wayland?

Hi, I keep my taskbar panel on the left side of my screen and use a script at startup to hide the shadow: #!/bin/sh for WID in `xwininfo -root -tree | sed '/"Plasma": ("plasmashell" "plasmashell")/!d; s/^ *\([^ ]*\) .*/\1/g'`; do xprop -id $WID -remove _KDE_NET_WM_SHADOW done This doesn't

D9506: milti-screen sleep fix

McPain added a comment. In https://phabricator.kde.org/D9506#193271, @sebas wrote: > Okay, patch as-is now definitely breaks unplugging outputs, it eats these events. I'll mark it as such, if you fix it in another way, either update this or create a new review. Yesterday I

D9892: cmake: Use the official CMake variable for building as a static plugin.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:8c34dde112e7: cmake: Use the official CMake variable for building as a static plugin. (authored by mart). CHANGED

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 78 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/78/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 19 Jan 2018 09:52:37 + Build duration: 20 min and counting JUnit Tests

D9978: [Notifications] Put history into a ListView

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:e8f76cc5386d: [Notifications] Put history into a ListView (authored by broulik). REPOSITORY R120 Plasma Workspace

D9979: [Notifications] Disable history check box when notifications are disabled

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c81a0151f50e: [Notifications] Disable history check box when notifications are disabled (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9979?vs=25625=25628#toc

D9944: [WIP]expose if the tablet mode switch is available

mart added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > mart wrote in tabletmodemanager.cpp:87 > I tought as much, but would be possible then to expose the property in an > abstract way from the core for this to read? > maybe something

D9944: [WIP]expose if the tablet mode switch is available

mart added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > graesslin wrote in tabletmodemanager.cpp:87 > Impossible! That's violating the layering. KWin core does not depend or > interact with libinput for our overall sanity. I tought as

D8652: Add supported transformations to OutputDevice

sebas added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Dingdong? REPOSITORY R127 KWayland BRANCH supported-transformations REVISION DETAIL https://phabricator.kde.org/D8652 To: graesslin, #frameworks, #kwin, #plasma, sebas,

D9979: [Notifications] Disable history check box when notifications are disabled

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9979 To: broulik, #plasma, #vdg, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

Re: KDE and Google Summer of Code 2018

On Thu, Jan 18, 2018 at 7:51 PM, Martin Flöser wrote: > Am 2018-01-17 18:18, schrieb Roman Gilg: >> >> Hi, >> >> Valorie, do we have until 23rd with project ideas? I didn't want to >> mentor this year because I only was a GSoC student last year, but >> since there are not yet

D9506: milti-screen sleep fix

sebas requested changes to this revision. sebas added a comment. Okay, patch as-is now definitely breaks unplugging outputs, it eats these events. I'll mark it as such, if you fix it in another way, either update this or create a new review. REPOSITORY R110 KScreen Library REVISION

D9963: [KCMShell] Don't assume KCModuleProxy is our child widget

This revision was automatically updated to reflect the committed changes. Closed by commit R126:25132c48039d: [KCMShell] Dont assume KCModuleProxy is our child widget (authored by broulik). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D9979: [Notifications] Disable history check box when history is disabled

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY You cannot have a history of notifications if you don't get

D9979: [Notifications] Disable history check box when notifications are disabled

broulik edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9979 To: broulik, #plasma, #vdg Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9979: [Notifications] Disable history check box when notifications are disabled

broulik retitled this revision from "[Notifications] Disable history check box when history is disabled" to "[Notifications] Disable history check box when notifications are disabled". REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9979 To: broulik, #plasma,

D9978: [Notifications] Put history into a ListView

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Notification uses Repeaters for everything. While