KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 85 - Still unstable!

2018-01-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/85/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 24 Jan 2018 06:18:42 + Build duration: 9 min 25 sec and counting JUnit

D10065: Fix brightness shortcuts in the whitelist

2018-01-23 Thread Martin Flöser
graesslin added a comment. And on Wayland it is KWin. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D10065 To: dos, #plasma Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10066: Add touchpad shortcuts to the whitelist

2018-01-23 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > globalaccel.cpp:59 > +)}, > +{QStringLiteral("/component/kcm_touchpad"), QRegularExpression( > +QStringLiteral("Toggle Touchpad|Enable

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 84 - Failure!

2018-01-23 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/84/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 24 Jan 2018 04:14:26 + Build duration: 3 min 24 sec and counting CONSOLE

[Powerdevil] [Bug 353463] RFE: Make use of iio-sensor-proxy

2018-01-23 Thread Sebastian Krzyszkowiak
https://bugs.kde.org/show_bug.cgi?id=353463 Sebastian Krzyszkowiak changed: What|Removed |Added CC||k...@dosowisko.net

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

2018-01-23 Thread Sebastian Krzyszkowiak
Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, fredrik Cc: dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

2018-01-23 Thread Sebastian Krzyszkowiak
Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, fredrik Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham,

D10065: Fix brightness shortcuts in the whitelist

2018-01-23 Thread Sebastian Krzyszkowiak
dos edited the summary of this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D10065 To: dos, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8481: Adjusted scrollbars to fit the Qt theme

2018-01-23 Thread Sebastian Krzyszkowiak
dos abandoned this revision. dos added a comment. Although I really like smaller scrollbars and will keep them in my gtkrc, it turns out it's not really intended in Qt - my session had DPI adjusted only by font setting, the screen scaling factor was still 1. After adjusting the screen

D10066: Add touchpad shortcuts to the whitelist

2018-01-23 Thread Sebastian Krzyszkowiak
dos created this revision. dos added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dos requested review of this revision. REVISION SUMMARY My laptop's ACPI has a weird habit of sending the touchpad toggle key stroke

D10065: Fix brightness shortcuts in the whitelist

2018-01-23 Thread Sebastian Krzyszkowiak
dos created this revision. dos added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dos requested review of this revision. REVISION SUMMARY Since 5.12, screen and keyboard brightness shortcuts are sent from

D10027: Removed duplicate preview screenshots

2018-01-23 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R134:68c1aaabadf7: Removed duplicate preview screenshots (authored by anemeth, committed by davidedmundson). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D10027: Removed duplicate preview screenshots

2018-01-23 Thread Alex Nemeth
anemeth added a comment. I don't think I have push access. Can you do it instead? REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D10027 To: anemeth, apol, #discover_software_store, davidedmundson, abetts Cc: ngraham, plasma-devel,

Re: Comments for ‘The Lord of the Rings’ references in fuzzy clock widget

2018-01-23 Thread Luigi Toscano
Karl Ove Hufthammer ha scritto: > The translation file for the ‘fuzzy clock’ widget now contains some strange > ‘times of day’, like ‘Elevenses’ and ‘Second Breakfast’. It turns out that > these are actually references to the ‘The Lord of the Rings’ and ‘The Hobbit’ > novels: > >  

Re: Allow removal of taskbar panel shadow in Wayland?

2018-01-23 Thread David Edmundson
​>Is there any possibility for adding an option to hide the plasma panel shadows? To change how UI elements appear, change the theme. You can find a theme editor in plasma-sdk. You then won't need this interesting solution. David

D10060: Enable blending if a subsurface has an alpha channel

2018-01-23 Thread Roman Gilg
romangg added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > scene_opengl.cpp:1383 > texture->render(region, QRect(0, 0, texture->width() / scale, > texture->height() / scale), hardwareClipping); > texture->unbind(); >

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread Nathaniel Graham
ngraham added a comment. Someone in the VDG room suggested the following (or something like it) for the "currently playing something" icon: http://www.iconninja.com/files/407/146/323/note-audio-play-sound-listen-song-music-icon.svg And when not playing, it could have a line through the

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread Nicolas Fella
nicolasfella added a comment. Before F5671035: IMG_20180123_205152_958.jpg After F5671036: IMG_20180123_205201_049.jpg REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread Andres Betts
abetts added a comment. Could you please share a screenshot of the issue? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10032 To: nicolasfella, #plasma, #vdg Cc: abetts, davidedmundson, broulik, ngraham, plasma-devel, #vdg, ZrenBot, progwolff,

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread Nathaniel Graham
ngraham added a comment. > *but* they're not re-using the same icon in both cases, which I think is interesting. I think that's the key. If we can use different icons for the state and the action, the complaints may just vanish. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread David Edmundson
davidedmundson added a comment. This is a gnome extension: http://www.omgubuntu.co.uk/wp-content/uploads/2016/09/music-control-gnome-extensions.jpg They have the state and action icons matching as we do. It's clearly playing, and the tray icon shows a play icon, big action button

D10060: Enable blending if a subsurface has an alpha channel

2018-01-23 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread David Edmundson
davidedmundson added a comment. > That might be a sign that it's unintuitive and confusing for a lot of our users. Perhaps we should reconsider. I agree there's a problem. We have the same icon meaning two different things and there's no visual clues to infer from context. But I'm

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread Kai Uwe Broulik
broulik added a comment. Can you show me examples of how this is "common across various media players"? Amarok does the same as media controller does. And why this particular //status// indicator should behave differently from any other indicator next to it? Following your reasoning

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread Nathaniel Graham
ngraham added a comment. We are currently discussing the matter in the https://phabricator.kde.org/tag/vdg/ Telegram room, but I'll mention that so far, sentiments are overwhelmingly in favor of the patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread Nathaniel Graham
ngraham added a comment. In https://phabricator.kde.org/D10032#194606, @broulik wrote: > A patch like this comes up time and again. That might be a sign that it's unintuitive and confusing for a lot of our users. Perhaps we should reconsider. REPOSITORY R120 Plasma Workspace

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

2018-01-23 Thread Nathaniel Graham
ngraham added a comment. Looks like it also fixes basically everything in 371023, no? That bug is a bit of a hodgepodge, so if it were me, I'd also add BUG: 371023 and ask the reporter to file new bugs for any remaining issues. REPOSITORY R114 Plasma Addons REVISION DETAIL

D10057: Require libinput and udev

2018-01-23 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D10056: [Look and feel KCM] Sync color group after copying over color file values

2018-01-23 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10056 To: broulik, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10056: [Look and feel KCM] Sync color group after copying over color file values

2018-01-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 370162 FIXED-IN: 5.12.0 TEST PLAN Changed look and feel

D9944: [WIP]expose if the tablet mode switch is available

2018-01-23 Thread Martin Flöser
graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > mart wrote in tabletmodemanager.cpp:87-96 > yes, the point is to expose it to applications (on plasma i wouldn't want a > "show this only in tablet mode" option visible (or at

D10055: [Look and feel KCM] Keep cursor size when applying theme

2018-01-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I have configured my system to use an 48 px mouse cursor. When

D9984: WIP: Add bookmarks runner

2018-01-23 Thread Andres Betts
abetts added a comment. I like this idea. Can the bookmark list be offloaded to a temp file while the browser isn't running? REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D9984 To: broulik, #plasma, #vdg, davidedmundson Cc: abetts, mart,

D9944: [WIP]expose if the tablet mode switch is available

2018-01-23 Thread Marco Martin
mart added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > graesslin wrote in tabletmodemanager.cpp:87-96 > is this method still needed? yes, the point is to expose it to applications (on plasma i wouldn't want a "show this only in tablet

D9878: [Notifications] Keep notification popup open when covered by fullscreen window

2018-01-23 Thread Andres Betts
abetts added a comment. I am in favor of this idea visually. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9878 To: broulik, #plasma, hein, graesslin, #vdg Cc: abetts, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10053: Fix typo

2018-01-23 Thread Roman Gilg
This revision was automatically updated to reflect the committed changes. Closed by commit R127:6ad30db92316: Fix typo (authored by romangg). Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D9895: [UDisks] Ignore non-user mounts

2018-01-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R245:1384f275ab2f: [UDisks] Ignore non-user mounts (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9895?vs=25408=25828 REVISION DETAIL

D9967: Acknowledge the server side deco mode in WaylandServer not ShellClient

2018-01-23 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:339a08de3883: Acknowledge the server side deco mode in WaylandServer not ShellClient (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin

D9944: [WIP]expose if the tablet mode switch is available

2018-01-23 Thread Martin Flöser
graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > tabletmodemanager.cpp:87-96 > +void TabletModeManager::setTabletModeAvailable(bool available) > +{ > +//TODO: we need to access to libinput::connection from here > +if

D9895: [UDisks] Ignore non-user mounts

2018-01-23 Thread Kai Uwe Broulik
broulik edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9895 To: broulik, #plasma, #vdg, #frameworks, bshah Cc: mart, ngraham, sitter, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10053: Fix typo

2018-01-23 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D10053 To: romangg, #plasma,

D10053: Fix typo

2018-01-23 Thread Roman Gilg
romangg added a reviewer: Plasma. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10053 To: romangg, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10053: Fix typo

2018-01-23 Thread Roman Gilg
romangg created this revision. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. romangg requested review of this revision. REVISION SUMMARY Fix a typo REPOSITORY R127 KWayland BRANCH master REVISION

D9286: don't multiply svg sizes by devicepixelratio

2018-01-23 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R242:af00946f81c6: dont multiply svg sizes by devicepixelratio (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9286?vs=23759=25823

D8916: QML port of fonts kcm

2018-01-23 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:24b960f92284: QML port of fonts kcm (authored by mart). CHANGED PRIOR TO COMMIT

D9895: [UDisks] Ignore non-user mounts

2018-01-23 Thread Bhushan Shah
bshah accepted this revision as: bshah. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9895 To: broulik, #plasma, #vdg, #frameworks, bshah Cc: mart, ngraham, sitter, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

2018-01-23 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > main.qml:67 > + > +// TODO use contentsSize but that crashes, now mostly for some sane > initial size > +Layout.preferredWidth: units.gridUnit * 25 QTBUG-65942 REPOSITORY R114 Plasma Addons REVISION DETAIL

D8692: QML mouse cursor KCM and components

2018-01-23 Thread Marco Martin
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:bd95edf3abd8: QML mouse cursor KCM and components (authored by mart). CHANGED PRIOR TO COMMIT

D4353: [Applet Configuration] Add mnemonics for dialog buttons

2018-01-23 Thread Kai Uwe Broulik
broulik added a comment. I think the auto mnemonic stuff only affects QQC2? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4353 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9325: Use QUrl in the ScreenMapper API

2018-01-23 Thread Eike Hein
hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9325 To: amantia, #plasma, mwolff, broulik, hein Cc: ervin, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9951: [KUserProxy] Adjust to accounts service

2018-01-23 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. with Aleix's comment addressed in both places. (or just put the slash on accountsServiceIconPath) REPOSITORY R296 KDeclarative REVISION DETAIL

D4353: [Applet Configuration] Add mnemonics for dialog buttons

2018-01-23 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Is this the right approach given the auto mnemoics stuff Marco wrote which is merged now? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10040: Add serial number and EISA ID to OutputDevice interface

2018-01-23 Thread Daniel Vrátil
dvratil updated this revision to Diff 25806. dvratil marked an inline comment as done. dvratil added a comment. Fix versioning REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10040?vs=25802=25806 BRANCH master REVISION DETAIL

D10040: Add serial number and EISA ID to OutputDevice interface

2018-01-23 Thread Daniel Vrátil
dvratil marked 2 inline comments as done. dvratil added inline comments. INLINE COMMENTS > davidedmundson wrote in outputdevice_interface.cpp:450 > You're not actually sending the serial number or eisa anywhere.. > > The others do it in sendGeometry (including the manufacturer) > > When you do

D10042: Parse EDID on the backend side

2018-01-23 Thread Daniel Vrátil
dvratil added a dependency: D10040: Add serial number and EISA ID to OutputDevice interface. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D10042 To: dvratil, sebas Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10040: Add serial number and EISA ID to OutputDevice interface

2018-01-23 Thread Daniel Vrátil
dvratil added a dependent revision: D10042: Parse EDID on the backend side. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: dvratil, graesslin, sebas Cc: davidedmundson, plasma-devel, #frameworks, schernikov, ZrenBot, ngraham, alexeymin, progwolff,

D10042: Parse EDID on the backend side

2018-01-23 Thread Daniel Vrátil
dvratil created this revision. dvratil added a reviewer: sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dvratil requested review of this revision. REVISION SUMMARY Parse EDID on the backend side so that backends that don't have

D10040: Add serial number and EISA ID to OutputDevice interface

2018-01-23 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > outputdevice.xml:32 > > > you need to bump this > outputdevice_interface.cpp:450 > SETTER(setModel, const QString&, model) > +SETTER(setSerialNumber, const QString&, serialNumber) > +SETTER(setEisaId, const QString&, eisaId)

D10040: Add serial number and EISA ID to OutputDevice interface

2018-01-23 Thread Daniel Vrátil
dvratil added a dependent revision: D10041: Improve EDID information on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: dvratil, graesslin, sebas Cc: plasma-devel, #frameworks, schernikov, ZrenBot, ngraham, alexeymin, progwolff, lesliezhai,

D10040: Add serial number and EISA ID to OutputDevice interface

2018-01-23 Thread Daniel Vrátil
dvratil created this revision. dvratil added reviewers: graesslin, sebas. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. dvratil requested review of this revision. REPOSITORY R127 KWayland BRANCH

D9286: don't multiply svg sizes by devicepixelratio

2018-01-23 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I'm 100% convinced Plasma needs to multiply it as it does everything in device pixels. However: void FrameSvgItem::updateDevicePixelRatio()

D9223: [Plasma Dialog] Call window effects only if visible

2018-01-23 Thread Kai Uwe Broulik
broulik closed this revision. broulik added a comment. https://cgit.kde.org/plasma-framework.git/commit/?id=f3cd5d55fa323e65c0b01794a59b801d2716634a REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9223 To: broulik, #plasma, graesslin, apol Cc:

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

2018-01-23 Thread Kai Uwe Broulik
broulik edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10039 To: broulik, #plasma, #vdg, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10039: [WebBrowser Plasmoid] Port to QtWebEngine

2018-01-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY QtWebkit is old, unmaintained, possibly

D9325: Use QUrl in the ScreenMapper API

2018-01-23 Thread Andras Mantia
amantia edited reviewers, added: hein; removed: dakon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9325 To: amantia, #plasma, mwolff, broulik, hein Cc: ervin, mlaurent, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9325: Use QUrl in the ScreenMapper API

2018-01-23 Thread Andras Mantia
amantia added inline comments. INLINE COMMENTS > mwolff wrote in foldermodel.cpp:1509 > not your change: why is m_url not an url :-/ > > also: introduce the helper function you have in the tests here, too - maybe > even move it into a static function in the ScreenMapper and then use it >

D9325: Use QUrl in the ScreenMapper API

2018-01-23 Thread Andras Mantia
amantia updated this revision to Diff 25799. amantia added a comment. Change code according to reviewer's requests REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9325?vs=23954=25799 BRANCH master REVISION DETAIL

D10038: Use QTemporaryDir::filePath() instead of path concatenation

2018-01-23 Thread Alexander Volkov
volkov created this revision. volkov added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY This is the preferred way to get a file path in a temporary

D9878: [Notifications] Keep notification popup open when covered by fullscreen window

2018-01-23 Thread Marco Martin
mart added a comment. I'm a bit hesitant adding a taskmodel instance just for that.. i'm wondering if there are some models we might want to share across the whole process.. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9878 To: broulik, #plasma, hein,

D9895: [UDisks] Ignore non-user mounts

2018-01-23 Thread Marco Martin
mart added a comment. +100 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D9895 To: broulik, #plasma, #vdg, #frameworks Cc: mart, ngraham, sitter, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D9984: WIP: Add bookmarks runner

2018-01-23 Thread Marco Martin
mart added a comment. the problem is when the browser isn't running REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D9984 To: broulik, #plasma, #vdg, davidedmundson Cc: mart, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10016: [KFileTreeView] Manually expand tree when model tells us to

2018-01-23 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D10016 To: broulik, #plasma, dfaure, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10024: Add supportedSchemes feature

2018-01-23 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. ship it with the extra check Aleix noted REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10024 To: mwolff, #plasma, dfaure, mart Cc: mart, apol,

D10025: Use KFileWidget::setSupportedSchemes when available

2018-01-23 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D10025 To: mwolff, dfaure, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9944: [WIP]expose if the tablet mode switch is available

2018-01-23 Thread Marco Martin
mart marked an inline comment as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9944 To: mart, #kwin, #plasma Cc: graesslin, ngraham, davidedmundson, plasma-devel, kwin, iodelay, bwowk, ZrenBot,

D10037: Remove QT_VERSION checks

2018-01-23 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10037 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10037: Remove QT_VERSION checks

2018-01-23 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10037 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10037: Remove QT_VERSION checks

2018-01-23 Thread Alexander Volkov
volkov added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10037 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10037: Remove QT_VERSION checks

2018-01-23 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY We require Qt 5.9, so these checks are redundant. REPOSITORY R119 Plasma Desktop BRANCH

D10036: Bump Qt version to 5.9

2018-01-23 Thread Alexander Volkov
volkov closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10036 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10036: Bump Qt version to 5.9

2018-01-23 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D10036 To: volkov, #plasma, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10036: Bump Qt version to 5.9

2018-01-23 Thread Alexander Volkov
volkov added a reviewer: Plasma. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10036 To: volkov, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10036: Bump Qt version to 5.9

2018-01-23 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY For Plasma/5.12. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.12 REVISION DETAIL

D10031: Fix potential crash

2018-01-23 Thread Marco Martin
mart added a comment. ship it with the caveat david said, a Qt bug report REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D10031 To: apol, #kirigami, mart Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10031: Fix potential crash

2018-01-23 Thread David Edmundson
davidedmundson added a comment. Working round a Qt bug needs a Qt bug report in a code comment. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D10031 To: apol, #kirigami, mart Cc: davidedmundson, plasma-devel, ZrenBot, progwolff,

D9944: [WIP]expose if the tablet mode switch is available

2018-01-23 Thread Marco Martin
mart updated this revision to Diff 25794. mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. - fix logic REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9944?vs=25763=25794 BRANCH phab/tabletModeSupported REVISION

D9506: milti-screen sleep fix

2018-01-23 Thread Oleg Solovyov
McPain abandoned this revision. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D9506 To: McPain, sebas, drosca Cc: zerg, anthonyfieroni, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 369 - Still unstable!

2018-01-23 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/369/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 Date of build: Tue, 23 Jan 2018 08:47:25 + Build duration: 28 min and counting JUnit Tests

D10024: Add supportedSchemes feature

2018-01-23 Thread Milian Wolff
mwolff added a comment. In https://phabricator.kde.org/D10024#194431, @apol wrote: > Makes sense I guess. > > Sounds like it would be useful to set this through kiosk, would that work? Probably, but I have zero experience about kiosk. I'd have to read the defaults from a

KDE CI: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 - Build # 368 - Failure!

2018-01-23 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.9/368/ Project: Plasma plasma-workspace kf5-qt5 SUSEQt5.9 Date of build: Tue, 23 Jan 2018 06:57:32 + Build duration: 1 hr 27 min and counting CONSOLE

D10032: Swap play/pause icons in mediacontroller plasmoid

2018-01-23 Thread Kai Uwe Broulik
broulik added a comment. A patch like this comes up time and again. The tray icon indicates the current playback state whereas the button changes to the one displayed. > which is common across various media players. Please provide some evidence on that REPOSITORY R120 Plasma