D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

sharvey updated this revision to Diff 32938. sharvey added a comment. - Turned off "glow" effect on vendor URL; was rendering strange transparency REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12479?vs=32917=32938 BRANCH

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. In D12311#252212 , @stikonas wrote: > In D12311#252165 , @bruns wrote: > > > Resizing:

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

ngraham added a comment. I do like this as a vastly superior replacement for "minimize to tray", yeah. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12463 To: Fuchs, hein Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12481: Add dptr to models

nicolasfella updated this revision to Diff 32924. nicolasfella added a comment. - Remove unneeded modifier REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12481?vs=32921=32924 BRANCH dptr REVISION DETAIL

D12481: Add dptr to models

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in models.h:81 > Why `void*`? So we can replace it with a "real" private class when we need it without creating a empty one now REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D12481

D12481: Add dptr to models

broulik added inline comments. INLINE COMMENTS > models.h:47 > > -~AbstractModel() override; > +virtual ~AbstractModel() override; > QHash roleNames() const Q_DECL_FINAL; The `override` is sufficient > models.h:81 > +private: > +void *d; > }; Why `void*`?

D12481: Add dptr to models

nicolasfella updated this revision to Diff 32921. nicolasfella added a comment. - Add license header REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12481?vs=32920=32921 BRANCH dptr REVISION DETAIL https://phabricator.kde.org/D12481

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

abetts added a comment. +1 REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D12479 To: sharvey, davidedmundson, ngraham Cc: abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

sharvey added a comment. A little UI polishing, just for the details panel. The redesign of the main dialog is still under discussion (T8569 , D12311 ) so I touched up the details. Does anyone know of an application

D12481: Add dptr to models

nicolasfella updated this revision to Diff 32920. nicolasfella added a comment. - Coding style REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12481?vs=32919=32920 BRANCH dptr REVISION DETAIL https://phabricator.kde.org/D12481 AFFECTED

D12481: Add dptr to models

nicolasfella created this revision. nicolasfella added reviewers: drosca, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Last exported classes without dptr TEST PLAN

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

sharvey added a comment. **Before** F5819725: polkit-details-before.png **After** F5819727: polkit-details-after.png REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

sharvey created this revision. sharvey added reviewers: davidedmundson, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. sharvey requested review of this revision. REVISION SUMMARY Aligned detail item labels; added "Not

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

Fuchs added a comment. On the existing bug: it's related to the TODO, changing that to for (int i = 0; i < d->concatProxyModel->rowCount(); ++i) { const QModelIndex = d->concatProxyModel->index(i, 0); // Launchers can't be pinned / unpinned if

D12476: kcm_opengl: Fix retrieval of DRI information

roberts created this revision. roberts added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. roberts requested review of this revision. REVISION SUMMARY Currently DRI information retrieval is attempted via /proc/dri,

D12455: kcm_opengl: Fix EGL info retrieval.

fvogt added a comment. What about Plasma/5.12? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D12455 To: roberts, #plasma, davidedmundson, graesslin Cc: fvogt, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D12455: kcm_opengl: Fix EGL info retrieval.

This revision was automatically updated to reflect the committed changes. Closed by commit R102:f4af6581d03e: kcm_opengl: Fix EGL info retrieval. (authored by roberts). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12455?vs=32837=32903 REVISION DETAIL

D12469: Fix avatar picture aliasing and stretching in kickoff

ktatunov updated this revision to Diff 32902. ktatunov added a comment. Replace `mipmap` with `sourceSize`. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12469?vs=32891=32902 REVISION DETAIL https://phabricator.kde.org/D12469 AFFECTED FILES

D12469: Fix avatar picture aliasing and stretching in kickoff

ktatunov added a comment. Thanks for the pointer. Upon further investigation it looks like setting sourceSize.width: width sourceSize.height: height instead of mipmap works well for more or less square images. However, for images that are significantly wider than they are

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol updated this revision to Diff 32897. apol added a comment. adapt REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=32887=32897 BRANCH arcpatch-D5961 REVISION DETAIL https://phabricator.kde.org/D5961 AFFECTED FILES

D12278: WIP: [Colors KCM] Port to new design

ngraham added a comment. Beautiful! Could we move the pushbuttons over like 2 pixels to the left so they're vertically aligned with the labels above them? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To: broulik, #plasma, #vdg Cc: mart, abetts,

D12278: WIP: [Colors KCM] Port to new design

broulik added a comment. This is what it will most likely look like once the tinting of controls has been figured out F5819517: Screenshot_20180423_185432.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12278 To:

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

Fuchs added a comment. In D12463#252419 , @ngraham wrote: > This is a neat feature, but I worry that it would muddy the difference between the regular task manager and the icons-only task manager. It's not inconceivable that a user wanting to

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

ngraham added a comment. This is a neat feature, but I worry that it would muddy the difference between the regular task manager and the icons-only task manager. It's not inconceivable that a user wanting to get an IOTM-style panel would resort to using this feature to force every single

D12469: Fix avatar picture aliasing and stretching in kickoff

davidedmundson added a comment. setting sourceWidth/height so that it resizes before the texture upload REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12469 To: ktatunov, #plasma Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12469: Fix avatar picture aliasing and stretching in kickoff

ktatunov added a comment. In D12469#252388 , @davidedmundson wrote: > why mipmap? Because smooth property is enabled by default and it's apparently not enough for a good looking image. Unless I'm missing something, nothing else is

D12469: Fix avatar picture aliasing and stretching in kickoff

davidedmundson added a comment. why mipmap? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12469 To: ktatunov, #plasma Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12469: Fix avatar picture aliasing and stretching in kickoff

ktatunov created this revision. ktatunov added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ktatunov requested review of this revision. REVISION SUMMARY QML Image element has some smoothing when scaling an image by

D12468: Enable anti-aliasing for user avatars

ktatunov updated this revision to Diff 32890. ktatunov added a comment. Qt::IgnoreAspectRatio -> Qt::KeepAspectRatio REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12468?vs=32880=32890 REVISION DETAIL https://phabricator.kde.org/D12468 AFFECTED

D12278: WIP: [Colors KCM] Port to new design

abetts added a comment. In D12278#252314 , @ngraham wrote: > Hmm, I'm not sure those white strips communicate "This is what text looks like." I think some sort of placeholder text would work better. To be honest I kinda liked the first one

D12468: Enable anti-aliasing for user avatars

abetts added a comment. +1 REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D12468 To: ktatunov, #plasma, davidedmundson Cc: abetts, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I think so. Then ship it! REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D12468 To: ktatunov, #plasma, davidedmundson Cc:

D12468: Enable anti-aliasing for user avatars

ktatunov added a comment. In D12468#252342 , @davidedmundson wrote: > why ignore aspect ratio? I kept the default behaviour for this argument since it wasn't what I was after. But now that you mention it it would probably be better to

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol updated this revision to Diff 32887. apol added a comment. Rebase to master REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=15686=32887 BRANCH arcpatch-D5961 REVISION DETAIL https://phabricator.kde.org/D5961 AFFECTED

D12468: Enable anti-aliasing for user avatars

davidedmundson added a comment. why ignore aspect ratio? REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D12468 To: ktatunov, #plasma Cc: davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D12468: Enable anti-aliasing for user avatars

ngraham added a comment. +1! REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D12468 To: ktatunov, #plasma Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12468: Enable anti-aliasing for user avatars

ktatunov created this revision. ktatunov added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ktatunov requested review of this revision. REVISION SUMMARY By default, QT uses fast transformations when scaling pixmaps

D12278: WIP: [Colors KCM] Port to new design

ngraham added a comment. Hmm, I'm not sure those white strips communicate "This is what text looks like." I think some sort of placeholder text would work better. To be honest I kinda liked the first one better, but I think it's mostly moot until we can show a real window or view preview.

D12375: [Power Management Engine] Fix kiosk restriction for lockscreen

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4932c6e2cbc9: [Power Management Engine] Fix kiosk restriction for lockscreen (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D12376: [ContextMenu Containment Action] Fix checking for KIOSK

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cfd77db90cf6: [ContextMenu Containment Action] Fix checking for KIOSK (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D12278: WIP: [Colors KCM] Port to new design

broulik updated this revision to Diff 32881. broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Implement applying color schemes and notifying applications about that - Implement "Install from file" including drag and drop

D12459: [Icon KCM] Port to new design

zzag added a comment. In D12459#252290 , @broulik wrote > Looks just like compression artefact in the screenshot. The theme cannot be uninstalled as it's system-wide and the thin lines seemed to throw it off. Yeah, it makes sense.

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

This revision was automatically updated to reflect the committed changes. Closed by commit R119:101b5f749aa9: Add KCM for adjusting QtQuick Rendering in Plasma (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12449: Add hidden system setting group

This revision was automatically updated to reflect the committed changes. Closed by commit R124:2b158ac36aa6: Add hidden system setting group (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12449?vs=32813=32878#toc REPOSITORY R124 System Settings CHANGES

D12459: [Icon KCM] Port to new design

broulik added a comment. In D12459#252269 , @zzag wrote: > Delete button is not visible in the attached video at 0:14 (when you hover Breeze). Looks just like compression artefact in the screenshot. The theme cannot be uninstalled as

D12449: Add hidden system setting group

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > hidden.desktop:5 > +X-KDE-Weight=100 > +Icon=preferences-desktop-default-applications > +Enabled=false can you remove the icon? REPOSITORY R124 System Settings BRANCH

D12256: [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin

zzag added a comment. @broulik Ping. REPOSITORY R31 Breeze BRANCH drop-QStyleOptionProgressBarV2 REVISION DETAIL https://phabricator.kde.org/D12256 To: zzag, #breeze, hpereiradacosta Cc: davidedmundson, broulik, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12459: [Icon KCM] Port to new design

zzag added a comment. Delete button is not visible in the attached video at 0:14 (when you hover Breeze). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12459 To: broulik, #plasma, #vdg Cc: zzag, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D12459: [Icon KCM] Port to new design

broulik updated this revision to Diff 32871. broulik retitled this revision from "WIP: [Icon KCM] Port to new design" to "[Icon KCM] Port to new design". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Kill old KCM code

D12311: Align lock icon with bold message text; reduce overall size of dialog

stikonas added a comment. In D12311#252165 , @bruns wrote: > Resizing: http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#gdbus-method-org-freedesktop-UDisks2-Partition.Resize Does not work well yet,

D12376: [ContextMenu Containment Action] Fix checking for KIOSK

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. LGTM now REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12376 To: broulik, #plasma, sitter Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 32867. fabianr added a comment. - Merge branch 'master' into swipe - added a screenshot for a desktop swipelistitem, small formating change - Added png file REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE

D12171: Kicker: Make menus grow (to a limit) if the text doesn't fit on the default width

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b8762edefd04: Kicker: Make menus grow (to a limit) if the text doesnt fit on the default… (authored by aacid). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #27 from Pascal d'Hermilly --- Looks good. You can read the text with a white background, right? I'm having trouble imagining the whole thing from the explanation. Den 22. april 2018 16.41.19 CEST, Marco Martin