D14035: Unbreak SSH agent support for SSH VPN tunnels.

jgrulich requested changes to this revision. jgrulich added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > secretagent.cpp:370 > + QLatin1String("SSH_AUTH_SOCK not present"), > + request.message); > +

D14493: fontinst quits after KJob is done

ngraham added a comment. Generally speaking, bugfixes go into the stable branches. If the bugfix is particularly large, complex, or risky, it might be worth it to commit to master only. For this one, I think it's okay to commit it to the `Plasma/5.12` branch too. The preferred workflow

D14493: fontinst quits after KJob is done

mathiastillman added a comment. It would indeed, but I will wait for input before pushing it as I'm not entirely sure how it's decided what release a patch goes in to. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14493 To: mathiastillman, #plasma, dfaure,

D14514: Install the OSD icons to hicolor

gladhorn added a comment. In D14514#301328 , @broulik wrote: > Why are they not in the Plasma theme, though? What does that mean? "the plasma theme" ? I'm happy to move these to wherever it makes sense. Currently they are big uncompressed

D14476: QMLScreen: do not declare the engine a member

This revision was automatically updated to reflect the committed changes. Closed by commit R104:a6929de88b89: QMLScreen: do not declare the engine a member (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14476?vs=38857&id=38860#toc REPOSITORY R104 KScreen CHANGE

D14476: QMLScreen: do not declare the engine a member

gladhorn updated this revision to Diff 38857. gladhorn added a comment. Remove more cruft REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14476?vs=38745&id=38857 BRANCH arcpatch-D14476 REVISION DETAIL https://phabricator.kde.org/D14476 AFFECTED FILES

D14493: fontinst quits after KJob is done

wbauer added a comment. Wouldn't it make sense to push this to the 5.12 and 5.13 branches as well? After all, there are quite a lot of bug reports about this... Should be answered by some Plasma developer though, I suppose. ;-) REPOSITORY R119 Plasma Desktop REVISION DETAIL https:/

D14035: Unbreak SSH agent support for SSH VPN tunnels.

catherinez updated this revision to Diff 38850. catherinez added a comment. Added QLatin1String() where requested, handled the case of empty SSH_AUTH_SOCK. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14035?vs=37535&id=38850 REVISION DETAIL https://phabricator.kde.org/D14035 A

D14035: Unbreak SSH agent support for SSH VPN tunnels.

catherinez marked 3 inline comments as done. catherinez added a comment. Done. REVISION DETAIL https://phabricator.kde.org/D14035 To: catherinez, #plasma, jgrulich Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. Sure, here you go: F6167313: fonts.tar.gz REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, ngraham, #plasma Cc: rkflx, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, l

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. could you give me all those files? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12925 To: progwolff, ngraham, #plasma Cc: rkflx, ngraham, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abett

D14514: Install the OSD icons to hicolor

broulik added a comment. Why are they not in the Plasma theme, though? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14514 To: gladhorn, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. cat ~/.config/fontconfig/fonts.conf ~/.fonts true ls /etc/fonts/conf.d 10-antialias.conf 57-dejavu-serif.conf 10-hinting-slight.conf 58-dejavu-

D14514: Install the OSD icons to hicolor

gladhorn created this revision. gladhorn added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY These icons were only in breeze-icons and would not be found wh

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. Works for me F6167260: Screenshot_20180731_164900.png Could you show me your `~/.config/fontconfig/fonts.conf` and the content of `/etc/fonts/conf.d`? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phab

D14353: Improve alignment of types

gladhorn abandoned this revision. gladhorn added a comment. seems like this is not wanted REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14353 To: gladhorn, #plasma, romangg Cc: zzag, romangg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. On the other hand, no matter what combination of sub-pixel antialiasing and hinting style I suggest, and regardless of what default value is shown in the UI, the result seems to

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

ngraham added a comment. In D12925#301133 , @progwolff wrote: > I am not sure about the case when neither global nor local configs exist for subpixel or hint. > On my system it seems like rgb subpixel rendering with slight hinting is used wh

Plasma 5.13.4

Plasma 5.13.4 sources are now available for packaging https://www.kde.org/announcements/plasma-5.13.4.php

D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available

ngraham closed this revision. REVISION DETAIL https://phabricator.kde.org/D12708 To: tundracomp, mart Cc: ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available

tundracomp added a comment. @ngraham: I've updated the patch to the latest GIT master of breeze. A quick test compile without `qtdeclarative5-dev` suggests that it still works. Cheers! REVISION DETAIL https://phabricator.kde.org/D12708 To: tundracomp, mart Cc: ngraham, davidedmundson,

D12708: Only include QtQuick support in Breeze KStyle if QtQuick is available

tundracomp updated this revision to Diff 38838. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12708?vs=33683&id=38838 REVISION DETAIL https://phabricator.kde.org/D12708 AFFECTED FILES kstyle/CMakeLists.txt kstyle/breezestyle.cpp kstyle/breezewindowmanager.cpp kstyle/breezewi

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 - Build # 12 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20FreeBSDQt5.10/12/ Project: Plasma kde-cli-tools stable-kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 31 Jul 2018 12:15:00 + Build duration: 43 min and counting CONS

D14478: Do not leak all instances of QMLOutput when QMLScreen is destroyed

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ff717c0a9c4c: Do not leak all instances of QMLOutput when QMLScreen is destroyed (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14478?vs=387

KDE CI: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 - Build # 34 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20systemsettings%20stable-kf5-qt5%20SUSEQt5.10/34/ Project: Plasma systemsettings stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 31 Jul 2018 12:17:42 + Build duration: 22 min and counting CONSOLE

KDE CI: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 - Build # 21 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20powerdevil%20stable-kf5-qt5%20SUSEQt5.10/21/ Project: Plasma powerdevil stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 31 Jul 2018 12:17:33 + Build duration: 21 min and counting CONSOLE OUTPUT

KDE CI: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kde-cli-tools%20stable-kf5-qt5%20SUSEQt5.10/14/ Project: Plasma kde-cli-tools stable-kf5-qt5 SUSEQt5.10 Date of build: Tue, 31 Jul 2018 12:15:00 + Build duration: 6 min 18 sec and counting CONS

D14493: fontinst quits after KJob is done

mathiastillman closed this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14493 To: mathiastillman, #plasma, dfaure, aacid, gateau Cc: wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,

D14487: [Klipper] Only create KHelpMenu when used

broulik added a comment. > What issue did this cause? A bunch of useless `QActions`, `createActions` is called in `KHelpMenu` constructor. The menu itself is created lazily but the `QAction` instances are not REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.

D14493: fontinst quits after KJob is done

dfaure added a comment. Please push the first patch ;) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14493 To: mathiastillman, #plasma, dfaure, aacid, gateau Cc: wbauer, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D14493: fontinst quits after KJob is done

mathiastillman marked an inline comment as done. mathiastillman added a comment. Either one is fine by me as well, so pick whichever one you fancy :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14493 To: mathiastillman, #plasma, dfaure, aacid, gateau Cc: w

D14493: fontinst quits after KJob is done

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. With your explanations, I actually have a better feeling about the first patch after all (if a job is stuck for more than 30s, then the process will never exit). But really, I'm nitpickin

D14493: fontinst quits after KJob is done

mathiastillman updated this revision to Diff 38832. mathiastillman added a comment. Grammatical fixes ;) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14493?vs=38831&id=38832 REVISION DETAIL https://phabricator.kde.org/D14493 AFFECTED FILES kc

D14493: fontinst quits after KJob is done

mathiastillman added a comment. Well, it's sort of a daemon, but it doesn't run until the user logs out - there's a built-in timeout of 30 seconds that will check for any connected clients and if none are found it will kill itself. The KCM communicates with the fontinst daemon via dbus :) R

D14493: fontinst quits after KJob is done

dfaure added a comment. Ah so it's kind of a daemon, that should keep running until logout? I wasn't aware of that, I thought it was a KCM. Disabling as in the first patch made sense then ;) Either version is fine with me. INLINE COMMENTS > FontInst.h:161 > +// This is needed becau

D14493: fontinst quits after KJob is done

mathiastillman updated this revision to Diff 38831. mathiastillman added a comment. Use a QEventLoopLocker instead of completely disabling the quit lock functionality. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14493?vs=38795&id=38831 REVISION

D14493: fontinst quits after KJob is done

mathiastillman added a comment. Okay, that makes sense. kfontinst doesn't actually display a UI at all, instead it just receives dbus commands from kcm - so there is no real GUI class, it just uses QCoreApplication. I could add a QEventLoopLocker to KFI::FontInst though, but, from reading th

D14440: File Dialog: fix testSelectUrl() again, i.e. selectUrl() should set the directory too

arichardson added a comment. +1 LGTM. Thanks! REVISION DETAIL https://phabricator.kde.org/D14440 To: dfaure, arichardson, anthonyfieroni, elvisangelaccio, plasma-devel, broulik

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38829. progwolff added a comment. - fix previews REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12925?vs=38828&id=38829 BRANCH arcpatch-D12925 REVISION DETAIL https://phabricator.kde.org/D12925 AFFECTED

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff added a comment. I am not sure about the case when neither global nor local configs exist for subpixel or hint. On my system it seems like rgb subpixel rendering with slight hinting is used when no configs exist. But I cannot find any documentation on this. We also need to ma

D12925: Parse global config files. Remove 'Vendor default' option. Fix changes not recognized.

progwolff updated this revision to Diff 38828. progwolff added a comment. - Merge branch 'master' of git://anongit.kde.org/plasma-desktop into arcpatch-D12925 - Merge branch 'master' of git://anongit.kde.org/plasma-desktop into arcpatch-D12925 - also drop vendor-default-option for subpixe

D14493: fontinst quits after KJob is done

dfaure added a comment. The idea of KJob reference-counting the event loop is that if you quit the application while a kjob is executing, then the process will wait for the job to finish before quitting. (Use case back then, konqueror and a HTTP download). The reason why we don't just quit

D14437: Fix QFileDialog not remembering the last visited directory.

dfaure updated this revision to Diff 38826. dfaure added a comment. Remove TODO comment. Although I can say it would have definitely helped me when investigating this bug... REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D14493: fontinst quits after KJob is done

wbauer added a comment. I can confirm that this patch does fix the problem with installing several fonts at once systemwide here. And fontinst still exits after some time of idleness. Btw, there's also BUG:349673 about the same problem. REPOSITORY R119 Plasma Desktop REVISION DETAIL

vnc client keyboard mapping

Hi, I don't manage to have my local client keyboard mapping when I connect to vnc server (x11vnc) in a kde plasma system. Are there some settings needed in order to make it recognized ? Is it supported in KDE plasma (that works fine in other systems.) Regards, S.Ancelot