D18018: [Digital Clock] Add ability to change first day of week

ngraham added inline comments. INLINE COMMENTS > configCalendar.qml:56 > +id: firstDayOfWeekComboBox > +Kirigami.FormData.label: i18n("First day of week:") > +// [-1, 0, 1, 2, 3, 4, 5, 6] // Default = -1, 0..6 = Sun..Sat I'd add a "the" and make this "First da

D18032: Fix USB view

alexandref added a comment. Fix USB view to correctly present the USB hierarchy REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D18032 To: alexandref Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abet

D18032: Fix USB view

alexandref created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexandref requested review of this revision. REVISION SUMMARY Fix BUG: 402949 REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D18032 AFFECTED FILES Modul

D18027: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18027 To: aacid, apol Cc: apol, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18027: Use the nicer K_PLUGIN_CLASS_WITH_JSON

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks much better! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18027 To: aacid, apol Cc: apol, plasma-devel, kvanton, jraleigh, GB_2, rag

D18027: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18027 AFFECTED FILES freespacenotifier/module.cpp

D18005: Include only the largest size for each wallpaper

ngraham added a comment. @filipf That looks about right! @davidedmundson Reading through that bug report, it looks like we do some magic to avoid storing huge pixmaps in memory, so is it true that this change would avoid increasing users' memory consumption? I was thinking that on future

D18026: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D18026 AFFECTED FILES kded/daemon.cpp To: aacid Cc: plasma-de

D18025: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D18025 AFFECTED FILES dataengines/potd/apodprovider.cpp

D17975: [WIP, Notifications] Add padding to notifications

ngraham added a comment. How are you scaling plasma? Are you setting `PLASMA_USE_QT_SCALING=1` to make sure it's really actually using the scale factor you set in the KScreen KCM? Technically Plasma doesn't support fractional scale factors yet (see https://bugs.kde.org/show_bug.cgi?id=35

D18023: Use the nicer K_PLUGIN_CLASS_WITH_JSON

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D18023 AFFECTED FILES src/kcm/module.cpp T

D18005: Include only the largest size for each wallpaper

filipf added a comment. Couldn't it be this? https://bugs.kde.org/show_bug.cgi?id=338506 REPOSITORY R131 Plasma Wallpapers BRANCH keep-only-largest-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D18005 To: ngraham, #vdg, #plasma, ndavis Cc: filipf, davidedmund

D18005: Include only the largest size for each wallpaper

davidedmundson added a comment. I can list bugs that you might have seen in 5.x. I can't name things in 4.x. which is when it was introduced. Its before my plasma time. REPOSITORY R131 Plasma Wallpapers BRANCH keep-only-largest-size (branched from master) REVISION DETAIL https:/

D18005: Include only the largest size for each wallpaper

filipf added a comment. In D18005#387738 , @davidedmundson wrote: > > In short, images were blurry when scaled and cropped. > > I want the "In long" version. QImage resizing hasn't changed, and with the source size set that's what we'll be

D18005: Include only the largest size for each wallpaper

davidedmundson added a comment. > In short, images were blurry when scaled and cropped. I want the "In long" version. QImage resizing hasn't changed, and with the source size set that's what we'll be using. REPOSITORY R131 Plasma Wallpapers BRANCH keep-only-largest-size (branched f

D18005: Include only the largest size for each wallpaper

filipf added a comment. In D18005#387607 , @davidedmundson wrote: > What previous technical constraint are you referring to? See D18006#387372 . In short, images were blurry when scaled and crop

D18016: Don't use hardcoded background color

This revision was automatically updated to reflect the committed changes. Closed by commit R123:3a43aa10b4dd: Don't use hardcoded background color (authored by GB_2, committed by ngraham). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1

D18016: Don't use hardcoded background color

ngraham accepted this revision. ngraham added a comment. Awesome! Now the only things left to fix are: - Make the frame in which this thing lives large enough to display all of it - Make the image picker remember the image you chose after leaving and reopening the KCM: https://bugs.kde.

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.12 - Build # 4 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.12/4/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 06 Jan 2019 18:59:48 + Build duration: 27 min and counting JUnit Tests Name: projec

D18019: [Digital Clock] Add ability to set a custom date format string

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY Adds a new `dateFormatStr` config key which is used when the `dateFormat` "StringEnum" is set to `custom`. Shows a link to the Qt time

D16284: do not force text display for ToolButton

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Seems sensible. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH toolbutton REVISION DETAIL https://phabricator.kde.org/D16284 To: astippich, mart, apol, da

D18016: Don't use hardcoded background color

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D18016 To: GB_2, #vdg, #breeze, davidedmundson Cc: da

D18018: [Digital Clock] Add ability to change first day of week

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY CCBUG: 390330 The Qt enum can have Sunday value of 0 or 7, so we start the enum at -1 to represent the locale's default value.

D18005: Include only the largest size for each wallpaper

davidedmundson added a comment. What previous technical constraint are you referring to? And we've had the multiple resolutions since 4.x so it dates back a long way. It's about a few things: - CPU usage to load an image is a sizable amount of our loading. Especially for JPEG im

D18016: Don't use hardcoded background color

GB_2 created this revision. GB_2 added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Fixes the hardcoded SDDM theme preview background color F6530004: SDDM KCM Breeze.png

D18012: [SDDM theme] Update the theme preview

raddison added a comment. You've got my blessing. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18012 To: filipf, #plasma, #vdg, #breeze, GB_2, ngraham Cc: raddison, ngraham, GB_2, oussemabouaneni, plasma-devel, kvanton, jraleigh, ragreen, Pitel, ZrenBot,

D18012: [SDDM theme] Update the theme preview

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a3bbdef02ad8: [SDDM theme] Update the theme preview (authored by filipf, committed by GB_2). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18012?vs=48796&

D18012: [SDDM theme] Update the theme preview

ngraham accepted this revision. ngraham added a comment. Nice, ship it! REPOSITORY R120 Plasma Workspace BRANCH new-sddm-preview (branched from master) REVISION DETAIL https://phabricator.kde.org/D18012 To: filipf, #plasma, #vdg, #breeze, GB_2, ngraham Cc: ngraham, GB_2, oussemabouane

D18012: [SDDM theme] Update the theme preview

GB_2 accepted this revision. GB_2 added a comment. This revision is now accepted and ready to land. +1, updated and looks much better REPOSITORY R120 Plasma Workspace BRANCH new-sddm-preview (branched from master) REVISION DETAIL https://phabricator.kde.org/D18012 To: filipf, #plasma,

D18005: Include only the largest size for each wallpaper

cfeck added a comment. Maybe symlinking all to the largest version? REPOSITORY R131 Plasma Wallpapers BRANCH keep-only-largest-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D18005 To: ngraham, #vdg, #plasma, ndavis Cc: cfeck, ndavis, plasma-devel, kvanton, jr

D18012: [SDDM theme] Update the theme preview

oussemabouaneni added a comment. In D18012#387473 , @filipf wrote: > I believe it's because the old one has a plain color background, whereas for the new one it has to store more data because it's a blurred wallpaper. That makes sense to

D18012: [SDDM theme] Update the theme preview

filipf added a comment. In D18012#387471 , @oussemabouaneni wrote: > Hello, I am new here. But I wanted to ask something. Why does the older image take less space on disk than the newer one even though its resolution is higher? I believ

D18012: [SDDM theme] Update the theme preview

oussemabouaneni added a comment. Hello, I am new here. But I wanted to ask something. Why does the older image take less space on disk than the newer one even though its resolution is higher? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18012 To: filipf,

D18012: [SDDM theme] Update the theme preview

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The current preview of our Breeze SDDM theme is outdated. This patch adds a new and updated preview. REPOSITORY R120 Plasma Work

D16284: do not force text display for ToolButton

astippich added a comment. friendly ping REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D16284 To: astippich, mart, apol Cc: hein, mgallien, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18006: Include only the largest size for the "Next" wallpaper

filipf added a comment. And from my understanding this removes the file the SDDM theme needs so I created D18007 as a dependent revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D18006 To: ngraham, #vdg, #breeze Cc: filipf,

D18007: [SDDM theme] Use the biggest wallpaper resolution

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The SDDM theme now uses the 3200x2000 version of the "Next" wallpaper. If that gets removed in D18006

D18006: Include only the largest size for the "Next" wallpaper

filipf added subscribers: kvermette, filipf. filipf added a comment. I've reproduced what the issue was before. Tests done with a 1280x1024 monitor. - **Tested on a Kubuntu 16.04 install with Plasma** Using the optimized 1280x1024 wallpaper: F6529646: Screenshot_20190106_110639.

D17834: Allow the use of One-Time Password

jgrulich added a comment. It doesn't build now, can you please fix that? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D17834 To: enriquem, jgrulich Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed

D17925: [containmentactions/switchwindow] Fix loop itteration

hein added a comment. Sorry about this, thx for fixing :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17925 To: davidedmundson, #plasma, ngraham Cc: hein, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 10 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/10/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 06 Jan 2019 07:50:00 + Build duration: 2 hr 3 min and counting JUnit Tests Name: proje

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.12 - Build # 3 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.12/3/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 06 Jan 2019 07:47:45 + Build duration: 1 hr 53 min and counting CONSOLE OUTPUT [...t

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. @davidedmundson Is there anything I can put in the code to get the icons to scale properly? this is a screenshot of master (not this patch): F6529598: image.png I've tried multiplying units.iconSizes.large by the scaling f