D18310: Require breeze >= 5.14.90

heikobecker added a comment. Should probably wait until the version in breeze is actually increased to 5.14.90. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18310 To: heikobecker, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18310: Require breeze >= 5.14.90

heikobecker created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY 622db3767ea7b6584800a9d140396a6855b2efba

D18309: don't set python exe to undefined

heikobecker added a comment. +1 I have no cmake < 3.12.0 to test, but the changes are reasonable. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18309 To: sitter, davidedmundson Cc: heikobecker, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18309: don't set python exe to undefined

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY FindPythonInterp sets PYTHON_EXECUTABLE, we overrode it by setting an empty var. add a comment to explain the unbalancedness of the

D18287: Remove hardcoded /usr/share paths in install

rikmills added a comment. Build fails now on Kubuntu Cosim and Disco builds. https://launchpadlibrarian.net/406558385/buildlog_ubuntu-disco-amd64.breeze-gtk_5.14.80+p19.04+git20190117.0641-0_BUILDING.txt.gz > make[3]: Leaving directory

D18244: Check for python-cairo

rikmills added a comment. This breaks Neon builds, whereas previously the builds were working as I explicitly had added python3-cairo to the build depends. It is there still, but cmake thinks not. https://build.neon.kde.org/job/bionic_unstable_kde_breeze-gtk_bin_amd64/51/consoleFull

D13418: Add build dependencies to INSTALL file

ngraham added a comment. Repo seems wrongly set. I think it's https://cgit.kde.org/plasma-active-window-control.git REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D13418 To: majohnson, martinkostolny, mart Cc: ngraham, aacid,

D13418: Add build dependencies to INSTALL file

aacid added a comment. Which is the repo for this? REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D13418 To: majohnson, martinkostolny, mart Cc: aacid, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, skadinna, lesliezhai,

D15876: Fix copyrights in binary clock files

aacid closed this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D15876 To: piotrkakol, davidedmundson Cc: plasma-devel, ngraham, gladhorn, zzag, davidedmundson, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D16038: Allow dictionary runner to search multiple times

This revision was automatically updated to reflect the committed changes. Closed by commit R114:04dff1e01632: Allow dictionary runner to search multiple times (authored by McPain, committed by aacid). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D14444: Use nullptr/override

aacid added a comment. @davidedmundson No he doesn't. He also doesn't have an actual name, so i didn't commit the patch myself. REPOSITORY R106 KSysguard BRANCH arcpatch-D1 REVISION DETAIL https://phabricator.kde.org/D1 To: al1xz, apol Cc: aacid, davidedmundson, zzag,

D17366: Implement "Kill" button when sysguard was invoked from freememorynotifier

ngraham added a comment. D17217 is a non-starter, for all the reasons given in the review for that patch. Since it's a prerequisite of this, it doesn't make sense to land this until and unless D17217 lands.

D17448: Revamp README

This revision was automatically updated to reflect the committed changes. Closed by commit R846:41ba3818da16: Revamp README (authored by marcinse, committed by aacid). REPOSITORY R846 Mycroft Plasma integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17448?vs=47166=49679

D17366: Implement "Kill" button when sysguard was invoked from freememorynotifier

aacid added a comment. Should this be landed even if D17217 has not landed? REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D17366 To: McPain, mart Cc: aacid, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18306: Word-wrap long tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R858:fbfdd78324f6: Word-wrap long tooltips (authored by ngraham). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18306?vs=49671=49672

D18306: Word-wrap long tooltips

ngraham created this revision. ngraham added reviewers: mart, Plasma, Kirigami. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch fixes long tooltips so that they word-wrap instead of overflowing.

KDE CI: Plasma » breeze-gtk » kf5-qt5 FreeBSDQt5.12 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20FreeBSDQt5.12/6/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 16 Jan 2019 19:04:34 + Build duration: 1 min 1 sec and counting

D17751: Add shadow to Hour's hand

ngraham added a comment. > `units.smallSpacing * [some value]` I'm afraid this won't work, since it will result in fractional pixel values and blurry edges. For this, you need to just hardcode the number of pixels. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D18300: [Mouse KCM] Port away from KDELibs4Support

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18300 AFFECTED FILES kcms/mouse/CMakeLists.txt

D17751: Add shadow to Hour's hand

shubham updated this revision to Diff 49656. shubham added a comment. 1. Set the hour hand shadow's topMargin to -6px and second hand shadow's topMargin to 2px 2. Use units.smallSpacing instead of hardcoding the values REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D17751: Add shadow to Hour's hand

ngraham added a comment. D18288 has landed! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17751 To: shubham, mart, hein, #vdg, ngraham, davidedmundson Cc: ndavis, abetts, ngraham, davidedmundson, plasma-devel,

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi added a comment. will also need to wait for commit message update, like the other change. INLINE COMMENTS > ptracer.cpp:92 > + > +qCWarning(DRKONQI_LOG) << "debugged process did not acknowledge setting > ptracer to" << debuggerpid; > +close(sfd); not wrong per se, but mildly

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick added inline comments. INLINE COMMENTS > ossi wrote in ptracer.cpp:65 > you really could just use != here ... ^^ wow... REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11235 To: croick, #plasma_workspaces, #frameworks, ossi Cc: ossi, lepagevalleeemmanuel,

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49651. croick marked 5 inline comments as done. croick added a comment. - emit warning if no socket is available REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49649=49651 BRANCH ptracer REVISION DETAIL

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49649. croick marked an inline comment as done. croick added a comment. - change order and add comment to kdeinit option in crashtest - add warning if debuggee does not respond as expected REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi requested changes to this revision. ossi added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ptracer.cpp:65 > +bytes += r; > +else if (r == -1 && !(errno == EINTR)) > +break; you really could just use != here

D18299: ComboBox: fix default delegate

broulik added inline comments. INLINE COMMENTS > ComboBox.qml:58 > +controlRoot.currentIndex = index; > +controlRoot.popup.visible = false; > +} Are you sure this is needed? Qt docs say for that using `ItemDelegate` for a `ComboBox` is recommended as: "This

D18299: ComboBox: fix default delegate

This revision was automatically updated to reflect the committed changes. Closed by commit R858:cb49b355f946: ComboBox: fix default delegate (authored by apol). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18299?vs=49646=49648

D18189: Fix ComboBox

apol added a comment. https://phabricator.kde.org/D18299 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18189 To: apol, #kirigami, mart Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16212: [Device Notifier] Add a button to unmount all devices

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace BRANCH arc_unmountall (branched from master) REVISION DETAIL https://phabricator.kde.org/D16212 To: thsurrel, #plasma, #vdg, ngraham, broulik Cc: abetts, broulik, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18299: ComboBox: fix default delegate

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Should use the selected item when it's interacted with using the mouse. TEST PLAN Selecting an item

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 49644. thsurrel added a comment. Display the unmountAll button only when there are some MOUNTED devices. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=49640=49644 BRANCH arc_unmountall (branched

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added a comment. There is a regression, I did not notice at first. By storing the connectedRemovables and not the mountedRemovables, the unmountAll button will appear even if nothing is mounted. That's not good. I have to update a list in the onMountedChanged slot as I was doing

D16212: [Device Notifier] Add a button to unmount all devices

broulik accepted this revision. broulik added a comment. Let's go for it, I guess INLINE COMMENTS > thsurrel wrote in FullRepresentation.qml:113 > That does not seem to do the trick. > I am trying to have the button at a fix location at the top right, but it is > 'over' the scrollArea.

D18189: Fix ComboBox

apol added a comment. I gave it a test and indeed selecting also needs looking into. I guess I just didn't fully fix it. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18189 To: apol, #kirigami, mart Cc: davidedmundson, plasma-devel,

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added inline comments. INLINE COMMENTS > broulik wrote in FullRepresentation.qml:113 > How about adding the following to the button: > > Layout.alignment: Qt.AlignRight > Layout.preferredWidth: minimumWidth That does not seem to do the trick. I am trying to have the button at a

D18189: Fix ComboBox

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in ComboBox.qml:207 > Breaking it down it's this one line that causes major regressions for me > though I can't immediately see why. > > Can you elaborate on what was broken and why you changed it? delegateModel property

D18244: Check for python-cairo

This revision was automatically updated to reflect the committed changes. Closed by commit R98:fda7d4375883: Check for python-cairo (authored by davidedmundson). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18244?vs=49627=49641 REVISION DETAIL

D18287: Remove hardcoded /usr/share paths in install

This revision was automatically updated to reflect the committed changes. Closed by commit R98:de20417d6d2e: Remove hardcoded /usr/share paths in install (authored by davidedmundson). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18287?vs=49620=49642

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 3 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/3/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 16 Jan 2019 14:42:09 + Build duration: 1 min 22 sec and counting JUnit Tests

D16212: [Device Notifier] Add a button to unmount all devices

broulik added inline comments. INLINE COMMENTS > thsurrel wrote in FullRepresentation.qml:113 > I do not manage to get the layout I want with ColumnLayout: I need to align > that ScrollArea to the same level than the 'unmountAll' button How about adding the following to the button:

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added inline comments. INLINE COMMENTS > broulik wrote in devicenotifier.qml:122 > This is for having the bindings refresh, right? Yes indeed. Any better ways ? REPOSITORY R120 Plasma Workspace BRANCH arc_unmountall (branched from master) REVISION DETAIL

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel marked 6 inline comments as done. thsurrel added inline comments. INLINE COMMENTS > broulik wrote in DeviceItem.qml:92 > Can we assume "action" is always unmount? If the device is removable and mounted, than the action can only be unmounting, yes. > broulik wrote in

D16212: [Device Notifier] Add a button to unmount all devices

broulik added a comment. Looking good, please check again the layout change you didn't explain. Otherwise I think shis hould be good. Sorry for the long delay. INLINE COMMENTS > broulik wrote in FullRepresentation.qml:113 > Why this change? `ColumnLayout` should layout everything

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.11 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.11/19/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Wed, 16 Jan 2019 14:30:01 + Build duration: 5 min 47 sec and counting BUILD ARTIFACTS

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 49640. thsurrel added a comment. Trying to improve based on broulik comments. Thank you very much for the review! REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=46999=49640 BRANCH arc_unmountall

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.11 - Build # 17 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.11/17/ Project: stable-kf5-qt5 SUSEQt5.11 Date of build: Wed, 16 Jan 2019 14:30:21 + Build duration: 1 min 54 sec and counting BUILD ARTIFACTS

KDE CI: Plasma » breeze-gtk » kf5-qt5 FreeBSDQt5.12 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20FreeBSDQt5.12/5/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 16 Jan 2019 14:17:54 + Build duration: 3 min 4 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » breeze-gtk » kf5-qt5 SUSEQt5.11 - Build # 13 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/breeze-gtk/job/kf5-qt5%20SUSEQt5.11/13/ Project: kf5-qt5 SUSEQt5.11 Date of build: Wed, 16 Jan 2019 14:17:53 + Build duration: 2 min 39 sec and counting CONSOLE OUTPUT [...truncated

D18286: Export path of installed color-schemes in BreezeConfig cmake

This revision was automatically updated to reflect the committed changes. Closed by commit R31:622db3767ea7: Export path of installed color-schemes in BreezeConfig cmake (authored by davidedmundson). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D18291: [Greeter] Ignore unwritable configuration files

This revision was automatically updated to reflect the committed changes. Closed by commit R133:30e61b4aa4e7: [Greeter] Ignore unwritable configuration files (authored by broulik). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18291?vs=49602=49634

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd created this revision. arrowd added a reviewer: KDE Applications. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arrowd requested review of this revision. REVISION SUMMARY Second part of fix for a BUG 398998 ( https://bugs.kde.org/show_bug.cgi?id=398998 ).

D18189: Fix ComboBox

davidedmundson added inline comments. INLINE COMMENTS > ComboBox.qml:207 > implicitHeight: contentHeight > -model: controlRoot.popup.visible ? controlRoot.delegateModel : > null > +model: controlRoot.model > +delegate: controlRoot.delegate

D18244: Check for python-cairo

cgiboudeaux added a comment. +1 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18244 To: davidedmundson, #plasma, ngraham, cgiboudeaux Cc: ngraham, zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D18286: Export path of installed color-schemes in BreezeConfig cmake

davidedmundson updated this revision to Diff 49629. davidedmundson added a comment. Use PACKAGE_ var REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18286?vs=49590=49629 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18286 AFFECTED FILES

D18244: Check for python-cairo

davidedmundson updated this revision to Diff 49627. davidedmundson added a comment. move set(python_exec) into relevant scope REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18244?vs=49525=49627 REVISION DETAIL https://phabricator.kde.org/D18244

D18285: Fake mousehover whilst combobox is open

This revision was automatically updated to reflect the committed changes. Closed by commit R858:a78ef64134dd: Fake mousehover whilst combobox is open (authored by davidedmundson). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D18284: Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets

This revision was automatically updated to reflect the committed changes. Closed by commit R858:c4a35f5e36bd: Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets (authored by davidedmundson). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D18285: Fake mousehover whilst combobox is open

davidedmundson added a comment. > I don't fully understand why widget ComboBox turns fully blue sometimes when open Keyboard Focus when clicking vs not. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18285 To: davidedmundson,

D18285: Fake mousehover whilst combobox is open

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I don't fully understand why widget ComboBox turns fully blue sometimes when open. Perhaps there's another case for focus && hovered vs just hovered. REPOSITORY R858 Qt Quick Controls

D18287: Remove hardcoded /usr/share paths in install

davidedmundson updated this revision to Diff 49620. davidedmundson added a comment. whitespace REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18287?vs=49591=49620 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18287 AFFECTED FILES

D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in virtualdesktopinfo.cpp:218 > Would it be safer to assume there's 1 row until we update. > > I'm sure we have some > > columns = count / rows > > code somewhere Indeed. I had 1 initially, but somehow it changed during

D18284: Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. as far as I understood the issue is that in the popup the list elements are elided because they're too narrow. So, we have two separate bugs I presume :) REPOSITORY R858 Qt Quick

D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland

davidedmundson added inline comments. INLINE COMMENTS > virtualdesktopinfo.cpp:218 > QStringList virtualDesktops; > +uint cachedDesktopLayoutRows = 0; > KWayland::Client::PlasmaVirtualDesktopManagement > *virtualDesktopManagement = nullptr; Would it be safer to assume there's 1

D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R120:49d9553f15c8: Use KWins D-Bus interface to get desktop layout rows on Wayland (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18284: Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets

davidedmundson added a comment. When we click without explicit keyboard focus: Currently we get black text on dark blue background. After this patch we get black text on a light background. Which I understood to be the main issue in that bug report. REPOSITORY R858 Qt Quick

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick marked 11 inline comments as done. croick added a comment. `read()` and `write()` were assumed to work right away, I added a loop around. INLINE COMMENTS > ossi wrote in crashtest.cpp:133 > this addition isn't used or explained anywhere for all i can tell. It's used to unset the

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49618. croick added a comment. - use debuggee pid instead of DrKonqi pid for socket name - make sure to read/write all bytes from/to socket REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11235?vs=49607=49618 BRANCH

D11235: [DrKonqi] Request change of ptrace scope from KCrash

ossi requested changes to this revision. ossi added a comment. This revision now requires changes to proceed. mark handled issues as done here as well. INLINE COMMENTS > ptracer.cpp:47 > + >

D11235: [DrKonqi] Request change of ptrace scope from KCrash

croick updated this revision to Diff 49607. croick edited the summary of this revision. croick edited the test plan for this revision. croick added a comment. - rename queryPtrace to setPtracer - add a kdeinit option in crashtest REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D16212: [Device Notifier] Add a button to unmount all devices

broulik added inline comments. INLINE COMMENTS > DeviceItem.qml:38 > > -property bool mounted > +property bool mounted: false > property bool expanded: devicenotifier.expandedDevice == udi Isn't this overridden anyway? It's also the default anyway > DeviceItem.qml:90 > > +

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added a comment. A last minute review in case this can get into 5.15 ? Please :) REPOSITORY R120 Plasma Workspace BRANCH arc_unmountall (branched from master) REVISION DETAIL https://phabricator.kde.org/D16212 To: thsurrel, #plasma, #vdg, ngraham Cc: broulik, ngraham,

D18244: Check for python-cairo

cgiboudeaux added inline comments. INLINE COMMENTS > zzag wrote in FindPythonCairo.cmake:6 > Shouldn't it be right after find_package(Python3)? Correct, or this will be empty with CMake < 3.12 REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL

D18287: Remove hardcoded /usr/share paths in install

zzag accepted this revision. zzag added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > build_theme.sh:73 > + echo " empty, it is installed into" >echo " ~/.local/share/themes/THEME_NAME" >exit 0

D18284: Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets

broulik added a comment. That doesn't fix the linked bug, however REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D18284 To: davidedmundson Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18244: Check for python-cairo

zzag added inline comments. INLINE COMMENTS > FindPythonCairo.cmake:6 > +endif() > +set(PYTHON_EXECUTABLE "${Python3_EXECUTABLE}") > + Shouldn't it be right after find_package(Python3)? REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D18244 To:

D18291: [Greeter] Ignore unwritable configuration files

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, graesslin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When opening a non-writable config file, a `kdialog` process is spawned

D18286: Export path of installed color-schemes in BreezeConfig cmake

zzag added inline comments. INLINE COMMENTS > BreezeConfig.cmake.in:11 > set(BREEZE_STYLE_NAME "breeze") > +set(BREEZE_COLOR_INSTALL_ROOT "@KDE_INSTALL_FULL_DATADIR@/color-schemes/") Why KDE_INSTALL_FULL_DATADIR instead of PACKAGE_KDE_INSTALL_FULL_DATADIR? REPOSITORY R31 Breeze REVISION

D18290: Use KWin's D-Bus interface to get desktop layout rows on Wayland

hein created this revision. hein added reviewers: Plasma, davidedmundson, mart. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY While I think mixing IPC systems in this class is not the way to go long-term, we have a strong desire to ship a complete